]> git.koha-community.org Git - koha.git/commit
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 10 Feb 2016 16:06:14 +0000 (16:06 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Oct 2016 12:04:58 +0000 (12:04 +0000)
commitddb1ecb9d8b4a29a3c0360a07aa539d378193747
tree497eb9f6ce6fda08c32791cdacf336eafea721f9
parentc7bc14cead116d7a8737be8da19b688e53049864
Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop

The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns
them ordered by the description (frameworktext). If a parameter is
passed, a selected flag is set. The selection of the options should be
done on the template side.
These 2 calls can be replaced with
  Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });

Test plan:
1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl)
You should see a dropdown list with the biblio frameworks. The framework
of the record should be selected by default
2/ Create a sql report using the biblio_framework parameter, something
like:
  SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>>
Save and execute the report.
You should get a dropdown list with the framework list.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Both dropdowns Ok
No errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Koha.pm
catalogue/labeledMARCdetail.pl
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
reports/guided_reports.pl
t/db_dependent/Koha.t