]> git.koha-community.org Git - koha.git/commit
Bug 34934: Remove the use of event attributes from OPAC lists page
authorOwen Leonard <oleonard@myacpl.org>
Wed, 27 Sep 2023 15:42:26 +0000 (15:42 +0000)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Tue, 17 Oct 2023 13:35:11 +0000 (14:35 +0100)
commite0964c19ecb69abc25014686beed337ff9230dd5
treedff4080d47c832ff4929e7cc7f978497a4890045
parent2282021cb9e0fc20185cf38c3a7c59f8dbf6b07f
Bug 34934: Remove the use of event attributes from OPAC lists page

This patch removes the use of event attributes (onclick, onchange) from
the OPAC lists template. These events are defined now along with the
other in-page JS.

The patch also removes a "delete list" button which was only shown
when viewing an empty list and which was redundant.

To test, apply the patch and log into the OPAC.

- Go to Lists -> New list.
- Change the category to "Private" and the "Allow changes" dropdown to
  "Staff only."
  - You should see a message, 'The "Staff only" permission has no actual
    effect while this list is strictly private'
- Change the category to "Public." The message should disappear.

- View the contents of a list.
  - Click the "Send list" button at the top of the table of titles.
  - It should trigger the "Sending your list" popup window.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 56348379ec35bbccbb54e205cc180cc0bd4f9297)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit ea411a563a3bd57a1fa8fbb8a75ddf0a5a5a44fc)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt