]> git.koha-community.org Git - koha.git/commit
Bug 18980: Remove js function Check from opac-shelves
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 21 Jun 2017 14:53:56 +0000 (16:53 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 10 Aug 2017 16:20:31 +0000 (13:20 -0300)
commitefc4caec968dd0394c6d1ee8a2c4be66cc697afb
tree5efc143b795fa90fb8aa6329e94c09ec988fd645
parent93366e10fbe2b018caa9d6b388b74cc3ef302a86
Bug 18980: Remove js function Check from opac-shelves

This function only serves to check if the shelf name is not empty. It
does not even work since it incorrectly refers to f.addshelf (while it
should test #shelfname).
We can solve this and improve consistency by doing the same as in the
staff template with html5 required.

Test plan:
[1] Without this patch it was possible to add a list without a name in
    OPAC (with js error: TypeError: f.addshelf is undefined).
[2] With this patch, verify that you cannot do this anymore.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt