Bug 35973: Correct wrong values for RedirectGuaranteeEmail system preference
authorKatrin Fischer <katrin.fischer.83@web.de>
Sun, 17 Mar 2024 16:46:26 +0000 (16:46 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 23 May 2024 13:43:39 +0000 (15:43 +0200)
commitfc05305694e44c2956b223f37b2798d05be645db
tree02abf824c8764c6f969b7a350f89560da2f128ce
parent40bd96aa82f5513fb8a72b7198498a8b560067e3
Bug 35973: Correct wrong values for RedirectGuaranteeEmail system preference

The system preferences was added with 0/1 in sysprefs.sql is checked
as boolean. But the .pref file was added with yes/no which both
evaluate as strings to true.

This fixes the .pref file and includes a database update that sets
0 and 1 correctly for the value currently chosen in the pref.

To test:
* Make sure to update RedirectGuaranteeEmail to Enable/Don't enable
  before applying the patch
* Verify in the database, that the values was set to yes or no
  You can use a report like:
    SELECT * from systempreferences WHERE variable = "RedirectGuaranteeEmail";
* Apply patch and run database update
* Verify the value in the database was corrected:
  Yes = 1, No = 0
* Change the setting, verify the new value is stored correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 34c85d051d330210227eccf76dd835d6b35b3e60)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
installer/data/mysql/atomicupdate/bug_35973.pl [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref