]> git.koha-community.org Git - koha.git/log
koha.git
12 years agobug 7990 - styl= in aqplan.tt
Stéphane Delaune [Fri, 20 Apr 2012 13:32:10 +0000 (15:32 +0200)]
bug 7990 - styl= in aqplan.tt

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7953 - add opacuserjs to the sco template
Liz Rea [Thu, 12 Apr 2012 21:54:28 +0000 (16:54 -0500)]
Bug 7953 - add opacuserjs to the sco template

To test:
add some jquery to opacuserjs that would change the screen
a la: $(".checkout label[for='patronid']").css("border","3px solid red");
verify you see a red box on the sco-main page.

Also adds the ability to use opacusercss to style sco-main.tt

to test:
Add some css to opacusercss that would change the screen:
.checkout { background: grey; }
verify you see a grey box around the checkout div.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
http://bugs.koha-community.org/show_bug.cgi?id=7959
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8008 - Fix typo in man page for koha-create
Magnus Enger [Wed, 25 Apr 2012 12:28:32 +0000 (14:28 +0200)]
Bug 8008 - Fix typo in man page for koha-create

Line 121 had "/etc/koha/koha-site.conf" instead of "/etc/koha/koha-sites.conf"

To test:
I don't think this needs any actual testing, just read the patch and check
that it looks sensible...

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 6372: moved background-job.inc to background-job-progressbar.js
Srdjan [Fri, 23 Mar 2012 00:08:54 +0000 (13:08 +1300)]
bug 6372: moved background-job.inc to background-job-progressbar.js

Check for div 0 when calculating percentage

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
div0 no longer appears on 0 size jobs.
Passes t xt

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7929 - Duplicate id "availability" on XSLT result page
Katrin Fischer [Wed, 11 Apr 2012 06:06:00 +0000 (08:06 +0200)]
Bug 7929 - Duplicate id "availability" on XSLT result page

Changes id="availability" to class="availability" for XHTML valididy
(ids have to be unique on a page).

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7987 [SIGNED-OFF] Fix typo in circulation template
Colin Campbell [Fri, 20 Apr 2012 11:16:13 +0000 (12:16 +0100)]
Bug 7987 [SIGNED-OFF] Fix typo in circulation template

li was not properly closed after loss of a character

Signed-off-by: Marc Veron <veron@veron.ch>
- Checked koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt before / after applying patch
- Line is changed as expected, ends now with </li>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files
Katrin Fischer [Tue, 3 Apr 2012 18:23:47 +0000 (20:23 +0200)]
Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2399: All status fields in the item edit interface offer two blank/null entries...
Katrin Fischer [Mon, 2 Apr 2012 17:28:37 +0000 (19:28 +0200)]
Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one

Removes the '0' values without description from the sample date for
authorised values.

To test:
1) Verify that SQL files load correctly
- truncate authorised_values; /* empty authorised values table */
- load sample data using one of the SQL files
2) Check cataloging interface - all status fields should only show 1 empty line

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 3413: Checkboxes for new subfields not saving correctly
Katrin Fischer [Mon, 9 Apr 2012 09:44:06 +0000 (11:44 +0200)]
Bug 3413: Checkboxes for new subfields not saving correctly

The bug was in the numbering of the fields and subfields in the form.
The form elements for the 'new subfield' got the same numbered names and ids as
the form elements for the second subfield. (example: repeatable1)
The patch fixes the numbering to continue to the new subfield.

To test:
- Create some new subfields and check all checkbox fields save correctly
  (mandatory, repeatable, is url)
- Check that other subfields' checkboxes are not changed
- Check existing subfields and newly created subfields can be edited

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8020 [3.8.x/MASTER] - update git build script to 3.9
Robin Sheat [Sat, 28 Apr 2012 01:02:26 +0000 (13:02 +1200)]
Bug 8020 [3.8.x/MASTER] - update git build script to 3.9

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8020 - [3.8.x] Update changelog for 3.8.0-1
Robin Sheat [Sat, 28 Apr 2012 00:40:09 +0000 (12:40 +1200)]
Bug 8020 - [3.8.x] Update changelog for 3.8.0-1

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8020 [3.8.x/MASTER] - update changelogs to get to 3.8
Robin Sheat [Wed, 26 Oct 2011 03:02:32 +0000 (16:02 +1300)]
Bug 8020 [3.8.x/MASTER] - update changelogs to get to 3.8

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8025: corrects the return of a zero value for authorised values
Adrien Saurat [Mon, 30 Apr 2012 08:05:07 +0000 (10:05 +0200)]
Bug 8025: corrects the return of a zero value for authorised values

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8027: fix param order for z3950 INSERT
Adrien Saurat [Mon, 30 Apr 2012 10:15:13 +0000 (12:15 +0200)]
Bug 8027: fix param order for z3950 INSERT

In the z3950servers.pl order of columns which are inserted
for new server is wrong, which results in empty timeout
and encoding values when new server is added.

Test scenario:

1. Open Z39.50 server administration
2. add new server with encoding and timeout
3. save server and verify that it has encoding and timeout

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_3969'
Paul Poulain [Mon, 7 May 2012 19:49:42 +0000 (21:49 +0200)]
Merge remote-tracking branch 'origin/new/bug_3969'

12 years agoBug 3969: Budget search in acquisition doesn't work (string changes)
Katrin Fischer [Sat, 14 Apr 2012 16:12:42 +0000 (18:12 +0200)]
Bug 3969: Budget search in acquisition doesn't work (string changes)

String changes:
- Correcting tab name from "Search budgets" to "Seach funds"
- Changing search option from "Name" to "Fund code"

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Strings look a-ok.

12 years agoBug 8002 follow-up to use 3.09 and MODIFY instead of 3.08 and CHANGE
Paul Poulain [Mon, 30 Apr 2012 12:36:08 +0000 (14:36 +0200)]
Bug 8002 follow-up to use 3.09 and MODIFY instead of 3.08 and CHANGE

see Ian comment 4 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002)

12 years agoBug 8002 [SIGNED-OFF][REVISED] Can't add patron attribute type in newer installation
Owen Leonard [Tue, 24 Apr 2012 15:20:42 +0000 (11:20 -0400)]
Bug 8002 [SIGNED-OFF][REVISED] Can't add patron attribute type in newer installation

Correcting patron_attributes_types definition in kohastructure.sql
to allow NULL entries for category_code, matching the definition
specified in updatedatabase.pl. Adds an entry to updatedatabase.pl
to correct existing installations with the incorrect table structure.

After running the updated updatedatabase.pl the category_code
column in borrower_attribute_types should show that it allows
NULL entries. Adding a new patron attribute type with no
patron category specified should work correctly.

To test the update to kohastructure.sql: Back up your Koha
database, drop it, and recreate it. Load the staff interface
and go through the web installer. After recreating the database
enable ExtendedPatronAttributes and try adding a new patron
attribute type with no patron category specified. The operation
should be successful.

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
a new update for installations affected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7849'
Paul Poulain [Mon, 30 Apr 2012 12:15:23 +0000 (14:15 +0200)]
Merge remote-tracking branch 'origin/new/bug_7849'

12 years agoFix typo in patch for bug 7849
Colin Campbell [Tue, 24 Apr 2012 13:27:58 +0000 (14:27 +0100)]
Fix typo in patch for bug 7849

$type declared twice effectively throwing away the returned value

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoKoha 3.8.0 bump
Paul Poulain [Mon, 23 Apr 2012 14:28:46 +0000 (16:28 +0200)]
Koha 3.8.0 bump

12 years agoRelease notes for 3.8.0 v3.08.00
Paul Poulain [Mon, 23 Apr 2012 10:42:07 +0000 (12:42 +0200)]
Release notes for 3.8.0

12 years agofixing missing " in french syspref file
Paul Poulain [Mon, 23 Apr 2012 10:40:16 +0000 (12:40 +0200)]
fixing missing " in french syspref file

12 years agoMerge remote-tracking branch 'origin/new/bug_7979'
Paul Poulain [Mon, 23 Apr 2012 09:41:50 +0000 (11:41 +0200)]
Merge remote-tracking branch 'origin/new/bug_7979'

12 years agoBug 7979 tiny follow-up for translatability (string freeze)
Paul Poulain [Mon, 23 Apr 2012 09:41:31 +0000 (11:41 +0200)]
Bug 7979 tiny follow-up for translatability (string freeze)

A few tiny string changes have been introduced, that I revert with this patch as we're string freeze
* Advanced search had been changed to Advanced Search (useless capital S). this is a mistake, I've reverted
* same thing for Koha administration
* the suggestions/comment/tags links have had a <span> and : added, the translator tool consider them as being changed. Switching back to the previous display.

The suggestion/comment/tags change can probably be reintroduced later

12 years agoMerge branch '3.8.0-translation' of git://git.tamil.fr/git/koha
Paul Poulain [Mon, 23 Apr 2012 09:17:49 +0000 (11:17 +0200)]
Merge branch '3.8.0-translation' of git://git.tamil.fr/git/koha

12 years ago[PATCH] Bug 7979 [FOLLOW-UP] New design for staff interface, rights fix
Paul Poulain [Mon, 23 Apr 2012 09:01:12 +0000 (11:01 +0200)]
[PATCH] Bug 7979 [FOLLOW-UP] New design for staff interface, rights fix

Fixes display of pending links (with necessary permissions being
enforced).

(patch made by Adrien Saurat, does not apply on my computer for an unknown reason)

12 years agoKoha 3.8.0 Translation Update
Frédéric Demians [Sat, 21 Apr 2012 18:02:22 +0000 (20:02 +0200)]
Koha 3.8.0 Translation Update

12 years agoBug 7979 [FOLLOW-UP] New design for staff interface
Owen Leonard [Thu, 19 Apr 2012 19:17:06 +0000 (15:17 -0400)]
Bug 7979 [FOLLOW-UP] New design for staff interface

This follow-up changes the structure of the page
so that it uses a standard YUI grid structure. This
helps keep the page flexible while preventing the
buttons from wrapping below the news block. The buttons
have been given a percentage width and a max-width value.

The benefit to flexibility is countered by the less-
strict spacing of the buttons. The columns of buttons
don't form a strict grid at higher screen widths.

There is probably a middle ground between this and
the previous design but I think we need to make it a
priority for the design not to break at 1024x768.

Another minor change: A tweak to the position and
padding of the icons.

12 years agoBug 7979: New design for staff interface + fixes + css call moved
Adrien Saurat [Wed, 18 Apr 2012 12:53:19 +0000 (14:53 +0200)]
Bug 7979: New design for staff interface + fixes + css call moved

Many modifications, see bugzilla for more informations.
Moved the CSS call to allow override with intranetusercss.

12 years agoBug 3969 follow-up = budget name field is budget_name, not name
Paul Poulain [Fri, 20 Apr 2012 14:59:35 +0000 (16:59 +0200)]
Bug 3969 follow-up = budget name field is budget_name, not name

12 years agoBug 3969: Budget search in acquisition does't work (search)
Katrin Fischer [Sat, 14 Apr 2012 17:39:30 +0000 (19:39 +0200)]
Bug 3969: Budget search in acquisition does't work (search)

Search term was never evaluated.
Patch makes sure input param is correctly stored in the variable
and changes comparison to be case insensitive.

To test:
- Check search for fund codes (case insensitive) works
- Check search for fund code in combination with library works

The budgets to be shown can depend on your permissions.
Testing with with a superlibrarian should bring up all funds.

Also fixes warns in the logs that appeared when viewing the funds
for a budget without funds.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Funds are now searchable.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6931 : Only update frameworks for the correct marcflavour
Chris Cormack [Thu, 19 Apr 2012 21:52:04 +0000 (09:52 +1200)]
Bug 6931 : Only update frameworks for the correct marcflavour

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7759, update of install files to use background indexing (and some whitespace...
tajoli@cilea.it [Tue, 20 Mar 2012 15:31:20 +0000 (16:31 +0100)]
Bug 7759, update of install files to use background indexing (and some whitespace tidy)

Signed-off-by: Mason James <mtj @ kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 1577 - update INSTALL to mention need to translate templates
MJ Ray [Wed, 18 Apr 2012 15:34:02 +0000 (16:34 +0100)]
Bug 1577 - update INSTALL to mention need to translate templates

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdding Marc Veron
Paul Poulain [Thu, 19 Apr 2012 16:28:11 +0000 (18:28 +0200)]
Adding Marc Veron

12 years agobug 7849 Instant Fine Calculation\n Adds functionality of calculate fines instantly...
Elliott Davis [Tue, 17 Apr 2012 10:38:14 +0000 (10:38 +0000)]
bug 7849 Instant Fine Calculation\n Adds functionality of calculate fines instantly. This is very important for Hourly loans becuase of a loophole from the cron.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7861 : Update of italian sql files for 3.8
Zeno Tajoli [Sat, 31 Mar 2012 15:42:52 +0000 (17:42 +0200)]
Bug 7861 : Update of italian sql files for 3.8

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7855 - marcflavour files changed to set the maxlength field into fresh installs...
Juan Romay Sieira [Fri, 30 Mar 2012 08:32:35 +0000 (10:32 +0200)]
Bug 7855 - marcflavour files changed to set the maxlength field into fresh installs. Include NORMARC in updatedatabase to change maxlength.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6267 custom http user-agent in check-url.pl (fix for books.google.com 401 error)
MJ Ray [Thu, 5 Apr 2012 12:18:07 +0000 (13:18 +0100)]
Bug 6267 custom http user-agent in check-url.pl (fix for books.google.com 401 error)

Patch by Judit with a small change to the help wording.
Sponsored by CALYX information essentials.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5347'
Paul Poulain [Thu, 19 Apr 2012 09:53:44 +0000 (11:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_5347'

12 years agoBug 5347 Follow up, fix for broken test
Chris Cormack [Thu, 19 Apr 2012 09:33:04 +0000 (21:33 +1200)]
Bug 5347 Follow up, fix for broken test

12 years agoBug 7726: explanation and options that were in the wrong order
Paul Poulain [Tue, 27 Mar 2012 07:56:33 +0000 (09:56 +0200)]
Bug 7726: explanation and options that were in the wrong order

I also removed the ` mysql-ism

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7950 - Typo for preference intranetuserjs
Kyle M Hall [Thu, 12 Apr 2012 16:25:09 +0000 (12:25 -0400)]
Bug 7950 - Typo for preference intranetuserjs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7693 - clear screen button misaligned
Gaetan Boisson [Thu, 12 Apr 2012 15:59:32 +0000 (17:59 +0200)]
Bug 7693 - clear screen button misaligned

This patch removes firefox specific lines in the css which were breaking the display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This fixes the layout problem in current versions of Firefox. I think
the CSS which is removed by this patch might be necessary for older
versions of Firefox, but if this turns out to be a problem we can
follow up.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7828 - On circulation home page, URL to offline circulation Firefox addon should...
Owen Leonard [Wed, 11 Apr 2012 12:31:22 +0000 (08:31 -0400)]
Bug 7828 - On circulation home page, URL to offline circulation Firefox addon should be a hyperlink

Along with making the URL a hyperlink I removed the language
part of the URL ("/fr/"). The link correctly redirects to 'en'
for me. I'm curious whether it will for other languages.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Link works and redirects to my language (english).

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(Redirects to fr if your browser is FR)

12 years agoBug 3337 - RSS link is not correct for searches without results
Katrin Fischer [Sat, 14 Apr 2012 22:09:34 +0000 (00:09 +0200)]
Bug 3337 - RSS link is not correct for searches without results

RSS links for searches without results didn't have the search terms.

To test:
- Search for something with results and check RSS link
- Search for something with no results and check RSS link

In both cases your search should show up in the link.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
RSS Link works in both cases listed in test plan.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress
Katrin Fischer [Thu, 12 Apr 2012 05:53:32 +0000 (07:53 +0200)]
Bug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress

The systempref.sql file had one more option 'cardnumber' that was not
visible from the system preference editor. This patch adds the setting.

To test:
- Check new setting cardnumber is available for AutoEmailPrimaryAddress
- Use setting with a patron that has an email address as cardnumber and
verify email is sent out correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7733 - HidePatronName not working on moredetail
Katrin Fischer [Sun, 15 Apr 2012 09:03:31 +0000 (11:03 +0200)]
Bug 7733 - HidePatronName not working on moredetail

Patch implements HidePatronName system preference for 'Checkout status'
on moredetail (tab items from staff detail page).

Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are
only shown when they are not empty.

Silences warns in the logs.

To test:
- Toggle system preference for an issued item and check name/cardnumber
are displayed correctly.
- Check serial enumeration and Paid for? show when not empty.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7833 - unique holiday link broken
Katrin Fischer [Sat, 14 Apr 2012 15:50:51 +0000 (17:50 +0200)]
Bug 7833 - unique holiday link broken

As Nicole stated on the bug the branchcode was missing from the links.

To test:
- add unique holidays to calendar for different branches
- click on link and check that the date is opened in the right calendar

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Clicked links for unique holidays and exceptions for
multiple branches and everything works perfectly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7845: Multiple 260s don't display properly in search results
Katrin Fischer [Mon, 9 Apr 2012 15:44:38 +0000 (17:44 +0200)]
Bug 7845: Multiple 260s don't display properly in search results

Corrects display for multiple 260 fields in intranet and OPAC.
In intranet the order of fields was wrong on the detail page.
In OPAC and intranet punctuation for multiple 260 fields in the
result list was not displaying properly.

Example after correction:
Publisher: Jena : Elsevier, 1907 ; Stuttgart : Franckh, 1907-1992 ; Jena : Urban & Fischer, 1993-2003

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7922: Fixing typo in German sample news
Katrin Fischer [Sun, 8 Apr 2012 11:30:10 +0000 (13:30 +0200)]
Bug 7922: Fixing typo in German sample news

Fehlerkorrektoren > Fehlerkorrekturen

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoRevert "Bug 7785: Remove unused function columns() which uses a MySQLism."
Paul Poulain [Thu, 19 Apr 2012 08:21:47 +0000 (10:21 +0200)]
Revert "Bug 7785: Remove unused function columns() which uses a MySQLism."

This reverts commit 1c8df08aea5eb173d7216cdfc9895fdd601a5f11.

See:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785#c5
and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7975

This patch broke tools/import_borrowers.pl

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7962 - Cart missing from result lists
Owen Leonard [Sun, 15 Apr 2012 20:46:57 +0000 (16:46 -0400)]
Bug 7962 - Cart missing from result lists

Removing duplicate inclusion of jQuery on the results page
which was added with the star ratings feature. Koha already
uses jQuery by default.

I have also made the inclusion of ratings JS and CSS dependent
on ratings being turned on.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7354: Can't edit local use system preferences
Katrin Fischer [Thu, 12 Apr 2012 06:59:32 +0000 (08:59 +0200)]
Bug 7354: Can't edit local use system preferences

Fixes adding and editing of local use system preferences and redirects to correct
page after saving.

To test:
- Create a new local use system preference
- Edit an existing local use system preference from summary page
- Edit an existing local use system preference using 'Edit'
- Delete a local use system preference

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7528 - amount subtracting 1 cent
mveron [Sun, 15 Apr 2012 15:20:16 +0000 (17:20 +0200)]
Bug 7528 - amount subtracting 1 cent

Rounding issue with JavaScript and float numbers, JavaScript changed to do no calculation if discount is 0

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7927 - library not showing on subscription full history anymore
Katrin Fischer [Wed, 11 Apr 2012 06:41:57 +0000 (08:41 +0200)]
Bug 7927 - library not showing on subscription full history anymore

Restores former functionality:
Shows the branchcode in the branch column for the full history
view of subscriptions in OPAC.

http://bugs.koha-community.org/show_bug.cgi?id=7929
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Branch codes are visible again.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7958 - Batch Item Delete Fails
Katrin Fischer [Sat, 14 Apr 2012 10:13:44 +0000 (12:13 +0200)]
Bug 7958 - Batch Item Delete Fails

Adding back "use C4::Search;" in Items.pm fixes the problem.

I think this is probably related to the denesting efforts.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5347: Followup: FIX 2 bugs in lateorders
Jonathan Druart [Fri, 13 Apr 2012 07:15:35 +0000 (09:15 +0200)]
Bug 5347: Followup: FIX 2 bugs in lateorders

1/ Failed to claim late orders (Can't use string as a HASH ref)
2/ Don't show the red error message after submit the form for claims

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1/ Fixed.
2/ Also fixed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5347'
Paul Poulain [Wed, 18 Apr 2012 15:02:25 +0000 (17:02 +0200)]
Merge remote-tracking branch 'origin/new/bug_5347'

12 years agoBug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders
Ian Walls [Mon, 19 Mar 2012 23:16:48 +0000 (19:16 -0400)]
Bug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders

If there are no late orders in the database, the 5th unit test for C4/Acquisition.pm
fails, since no date is returned (and today's date is expected)

This patch adds a conditional check around whether any late orders are actually returned
by GetLateOrders. If so, tests proceed, if not, they're skipped.  This seems to quiet
the failures in the automated test suite.

http://bugs.koha-community.org/show_bug.cgi?id=5347

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

12 years agoMerge remote-tracking branch 'origin/new/bug_7016'
Paul Poulain [Wed, 18 Apr 2012 14:54:44 +0000 (16:54 +0200)]
Merge remote-tracking branch 'origin/new/bug_7016'

12 years agobug 7016 further followup: clarify return of GetItemnumbersForBiblio
Galen Charlton [Wed, 11 Apr 2012 20:13:22 +0000 (16:13 -0400)]
bug 7016 further followup: clarify return of GetItemnumbersForBiblio

New function was actually returning an arrayref, so made
perldoc and function usage consistent.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7016 Followup: Add new GetItemnumberForBiblio subroutine
Ian Walls [Fri, 6 Jan 2012 14:53:49 +0000 (09:53 -0500)]
Bug 7016 Followup: Add new GetItemnumberForBiblio subroutine

Adds a new subroutine in C4::Items, GetItemnumbersForBiblio, which takes a
single biblionumber, and returns an array of all the corresponding itemnumbers.

This patch also replaces the usage of get_itemnumbers_of in C4::Reserves::CanBookBeReserved
with this new subroutine, as the output is more consistent with what we were
lookng for (this is what fixes the bug issue).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoBug 7902 - Adding Function to Check for Existence of Tables
Chris Nighswonger [Thu, 5 Apr 2012 13:38:52 +0000 (09:38 -0400)]
Bug 7902 - Adding Function to Check for Existence of Tables

This patch adds a function TableExists which checks for the existence
of a given table and returns 1 or 0 accordingly. This allows us to
check for the existence of a given table when doing operations on
tables which may not exist in a given database which, in turn, will
reduce the number of red errors which show up after an upgrade.

An example of its use is included in this patch.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7936: Reports Help Files for 3.8
Nicole C. Engard [Thu, 12 Apr 2012 14:03:49 +0000 (10:03 -0400)]
Bug 7936: Reports Help Files for 3.8

This updates the existing help files and adds a new
help file for the holds stats report.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7936: Patron Help Files
Nicole C. Engard [Thu, 12 Apr 2012 08:15:54 +0000 (04:15 -0400)]
Bug 7936: Patron Help Files

12 years agoBug 7936: Catalogue Help Files
Nicole C. Engard [Wed, 11 Apr 2012 06:59:48 +0000 (02:59 -0400)]
Bug 7936: Catalogue Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Patron Card Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:24:16 +0000 (00:24 -0400)]
Bug 7936: Patron Card Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Label Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:20:55 +0000 (00:20 -0400)]
Bug 7936: Label Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Circ Help Files
Nicole C. Engard [Wed, 11 Apr 2012 03:56:15 +0000 (23:56 -0400)]
Bug 7936: Circ Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Holds Help File for 3.8
Nicole C. Engard [Wed, 11 Apr 2012 02:59:35 +0000 (22:59 -0400)]
Bug 7936: Holds Help File for 3.8

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Comments Moderation Help File
Nicole C. Engard [Tue, 10 Apr 2012 19:46:07 +0000 (15:46 -0400)]
Bug 7936: Comments Moderation Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Suggestion help file
Nicole C. Engard [Tue, 10 Apr 2012 19:13:02 +0000 (15:13 -0400)]
Bug 7936: Suggestion help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Authorities Help Files
Nicole C. Engard [Tue, 10 Apr 2012 19:01:10 +0000 (15:01 -0400)]
Bug 7936: Authorities Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Marc Export Help File
Nicole C. Engard [Tue, 10 Apr 2012 18:57:36 +0000 (14:57 -0400)]
Bug 7936: Marc Export Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Tags help file
Nicole C. Engard [Tue, 10 Apr 2012 18:55:30 +0000 (14:55 -0400)]
Bug 7936: Tags help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Tools Help for 3.8
Nicole C. Engard [Tue, 10 Apr 2012 16:00:12 +0000 (12:00 -0400)]
Bug 7936: Tools Help for 3.8

This updates the tools help files and adds a new
help file for the new upload cover images tool.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Cataloging Help Files
Nicole C. Engard [Mon, 9 Apr 2012 20:12:25 +0000 (16:12 -0400)]
Bug 7936: Cataloging Help Files

These are the updated help files for cataloging

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Help file for Lists
Nicole C. Engard [Mon, 9 Apr 2012 20:06:36 +0000 (16:06 -0400)]
Bug 7936: Help file for Lists

This is the 3.8 help file for lists.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: 3.8 Help Files
Nicole C. Engard [Mon, 9 Apr 2012 19:57:41 +0000 (15:57 -0400)]
Bug 7936: 3.8 Help Files

These are the three help files that do not belong in any
specific directory. Links updated to the 3.8 manual.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5345 [FOLLOW-UP] DataTables in Koha
Owen Leonard [Tue, 6 Mar 2012 17:43:55 +0000 (12:43 -0500)]
Bug 5345 [FOLLOW-UP] DataTables in Koha

Adding missing images: The "disabled" version of the next,
previous, first, and last buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5668'
Paul Poulain [Fri, 13 Apr 2012 13:32:25 +0000 (15:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_5668'

12 years agoBug 5668 Error during during insall with web installer, Step 3
mveron [Thu, 12 Apr 2012 20:17:02 +0000 (22:17 +0200)]
Bug 5668 Error during during insall with web installer, Step 3

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Before patch web installer dies with error message on creating
database tables:
ERROR 1064 (42000) at line 2821: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '- biblionumber int(11)
NOT NULL, - rating_value tinyint(1) NOT NULL, - ' at line 2

After patch installation completes normally. I also checked
that tables ratings and pending_offline_operations were
created correctly.

Note: This is Marc Veron's first patch for Koha - congratulations!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7831 : Sort budgets for selection in new order
Colin Campbell [Tue, 27 Mar 2012 15:04:12 +0000 (16:04 +0100)]
Bug 7831 : Sort budgets for selection in new order

The select budget dropdown list should be presented in
an ordered fashion. To achieve this sort the budget array
by the visible text.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7876'
Paul Poulain [Thu, 12 Apr 2012 16:11:05 +0000 (18:11 +0200)]
Merge remote-tracking branch 'origin/new/bug_7876'

12 years agoBug 7876 - Followup - Fix span tag position, add fine amount spans.
Kyle M Hall [Tue, 10 Apr 2012 16:51:23 +0000 (12:51 -0400)]
Bug 7876 - Followup - Fix span tag position, add fine amount spans.

Span was outside, the if statement, could possible cause problems
with jQuery customizations, moved span to inside the conditional.

Also added span for the fine amount itself, so that it may be
re-used for jQuery customizations.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passed tests, spans appear to be correct.

12 years agoBug 2034: Removing unused scripts billig.pl/billing.tt
Katrin Fischer [Sun, 8 Apr 2012 09:26:24 +0000 (11:26 +0200)]
Bug 2034: Removing unused scripts billig.pl/billing.tt

- Scripts are currently not linked from anywhere in the templates
- Functionality can also be achieved with a custom report
- There are unresolved problems with the sql in the existig scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7940 - Placing a hold on a single item from the staff cart causes errors
Kyle M Hall [Tue, 10 Apr 2012 15:36:36 +0000 (11:36 -0400)]
Bug 7940 - Placing a hold on a single item from the staff cart causes errors

This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7838 - Add sort-string-utf.chr for Ukrainian and Russian
Serhij Dubyk {Сергій Дубик} [Tue, 27 Mar 2012 23:46:09 +0000 (02:46 +0300)]
Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7834: order search at the top of acq does nothing
Katrin Fischer [Mon, 9 Apr 2012 07:48:46 +0000 (09:48 +0200)]
Bug 7834: order search at the top of acq does nothing

Entering a search term for 'title' or 'vendor' at the top search
form in acq (tab 'Orders search') did redirect to the advanced
search form, but didn't start the search.

After applying the patch the search will bring back results immediately
or redirect to the form, when there are no results.

To test:
- Check all searches still work as expected by searching for title,
vendor, order name and invoice number
- Check advanced search still has the search terms prepopulated
- Check searches with and without results are ok

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7756: FIX send email for late orders
Jonathan Druart [Tue, 10 Apr 2012 08:06:59 +0000 (10:06 +0200)]
Bug 7756: FIX send email for late orders

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- sending claim mails works now
- claim counter is not increased when vendor has no email address

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agomissing \n in updatedatabase that causes some ugly display
Paul Poulain [Wed, 11 Apr 2012 13:18:40 +0000 (15:18 +0200)]
missing \n in updatedatabase that causes some ugly display

12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Wed, 11 Apr 2012 07:34:48 +0000 (09:34 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 [FOLLOW-UP] Capitalize strings consistently
Owen Leonard [Tue, 10 Apr 2012 19:43:48 +0000 (15:43 -0400)]
Bug 2780 [FOLLOW-UP] Capitalize strings consistently

Changes to the case of some hidden input values prevented
the user from being able to save a new SQL report.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, can now save sql reports.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agomembers now passes perlcritic, but not misc. removing testing of misc
Paul Poulain [Tue, 10 Apr 2012 16:03:55 +0000 (18:03 +0200)]
members now passes perlcritic, but not misc. removing testing of misc

12 years agoUpdating euskara and french translation teams
Paul Poulain [Tue, 10 Apr 2012 14:13:37 +0000 (16:13 +0200)]
Updating euskara and french translation teams

12 years agoBug 7935 follow-up: DBRev number
Paul Poulain [Tue, 10 Apr 2012 13:26:55 +0000 (15:26 +0200)]
Bug 7935 follow-up: DBRev number

12 years agoBug 7935: Introduce sys pref to control 'browse results' in OPAC
Katrin Fischer [Mon, 9 Apr 2012 19:27:16 +0000 (21:27 +0200)]
Bug 7935: Introduce sys pref to control 'browse results' in OPAC

Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.

Preference is activated by default and can be deactivated using the
system preference.

To test:
 - Check database update works correctly
 - Check that browsing and paging still works with after database update
 - Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
 - Check the feature does no longer show up in OPAC
 - Check that a new installation also has the system preference with correct default

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2505 follow-up: C4::Ris not ready for use strict;use warnings;
Paul Poulain [Tue, 10 Apr 2012 13:08:47 +0000 (15:08 +0200)]
Bug 2505 follow-up: C4::Ris not ready for use strict;use warnings;

The patch pushed a few hours ago is a good 1st step in the right direction.
however, many things are still to do to have the script OK with strict/warning, so commenting them

Errors if you have them:

Global symbol "$utf" requires explicit package name at C4/Ris.pm line 111.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 353.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 363.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 389.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 431.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 438.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 439.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 440.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 441.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 442.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 443.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 464.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 465.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 466.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 479.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 480.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 483.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 484.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 485.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 501.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 505.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 527.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 530.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 539.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 540.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 556.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 557.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 561.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 562.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 578.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 579.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 583.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 584.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 613.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 614.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 629.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 630.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 645.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 646.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 674.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 706.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 710.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 715.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 721.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 725.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 729.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 731.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 734.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 735.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 738.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 772.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 776.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 779.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 789.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 892.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 895.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 901.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 935.
Global symbol "$utf" requires explicit package name at C4/Ris.pm line 962.
Global symbol "$uniout" requires explicit package name at C4/Ris.pm line 966.
C4/Ris.pm had compilation errors.