]> git.koha-community.org Git - koha.git/commit
Bug 34767: Pass fee_ack into ::Transaction::Renew(All)
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 12 Sep 2023 15:24:19 +0000 (16:24 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 15 Sep 2023 14:57:11 +0000 (11:57 -0300)
commit3a2dcf0733733a92ddbf46fb863434a46060e279
tree944a422e6df466a71038912662fd035febe02cc8
parenta3e40408ea6792186e87e95a7de1dff515981432
Bug 34767: Pass fee_ack into ::Transaction::Renew(All)

This patch copies the $fee_ack field into the generated
::Transaction::Renew|All objects such that the fee acknowldegement flag
is respected for renewals.

Test plan
To test:
1) Add a rental charge to an itemtype
2) Checkout an item of that itemtype to a user
3) Attempt a renewal of that item via SIP2 and note that it fails
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m renew
4) Pass the fee_acknowledgement bit in renewal and note the renewal
   still fails.
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew
5) Apply patch and note the above now succeeds
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction/Renew.pm
C4/SIP/ILS/Transaction/RenewAll.pm