]> git.koha-community.org Git - koha.git/commit
Bug 33957: Add normalized_oclc and only fetch when needed
authorNick Clemens <nick@bywatersolutions.com>
Thu, 8 Jun 2023 11:15:27 +0000 (11:15 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 12 Jul 2023 08:18:21 +0000 (09:18 +0100)
commit67343cbd450cc3d74220a5838223d6700069fece
treeeedd7b8e51bbbeb092e5f243b132b0ad6018bf68
parent50165d8e86294d415da053e1a7ab4c7e198a93da
Bug 33957: Add normalized_oclc and only fetch when needed

opac-user.tt wants to normalized_oclc number if using syndetics or B&T images

We don't need to fetch it if not, but we need to pass it if so

To test:
1 - Switch all Syndetics prefs to 'Show' or 'Use' except
    SyndeticsClientCode = just enter 'test'
2 - Checkout some items to a patron, ensure the records have:
    - ISBN
    - UPC
    - OCLC number
3 - View opac-user.pl (sign in to opac as the user)
4 - View the network console tab (may need to reload)
5 - Note requests like:
    https://secure.syndetics.com/index.aspx?isbn=1780335792/MC.GIF&client=test&type=xw10&upc=&oclc=
6 - Note that oclc parameter is not filled for record with an oclc number
7 - Apply patch
8 - Reload
9 - Confirm the link now has oclc as expected
10 - Disable syndetics, enable google books or another source
11 - Confirm images display as expected

JD amended patch: tidy

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a59f757fd715600c21c9e7ceca87d1a24d5d694f)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
opac/opac-user.pl