]> git.koha-community.org Git - koha.git/commit
Bug 34552: Don't exclude payments with no status
authorNick Clemens <nick@bywatersolutions.com>
Fri, 25 Aug 2023 15:51:12 +0000 (15:51 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 18 Sep 2023 20:54:30 +0000 (10:54 -1000)
commit7d977be3e9431ee7f7e7c58a2889189ef648966b
tree8f94ff83110e9f4d7cce75d22d22ca023c74f4b4
parentcdb5734ade61abf0e62b5a3f79d8fdcb3fbe38f5
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 6ee6bea6bfee301146dc2f631480b227d237e43a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
reports/cash_register_stats.pl