]> git.koha-community.org Git - koha.git/commit
Bug 34613: Replace onclick attributes in midiplayer.js
authorDavid Cook <dcook@prosentient.com.au>
Fri, 25 Aug 2023 01:26:01 +0000 (01:26 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 18 Sep 2023 21:29:26 +0000 (11:29 -1000)
commit87ec1caebc1d3ce5b525c9c8605541e7f24341e7
tree949e6661aba0da5905de9b90e752755b4e4ea9bd
parent71b92c80c89c05311db4a8e2452632f114ef75c0
Bug 34613: Replace onclick attributes in midiplayer.js

This patch replaces the onclick attributes in midiplayer.js
with Javascript click handlers.

To test:
0. Apply patch
1. Clear browser cache (it may be necessary to go into the
   Network tab and explicitly disable cache)
2. Add 031 subfields 2gopnu to Default framework
3. Create a catalogue record with a 031 like follows:
2: pe
g: G-2
o: 4/4
p: 4bB''C2bE/2F4GbB/'bB2''C4D/F2.bE/4GG2bB/4'''C2C4''bB/4bE2G4bB/4bE2.F/
n: xFCGD
4. Enable the following sysprefs:
   OPACShowMusicalInscripts
   OPACPlayMusicalInscripts
5. Go to OPAC record view and click "Play this sample"
6. Play with the "Pause/Start" and "Stop" buttons
7. If the buttons work, it means the patch worked

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a4bdd27fd9d953a8ae086a6f3e8b7960f9b7160b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/lib/verovio/midiplayer.js