]> git.koha-community.org Git - koha.git/commit
Bug 34666: Allow item_group to be null and still match
authorNick Clemens <nick@bywatersolutions.com>
Wed, 30 Aug 2023 18:38:56 +0000 (18:38 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 8 Sep 2023 19:40:54 +0000 (09:40 -1000)
commitf4641ea97228966cc5b7a54e1bfda2778b4d1a3b
tree494cdede244ac34dc7af78de0c7747186a63bf10
parent0cad18658a2b04513349b7c4c9740b77261f02a5
Bug 34666: Allow item_group to be null and still match

The current logic requires that the grop ids match, but this eliminates null matches
from the group.

The fallout essentially is that the queue won't be checked to fill holds in cases of title level matches
where holds don't have an item group id. The queue checks the transport cost matrix while the check reserves
check does not, so this may have an impact on holds costs and delivery times

To test:
0 - Apply unit test patch
1 - prove -v t/db_dependent/Reserves.t
2 - It fails
3 - Apply this patch
4 - prove -v t/db_dependent/Reserves.t
5 - It passes!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit fe3872f62885b4b0ee483e446c0b2b85e74970f7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Reserves.pm