From 1a5efe389d17c49f24d94815c5695eaf07fec9f6 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 30 Jan 2020 13:19:37 +0000 Subject: [PATCH] Bug 24532: Fix original DB update for bug 23049 Pathalogical cases of Payments and Writeoffs being converted to debits are identified during the DB update for bug 23049, but we are not correctly limiting to those types accountlines when subsequently populating the debit_type field. Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize --- installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index f748f816ac..d2d8f7a9d9 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -19919,7 +19919,7 @@ if ( CheckVersion($DBversion) ) { # Populating debit_type_code $dbh->do( qq{ - UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) + UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) AND amount >= 0 } ); -- 2.39.5