From 28e980a25d02ea48609d3ec2ab025034a05ecc4b Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 6 Apr 2018 08:05:58 +0200 Subject: [PATCH] Bug 18816: (QA follow-up) Fix Circulation.t Resolve: ok 33 - Can renew, item is marked not for loan, hold does not block Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/devclone/C4/Items.pm line 557. Trivial fix. Remove fourth parameter. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- t/db_dependent/Circulation.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 0e82019e6e..d9c614bf6c 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -418,7 +418,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); ModItem({ notforloan => 1 }, $biblionumber, $itemnumber); ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1); is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block'); - ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber,1); + ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber); # FIXME: Add more for itemtype not for loan etc. -- 2.39.5