From 2dc5ae238ae0eb58040be4612cae641330b868ba Mon Sep 17 00:00:00 2001 From: Lyon3 Team Date: Fri, 5 Jun 2015 15:37:57 +0200 Subject: [PATCH] Bug 14343: Incorrect links to results pages in Receive Shipment List Numbered links have incorrect url. Links to result pages don't work in Receive Shipment List (but fortunately, Next and Previous buttons work) It's because the booksellerid is not furnished in the url. Test Plan : 1) Go to Acquisitions module, enter a bookseller name that you know you can get many page of invoices for and search for it. 2) click on Receive shipment button. 3) On bottom of the first results page, click on page number 2 link. (cf joined screencast) You'll see that the results include invoices from other booksellerid. Indeed, I suppose that you get results from all booksellerid. Intall patch and redo 3 steps. NOTE: I did not follow this test plan. I read the acqui/parcels.pl code. The template parameter numbers is assigned in a function which has no reference to booksellerid at all! Additionally, the booksellerid is set directly elsewhere. It is also strange that the booksellerid references before and after this loop do not use the numbers.booksellerid, but just booksellerid. The change from numbers.booksellerid to booksellerid is correct! Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt index 486fac2a15..9eabbdb067 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt @@ -139,7 +139,7 @@ [% IF ( number.highlight ) %] [% number.number %] [% ELSE %] - [% number.number %] + [% number.number %] [% END %] [% END %] [% IF ( displaynext ) %] -- 2.39.5