From 5db28348ea219dff070acc221f151ff8719d77ba Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Mon, 9 Oct 2023 21:29:13 +0000 Subject: [PATCH] Bug 34300: (QA follow-up) Add permission check and fix missing table cells * Changes text from "Place a hold on order" to the more common "Place hold" * Adds permission check on reserveforothers. * We were missing table cells in the footer rows of the table. I would have liked to hide the column for someone missing permissions, but I failed to get the datatable configuration right with the export and column configuration settings. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt index ceceeeb5fb..78e61ad302 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt @@ -482,7 +482,7 @@ [% IF Koha.Preference('EDIFACT') && ediaccount %] Supplier report [% END %] - Place hold + Place hold [% IF ( active ) %] [% UNLESS ( closedate ) %] Modify @@ -516,6 +516,7 @@ [% IF Koha.Preference('EDIFACT') && ediaccount %]   [% END %] +   [% IF ( active ) %] [% UNLESS ( closedate ) %]   @@ -547,6 +548,7 @@ [% IF Koha.Preference('EDIFACT') && ediaccount %]   [% END %] +   [% IF ( active ) %] [% UNLESS ( closedate ) %]   @@ -678,9 +680,11 @@ [% books_loo.suppliers_report | html %] [% END %] - - Place a hold on the order - + [% IF ( CAN_user_reserveforothers_place_holds ) %] + + Place hold + + [% END %] [% IF ( active ) %] [% UNLESS ( closedate ) %] -- 2.39.5