From 8d10a8ca3d818bc8c484b172eaf766dfcbe2645d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 28 Sep 2023 11:25:02 +0000 Subject: [PATCH] Bug 34944: Remove the use of event attributes from OPAC full serial issue page This patch removes the use of event attributes (onclick) from the OPAC's full serial issues template. These events are defined now along with the other in-page JS. To test you must have a serial record with issues from multiple years. - Locate the serial record and view the detail page. - Click "More details" at the bottom of the "Subscriptions" tab. - Click the "Full history" tab. - Test the "Show year" controls to confirm that clicking each year correctly filters the table of issues to show only issues from that year. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 10ef1fe67226a09b15a563b04cde6cca266b87ce) Signed-off-by: Fridolin Somers (cherry picked from commit fc8972d45b0010761d800ce16d711dc1c1162bfe) Signed-off-by: Matt Blenkinsop --- .../bootstrap/en/modules/opac-full-serial-issues.tt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt index 3b24ba9087..b7b6dc9c80 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt @@ -113,7 +113,7 @@ Show year: [% FOREACH year IN years %] [% IF ( year.year ) %] - [% year.year | html %] + [% year.year | html %] [% END %] [% END %] @@ -211,9 +211,12 @@ $("#reset").click(function(){ clearFilters(); }); - $("a.tabsubs").click(function(){ + $("a.tabsubs").on("click", function(e){ + e.preventDefault(); + let year = $(this).data("year"); $("a.tabsubs").removeClass("currentsubtab"); $(this).addClass("currentsubtab"); + showlayer( year ); }); $(".subscriptionstclass").dataTable($.extend(true, {}, dataTablesDefaults, { "order": [[ 0, "desc" ]] -- 2.39.5