From 94d5bd4f022c2b3f39e1d22aa28717ca0eb0d1a9 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Mon, 25 Mar 2024 09:46:06 +0000
Subject: [PATCH] Bug 36018: (follow-up) Do not rely on assumed correct
 quantities

Now filter_by_active checks quantities, we should ascertain that
our test data is correct, not leaving it to random values from
TestBuilder.

Test plan:
Run t/db_dependent/Koha/Acquisition/Order.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 t/db_dependent/Koha/Acquisition/Order.t | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t
index d80e1ee60e..d74afa1ff5 100755
--- a/t/db_dependent/Koha/Acquisition/Order.t
+++ b/t/db_dependent/Koha/Acquisition/Order.t
@@ -417,6 +417,8 @@ subtest 'filter_by_late' => sub {
                 datecancellationprinted => undef,
                 estimated_delivery_date => undef,
                 orderstatus             => 'ordered',
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
@@ -438,6 +440,8 @@ subtest 'filter_by_late' => sub {
                 datecancellationprinted => undef,
                 estimated_delivery_date => undef,
                 orderstatus             => 'ordered',
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
@@ -459,6 +463,8 @@ subtest 'filter_by_late' => sub {
                 datecancellationprinted => undef,
                 estimated_delivery_date => undef,
                 orderstatus             => 'ordered',
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
@@ -480,6 +486,8 @@ subtest 'filter_by_late' => sub {
                 datecancellationprinted => undef,
                 estimated_delivery_date => undef,
                 orderstatus             => 'ordered',
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
@@ -492,6 +500,8 @@ subtest 'filter_by_late' => sub {
                 datecancellationprinted => undef,
                 estimated_delivery_date => undef,
                 orderstatus             => 'complete',
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
@@ -576,6 +586,8 @@ subtest 'filter_by_late' => sub {
                 datereceived            => undef,
                 datecancellationprinted => undef,
                 estimated_delivery_date => $now->clone->subtract( days => 2 ),
+                quantity                => 1,
+                quantityreceived        => 0,
             }
         }
     );
-- 
2.20.1