From a8bc7c9ef8222d0c9292ff5a93f3ecb8d68a2eed Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 8 Nov 2013 00:31:09 +0100 Subject: [PATCH] Bug 11218: fix Item Due notices not being generated To test: - Check out at least 3 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. - Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional tests and automated tests. Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 34aa358742..0a22b76a85 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2433,7 +2433,7 @@ FROM issues LEFT JOIN items USING (itemnumber) LEFT OUTER JOIN branches USING (branchcode) WHERE returndate is NULL -HAVING days_until_due > 0 AND days_until_due < ? +HAVING days_until_due >= 0 AND days_until_due <= ? END_SQL my @bind_parameters = ( $params->{'days_in_advance'} ); -- 2.39.5