From bad638578b6bb3d0913841bd71ab9fba220a529e Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 5 Dec 2022 09:18:04 +0000 Subject: [PATCH] Bug 32399: Remove FK constraints while changing columns Some users have reported that the dbrev of bug 30483 fails. This might depend on bad data, SQL server version, etc. We now remove the constraints temporarily. Test plan: Reset your version in order to pass this dbrev again. So below 22.06.00.041. * update systempreferences set value='22.0600040' where variable = 'Version'; Run updatedatabase. Bonus: Create an issues record with invalid itemnumber (set FK check off when doing so). Verify that dbrev fails and installer stops. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/db_revs/220600041.pl | 26 +++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/installer/data/mysql/db_revs/220600041.pl b/installer/data/mysql/db_revs/220600041.pl index 1d3f498f4e..21731f3f92 100755 --- a/installer/data/mysql/db_revs/220600041.pl +++ b/installer/data/mysql/db_revs/220600041.pl @@ -6,10 +6,36 @@ return { up => sub { my ($args) = @_; my ($dbh, $out) = @$args{qw(dbh out)}; + + # Count bad records (expecting zero..) + my ( $cnt ) = $dbh->selectrow_array(q{ + SELECT COUNT(issue_id) FROM issues + LEFT JOIN borrowers USING (borrowernumber) + LEFT JOIN items USING (itemnumber) + WHERE items.itemnumber IS NULL OR borrowers.borrowernumber IS NULL }); + + # If we found bad records, we will not continue + if( $cnt ) { + say $out "ERROR: Your issues table contains $cnt records violating foreign key constraints to the borrowers or items table."; + say $out "We recommend to remove them with a statement like:"; + say $out " DELETE issues FROM issues LEFT JOIN borrowers bo USING (borrowernumber) WHERE bo.borrowernumber IS NULL;"; + say $out " DELETE issues FROM issues LEFT JOIN items it USING (itemnumber) WHERE it.itemnumber IS NULL;"; + die "Interrupting installer process: database revision for bug 30483 fails!"; + } + + # Green zone: remove FK constraints while changing columns (needed for some SQL server versions) + if( foreign_key_exists('issues', 'issues_ibfk_1') ) { + $dbh->do( q|ALTER TABLE issues DROP FOREIGN KEY issues_ibfk_1| ); + } + if( foreign_key_exists('issues', 'issues_ibfk_2') ) { + $dbh->do( q|ALTER TABLE issues DROP FOREIGN KEY issues_ibfk_2| ); + } $dbh->do(q{ ALTER TABLE issues MODIFY COLUMN borrowernumber int(11) NOT NULL COMMENT 'foreign key, linking this to the borrowers table for the patron this item was checked out to', MODIFY COLUMN itemnumber int(11) NOT NULL COMMENT 'foreign key, linking this to the items table for the item that was checked out' }); + $dbh->do( q|ALTER TABLE issues ADD CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE RESTRICT ON UPDATE CASCADE| ); + $dbh->do( q|ALTER TABLE issues ADD CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE RESTRICT ON UPDATE CASCADE| ); }, }; -- 2.39.5