From cf445df109fedd3ee663396f9347a75d19a46c7e Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 13 Feb 2024 09:06:13 +0100
Subject: [PATCH] Bug 34478: Move to get for modborrowers

Bug 34478: [TO SQUASH] tools/modborrowers

We actually want to POST here to not reach the limit of a GET request.
It also fixes the following warning in the console:
  Form contains enctype=multipart/form-data, but does not contain method=post.  Submitting normally with method=GET and no enctype instead.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 tools/modborrowers.pl | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
index ab8b2fff64..0d15e256e7 100755
--- a/tools/modborrowers.pl
+++ b/tools/modborrowers.pl
@@ -206,14 +206,14 @@ if ( $op eq 'cud-show' ) {
         ,
         {
             name => "branchcode",
-            type => "cud-select",
+            type => "select",
             option => \@branches_option,
             mandatory => ( grep /branchcode/, @mandatoryFields ) ? 1 : 0,
         }
         ,
         {
             name => "categorycode",
-            type => "cud-select",
+            type => "select",
             option => \@categories_option,
             mandatory => ( grep /categorycode/, @mandatoryFields ) ? 1 : 0,
         }
@@ -280,14 +280,14 @@ if ( $op eq 'cud-show' ) {
         ,
         {
             name => "sort1",
-            type => @sort1_option ? "cud-select" : "text",
+            type => @sort1_option ? "select" : "text",
             option => \@sort1_option,
             mandatory => ( grep /sort1/, @mandatoryFields ) ? 1 : 0,
         }
         ,
         {
             name => "sort2",
-            type => @sort2_option ? "cud-select" : "text",
+            type => @sort2_option ? "select" : "text",
             option => \@sort2_option,
             mandatory => ( grep /sort2/, @mandatoryFields ) ? 1 : 0,
         }
@@ -335,6 +335,7 @@ if ( $op eq 'cud-show' ) {
     $template->param('patron_attributes_values', \@patron_attributes_values);
 
     $template->param( fields => \@fields );
+    $op = 'show';
 }
 
 # Process modifications
-- 
2.39.5