From d32d035c0ee5933bec95510acdc3fb29286cbf2e Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Sat, 14 Oct 2023 14:20:00 +0000 Subject: [PATCH] Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5dd4043b06b462080858061dc5bf6b1b193d5c33) Signed-off-by: Fridolin Somers (cherry picked from commit 743538abe787c98b36926518926968a00557b051) Signed-off-by: Matt Blenkinsop --- .../opac-tmpl/bootstrap/en/includes/title-actions-menu.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc index 9f1fb2015e..ce9bd11358 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc @@ -50,12 +50,12 @@ [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && loggedinusername && ( Koha.Preference( 'virtualshelves' ) == 1 ) ) %] [% IF ( shelf AND op == 'view' ) %] - Save to another list + Save to another list [% IF can_remove_biblios %] Remove from this list [% END %] [% ELSE %] - Save to lists + Save to lists [% END # /IF ( shelf AND op == 'view' ) %] [% END # /IF Koha.Preference( 'opacuserlogin' ) %] -- 2.39.5