From e552b366862431f0a601576914b7865600d097d3 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 22 Jul 2021 10:25:28 +0100 Subject: [PATCH] Bug 22690: (QA follow-up) Clarify uses of DBIC Signed-off-by: Jonathan Druart --- Koha/Item.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 13bf032b4b..fdc13a90b9 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -1192,7 +1192,7 @@ sub orders { $item->move_to_biblio($to_biblio[, $params]); -Move the item to another biblio and update any references also in other tables. +Move the item to another biblio and update any references in other tables. The final optional parameter, C<$params>, is expected to contain the 'skip_record_index' key, which is relayed down to Koha::Item->store. @@ -1237,7 +1237,7 @@ sub move_to_biblio { # Holds $self->holds->update({ biblionumber => $to_biblionumber }); - # hold_fill_target (there's no Koha object available) + # hold_fill_target (there's no Koha object available yet) my $hold_fill_target = $self->_result->hold_fill_target; if ($hold_fill_target) { $hold_fill_target->update({ biblionumber => $to_biblionumber }); @@ -1254,7 +1254,8 @@ sub move_to_biblio { } ); - # linktrackers + # linktrackers (there's no Koha object set available yet) + # direct lookup as there's no foreign key relationship yet my $schema = Koha::Database->new()->schema(); my $linktrackers = $schema->resultset('Linktracker')->search({ itemnumber => $self->itemnumber }); $linktrackers->update_all({ biblionumber => $to_biblionumber }); -- 2.39.5