From ea0406404832482bce4d160bfb8a7dd77fb238b5 Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Tue, 15 Nov 2022 06:57:44 -0500 Subject: [PATCH] Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Adapted test plan: 1) Apply this patch 2) For DUE and PREDUE notices, set the message body to the following: Title: [% checkout.title %] 3) For DUEDGST and PREDUEDGST notices, set the message body to the following: Titles: [% FOREACH c IN checkouts %] * [% c.title %][% END %] 4) Generate PREDUE and DUE notices for patrons including digests 5) Verify those notices contain the checkout titles Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Edit: tcohen renamed @issues => @checkouts as well Signed-off-by: Tomas Cohen Arazi Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d81bca827058e04f656ce0bf95187b7b74b2d5c2) Signed-off-by: Pedro Amorim --- misc/cronjobs/advance_notices.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index e964873e0c..b13e5cdeba 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -306,7 +306,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { itemnumber => $upcoming->{'itemnumber'}, substitute => { 'items.content' => $title, - issue => $item_info, + checkout => $item_info, }, message_transport_type => $transport, } ) @@ -355,7 +355,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { itemnumber => $upcoming->{'itemnumber'}, substitute => { 'items.content' => $title, - issue => $item_info, + checkout => $item_info, }, message_transport_type => $transport, } ) @@ -595,10 +595,10 @@ sub send_digests { }); my $titles = ""; my @itemnumbers; - my @issues; + my @checkouts; while ( my $item_info = $next_item_info->()) { push @itemnumbers, $item_info->{itemnumber}; - push( @issues, $item_info ); + push( @checkouts, $item_info ); $titles .= C4::Letters::get_item_content( { item => $item_info, item_content_fields => \@item_content_fields } ); } @@ -608,11 +608,11 @@ sub send_digests { { letter_code => $params->{letter_code}, borrowernumber => $borrowernumber, - issues => \@issues, + checkouts => \@checkouts, substitute => { count => $count, 'items.content' => $titles, - issues => \@issues, + checkouts => \@checkouts, %branch_info }, itemnumbers => \@itemnumbers, -- 2.39.5