]> git.koha-community.org Git - koha.git/commit
Bug 11247: Fix calls of TransformHtmlToXml
authorSrdjan <srdjan@catalyst.net.nz>
Thu, 14 Nov 2013 06:10:30 +0000 (19:10 +1300)
committerChris Cormack <chris@bigballofwax.co.nz>
Tue, 22 Sep 2015 01:32:06 +0000 (13:32 +1200)
commit172dce8b0dcc7870279c8571b386392d31124d81
tree99cc5d4f4ab38987d46b280ef899aa12d909b458
parent270187404e87bdae985e70a590834ed2dc5d49c7
Bug 11247: Fix calls of TransformHtmlToXml

The ind_tag of TransformHtmlToXml is unused.
Some calls to this function incorrectly revert indicator and ind_tag (which
is not a problem when both are empty..)

Patch of Srdjan Jankovic, amended and signed off by Marcel de Rooy.

The following calls are fixed:
call in acqui/addorder.pl: switched indicator with ind_tag
call in acqui/addorderiso2709.pl replaced too
acqui/finishreceive.pl replaced too

These calls are fine:
two calls in cataloguing/additem.pl are fine
call in serials/serials-edit.pl is fine
call in tools/batchMod.pl is fine

The folllow-up patch adds a simple unit test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
With AcqCreateItem=='placing an order', tested if adding an order still
worked (covered both addorder.pl and addorderiso2709.pl).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 22b41063981de608402d1dd87f6aa9e2010245dd)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
C4/Biblio.pm
acqui/addorder.pl
acqui/addorderiso2709.pl
acqui/finishreceive.pl