From 0ed8da203bdbd05a95b5921d9c7f90987b24f81a Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Fri, 12 Jun 2020 13:51:16 +0000 Subject: [PATCH] Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit Signed-off-by: donnab Signed-off-by: Marcel de Rooy [EDIT] Using capitals for SQL reserved words; added a FIXME Tested with: update reserves set found='T', itemnumber=NULL where reserve_id=... This should be a workaround while we fix the underlying problem. Signed-off-by: Jonathan Druart (cherry picked from commit 56220d211d7b5c4e2622787f9ea38ab12c8868f5) Signed-off-by: Lucas Gass (cherry picked from commit cb76501776b3d03cf7c513b50c6b38630740416e) Signed-off-by: Aleisha Amohia (cherry picked from commit 39547a6279e418823a23809c813dc198a07eca75) Signed-off-by: Victor Grousset/tuxayo --- circ/pendingreserves.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index f2f291a154..87fc5156d5 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -215,7 +215,7 @@ my $strsth = $sqldatewhere AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber) AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where datearrived IS NULL) - AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL) + AND items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE found IS NOT NULL AND itemnumber IS NOT NULL) AND issues.itemnumber IS NULL AND reserves.priority <> 0 AND reserves.suspend = 0 @@ -224,7 +224,7 @@ my $strsth = "; # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when # multiple patrons have a hold on an item - +#FIXME "found IS NOT NULL AND itemnumber IS NOT NULL" is just a workaround: see BZ 25726 if (C4::Context->preference('IndependentBranches')){ $strsth .= " AND items.holdingbranch=? "; -- 2.39.5