]> git.koha-community.org Git - koha.git/commit
Bug 9135: updatedatabase.pl fails when DEBUG is set
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Fri, 23 Nov 2012 17:30:26 +0000 (12:30 -0500)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 5 Dec 2012 02:52:38 +0000 (15:52 +1300)
commit1ba19cdda919ab4ece758ee29413b3735040c1e9
tree7d5349c68cf5063b585e7b0842c1737f4356361b
parentb86c7be28d888d61bb60df5082641bea61e8f938
Bug 9135: updatedatabase.pl fails when DEBUG is set

When the DEBUG environment variable is set to a true value, all DBI
errors are treated as fatal. Unfortunately, duplicate keys are
incredibly common in updatedatabase.pl, since sysprefs are often added
in testing, then re-added once the patches have been pushed to master
(or added when on a maintenance branch, and then re-added when the
system is upgraded to either a newer maintenance branch or master).
This patch disables fatal errors for the updatedatabase.pl script.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.
To test, run from command line:
export DEBUG=1
installer/data/mysql/updatedatabase.pl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
If a query causes an error, the script continues as expected.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
installer/data/mysql/updatedatabase.pl