]> git.koha-community.org Git - koha.git/commit
Bug 23242: Fix insert of Z3950 servers with strict SQL modes
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 4 Aug 2019 17:48:07 +0000 (12:48 -0500)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 17 Sep 2019 20:24:45 +0000 (20:24 +0000)
commitaccba6b13a37b0b5a68c7955161e29d3ca1e24da
treea83814f8221c1a656b157dff898ce40f399aeb12
parent105e3c9ce04d2958d9e0749c579f73fece94d641
Bug 23242: Fix insert of Z3950 servers with strict SQL modes

If strict SQL modes are set, the insertion of a new Z3950 server can
fail.

DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: ''
for column 'checked' at row 1 at
/home/vagrant/kohaclone/admin/z3950servers.pl line 82

Using Koha::Z3950Servers fixes the issue (handled from
Koha::Object->store)

Test plan:
- Turn the strict SQL modes on (config strict_sql_modes)
- Create a new Z3950 server filling only the mandatory fields.
=> Without this patch you will get the failure, with this patch applied
the server will be inserted sucessfully
- Delete it
=> No regression should be found
- Search for servers
=> No regression should be found (the search is a start-with, LIKE "$pattern%")

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a9c730244768ea355004e821d5be35dc2e617840)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 164893acfe89fbf1156ad8a93bee28771ba370d8)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
admin/z3950servers.pl