]> git.koha-community.org Git - koha.git/commit
Bug 25237: Fix semantic heading for opac-details
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 Jun 2020 11:45:57 +0000 (12:45 +0100)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Thu, 30 Jul 2020 14:35:56 +0000 (02:35 +1200)
commite0b84c81321dba72f6c333eabe0ac4ca8e81cb4b
tree51d1b19dd4f23a695bc9727701e4266230451a5a
parentca7607af5cdfcf96833d5b883a61e1d629a38056
Bug 25237: Fix semantic heading for opac-details

Prior to this patch the opac-details view contained semantically incorrect h3
headings for the author information.

Test plan
1/ Perform a search in the OPAC that will yield results
2/ Navigate to any results detailed view
3/ Inspect the page and note that there are semantically incorrect headings
   H1 (Page title) > H2 (Item title) > H5 (Author)
4/ Apply the patch
5/ Reload the page
6/ Inspect the page and note that the semantically incorrect author block has
   been converted to a span with an 'h3' class for styling
7/ Note the page still appears nicely
8/ Signoff

Bonus points: Check with XSLT views enabled and disabled.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6b49a70b94d6b5e0e2e1cde3025ade1278814925)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit bb805283f6094c0ba0988b574bd7ee8b5492f53f)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl