From 0f1c1f11b35241daf12c359915ec7767b8196cff Mon Sep 17 00:00:00 2001
From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Date: Thu, 23 May 2024 09:23:10 +0000
Subject: [PATCH] Bug 36937: Remove warning from unit tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This patch fixes a warning in the unit tests

Test plan:
1) prove t/db_dependent/api/v1/password_validation.t
2) There will be a warning in the output - 'Use of uninitialized value $status in numeric eq (==)'
3) Apply patch
4) Re-run the test
5) The warning will disappear

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit 0af87f009f5e66ee82ea33767489ef4158820377)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
---
 Koha/REST/V1/Auth/Password.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Koha/REST/V1/Auth/Password.pm b/Koha/REST/V1/Auth/Password.pm
index 189dcc80d5..339229477d 100644
--- a/Koha/REST/V1/Auth/Password.pm
+++ b/Koha/REST/V1/Auth/Password.pm
@@ -73,7 +73,7 @@ sub validate {
     return try {
         my ( $status, $THE_cardnumber, $THE_userid, $patron ) = C4::Auth::checkpw( $identifier, $password );
         unless ( $status && $status > 0 ) {
-            my $error_response = $status == -2 ? 'Password expired' : 'Validation failed';
+            my $error_response = ($status && $status == -2) ? 'Password expired' : 'Validation failed';
             return $c->render(
                 status  => 400,
                 openapi => { error => $error_response }
-- 
2.39.5