From 8ae8bb11b4fd4d302243323a703b62cdccb353e5 Mon Sep 17 00:00:00 2001 From: Slava Shishkin Date: Wed, 26 Apr 2023 19:59:14 +0300 Subject: [PATCH] Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6ebe303e14e0c5ca542c6d3da5df1369ab3b6c18) Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/en/modules/circ/article-requests.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt index af63e41876..88e0306baa 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt @@ -521,15 +521,15 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'datatables.inc' %]