From a0b1ee7df30a191a65fc44020bbe18dd69366ce2 Mon Sep 17 00:00:00 2001
From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Date: Fri, 10 May 2024 08:31:42 +0300
Subject: [PATCH] Bug 36825: Hide "Protected" field via BorrowerUnwantedField
 syspref

Setting field "Protected" as hidden in patron entry/modification
form via BorrowerUnwantedField syspref doesn't work. Form is
missing condition "UNLESS noprotected".

To test:
1. From BorrowerUnwantedField, check field "Protected" as hidden.
2. Either attempt to create a new patron or modify existing one.
=> Note that "Protected" is still displayed in the form.
3. Apply this patch.
4. Navigate back to create/modify patron form.
=> Note that "Protected" is no longer displayed.
5. Uncheck field "Protected" from BorrowerUnwantedField.
=> Field should now be displayed in create/modify form.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/modules/members/memberentrygen.tt | 46 ++++++++++---------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index 0d61794723..6877ef453f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -1080,28 +1080,30 @@ legend.collapsed i.fa.fa-caret-down::before {
                                             </li>
                                         [% END %]
 
-                                        <li class="radio">
-                                            <label for="protected">Protected:</label>
-                                            [% IF ( patron.protected == 1 ) %]
-                                                <label for="yes-protected">
-                                                    Yes
-                                                    <input type="radio" id="yes-protected" name="protected" value="1" checked="checked" />
-                                                </label>
-                                                <label for="no-protected">
-                                                    No
-                                                    <input type="radio" id="no-protected" name="protected" value="0" />
-                                                </label>
-                                            [% ELSE %]
-                                                <label for="yes-protected">
-                                                    Yes
-                                                    <input type="radio" id="yes-protected" name="protected" value="1" />
-                                                </label>
-                                                <label for="no-protected">
-                                                    No
-                                                    <input type="radio" id="no-protected" name="protected" value="0" checked="checked" />
-                                                </label>
-                                            [% END %]
-                                        </li>
+                                        [% UNLESS noprotected %]
+                                            <li class="radio">
+                                                <label for="protected">Protected:</label>
+                                                [% IF ( patron.protected == 1 ) %]
+                                                    <label for="yes-protected">
+                                                        Yes
+                                                        <input type="radio" id="yes-protected" name="protected" value="1" checked="checked" />
+                                                    </label>
+                                                    <label for="no-protected">
+                                                        No
+                                                        <input type="radio" id="no-protected" name="protected" value="0" />
+                                                    </label>
+                                                [% ELSE %]
+                                                    <label for="yes-protected">
+                                                        Yes
+                                                        <input type="radio" id="yes-protected" name="protected" value="1" />
+                                                    </label>
+                                                    <label for="no-protected">
+                                                        No
+                                                        <input type="radio" id="no-protected" name="protected" value="0" checked="checked" />
+                                                    </label>
+                                                [% END %]
+                                            </li>
+                                        [% END %]
 
                                         [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' ) %]
                                             <li>
-- 
2.39.5