3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 32;
21 use DateTime::Duration;
24 use t::lib::TestBuilder;
39 require_ok('C4::Circulation');
57 my $schema = Koha::Database->schema;
58 $schema->storage->txn_begin;
59 my $dbh = C4::Context->dbh;
61 my $builder = t::lib::TestBuilder->new();
63 $dbh->do(q|DELETE FROM issues|);
64 $dbh->do(q|DELETE FROM items|);
65 $dbh->do(q|DELETE FROM borrowers|);
66 $dbh->do(q|DELETE FROM categories|);
67 $dbh->do(q|DELETE FROM accountlines|);
68 $dbh->do(q|DELETE FROM issuingrules|);
69 $dbh->do(q|DELETE FROM reserves|);
70 $dbh->do(q|DELETE FROM old_reserves|);
71 $dbh->do(q|DELETE FROM statistics|);
73 # Generate sample datas
74 my $itemtype = $builder->build(
75 { source => 'Itemtype',
76 value => { notforloan => undef, rentalcharge => 0 }
79 my $branchcode_1 = $builder->build({ source => 'Branch' })->{branchcode};
80 my $branchcode_2 = $builder->build({ source => 'Branch' })->{branchcode};
81 my $branchcode_3 = $builder->build({ source => 'Branch' })->{branchcode};
82 my $categorycode = $builder->build({
84 value => { enrolmentfee => undef }
88 my $dt_today = dt_from_string;
89 my $today = output_pref(
97 my $dt_today2 = dt_from_string;
98 my $dur10 = DateTime::Duration->new( days => -10 );
99 $dt_today2->add_duration($dur10);
100 my $daysago10 = output_pref(
103 timeformat => '24hr',
108 # Add biblio and item
109 my $record = MARC::Record->new();
110 $record->append_fields(
111 MARC::Field->new( '952', '0', '0', a => $branchcode_1 ) );
113 my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' );
115 my $barcode_1 = 'barcode_1';
116 my $barcode_2 = 'barcode_2';
117 my @sampleitem1 = C4::Items::AddItem(
119 barcode => $barcode_1,
120 itemcallnumber => 'callnumber1',
121 homebranch => $branchcode_1,
122 holdingbranch => $branchcode_1,
129 my $item_id1 = $sampleitem1[2];
130 my @sampleitem2 = C4::Items::AddItem(
132 barcode => $barcode_2,
133 itemcallnumber => 'callnumber2',
134 homebranch => $branchcode_2,
135 holdingbranch => $branchcode_2,
142 my $item_id2 = $sampleitem2[2];
145 my $borrower_id1 = Koha::Patron->new({
146 firstname => 'firstname1',
147 surname => 'surname1 ',
148 categorycode => $categorycode,
149 branchcode => $branchcode_1
150 })->store->borrowernumber;
151 my $patron_1 = Koha::Patrons->find( $borrower_id1 );
152 my $borrower_1 = $patron_1->unblessed;
153 my $borrower_id2 = Koha::Patron->new({
154 firstname => 'firstname2',
155 surname => 'surname2 ',
156 categorycode => $categorycode,
157 branchcode => $branchcode_2,
158 })->store->borrowernumber;
159 my $patron_2 = Koha::Patrons->find( $borrower_id2 );
160 my $borrower_2 = $patron_2->unblessed;
162 t::lib::Mocks::mock_userenv({ patron => $patron_1 });
167 my $query = " SELECT count(*) FROM issues";
168 my $sth = $dbh->prepare($query);
170 my $countissue = $sth -> fetchrow_array;
171 is ($countissue ,0, "there is no issue");
172 my $issue1 = C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10,0, $today, '' );
173 is( ref $issue1, 'Koha::Checkout',
174 'AddIssue returns a Koha::Checkout object' );
175 my $datedue1 = dt_from_string( $issue1->date_due() );
178 qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
179 "Koha::Checkout->date_due() returns a date"
181 my $issue_id1 = $issue1->issue_id;
183 my $issue2 = C4::Circulation::AddIssue( $borrower_1, 'nonexistent_barcode' );
184 is( $issue2, undef, "AddIssue returns undef if no datedue is specified" );
187 $countissue = $sth -> fetchrow_array;
188 is ($countissue,1,"1 issues have been added");
190 #Test AddIssuingCharge
191 $query = " SELECT count(*) FROM accountlines";
192 $sth = $dbh->prepare($query);
194 my $countaccount = $sth -> fetchrow_array;
195 is ($countaccount,0,"0 accountline exists");
196 my $checkout = Koha::Checkouts->find( $issue_id1 );
197 my $offset = C4::Circulation::AddIssuingCharge( $checkout, 10 );
198 is( ref( $offset ), 'Koha::Account::Offset', "An issuing charge has been added" );
199 my $charge = Koha::Account::Lines->find( $offset->debit_id );
200 is( $charge->issue_id, $issue_id1, 'Issue id is set correctly for issuing charge' );
201 my $account_id = $dbh->last_insert_id( undef, undef, 'accountlines', undef );
203 $countaccount = $sth -> fetchrow_array;
204 is ($countaccount,1,"1 accountline has been added");
208 my $se = Test::MockModule->new( 'C4::Context' );
209 $se->mock( 'interface', sub {return 'intranet'});
211 # Let's renew this one at a different library for statistical purposes to test Bug 17781
212 # Mocking userenv with a different branchcode
213 t::lib::Mocks::mock_userenv({ patron => $patron_2, branchcode => $branchcode_3 });
215 my $datedue3 = AddRenewal( $borrower_id1, $item_id1, $branchcode_1, $datedue1, $daysago10 );
217 # Restoring the userenv with the original branchcode
218 t::lib::Mocks::mock_userenv({ patron => $patron_1});
222 qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
223 "AddRenewal returns a date"
226 my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
227 ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
229 $se->mock( 'interface', sub {return 'opac'});
231 #Let's do an opac renewal - whatever branchcode we send should be used
232 my $opac_renew_issue = $builder->build({
235 date_due => '2017-01-01',
236 branch => $branchcode_1,
238 borrowernumber => $borrower_id1
242 my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula", $datedue1, $daysago10 );
244 $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula" );
245 ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
249 #Test GetBiblioIssues
250 is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
253 is( GetOpenIssue(), undef, "Without parameter GetOpenIssue returns undef" );
254 is( GetOpenIssue(-1), undef,
255 "With wrong parameter GetOpenIssue returns undef" );
256 my $openissue = GetOpenIssue($borrower_id1, $item_id1);
260 my $issue3 = C4::Circulation::AddIssue( $borrower_1, $barcode_1 );
261 #Without anything in DB
262 @renewcount = C4::Circulation::GetRenewCount();
265 [ 0, 0, 0 ], # FIXME Need to be fixed, see FIXME in GetRenewCount
266 "Without issuing rules and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
268 @renewcount = C4::Circulation::GetRenewCount(-1);
271 [ 0, 0, 0 ], # FIXME Need to be fixed
272 "Without issuing rules and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
274 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
278 "Without issuing rules and with a valid parameter, renewcount = 2, renewsallowed = undef, renewsleft = 0"
281 #With something in DB
282 # Add a default rule: No renewal allowed
284 INSERT INTO issuingrules( categorycode, itemtype, branchcode, issuelength, renewalsallowed )
285 VALUES ( '*', '*', '*', 10, 0 )
287 @renewcount = C4::Circulation::GetRenewCount();
291 "With issuing rules (renewal disallowed) and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
293 @renewcount = C4::Circulation::GetRenewCount(-1);
297 "With issuing rules (renewal disallowed) and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
299 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
303 "With issuing rules (renewal disallowed) and with a valid parameter, Getrenewcount returns renewcount = 2, renewsallowed = 0, renewsleft = 0"
306 # Add a default rule: renewal is allowed
308 UPDATE issuingrules SET renewalsallowed = 3
310 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
314 "With issuing rules (renewal allowed) and with a valid parameter, Getrenewcount of item1 returns 3 renews left"
317 AddRenewal( $borrower_id1, $item_id1, $branchcode_1,
318 $datedue3, $daysago10 );
319 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
323 "With issuing rules (renewal allowed, 1 remaining) and with a valid parameter, Getrenewcount of item1 returns 0 renews left"
326 $dbh->do("DELETE FROM old_issues");
327 AddReturn($barcode_1);
328 my $return = $dbh->selectrow_hashref("SELECT DATE(returndate) AS return_date, CURRENT_DATE() AS today FROM old_issues LIMIT 1" );
329 ok( $return->{return_date} eq $return->{today}, "Item returned with no return date specified has todays date" );
331 $dbh->do("DELETE FROM old_issues");
332 C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10, 0, $today );
333 AddReturn($barcode_1, undef, undef, undef, '2014-04-01 23:42');
334 $return = $dbh->selectrow_hashref("SELECT * FROM old_issues LIMIT 1" );
335 ok( $return->{returndate} eq '2014-04-01 23:42:00', "Item returned with a return date of '2014-04-01 23:42' has that return date" );
338 ($biblionumber, $biblioitemnumber, $itemnumber) = C4::Items::AddItem(
340 barcode => 'barcode_3',
341 itemcallnumber => 'callnumber3',
342 homebranch => $branchcode_1,
343 holdingbranch => $branchcode_1,
350 t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', q{} );
351 AddReturn( 'barcode_3', $branchcode_1 );
352 my $item = GetItem( $itemnumber );
353 ok( $item->{notforloan} eq 1, 'UpdateNotForLoanStatusOnCheckin does not modify value when not enabled' );
355 t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: 9' );
356 AddReturn( 'barcode_3', $branchcode_1 );
357 $item = GetItem( $itemnumber );
358 ok( $item->{notforloan} eq 9, q{UpdateNotForLoanStatusOnCheckin updates notforloan value from 1 to 9 with setting "1: 9"} );
360 AddReturn( 'barcode_3', $branchcode_1 );
361 $item = GetItem( $itemnumber );
362 ok( $item->{notforloan} eq 9, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 9 with setting "1: 9"} );
364 # Bug 14640 - Cancel the hold on checking out if asked
365 my $reserve_id = AddReserve($branchcode_1, $borrower_id1, $biblionumber,
366 undef, 1, undef, undef, "a note", "a title", undef, '');
367 ok( $reserve_id, 'The reserve should have been inserted' );
368 AddIssue( $borrower_2, $barcode_1, dt_from_string, 'cancel' );
369 my $hold = Koha::Holds->find( $reserve_id );
370 is( $hold, undef, 'The reserve should have been correctly cancelled' );
373 $schema->storage->txn_rollback;