t/db_dependent/Circulation/transfers.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19 use C4::Context;
  20 use C4::Circulation qw( CreateBranchTransferLimit DeleteBranchTransferLimits GetTransfersFromTo TransferSlip );
  21 use C4::Biblio qw( AddBiblio );
  22 use C4::Items qw( ModItemTransfer );
  23 use Koha::Database;
  24 use Koha::DateUtils qw( dt_from_string );
  25 use DateTime::Duration;
  26 use Koha::Item::Transfers;
  27
  28 use t::lib::TestBuilder;
  29
  30 use Test::More tests => 19;
  31 use Test::Deep;
  32
  33 BEGIN {
  34     use_ok('C4::Circulation', qw( CreateBranchTransferLimit DeleteBranchTransferLimits GetTransfersFromTo TransferSlip ));
  35 }
  36 can_ok(
  37     'C4::Circulation',
  38     qw(
  39       CreateBranchTransferLimit
  40       DeleteBranchTransferLimits
  41       GetTransfersFromTo
  42       )
  43 );
  44
  45 my $schema = Koha::Database->schema;
  46 $schema->storage->txn_begin;
  47 my $builder = t::lib::TestBuilder->new;
  48
  49 my $dbh = C4::Context->dbh;
  50 $dbh->do(q|DELETE FROM issues|);
  51 $dbh->do(q|DELETE FROM borrowers|);
  52 $dbh->do(q|DELETE FROM items|);
  53 $dbh->do(q|DELETE FROM branches|);
  54 $dbh->do(q|DELETE FROM branch_transfer_limits|);
  55 $dbh->do(q|DELETE FROM branchtransfers|);
  56
  57 ## Create sample datas
  58 # Add branches
  59 my $branchcode_1 = $builder->build( { source => 'Branch', } )->{branchcode};
  60 my $branchcode_2 = $builder->build( { source => 'Branch', } )->{branchcode};
  61 # Add itemtype
  62 my $itemtype = $builder->build( { source => 'Itemtype' } )->{itemtype};
  63
  64 #Add biblio and items
  65 my $record = MARC::Record->new();
  66 $record->append_fields(
  67     MARC::Field->new( '952', '0', '0', a => $branchcode_1 ) );
  68 my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '', );
  69
  70 my $item_id1 = Koha::Item->new(
  71     {
  72         biblionumber   => $biblionumber,
  73         barcode        => 1,
  74         itemcallnumber => 'callnumber1',
  75         homebranch     => $branchcode_1,
  76         holdingbranch  => $branchcode_1,
  77         itype          => $itemtype
  78     },
  79 )->store->itemnumber;
  80 my $item_id2 = Koha::Item->new(
  81     {
  82         biblionumber   => $biblionumber,
  83         barcode        => 2,
  84         itemcallnumber => 'callnumber2',
  85         homebranch     => $branchcode_1,
  86         holdingbranch  => $branchcode_1,
  87         itype          => $itemtype
  88     },
  89 )->store->itemnumber;
  90 my $item_id3 = Koha::Item->new(
  91     {
  92         biblionumber   => $biblionumber,
  93         barcode        => 3,
  94         itemcallnumber => 'callnumber3',
  95         homebranch     => $branchcode_1,
  96         holdingbranch  => $branchcode_1,
  97         itype          => $itemtype
  98     },
  99 )->store->itemnumber;
 100 my $item_id4 = Koha::Item->new(
 101     {
 102         biblionumber   => $biblionumber,
 103         barcode        => 4,
 104         itemcallnumber => 'callnumber4',
 105         homebranch     => $branchcode_1,
 106         holdingbranch  => $branchcode_1,
 107         itype          => $itemtype
 108     },
 109 )->store->itemnumber;
 110
 111 #Add transfers
 112 my $trigger = 'Manual';
 113 ModItemTransfer(
 114     $item_id1,
 115     $branchcode_1,
 116     $branchcode_2,
 117     $trigger
 118 );
 119
 120 my $item_obj = Koha::Items->find({ itemnumber => $item_id1 });
 121 is( $item_obj->holdingbranch, $branchcode_1, "Item should be held at branch that initiates transfer");
 122
 123 ModItemTransfer(
 124     $item_id2,
 125     $branchcode_1,
 126     $branchcode_2,
 127     $trigger
 128 );
 129
 130 # Add an "unsent" transfer for tests
 131 ModItemTransfer(
 132     $item_id3,
 133     $branchcode_1,
 134     $branchcode_2,
 135     $trigger
 136 );
 137 my $transfer_requested = Koha::Item::Transfers->search( { itemnumber => $item_id3 }, { rows => 1 })->single;
 138 $transfer_requested->set({ daterequested => dt_from_string, datesent => undef })->store;
 139
 140 # Add a "cancelled" transfer for tests
 141 ModItemTransfer(
 142     $item_id4,
 143     $branchcode_1,
 144     $branchcode_2,
 145     $trigger
 146 );
 147 my $transfer_cancelled = Koha::Item::Transfers->search( { itemnumber => $item_id4 }, { rows => 1 })->single;
 148 $transfer_cancelled->set( { daterequested => dt_from_string, datesent => undef, datecancelled => dt_from_string } )->store;
 149
 150 #Begin Tests
 151 #Test CreateBranchTransferLimit
 152 is(
 153     CreateBranchTransferLimit(
 154         $branchcode_2,
 155         $branchcode_1, 'CODE'
 156     ),
 157     1,
 158     "A Branch TransferLimit has been added"
 159 );
 160 is(CreateBranchTransferLimit(),undef,
 161     "Without parameters CreateBranchTransferLimit returns undef");
 162 is(CreateBranchTransferLimit($branchcode_2),undef,
 163     "With only tobranch CreateBranchTransferLimit returns undef");
 164 is(CreateBranchTransferLimit(undef,$branchcode_2),undef,
 165     "With only frombranch CreateBranchTransferLimit returns undef");
 166 #FIXME: Currently, we can add a transferlimit even to nonexistent branches because in the database,
 167 #branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys
 168 #is(CreateBranchTransferLimit(-1,-1,'CODE'),0,"With wrong CreateBranchTransferLimit returns 0 - No transfertlimit added");
 169
 170 #Test GetTransfersFromTo
 171 my @transferfrom1to2 = GetTransfersFromTo( $branchcode_1,
 172     $branchcode_2 );
 173 cmp_deeply(
 174     \@transferfrom1to2,
 175     [
 176         {
 177             branchtransfer_id => re('[0-9]*'),
 178             itemnumber        => $item_id1,
 179             datesent          => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
 180             frombranch        => $branchcode_1
 181         },
 182         {
 183             branchtransfer_id => re('[0-9]*'),
 184             itemnumber        => $item_id2,
 185             datesent          => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
 186             frombranch        => $branchcode_1
 187         }
 188     ],
 189     "Item1 and Item2 has been transferred from branch1 to branch2"
 190 );
 191 my @transferto = GetTransfersFromTo( undef, $branchcode_2 );
 192 is_deeply( \@transferto, [],
 193     "GetTransfersfromTo without frombranch returns an empty array" );
 194 my @transferfrom = GetTransfersFromTo( $branchcode_1 );
 195 is_deeply( \@transferfrom, [],
 196     "GetTransfersfromTo without tobranch returns an empty array" );
 197 @transferfrom = GetTransfersFromTo();
 198 is_deeply( \@transferfrom, [],
 199     "GetTransfersfromTo without params returns an empty array" );
 200
 201 #Test DeleteBranchTransferLimits
 202 is(
 203     C4::Circulation::DeleteBranchTransferLimits( $branchcode_1 ),
 204     1,
 205     "A Branch TransferLimit has been deleted"
 206 );
 207 is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef");
 208 is(C4::Circulation::DeleteBranchTransferLimits('B'),'0E0',"With a wrong id DeleteBranchTransferLimit returns 0E0");
 209
 210 #Test TransferSlip
 211 is( C4::Circulation::TransferSlip($branchcode_1, undef, 5, $branchcode_2),
 212     undef, "No tranferslip if invalid or undef itemnumber or barcode" );
 213 is( C4::Circulation::TransferSlip($branchcode_1, $item_id1, 1, $branchcode_2)->{'code'},
 214     'TRANSFERSLIP', "Get a transferslip on valid itemnumber and/or barcode" );
 215 cmp_deeply(
 216     C4::Circulation::TransferSlip($branchcode_1, $item_id1, undef, $branchcode_2),
 217     C4::Circulation::TransferSlip($branchcode_1, undef, 1, $branchcode_2),
 218     "Barcode and itemnumber for same item both generate same TransferSlip"
 219     );
 220
 221 $dbh->do("DELETE FROM branchtransfers");
 222 ModItemTransfer(
 223     $item_id1,
 224     $branchcode_1,
 225     $branchcode_2,
 226     $trigger
 227 );
 228 my $transfer = Koha::Item::Transfers->search()->next();
 229 ModItemTransfer(
 230     $item_id1,
 231     $branchcode_1,
 232     $branchcode_2,
 233     $trigger
 234 );
 235 $transfer->{_result}->discard_changes;
 236 ok( $transfer->datecancelled, 'Date cancelled is set when new transfer is initiated' );
 237 is( $transfer->cancellation_reason, "Manual", 'Cancellation reason is set correctly when new transfer is initiated' );
 238
 239 $schema->storage->txn_rollback;
 240