3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
26 use C4::Overdues qw(UpdateFine);
30 use Test::More tests => 69;
33 use_ok('C4::Circulation');
36 my $dbh = C4::Context->dbh;
37 my $schema = Koha::Database->new()->schema();
40 $dbh->{RaiseError} = 1;
41 $schema->storage->txn_begin();
43 # Start with a clean slate
44 $dbh->do('DELETE FROM issues');
46 my $CircControl = C4::Context->preference('CircControl');
47 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
51 holdingbranch => 'MPL'
58 # No userenv, PickupLibrary
59 C4::Context->set_preference('CircControl', 'PickupLibrary');
61 C4::Context->preference('CircControl'),
63 'CircControl changed to PickupLibrary'
66 C4::Circulation::_GetCircControlBranch($item, $borrower),
67 $item->{$HomeOrHoldingBranch},
68 '_GetCircControlBranch returned item branch (no userenv defined)'
71 # No userenv, PatronLibrary
72 C4::Context->set_preference('CircControl', 'PatronLibrary');
74 C4::Context->preference('CircControl'),
76 'CircControl changed to PatronLibrary'
79 C4::Circulation::_GetCircControlBranch($item, $borrower),
80 $borrower->{branchcode},
81 '_GetCircControlBranch returned borrower branch'
84 # No userenv, ItemHomeLibrary
85 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
87 C4::Context->preference('CircControl'),
89 'CircControl changed to ItemHomeLibrary'
92 $item->{$HomeOrHoldingBranch},
93 C4::Circulation::_GetCircControlBranch($item, $borrower),
94 '_GetCircControlBranch returned item branch'
98 C4::Context->_new_userenv('xxx');
99 C4::Context->set_userenv(0,0,0,'firstname','surname', 'MPL', 'Midway Public Library', '', '', '');
100 is(C4::Context->userenv->{branch}, 'MPL', 'userenv set');
102 # Userenv set, PickupLibrary
103 C4::Context->set_preference('CircControl', 'PickupLibrary');
105 C4::Context->preference('CircControl'),
107 'CircControl changed to PickupLibrary'
110 C4::Circulation::_GetCircControlBranch($item, $borrower),
112 '_GetCircControlBranch returned current branch'
115 # Userenv set, PatronLibrary
116 C4::Context->set_preference('CircControl', 'PatronLibrary');
118 C4::Context->preference('CircControl'),
120 'CircControl changed to PatronLibrary'
123 C4::Circulation::_GetCircControlBranch($item, $borrower),
124 $borrower->{branchcode},
125 '_GetCircControlBranch returned borrower branch'
128 # Userenv set, ItemHomeLibrary
129 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
131 C4::Context->preference('CircControl'),
133 'CircControl changed to ItemHomeLibrary'
136 C4::Circulation::_GetCircControlBranch($item, $borrower),
137 $item->{$HomeOrHoldingBranch},
138 '_GetCircControlBranch returned item branch'
141 # Reset initial configuration
142 C4::Context->set_preference('CircControl', $CircControl);
144 C4::Context->preference('CircControl'),
146 'CircControl reset to its initial value'
149 # Set a simple circ policy
150 $dbh->do('DELETE FROM issuingrules');
152 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
153 maxissueqty, issuelength, lengthunit,
154 renewalsallowed, renewalperiod,
155 norenewalbefore, auto_renew,
172 # Test C4::Circulation::ProcessOfflinePayment
173 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
175 my ( $original_count ) = $sth->fetchrow_array();
177 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', 'S', 'MPL' )");
179 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
182 my ( $new_count ) = $sth->fetchrow_array();
184 ok( $new_count == $original_count + 1, 'ProcessOfflinePayment makes payment correctly' );
186 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
187 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
188 C4::Context->dbh->do("DELETE FROM accountlines");
190 # CanBookBeRenewed tests
192 # Generate test biblio
193 my $biblio = MARC::Record->new();
194 my $title = 'Silence in the library';
195 $biblio->append_fields(
196 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
197 MARC::Field->new('245', ' ', ' ', a => $title),
200 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
202 my $barcode = 'R00000342';
205 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
207 homebranch => $branch,
208 holdingbranch => $branch,
210 replacementprice => 12.00
215 my $barcode2 = 'R00000343';
216 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
218 homebranch => $branch,
219 holdingbranch => $branch,
220 barcode => $barcode2,
221 replacementprice => 23.00
226 my $barcode3 = 'R00000346';
227 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
229 homebranch => $branch,
230 holdingbranch => $branch,
231 barcode => $barcode3,
232 replacementprice => 23.00
238 my %renewing_borrower_data = (
240 surname => 'Renewal',
242 branchcode => $branch,
245 my %reserving_borrower_data = (
246 firstname => 'Katrin',
247 surname => 'Reservation',
249 branchcode => $branch,
252 my %hold_waiting_borrower_data = (
254 surname => 'Reservation',
256 branchcode => $branch,
259 my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
260 my $reserving_borrowernumber = AddMember(%reserving_borrower_data);
261 my $hold_waiting_borrowernumber = AddMember(%hold_waiting_borrower_data);
263 my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
270 my $checkitem = undef;
273 my $issue = AddIssue( $renewing_borrower, $barcode);
274 my $datedue = dt_from_string( $issue->date_due() );
275 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
277 my $issue2 = AddIssue( $renewing_borrower, $barcode2);
278 $datedue = dt_from_string( $issue->date_due() );
279 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
281 my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber};
282 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
284 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
285 is( $renewokay, 1, 'Can renew, no holds for this title or item');
288 # Biblio-level hold, renewal test
290 $branch, $reserving_borrowernumber, $biblionumber,
291 $bibitems, $priority, $resdate, $expdate, $notes,
292 $title, $checkitem, $found
295 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
296 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
297 C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 1 );
298 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
299 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
300 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
301 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
303 # Now let's add an item level hold, we should no longer be able to renew the item
304 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
306 borrowernumber => $hold_waiting_borrowernumber,
307 biblionumber => $biblionumber,
308 itemnumber => $itemnumber,
309 branchcode => $branch,
313 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
314 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
317 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
318 # be able to renew these items
319 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
321 borrowernumber => $hold_waiting_borrowernumber,
322 biblionumber => $biblionumber,
323 itemnumber => $itemnumber3,
324 branchcode => $branch,
329 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
330 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
331 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
332 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
333 C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 0 );
335 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
336 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
337 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
339 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
340 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
341 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
343 my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber});
344 my $reserving_borrower = GetMember( borrowernumber => $reserving_borrowernumber );
345 AddIssue($reserving_borrower, $barcode3);
346 my $reserve = $dbh->selectrow_hashref(
347 'SELECT * FROM old_reserves WHERE reserve_id = ?',
351 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
353 # Item-level hold, renewal test
355 $branch, $reserving_borrowernumber, $biblionumber,
356 $bibitems, $priority, $resdate, $expdate, $notes,
357 $title, $itemnumber, $found
360 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
361 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
362 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
364 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
365 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
368 # Items can't fill hold for reasons
369 ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
370 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
371 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
372 ModItem({ notforloan => 0, itype => '' }, $biblionumber, $itemnumber,1);
374 # FIXME: Add more for itemtype not for loan etc.
376 $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber});
377 CancelReserve({ reserve_id => $reserveid });
379 # Test automatic renewal before value for "norenewalbefore" in policy is set
380 my $barcode4 = '11235813';
381 my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
383 homebranch => $branch,
384 holdingbranch => $branch,
385 barcode => $barcode4,
386 replacementprice => 16.00
391 AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
392 ( $renewokay, $error ) =
393 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
394 is( $renewokay, 0, 'Cannot renew, renewal is automatic' );
395 is( $error, 'auto_renew',
396 'Cannot renew, renewal is automatic (returned code is auto_renew)' );
398 # set policy to require that loans cannot be
399 # renewed until seven days prior to the due date
400 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
401 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
402 is( $renewokay, 0, 'Cannot renew, renewal is premature');
403 is( $error, 'too_soon', 'Cannot renew, renewal is premature (returned code is too_soon)');
405 GetSoonestRenewDate($renewing_borrowernumber, $itemnumber),
406 $datedue->clone->add(days => -7),
407 'renewals permitted 7 days before due date, as expected',
410 # Test automatic renewal again
411 ( $renewokay, $error ) =
412 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
413 is( $renewokay, 0, 'Cannot renew, renewal is automatic and premature' );
414 is( $error, 'auto_too_soon',
415 'Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
420 # set policy to forbid renewals
421 $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
423 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
424 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
425 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
427 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
428 C4::Context->set_preference('WhenLostForgiveFine','1');
429 C4::Context->set_preference('WhenLostChargeReplacementFee','1');
431 C4::Overdues::UpdateFine( $itemnumber, $renewing_borrower->{borrowernumber},
432 15.00, q{}, Koha::DateUtils::output_pref($datedue) );
434 LostItem( $itemnumber, 1 );
436 my $item = $schema->resultset('Item')->find( $itemnumber );
437 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
439 my $total_due = $dbh->selectrow_array(
440 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
441 undef, $renewing_borrower->{borrowernumber}
444 ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
446 C4::Context->dbh->do("DELETE FROM accountlines");
448 C4::Context->set_preference('WhenLostForgiveFine','0');
449 C4::Context->set_preference('WhenLostChargeReplacementFee','0');
451 C4::Overdues::UpdateFine( $itemnumber2, $renewing_borrower->{borrowernumber},
452 15.00, q{}, Koha::DateUtils::output_pref($datedue) );
454 LostItem( $itemnumber2, 0 );
456 my $item2 = $schema->resultset('Item')->find( $itemnumber2 );
457 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
459 $total_due = $dbh->selectrow_array(
460 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
461 undef, $renewing_borrower->{borrowernumber}
464 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
466 my $now = dt_from_string();
467 my $future = dt_from_string();
468 $future->add( days => 7 );
469 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, 'MPL');
470 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
474 # GetUpcomingDueIssues tests
475 my $barcode = 'R00000342';
476 my $barcode2 = 'R00000343';
477 my $barcode3 = 'R00000344';
480 #Create another record
481 my $biblio2 = MARC::Record->new();
482 my $title2 = 'Something is worng here';
483 $biblio2->append_fields(
484 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
485 MARC::Field->new('245', ' ', ' ', a => $title2),
487 my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, '');
492 homebranch => $branch,
493 holdingbranch => $branch,
500 my %a_borrower_data = (
501 firstname => 'Fridolyn',
504 branchcode => $branch,
507 my $a_borrower_borrowernumber = AddMember(%a_borrower_data);
508 my $a_borrower = GetMember( borrowernumber => $a_borrower_borrowernumber );
510 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
511 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
512 my $today = DateTime->today(time_zone => C4::Context->tz());
514 my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
515 my $datedue = dt_from_string( $issue->date_due() );
516 my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
517 my $datedue2 = dt_from_string( $issue->date_due() );
521 # GetUpcomingDueIssues tests
523 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
524 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
527 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
528 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
529 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
532 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
533 is ( scalar( @$upcoming_dues ), 1,
534 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
537 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
539 my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
541 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
542 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
544 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
545 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
547 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
548 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
550 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
551 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
553 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
554 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
556 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
557 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
562 my $barcode = '1234567890';
565 my $biblio = MARC::Record->new();
566 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
569 my ( undef, undef, $itemnumber ) = AddItem(
571 homebranch => $branch,
572 holdingbranch => $branch,
579 my %a_borrower_data = (
583 branchcode => $branch,
586 my $borrowernumber = AddMember(%a_borrower_data);
588 UpdateFine( $itemnumber, $borrowernumber, 0 );
590 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
591 my $count = $hr->{count};
593 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
597 $dbh->do('DELETE FROM issues');
598 $dbh->do('DELETE FROM items');
599 $dbh->do('DELETE FROM issuingrules');
602 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
603 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
612 my $biblio = MARC::Record->new();
613 my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $biblio, '' );
615 my $barcode1 = '1234';
616 my ( undef, undef, $itemnumber1 ) = AddItem(
619 holdingbranch => 'MPL',
620 barcode => $barcode1,
624 my $barcode2 = '4321';
625 my ( undef, undef, $itemnumber2 ) = AddItem(
628 holdingbranch => 'MPL',
629 barcode => $barcode2,
634 my $borrowernumber1 = AddMember(
640 my $borrowernumber2 = AddMember(
641 firstname => 'Chelsea',
647 my $borrower1 = GetMember( borrowernumber => $borrowernumber1 );
648 my $borrower2 = GetMember( borrowernumber => $borrowernumber2 );
650 my $issue = AddIssue( $borrower1, $barcode1 );
652 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
653 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
656 'MPL', $borrowernumber2, $biblionumber,
657 '', 1, undef, undef, '',
661 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
662 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
663 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
664 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
666 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
667 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
668 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
669 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
671 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
672 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
673 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
674 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
676 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
677 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
678 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
679 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
681 # Setting item not checked out to be not for loan but holdable
682 ModItem({ notforloan => -1 }, $biblionumber, $itemnumber2);
684 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
685 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
689 # Don't allow renewing onsite checkout
690 my $barcode = 'R00000XXX';
693 #Create another record
694 my $biblio = MARC::Record->new();
695 $biblio->append_fields(
696 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
697 MARC::Field->new('245', ' ', ' ', a => 'A title'),
699 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
701 my (undef, undef, $itemnumber) = AddItem(
703 homebranch => $branch,
704 holdingbranch => $branch,
710 my $borrowernumber = AddMember(
714 branchcode => $branch,
717 my $borrower = GetMember( borrowernumber => $borrowernumber );
718 my $issue = AddIssue( $borrower, $barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
719 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $itemnumber );
720 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
721 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
724 $schema->storage->txn_rollback();