3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 56;
24 use Test::Deep qw( cmp_deeply );
30 use POSIX qw( floor );
32 use t::lib::TestBuilder;
35 use C4::Calendar qw( new insert_single_holiday insert_week_day_holiday delete_holiday );
36 use C4::Circulation qw( AddIssue AddReturn CanBookBeRenewed GetIssuingCharges AddRenewal GetSoonestRenewDate GetLatestAutoRenewDate LostItem GetUpcomingDueIssues CanBookBeIssued AddIssuingCharge MarkIssueReturned ProcessOfflinePayment transferbook updateWrongTransfer );
38 use C4::Items qw( ModItemTransfer );
40 use C4::Reserves qw( AddReserve ModReserve ModReserveCancelAll ModReserveAffect CheckReserves GetOtherReserves );
41 use C4::Overdues qw( CalcFine UpdateFine get_chargeable_units );
42 use C4::Members::Messaging qw( SetMessagingPreference );
43 use Koha::DateUtils qw( dt_from_string output_pref );
46 use Koha::Item::Transfers;
49 use Koha::Patron::Debarments qw( GetDebarments AddDebarment DelUniqueDebarment );
51 use Koha::CirculationRules;
52 use Koha::Subscriptions;
53 use Koha::Account::Lines;
54 use Koha::Account::Offsets;
56 use Koha::Notice::Messages;
60 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
64 my ( $error, $question, $alert ) = @_;
66 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
67 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
68 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
72 sub test_debarment_on_checkout {
74 my $item = $params->{item};
75 my $library = $params->{library};
76 my $patron = $params->{patron};
77 my $due_date = $params->{due_date} || dt_from_string;
78 my $return_date = $params->{return_date} || dt_from_string;
79 my $expected_expiration_date = $params->{expiration_date};
81 $expected_expiration_date = output_pref(
83 dt => $expected_expiration_date,
89 my $line_number = $caller[2];
90 AddIssue( $patron, $item->barcode, $due_date );
92 my ( undef, $message ) = AddReturn( $item->barcode, $library->{branchcode}, undef, $return_date );
93 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
94 or diag('AddReturn returned message ' . Dumper $message );
95 my $debarments = Koha::Patron::Debarments::GetDebarments(
96 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
97 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
99 is( $debarments->[0]->{expiration},
100 $expected_expiration_date, 'Test at line ' . $line_number );
101 Koha::Patron::Debarments::DelUniqueDebarment(
102 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
105 my $schema = Koha::Database->schema;
106 $schema->storage->txn_begin;
107 my $builder = t::lib::TestBuilder->new;
108 my $dbh = C4::Context->dbh;
110 # Prevent random failures by mocking ->now
111 my $now_value = dt_from_string;
112 my $mocked_datetime = Test::MockModule->new('DateTime');
113 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
115 my $cache = Koha::Caches->get_instance();
116 $dbh->do(q|DELETE FROM special_holidays|);
117 $dbh->do(q|DELETE FROM repeatable_holidays|);
118 my $branches = Koha::Libraries->search();
119 for my $branch ( $branches->next ) {
120 my $key = $branch->branchcode . "_holidays";
121 $cache->clear_from_cache($key);
124 # Start with a clean slate
125 $dbh->do('DELETE FROM issues');
126 $dbh->do('DELETE FROM borrowers');
128 # Disable recording of the staff who checked out an item until we're ready for it
129 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 0);
131 my $module = Test::MockModule->new('C4::Context');
133 my $library = $builder->build({
136 my $library2 = $builder->build({
139 my $itemtype = $builder->build(
141 source => 'Itemtype',
145 rentalcharge_daily => 0,
146 defaultreplacecost => undef,
151 my $patron_category = $builder->build(
153 source => 'Category',
155 category_type => 'P',
157 BlockExpiredPatronOpacActions => -1, # Pick the pref value
162 my $CircControl = C4::Context->preference('CircControl');
163 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
166 homebranch => $library2->{branchcode},
167 holdingbranch => $library2->{branchcode}
171 branchcode => $library2->{branchcode}
174 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
176 # No userenv, PickupLibrary
177 t::lib::Mocks::mock_preference('IndependentBranches', '0');
178 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
180 C4::Context->preference('CircControl'),
182 'CircControl changed to PickupLibrary'
185 C4::Circulation::_GetCircControlBranch($item, $borrower),
186 $item->{$HomeOrHoldingBranch},
187 '_GetCircControlBranch returned item branch (no userenv defined)'
190 # No userenv, PatronLibrary
191 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
193 C4::Context->preference('CircControl'),
195 'CircControl changed to PatronLibrary'
198 C4::Circulation::_GetCircControlBranch($item, $borrower),
199 $borrower->{branchcode},
200 '_GetCircControlBranch returned borrower branch'
203 # No userenv, ItemHomeLibrary
204 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
206 C4::Context->preference('CircControl'),
208 'CircControl changed to ItemHomeLibrary'
211 $item->{$HomeOrHoldingBranch},
212 C4::Circulation::_GetCircControlBranch($item, $borrower),
213 '_GetCircControlBranch returned item branch'
217 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
218 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
220 # Userenv set, PickupLibrary
221 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
223 C4::Context->preference('CircControl'),
225 'CircControl changed to PickupLibrary'
228 C4::Circulation::_GetCircControlBranch($item, $borrower),
229 $library2->{branchcode},
230 '_GetCircControlBranch returned current branch'
233 # Userenv set, PatronLibrary
234 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
236 C4::Context->preference('CircControl'),
238 'CircControl changed to PatronLibrary'
241 C4::Circulation::_GetCircControlBranch($item, $borrower),
242 $borrower->{branchcode},
243 '_GetCircControlBranch returned borrower branch'
246 # Userenv set, ItemHomeLibrary
247 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
249 C4::Context->preference('CircControl'),
251 'CircControl changed to ItemHomeLibrary'
254 C4::Circulation::_GetCircControlBranch($item, $borrower),
255 $item->{$HomeOrHoldingBranch},
256 '_GetCircControlBranch returned item branch'
259 # Reset initial configuration
260 t::lib::Mocks::mock_preference('CircControl', $CircControl);
262 C4::Context->preference('CircControl'),
264 'CircControl reset to its initial value'
267 # Set a simple circ policy
268 $dbh->do('DELETE FROM circulation_rules');
269 Koha::CirculationRules->set_rules(
271 categorycode => undef,
275 reservesallowed => 25,
277 lengthunit => 'days',
278 renewalsallowed => 1,
280 norenewalbefore => undef,
288 subtest "CanBookBeRenewed AllowRenewalIfOtherItemsAvailable multiple borrowers and items tests" => sub {
291 #Can only reserve from home branch
292 Koha::CirculationRules->set_rule(
296 rule_name => 'holdallowed',
300 Koha::CirculationRules->set_rule(
303 categorycode => undef,
305 rule_name => 'onshelfholds',
310 # Patrons from three different branches
311 my $patron_borrower = $builder->build_object({ class => 'Koha::Patrons' });
312 my $patron_hold_1 = $builder->build_object({ class => 'Koha::Patrons' });
313 my $patron_hold_2 = $builder->build_object({ class => 'Koha::Patrons' });
314 my $biblio = $builder->build_sample_biblio();
316 # Item at each patron branch
317 my $item_1 = $builder->build_sample_item({
318 biblionumber => $biblio->biblionumber,
319 homebranch => $patron_borrower->branchcode
321 my $item_2 = $builder->build_sample_item({
322 biblionumber => $biblio->biblionumber,
323 homebranch => $patron_hold_2->branchcode
325 my $item_3 = $builder->build_sample_item({
326 biblionumber => $biblio->biblionumber,
327 homebranch => $patron_hold_1->branchcode
330 my $issue = AddIssue( $patron_borrower->unblessed, $item_1->barcode);
331 my $datedue = dt_from_string( $issue->date_due() );
332 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
337 branchcode => $patron_hold_1->branchcode,
338 borrowernumber => $patron_hold_1->borrowernumber,
339 biblionumber => $biblio->biblionumber,
341 reservation_date => dt_from_string(),
342 expiration_date => undef,
349 branchcode => $patron_hold_2->branchcode,
350 borrowernumber => $patron_hold_2->borrowernumber,
351 biblionumber => $biblio->biblionumber,
353 reservation_date => dt_from_string(),
354 expiration_date => undef,
359 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
361 my ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
362 is( $renewokay, 0, 'Cannot renew, reserved');
363 is( $error, 'on_reserve', 'Cannot renew, reserved (returned error is on_reserve)');
365 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
367 ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
368 is( $renewokay, 1, 'Can renew, two items available for two holds');
369 is( $error, undef, 'Can renew, each reserve has an item');
374 subtest "GetIssuingCharges tests" => sub {
376 my $branch_discount = $builder->build_object({ class => 'Koha::Libraries' });
377 my $branch_no_discount = $builder->build_object({ class => 'Koha::Libraries' });
378 Koha::CirculationRules->set_rule(
380 categorycode => undef,
381 branchcode => $branch_discount->branchcode,
383 rule_name => 'rentaldiscount',
387 my $itype_charge = $builder->build_object({
388 class => 'Koha::ItemTypes',
393 my $itype_no_charge = $builder->build_object({
394 class => 'Koha::ItemTypes',
399 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
400 my $item_1 = $builder->build_sample_item({ itype => $itype_charge->itemtype });
401 my $item_2 = $builder->build_sample_item({ itype => $itype_no_charge->itemtype });
403 t::lib::Mocks::mock_userenv({ branchcode => $branch_no_discount->branchcode });
404 # For now the sub always uses the env branch, this should follow CircControl instead
405 my ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
406 is( $charge + 0, 10.00, "Charge fetched correctly when no discount exists");
407 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
408 is( $charge + 0, 0.00, "Charge fetched correctly when no discount exists and no charge");
410 t::lib::Mocks::mock_userenv({ branchcode => $branch_discount->branchcode });
411 # For now the sub always uses the env branch, this should follow CircControl instead
412 ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
413 is( $charge + 0, 8.50, "Charge fetched correctly when discount exists");
414 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
415 is( $charge + 0, 0.00, "Charge fetched correctly when discount exists and no charge");
419 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
420 subtest "CanBookBeRenewed tests" => sub {
423 C4::Context->set_preference('ItemsDeniedRenewal','');
424 # Generate test biblio
425 my $biblio = $builder->build_sample_biblio();
427 my $branch = $library2->{branchcode};
429 my $item_1 = $builder->build_sample_item(
431 biblionumber => $biblio->biblionumber,
433 replacementprice => 12.00,
437 $reused_itemnumber_1 = $item_1->itemnumber;
439 my $item_2 = $builder->build_sample_item(
441 biblionumber => $biblio->biblionumber,
443 replacementprice => 23.00,
447 $reused_itemnumber_2 = $item_2->itemnumber;
449 my $item_3 = $builder->build_sample_item(
451 biblionumber => $biblio->biblionumber,
453 replacementprice => 23.00,
459 my %renewing_borrower_data = (
461 surname => 'Renewal',
462 categorycode => $patron_category->{categorycode},
463 branchcode => $branch,
466 my %reserving_borrower_data = (
467 firstname => 'Katrin',
468 surname => 'Reservation',
469 categorycode => $patron_category->{categorycode},
470 branchcode => $branch,
473 my %hold_waiting_borrower_data = (
475 surname => 'Reservation',
476 categorycode => $patron_category->{categorycode},
477 branchcode => $branch,
480 my %restricted_borrower_data = (
481 firstname => 'Alice',
482 surname => 'Reservation',
483 categorycode => $patron_category->{categorycode},
484 debarred => '3228-01-01',
485 branchcode => $branch,
488 my %expired_borrower_data = (
491 categorycode => $patron_category->{categorycode},
492 branchcode => $branch,
493 dateexpiry => dt_from_string->subtract( months => 1 ),
496 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
497 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
498 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
499 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
500 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
502 my $renewing_borrower_obj = Koha::Patrons->find( $renewing_borrowernumber );
503 my $renewing_borrower = $renewing_borrower_obj->unblessed;
504 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
505 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
512 my $checkitem = undef;
515 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
516 my $datedue = dt_from_string( $issue->date_due() );
517 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
519 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
520 $datedue = dt_from_string( $issue->date_due() );
521 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
524 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
525 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
527 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
528 is( $renewokay, 1, 'Can renew, no holds for this title or item');
531 # Biblio-level hold, renewal test
534 branchcode => $branch,
535 borrowernumber => $reserving_borrowernumber,
536 biblionumber => $biblio->biblionumber,
537 priority => $priority,
538 reservation_date => $resdate,
539 expiration_date => $expdate,
541 itemnumber => $checkitem,
546 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
547 Koha::CirculationRules->set_rule(
549 categorycode => undef,
552 rule_name => 'onshelfholds',
556 Koha::CirculationRules->set_rule(
558 categorycode => undef,
561 rule_name => 'renewalsallowed',
565 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
566 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
567 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
568 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
569 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
571 # Now let's add an item level hold, we should no longer be able to renew the item
572 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
574 borrowernumber => $hold_waiting_borrowernumber,
575 biblionumber => $biblio->biblionumber,
576 itemnumber => $item_1->itemnumber,
577 branchcode => $branch,
581 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
582 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
585 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
586 # be able to renew these items
587 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
589 borrowernumber => $hold_waiting_borrowernumber,
590 biblionumber => $biblio->biblionumber,
591 itemnumber => $item_3->itemnumber,
592 branchcode => $branch,
597 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
598 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
599 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
600 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
601 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
603 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
604 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
605 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
607 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
608 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
609 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
611 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
612 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
613 AddIssue($reserving_borrower, $item_3->barcode);
614 my $reserve = $dbh->selectrow_hashref(
615 'SELECT * FROM old_reserves WHERE reserve_id = ?',
619 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
621 # Item-level hold, renewal test
624 branchcode => $branch,
625 borrowernumber => $reserving_borrowernumber,
626 biblionumber => $biblio->biblionumber,
627 priority => $priority,
628 reservation_date => $resdate,
629 expiration_date => $expdate,
631 itemnumber => $item_1->itemnumber,
636 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
637 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
638 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
640 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
641 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
643 # Items can't fill hold for reasons
644 $item_1->notforloan(1)->store;
645 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
646 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
647 $item_1->set({notforloan => 0, itype => $itemtype })->store;
649 # FIXME: Add more for itemtype not for loan etc.
651 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
652 my $item_5 = $builder->build_sample_item(
654 biblionumber => $biblio->biblionumber,
656 replacementprice => 23.00,
660 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
661 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
663 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
664 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
665 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
666 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
667 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
668 is( $error, 'restriction', "Correct error returned");
670 # Users cannot renew an overdue item
671 my $item_6 = $builder->build_sample_item(
673 biblionumber => $biblio->biblionumber,
675 replacementprice => 23.00,
680 my $item_7 = $builder->build_sample_item(
682 biblionumber => $biblio->biblionumber,
684 replacementprice => 23.00,
689 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
690 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
692 my $now = dt_from_string();
693 my $five_weeks = DateTime::Duration->new(weeks => 5);
694 my $five_weeks_ago = $now - $five_weeks;
695 t::lib::Mocks::mock_preference('finesMode', 'production');
697 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
698 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
700 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
701 C4::Overdues::UpdateFine(
703 issue_id => $passeddatedue1->id(),
704 itemnumber => $item_7->itemnumber,
705 borrowernumber => $renewing_borrower->{borrowernumber},
707 due => Koha::DateUtils::output_pref($five_weeks_ago)
711 # Make sure fine calculation isn't skipped when adding renewal
712 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
714 t::lib::Mocks::mock_preference('RenewalLog', 0);
715 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
716 my %params_renewal = (
717 timestamp => { -like => $date . "%" },
718 module => "CIRCULATION",
722 timestamp => { -like => $date . "%" },
723 module => "CIRCULATION",
726 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
727 my $dt = dt_from_string();
728 Time::Fake->offset( $dt->epoch );
729 my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
730 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
731 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
732 isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
735 t::lib::Mocks::mock_preference('RenewalLog', 1);
736 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
737 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
738 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
739 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
740 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
742 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
743 is( $fines->count, 2, 'AddRenewal left both fines' );
744 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
745 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
748 t::lib::Mocks::mock_preference('OverduesBlockRenewing','allow');
749 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
750 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
751 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
752 is( $renewokay, 1, '(Bug 8236), Can renew, this item is overdue but not pref does not block');
754 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
755 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
756 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is not overdue but patron has overdues');
757 is( $error, 'overdue', "Correct error returned");
758 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
759 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue so patron has overdues');
760 is( $error, 'overdue', "Correct error returned");
762 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
763 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
764 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
765 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
766 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
767 is( $error, 'overdue', "Correct error returned");
770 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
771 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
772 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
773 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
774 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
775 $new_log_size = Koha::ActionLogs->count( \%params_issue );
776 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
778 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
781 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
785 # Test automatic renewal before value for "norenewalbefore" in policy is set
786 # In this case automatic renewal is not permitted prior to due date
787 my $item_4 = $builder->build_sample_item(
789 biblionumber => $biblio->biblionumber,
791 replacementprice => 16.00,
796 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
797 ( $renewokay, $error ) =
798 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
799 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
800 is( $error, 'auto_too_soon',
801 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
804 branchcode => $branch,
805 borrowernumber => $reserving_borrowernumber,
806 biblionumber => $biblio->biblionumber,
807 itemnumber => $bibitems,
808 priority => $priority,
809 reservation_date => $resdate,
810 expiration_date => $expdate,
813 itemnumber => $item_4->itemnumber,
817 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
818 is( $renewokay, 0, 'Still should not be able to renew' );
819 is( $error, 'on_reserve', 'returned code is on_reserve, reserve checked when not checking for cron' );
820 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, undef, 1 );
821 is( $renewokay, 0, 'Still should not be able to renew' );
822 is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked when checking for cron' );
823 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
824 is( $renewokay, 0, 'Still should not be able to renew' );
825 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
826 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1, 1 );
827 is( $renewokay, 0, 'Still should not be able to renew' );
828 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
829 $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
830 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
831 is( $renewokay, 0, 'Still should not be able to renew' );
832 is( $error, 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
833 ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);
837 $renewing_borrower_obj->autorenew_checkouts(0)->store;
838 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
839 is( $renewokay, 1, 'No renewal before is undef, but patron opted out of auto_renewal' );
840 $renewing_borrower_obj->autorenew_checkouts(1)->store;
844 # Test premature manual renewal
845 Koha::CirculationRules->set_rule(
847 categorycode => undef,
850 rule_name => 'norenewalbefore',
855 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
856 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
857 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
860 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
861 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
863 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
864 $datedue->clone->add( days => -7 ),
865 'Bug 14395: Renewals permitted 7 days before due date, as expected'
869 # Test 'date' setting for syspref NoRenewalBeforePrecision
870 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
872 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
873 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
874 'Bug 14395: Renewals permitted 7 days before due date, as expected'
878 # Test premature automatic renewal
879 ( $renewokay, $error ) =
880 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
881 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
882 is( $error, 'auto_too_soon',
883 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
886 $renewing_borrower_obj->autorenew_checkouts(0)->store;
887 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
888 is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
889 is( $error, 'too_soon', 'Error is too_soon, no auto' );
890 $renewing_borrower_obj->autorenew_checkouts(1)->store;
892 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
893 # and test automatic renewal again
894 $dbh->do(q{UPDATE circulation_rules SET rule_value = '0' WHERE rule_name = 'norenewalbefore'});
895 ( $renewokay, $error ) =
896 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
897 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
898 is( $error, 'auto_too_soon',
899 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
902 $renewing_borrower_obj->autorenew_checkouts(0)->store;
903 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
904 is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
905 is( $error, 'too_soon', 'Error is too_soon, no auto' );
906 $renewing_borrower_obj->autorenew_checkouts(1)->store;
908 # Change policy so that loans can be renewed 99 days prior to the due date
909 # and test automatic renewal again
910 $dbh->do(q{UPDATE circulation_rules SET rule_value = '99' WHERE rule_name = 'norenewalbefore'});
911 ( $renewokay, $error ) =
912 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
913 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
914 is( $error, 'auto_renew',
915 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
918 $renewing_borrower_obj->autorenew_checkouts(0)->store;
919 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
920 is( $renewokay, 1, 'No renewal before is 99, patron opted out of auto_renewal so can renew' );
921 $renewing_borrower_obj->autorenew_checkouts(1)->store;
923 subtest "too_late_renewal / no_auto_renewal_after" => sub {
925 my $item_to_auto_renew = $builder->build_sample_item(
927 biblionumber => $biblio->biblionumber,
932 my $ten_days_before = dt_from_string->add( days => -10 );
933 my $ten_days_ahead = dt_from_string->add( days => 10 );
934 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
936 Koha::CirculationRules->set_rules(
938 categorycode => undef,
942 norenewalbefore => '7',
943 no_auto_renewal_after => '9',
947 ( $renewokay, $error ) =
948 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
949 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
950 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
952 Koha::CirculationRules->set_rules(
954 categorycode => undef,
958 norenewalbefore => '7',
959 no_auto_renewal_after => '10',
963 ( $renewokay, $error ) =
964 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
965 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
966 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
968 Koha::CirculationRules->set_rules(
970 categorycode => undef,
974 norenewalbefore => '7',
975 no_auto_renewal_after => '11',
979 ( $renewokay, $error ) =
980 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
981 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
982 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
984 Koha::CirculationRules->set_rules(
986 categorycode => undef,
990 norenewalbefore => '10',
991 no_auto_renewal_after => '11',
995 ( $renewokay, $error ) =
996 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
997 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
998 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
1000 Koha::CirculationRules->set_rules(
1002 categorycode => undef,
1003 branchcode => undef,
1006 norenewalbefore => '10',
1007 no_auto_renewal_after => undef,
1008 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
1012 ( $renewokay, $error ) =
1013 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1014 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1015 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
1017 Koha::CirculationRules->set_rules(
1019 categorycode => undef,
1020 branchcode => undef,
1023 norenewalbefore => '7',
1024 no_auto_renewal_after => '15',
1025 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
1029 ( $renewokay, $error ) =
1030 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1031 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1032 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
1034 Koha::CirculationRules->set_rules(
1036 categorycode => undef,
1037 branchcode => undef,
1040 norenewalbefore => '10',
1041 no_auto_renewal_after => undef,
1042 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 1 ),
1046 ( $renewokay, $error ) =
1047 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1048 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1049 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
1052 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
1054 my $item_to_auto_renew = $builder->build_sample_item(
1056 biblionumber => $biblio->biblionumber,
1061 my $ten_days_before = dt_from_string->add( days => -10 );
1062 my $ten_days_ahead = dt_from_string->add( days => 10 );
1063 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1065 Koha::CirculationRules->set_rules(
1067 categorycode => undef,
1068 branchcode => undef,
1071 norenewalbefore => '10',
1072 no_auto_renewal_after => '11',
1076 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
1077 C4::Context->set_preference('OPACFineNoRenewals','10');
1078 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1079 my $fines_amount = 5;
1080 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
1081 $account->add_debit(
1083 amount => $fines_amount,
1084 interface => 'test',
1086 item_id => $item_to_auto_renew->itemnumber,
1087 description => "Some fines"
1089 )->status('RETURNED')->store;
1090 ( $renewokay, $error ) =
1091 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1092 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1093 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
1095 $account->add_debit(
1097 amount => $fines_amount,
1098 interface => 'test',
1100 item_id => $item_to_auto_renew->itemnumber,
1101 description => "Some fines"
1103 )->status('RETURNED')->store;
1104 ( $renewokay, $error ) =
1105 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1106 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1107 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
1109 $account->add_debit(
1111 amount => $fines_amount,
1112 interface => 'test',
1114 item_id => $item_to_auto_renew->itemnumber,
1115 description => "Some fines"
1117 )->status('RETURNED')->store;
1118 ( $renewokay, $error ) =
1119 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1120 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1121 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
1123 $account->add_credit(
1125 amount => $fines_amount,
1126 interface => 'test',
1128 description => "Some payment"
1131 ( $renewokay, $error ) =
1132 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1133 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1134 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1136 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
1137 ( $renewokay, $error ) =
1138 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1139 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1140 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1142 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
1143 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1146 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
1148 my $item_to_auto_renew = $builder->build_sample_item(
1150 biblionumber => $biblio->biblionumber,
1155 Koha::CirculationRules->set_rules(
1157 categorycode => undef,
1158 branchcode => undef,
1161 norenewalbefore => 10,
1162 no_auto_renewal_after => 11,
1167 my $ten_days_before = dt_from_string->add( days => -10 );
1168 my $ten_days_ahead = dt_from_string->add( days => 10 );
1170 # Patron is expired and BlockExpiredPatronOpacActions=0
1171 # => auto renew is allowed
1172 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
1173 my $patron = $expired_borrower;
1174 my $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1175 ( $renewokay, $error ) =
1176 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1177 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1178 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
1179 Koha::Checkouts->find( $checkout->issue_id )->delete;
1182 # Patron is expired and BlockExpiredPatronOpacActions=1
1183 # => auto renew is not allowed
1184 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1185 $patron = $expired_borrower;
1186 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1187 ( $renewokay, $error ) =
1188 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1189 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1190 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
1191 Koha::Checkouts->find( $checkout->issue_id )->delete;
1194 # Patron is not expired and BlockExpiredPatronOpacActions=1
1195 # => auto renew is allowed
1196 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1197 $patron = $renewing_borrower;
1198 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1199 ( $renewokay, $error ) =
1200 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1201 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1202 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
1203 Koha::Checkouts->find( $checkout->issue_id )->delete;
1206 subtest "GetLatestAutoRenewDate" => sub {
1208 my $item_to_auto_renew = $builder->build_sample_item(
1210 biblionumber => $biblio->biblionumber,
1215 my $ten_days_before = dt_from_string->add( days => -10 );
1216 my $ten_days_ahead = dt_from_string->add( days => 10 );
1217 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1218 Koha::CirculationRules->set_rules(
1220 categorycode => undef,
1221 branchcode => undef,
1224 norenewalbefore => '7',
1225 no_auto_renewal_after => '',
1226 no_auto_renewal_after_hard_limit => undef,
1230 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1231 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
1232 my $five_days_before = dt_from_string->add( days => -5 );
1233 Koha::CirculationRules->set_rules(
1235 categorycode => undef,
1236 branchcode => undef,
1239 norenewalbefore => '10',
1240 no_auto_renewal_after => '5',
1241 no_auto_renewal_after_hard_limit => undef,
1245 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1246 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1247 $five_days_before->truncate( to => 'minute' ),
1248 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
1250 my $five_days_ahead = dt_from_string->add( days => 5 );
1251 $dbh->do(q{UPDATE circulation_rules SET rule_value = '10' WHERE rule_name = 'norenewalbefore'});
1252 $dbh->do(q{UPDATE circulation_rules SET rule_value = '15' WHERE rule_name = 'no_auto_renewal_after'});
1253 $dbh->do(q{UPDATE circulation_rules SET rule_value = NULL WHERE rule_name = 'no_auto_renewal_after_hard_limit'});
1254 Koha::CirculationRules->set_rules(
1256 categorycode => undef,
1257 branchcode => undef,
1260 norenewalbefore => '10',
1261 no_auto_renewal_after => '15',
1262 no_auto_renewal_after_hard_limit => undef,
1266 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1267 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1268 $five_days_ahead->truncate( to => 'minute' ),
1269 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
1271 my $two_days_ahead = dt_from_string->add( days => 2 );
1272 Koha::CirculationRules->set_rules(
1274 categorycode => undef,
1275 branchcode => undef,
1278 norenewalbefore => '10',
1279 no_auto_renewal_after => '',
1280 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1284 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1285 is( $latest_auto_renew_date->truncate( to => 'day' ),
1286 $two_days_ahead->truncate( to => 'day' ),
1287 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
1289 Koha::CirculationRules->set_rules(
1291 categorycode => undef,
1292 branchcode => undef,
1295 norenewalbefore => '10',
1296 no_auto_renewal_after => '15',
1297 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1301 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1302 is( $latest_auto_renew_date->truncate( to => 'day' ),
1303 $two_days_ahead->truncate( to => 'day' ),
1304 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
1310 # set policy to forbid renewals
1311 Koha::CirculationRules->set_rules(
1313 categorycode => undef,
1314 branchcode => undef,
1317 norenewalbefore => undef,
1318 renewalsallowed => 0,
1323 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1324 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1325 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1327 # Too many unseen renewals
1328 Koha::CirculationRules->set_rules(
1330 categorycode => undef,
1331 branchcode => undef,
1334 unseen_renewals_allowed => 2,
1335 renewalsallowed => 10,
1339 t::lib::Mocks::mock_preference('UnseenRenewals', 1);
1340 $dbh->do('UPDATE issues SET unseen_renewals = 2 where borrowernumber = ? AND itemnumber = ?', undef, ($renewing_borrowernumber, $item_1->itemnumber));
1341 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1342 is( $renewokay, 0, 'Cannot renew, 0 unseen renewals allowed');
1343 is( $error, 'too_unseen', 'Cannot renew, returned code is too_unseen');
1344 Koha::CirculationRules->set_rules(
1346 categorycode => undef,
1347 branchcode => undef,
1350 norenewalbefore => undef,
1351 renewalsallowed => 0,
1355 t::lib::Mocks::mock_preference('UnseenRenewals', 0);
1357 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1358 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1359 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1361 C4::Overdues::UpdateFine(
1363 issue_id => $issue->id(),
1364 itemnumber => $item_1->itemnumber,
1365 borrowernumber => $renewing_borrower->{borrowernumber},
1368 due => Koha::DateUtils::output_pref($datedue)
1372 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
1373 is( $line->debit_type_code, 'OVERDUE', 'Account line type is OVERDUE' );
1374 is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
1375 is( $line->amountoutstanding+0, 15, 'Account line amount outstanding is 15.00' );
1376 is( $line->amount+0, 15, 'Account line amount is 15.00' );
1377 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
1379 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
1380 is( $offset->type, 'CREATE', 'Account offset type is CREATE' );
1381 is( $offset->amount+0, 15, 'Account offset amount is 15.00' );
1383 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
1384 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
1386 LostItem( $item_1->itemnumber, 'test', 1 );
1388 $line = Koha::Account::Lines->find($line->id);
1389 is( $line->debit_type_code, 'OVERDUE', 'Account type remains as OVERDUE' );
1390 isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
1392 my $item = Koha::Items->find($item_1->itemnumber);
1393 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
1394 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
1395 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
1397 my $total_due = $dbh->selectrow_array(
1398 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1399 undef, $renewing_borrower->{borrowernumber}
1402 is( $total_due+0, 15, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
1404 C4::Context->dbh->do("DELETE FROM accountlines");
1406 C4::Overdues::UpdateFine(
1408 issue_id => $issue2->id(),
1409 itemnumber => $item_2->itemnumber,
1410 borrowernumber => $renewing_borrower->{borrowernumber},
1413 due => Koha::DateUtils::output_pref($datedue)
1417 LostItem( $item_2->itemnumber, 'test', 0 );
1419 my $item2 = Koha::Items->find($item_2->itemnumber);
1420 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
1421 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
1423 $total_due = $dbh->selectrow_array(
1424 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1425 undef, $renewing_borrower->{borrowernumber}
1428 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
1430 my $future = dt_from_string();
1431 $future->add( days => 7 );
1432 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
1433 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
1435 my $manager = $builder->build_object({ class => "Koha::Patrons" });
1436 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
1437 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1438 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
1439 LostItem( $item_3->itemnumber, 'test', 0 );
1440 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
1441 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
1443 $accountline->description,
1444 sprintf( "%s %s %s",
1445 $item_3->biblio->title || '',
1446 $item_3->barcode || '',
1447 $item_3->itemcallnumber || '' ),
1448 "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
1452 subtest "GetUpcomingDueIssues" => sub {
1455 my $branch = $library2->{branchcode};
1457 #Create another record
1458 my $biblio2 = $builder->build_sample_biblio();
1461 my $item_1 = Koha::Items->find($reused_itemnumber_1);
1462 my $item_2 = Koha::Items->find($reused_itemnumber_2);
1463 my $item_3 = $builder->build_sample_item(
1465 biblionumber => $biblio2->biblionumber,
1473 my %a_borrower_data = (
1474 firstname => 'Fridolyn',
1475 surname => 'SOMERS',
1476 categorycode => $patron_category->{categorycode},
1477 branchcode => $branch,
1480 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1481 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1483 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1484 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1485 my $today = DateTime->today(time_zone => C4::Context->tz());
1487 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1488 my $datedue = dt_from_string( $issue->date_due() );
1489 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1490 my $datedue2 = dt_from_string( $issue->date_due() );
1494 # GetUpcomingDueIssues tests
1496 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1497 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1500 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1501 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1502 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1505 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1506 is ( scalar( @$upcoming_dues ), 1,
1507 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1510 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1512 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1514 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1515 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1517 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1518 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1520 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1521 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1523 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1524 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1526 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1527 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1529 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1530 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1534 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1535 my $branch = $library2->{branchcode};
1537 my $biblio = $builder->build_sample_biblio();
1540 my $item = $builder->build_sample_item(
1542 biblionumber => $biblio->biblionumber,
1549 my %a_borrower_data = (
1550 firstname => 'Kyle',
1552 categorycode => $patron_category->{categorycode},
1553 branchcode => $branch,
1556 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1558 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1559 my $issue = AddIssue( $borrower, $item->barcode );
1562 issue_id => $issue->id(),
1563 itemnumber => $item->itemnumber,
1564 borrowernumber => $borrowernumber,
1570 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1571 my $count = $hr->{count};
1573 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1576 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1577 $dbh->do('DELETE FROM issues');
1578 $dbh->do('DELETE FROM items');
1579 $dbh->do('DELETE FROM circulation_rules');
1580 Koha::CirculationRules->set_rules(
1582 categorycode => undef,
1584 branchcode => undef,
1586 reservesallowed => 25,
1588 lengthunit => 'days',
1589 renewalsallowed => 1,
1591 norenewalbefore => undef,
1599 my $biblio = $builder->build_sample_biblio();
1601 my $item_1 = $builder->build_sample_item(
1603 biblionumber => $biblio->biblionumber,
1604 library => $library2->{branchcode},
1609 my $item_2= $builder->build_sample_item(
1611 biblionumber => $biblio->biblionumber,
1612 library => $library2->{branchcode},
1617 my $borrowernumber1 = Koha::Patron->new({
1618 firstname => 'Kyle',
1620 categorycode => $patron_category->{categorycode},
1621 branchcode => $library2->{branchcode},
1622 })->store->borrowernumber;
1623 my $borrowernumber2 = Koha::Patron->new({
1624 firstname => 'Chelsea',
1626 categorycode => $patron_category->{categorycode},
1627 branchcode => $library2->{branchcode},
1628 })->store->borrowernumber;
1630 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1631 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1633 my $issue = AddIssue( $borrower1, $item_1->barcode );
1635 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1636 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1640 branchcode => $library2->{branchcode},
1641 borrowernumber => $borrowernumber2,
1642 biblionumber => $biblio->biblionumber,
1647 Koha::CirculationRules->set_rules(
1649 categorycode => undef,
1651 branchcode => undef,
1657 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1658 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1659 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1661 Koha::CirculationRules->set_rules(
1663 categorycode => undef,
1665 branchcode => undef,
1671 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1672 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1673 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1675 Koha::CirculationRules->set_rules(
1677 categorycode => undef,
1679 branchcode => undef,
1685 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1686 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1687 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1689 Koha::CirculationRules->set_rules(
1691 categorycode => undef,
1693 branchcode => undef,
1699 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1700 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1701 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1703 # Setting item not checked out to be not for loan but holdable
1704 $item_2->notforloan(-1)->store;
1706 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1707 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1711 # Don't allow renewing onsite checkout
1712 my $branch = $library->{branchcode};
1714 #Create another record
1715 my $biblio = $builder->build_sample_biblio();
1717 my $item = $builder->build_sample_item(
1719 biblionumber => $biblio->biblionumber,
1725 my $borrowernumber = Koha::Patron->new({
1728 categorycode => $patron_category->{categorycode},
1729 branchcode => $branch,
1730 })->store->borrowernumber;
1732 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1734 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1735 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1736 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1737 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1741 my $library = $builder->build({ source => 'Branch' });
1743 my $biblio = $builder->build_sample_biblio();
1745 my $item = $builder->build_sample_item(
1747 biblionumber => $biblio->biblionumber,
1748 library => $library->{branchcode},
1753 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1755 my $issue = AddIssue( $patron, $item->barcode );
1758 issue_id => $issue->id(),
1759 itemnumber => $item->itemnumber,
1760 borrowernumber => $patron->{borrowernumber},
1767 issue_id => $issue->id(),
1768 itemnumber => $item->itemnumber,
1769 borrowernumber => $patron->{borrowernumber},
1774 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1777 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1780 my $homebranch = $builder->build( { source => 'Branch' } );
1781 my $holdingbranch = $builder->build( { source => 'Branch' } );
1782 my $otherbranch = $builder->build( { source => 'Branch' } );
1783 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1784 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1786 my $item = $builder->build_sample_item(
1788 homebranch => $homebranch->{branchcode},
1789 holdingbranch => $holdingbranch->{branchcode},
1793 set_userenv($holdingbranch);
1795 my $issue = AddIssue( $patron_1->unblessed, $item->barcode );
1796 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1798 my ( $error, $question, $alerts );
1800 # AllowReturnToBranch == anywhere
1801 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1802 ## Test that unknown barcodes don't generate internal server errors
1803 set_userenv($homebranch);
1804 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1805 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1806 ## Can be issued from homebranch
1807 set_userenv($homebranch);
1808 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1809 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1810 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1811 ## Can be issued from holdingbranch
1812 set_userenv($holdingbranch);
1813 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1814 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1815 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1816 ## Can be issued from another branch
1817 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1818 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1819 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1821 # AllowReturnToBranch == holdingbranch
1822 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1823 ## Cannot be issued from homebranch
1824 set_userenv($homebranch);
1825 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1826 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1827 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1828 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1829 ## Can be issued from holdinbranch
1830 set_userenv($holdingbranch);
1831 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1832 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1833 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1834 ## Cannot be issued from another branch
1835 set_userenv($otherbranch);
1836 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1837 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1838 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1839 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1841 # AllowReturnToBranch == homebranch
1842 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1843 ## Can be issued from holdinbranch
1844 set_userenv($homebranch);
1845 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1846 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1847 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1848 ## Cannot be issued from holdinbranch
1849 set_userenv($holdingbranch);
1850 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1851 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1852 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1853 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1854 ## Cannot be issued from holdinbranch
1855 set_userenv($otherbranch);
1856 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1857 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1858 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1859 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1861 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1864 subtest 'AddIssue & AllowReturnToBranch' => sub {
1867 my $homebranch = $builder->build( { source => 'Branch' } );
1868 my $holdingbranch = $builder->build( { source => 'Branch' } );
1869 my $otherbranch = $builder->build( { source => 'Branch' } );
1870 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1871 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1873 my $item = $builder->build_sample_item(
1875 homebranch => $homebranch->{branchcode},
1876 holdingbranch => $holdingbranch->{branchcode},
1880 set_userenv($holdingbranch);
1882 my $ref_issue = 'Koha::Checkout';
1883 my $issue = AddIssue( $patron_1, $item->barcode );
1885 my ( $error, $question, $alerts );
1887 # AllowReturnToBranch == homebranch
1888 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1889 ## Can be issued from homebranch
1890 set_userenv($homebranch);
1891 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1892 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1893 ## Can be issued from holdinbranch
1894 set_userenv($holdingbranch);
1895 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1896 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1897 ## Can be issued from another branch
1898 set_userenv($otherbranch);
1899 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1900 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1902 # AllowReturnToBranch == holdinbranch
1903 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1904 ## Cannot be issued from homebranch
1905 set_userenv($homebranch);
1906 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1907 ## Can be issued from holdingbranch
1908 set_userenv($holdingbranch);
1909 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1910 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1911 ## Cannot be issued from another branch
1912 set_userenv($otherbranch);
1913 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1915 # AllowReturnToBranch == homebranch
1916 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1917 ## Can be issued from homebranch
1918 set_userenv($homebranch);
1919 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1920 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1921 ## Cannot be issued from holdinbranch
1922 set_userenv($holdingbranch);
1923 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1924 ## Cannot be issued from another branch
1925 set_userenv($otherbranch);
1926 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1927 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1930 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1933 my $library = $builder->build( { source => 'Branch' } );
1934 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1935 my $item_1 = $builder->build_sample_item(
1937 library => $library->{branchcode},
1940 my $item_2 = $builder->build_sample_item(
1942 library => $library->{branchcode},
1946 my ( $error, $question, $alerts );
1948 # Patron cannot issue item_1, they have overdues
1949 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1950 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, $yesterday ); # Add an overdue
1952 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1953 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1954 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1955 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1957 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1958 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1959 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1960 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1962 # Patron cannot issue item_1, they are debarred
1963 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1964 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1965 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1966 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1967 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1969 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1970 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1971 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1972 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1975 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1978 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1979 my $patron_category_x = $builder->build_object(
1981 class => 'Koha::Patron::Categories',
1982 value => { category_type => 'X' }
1985 my $patron = $builder->build_object(
1987 class => 'Koha::Patrons',
1989 categorycode => $patron_category_x->categorycode,
1990 gonenoaddress => undef,
1997 my $item_1 = $builder->build_sample_item(
1999 library => $library->{branchcode},
2003 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->barcode );
2004 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
2006 # TODO There are other tests to provide here
2009 subtest 'MultipleReserves' => sub {
2012 my $biblio = $builder->build_sample_biblio();
2014 my $branch = $library2->{branchcode};
2016 my $item_1 = $builder->build_sample_item(
2018 biblionumber => $biblio->biblionumber,
2020 replacementprice => 12.00,
2025 my $item_2 = $builder->build_sample_item(
2027 biblionumber => $biblio->biblionumber,
2029 replacementprice => 12.00,
2036 my $resdate = undef;
2037 my $expdate = undef;
2039 my $checkitem = undef;
2042 my %renewing_borrower_data = (
2043 firstname => 'John',
2044 surname => 'Renewal',
2045 categorycode => $patron_category->{categorycode},
2046 branchcode => $branch,
2048 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
2049 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
2050 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
2051 my $datedue = dt_from_string( $issue->date_due() );
2052 is (defined $issue->date_due(), 1, "item 1 checked out");
2053 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
2055 my %reserving_borrower_data1 = (
2056 firstname => 'Katrin',
2057 surname => 'Reservation',
2058 categorycode => $patron_category->{categorycode},
2059 branchcode => $branch,
2061 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
2064 branchcode => $branch,
2065 borrowernumber => $reserving_borrowernumber1,
2066 biblionumber => $biblio->biblionumber,
2067 priority => $priority,
2068 reservation_date => $resdate,
2069 expiration_date => $expdate,
2071 itemnumber => $checkitem,
2076 my %reserving_borrower_data2 = (
2077 firstname => 'Kirk',
2078 surname => 'Reservation',
2079 categorycode => $patron_category->{categorycode},
2080 branchcode => $branch,
2082 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
2085 branchcode => $branch,
2086 borrowernumber => $reserving_borrowernumber2,
2087 biblionumber => $biblio->biblionumber,
2088 priority => $priority,
2089 reservation_date => $resdate,
2090 expiration_date => $expdate,
2092 itemnumber => $checkitem,
2098 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2099 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
2102 my $item_3 = $builder->build_sample_item(
2104 biblionumber => $biblio->biblionumber,
2106 replacementprice => 12.00,
2112 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2113 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
2117 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
2120 my $library = $builder->build( { source => 'Branch' } );
2121 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2123 my $biblionumber = $builder->build_sample_biblio(
2125 branchcode => $library->{branchcode},
2128 my $item_1 = $builder->build_sample_item(
2130 biblionumber => $biblionumber,
2131 library => $library->{branchcode},
2135 my $item_2 = $builder->build_sample_item(
2137 biblionumber => $biblionumber,
2138 library => $library->{branchcode},
2142 my ( $error, $question, $alerts );
2143 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, dt_from_string->add( days => 1 ) );
2145 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2146 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2148 { error => $error, alerts => $alerts },
2149 { error => {}, alerts => {} },
2150 'No error or alert should be raised'
2152 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
2154 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2155 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2157 { error => $error, question => $question, alerts => $alerts },
2158 { error => {}, question => {}, alerts => {} },
2159 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1'
2162 # Add a subscription
2163 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
2165 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2166 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2168 { error => $error, question => $question, alerts => $alerts },
2169 { error => {}, question => {}, alerts => {} },
2170 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2173 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2174 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2176 { error => $error, question => $question, alerts => $alerts },
2177 { error => {}, question => {}, alerts => {} },
2178 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2182 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
2185 my $library = $builder->build( { source => 'Branch' } );
2186 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2189 my $biblionumber = $builder->build_sample_biblio(
2191 branchcode => $library->{branchcode},
2194 my $item_1 = $builder->build_sample_item(
2196 biblionumber => $biblionumber,
2197 library => $library->{branchcode},
2200 my $item_2 = $builder->build_sample_item(
2202 biblionumber => $biblionumber,
2203 library => $library->{branchcode},
2207 # And the circulation rule
2208 Koha::CirculationRules->search->delete;
2209 Koha::CirculationRules->set_rules(
2211 categorycode => undef,
2213 branchcode => undef,
2216 firstremind => 1, # 1 day of grace
2217 finedays => 2, # 2 days of fine per day of overdue
2218 lengthunit => 'days',
2223 # Patron cannot issue item_1, they have overdues
2224 my $now = dt_from_string;
2225 my $five_days_ago = $now->clone->subtract( days => 5 );
2226 my $ten_days_ago = $now->clone->subtract( days => 10 );
2227 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2228 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2229 ; # Add another overdue
2231 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
2232 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2233 my $debarments = Koha::Patron::Debarments::GetDebarments(
2234 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2235 is( scalar(@$debarments), 1 );
2237 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
2238 # Same for the others
2239 my $expected_expiration = output_pref(
2241 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2242 dateformat => 'sql',
2246 is( $debarments->[0]->{expiration}, $expected_expiration );
2248 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2249 $debarments = Koha::Patron::Debarments::GetDebarments(
2250 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2251 is( scalar(@$debarments), 1 );
2252 $expected_expiration = output_pref(
2254 dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),
2255 dateformat => 'sql',
2259 is( $debarments->[0]->{expiration}, $expected_expiration );
2261 Koha::Patron::Debarments::DelUniqueDebarment(
2262 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2264 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
2265 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2266 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2267 ; # Add another overdue
2268 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2269 $debarments = Koha::Patron::Debarments::GetDebarments(
2270 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2271 is( scalar(@$debarments), 1 );
2272 $expected_expiration = output_pref(
2274 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2275 dateformat => 'sql',
2279 is( $debarments->[0]->{expiration}, $expected_expiration );
2281 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2282 $debarments = Koha::Patron::Debarments::GetDebarments(
2283 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2284 is( scalar(@$debarments), 1 );
2285 $expected_expiration = output_pref(
2287 dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
2288 dateformat => 'sql',
2292 is( $debarments->[0]->{expiration}, $expected_expiration );
2295 subtest 'AddReturn + suspension_chargeperiod' => sub {
2298 my $library = $builder->build( { source => 'Branch' } );
2299 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2301 my $biblionumber = $builder->build_sample_biblio(
2303 branchcode => $library->{branchcode},
2306 my $item_1 = $builder->build_sample_item(
2308 biblionumber => $biblionumber,
2309 library => $library->{branchcode},
2313 # And the issuing rule
2314 Koha::CirculationRules->search->delete;
2315 Koha::CirculationRules->set_rules(
2317 categorycode => '*',
2322 firstremind => 0, # 0 day of grace
2323 finedays => 2, # 2 days of fine per day of overdue
2324 suspension_chargeperiod => 1,
2325 lengthunit => 'days',
2330 my $now = dt_from_string;
2331 my $five_days_ago = $now->clone->subtract( days => 5 );
2332 # We want to charge 2 days every day, without grace
2333 # With 5 days of overdue: 5 * Z
2334 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2335 test_debarment_on_checkout(
2338 library => $library,
2340 due_date => $five_days_ago,
2341 expiration_date => $expected_expiration,
2345 # Same with undef firstremind
2346 Koha::CirculationRules->search->delete;
2347 Koha::CirculationRules->set_rules(
2349 categorycode => '*',
2354 firstremind => undef, # 0 day of grace
2355 finedays => 2, # 2 days of fine per day of overdue
2356 suspension_chargeperiod => 1,
2357 lengthunit => 'days',
2362 my $now = dt_from_string;
2363 my $five_days_ago = $now->clone->subtract( days => 5 );
2364 # We want to charge 2 days every day, without grace
2365 # With 5 days of overdue: 5 * Z
2366 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2367 test_debarment_on_checkout(
2370 library => $library,
2372 due_date => $five_days_ago,
2373 expiration_date => $expected_expiration,
2377 # We want to charge 2 days every 2 days, without grace
2378 # With 5 days of overdue: (5 * 2) / 2
2379 Koha::CirculationRules->set_rule(
2381 categorycode => undef,
2382 branchcode => undef,
2384 rule_name => 'suspension_chargeperiod',
2389 $expected_expiration = $now->clone->add( days => floor( 5 * 2 ) / 2 );
2390 test_debarment_on_checkout(
2393 library => $library,
2395 due_date => $five_days_ago,
2396 expiration_date => $expected_expiration,
2400 # We want to charge 2 days every 3 days, with 1 day of grace
2401 # With 5 days of overdue: ((5-1) / 3 ) * 2
2402 Koha::CirculationRules->set_rules(
2404 categorycode => undef,
2405 branchcode => undef,
2408 suspension_chargeperiod => 3,
2413 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
2414 test_debarment_on_checkout(
2417 library => $library,
2419 due_date => $five_days_ago,
2420 expiration_date => $expected_expiration,
2424 # Use finesCalendar to know if holiday must be skipped to calculate the due date
2425 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
2426 Koha::CirculationRules->set_rules(
2428 categorycode => undef,
2429 branchcode => undef,
2433 suspension_chargeperiod => 1,
2438 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
2439 t::lib::Mocks::mock_preference('SuspensionsCalendar', 'noSuspensionsWhenClosed');
2441 # Adding a holiday 2 days ago
2442 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
2443 my $two_days_ago = $now->clone->subtract( days => 2 );
2444 $calendar->insert_single_holiday(
2445 day => $two_days_ago->day,
2446 month => $two_days_ago->month,
2447 year => $two_days_ago->year,
2448 title => 'holidayTest-2d',
2449 description => 'holidayDesc 2 days ago'
2451 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
2452 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
2453 test_debarment_on_checkout(
2456 library => $library,
2458 due_date => $five_days_ago,
2459 expiration_date => $expected_expiration,
2463 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
2464 my $two_days_ahead = $now->clone->add( days => 2 );
2465 $calendar->insert_single_holiday(
2466 day => $two_days_ahead->day,
2467 month => $two_days_ahead->month,
2468 year => $two_days_ahead->year,
2469 title => 'holidayTest+2d',
2470 description => 'holidayDesc 2 days ahead'
2473 # Same as above, but we should skip D+2
2474 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
2475 test_debarment_on_checkout(
2478 library => $library,
2480 due_date => $five_days_ago,
2481 expiration_date => $expected_expiration,
2485 # Adding another holiday, day of expiration date
2486 my $expected_expiration_dt = dt_from_string($expected_expiration);
2487 $calendar->insert_single_holiday(
2488 day => $expected_expiration_dt->day,
2489 month => $expected_expiration_dt->month,
2490 year => $expected_expiration_dt->year,
2491 title => 'holidayTest_exp',
2492 description => 'holidayDesc on expiration date'
2494 # Expiration date will be the day after
2495 test_debarment_on_checkout(
2498 library => $library,
2500 due_date => $five_days_ago,
2501 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
2505 test_debarment_on_checkout(
2508 library => $library,
2510 return_date => $now->clone->add(days => 5),
2511 expiration_date => $now->clone->add(days => 5 + (5 * 2 - 1) ),
2515 test_debarment_on_checkout(
2518 library => $library,
2520 due_date => $now->clone->add(days => 1),
2521 return_date => $now->clone->add(days => 5),
2522 expiration_date => $now->clone->add(days => 5 + (4 * 2 - 1) ),
2528 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
2531 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2532 my $patron1 = $builder->build_object(
2534 class => 'Koha::Patrons',
2536 library => $library->branchcode,
2537 categorycode => $patron_category->{categorycode}
2541 my $patron2 = $builder->build_object(
2543 class => 'Koha::Patrons',
2545 library => $library->branchcode,
2546 categorycode => $patron_category->{categorycode}
2551 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
2553 my $item = $builder->build_sample_item(
2555 library => $library->branchcode,
2559 my ( $error, $question, $alerts );
2560 my $issue = AddIssue( $patron1->unblessed, $item->barcode );
2562 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2563 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2564 is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
2566 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
2567 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2568 is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
2570 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2574 subtest 'AddReturn | is_overdue' => sub {
2577 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
2578 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
2579 t::lib::Mocks::mock_preference('finesMode', 'production');
2580 t::lib::Mocks::mock_preference('MaxFine', '100');
2582 my $library = $builder->build( { source => 'Branch' } );
2583 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2584 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2585 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2587 my $item = $builder->build_sample_item(
2589 library => $library->{branchcode},
2590 replacementprice => 7
2594 Koha::CirculationRules->search->delete;
2595 Koha::CirculationRules->set_rules(
2597 categorycode => undef,
2599 branchcode => undef,
2602 lengthunit => 'days',
2603 fine => 1, # Charge 1 every day of overdue
2609 my $now = dt_from_string;
2610 my $one_day_ago = $now->clone->subtract( days => 1 );
2611 my $two_days_ago = $now->clone->subtract( days => 2 );
2612 my $five_days_ago = $now->clone->subtract( days => 5 );
2613 my $ten_days_ago = $now->clone->subtract( days => 10 );
2614 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2616 # No return date specified, today will be used => 10 days overdue charged
2617 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2618 AddReturn( $item->barcode, $library->{branchcode} );
2619 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2620 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2622 # specify return date 5 days before => no overdue charged
2623 AddIssue( $patron->unblessed, $item->barcode, $five_days_ago ); # date due was 5d ago
2624 AddReturn( $item->barcode, $library->{branchcode}, undef, $ten_days_ago );
2625 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2626 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2628 # specify return date 5 days later => 5 days overdue charged
2629 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2630 AddReturn( $item->barcode, $library->{branchcode}, undef, $five_days_ago );
2631 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2632 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2634 # specify return date 5 days later, specify exemptfine => no overdue charge
2635 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2636 AddReturn( $item->barcode, $library->{branchcode}, 1, $five_days_ago );
2637 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2638 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2640 subtest 'bug 22877 | Lost item return' => sub {
2644 my $issue = AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2646 # Fake fines cronjob on this checkout
2648 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2649 $ten_days_ago, $now );
2652 issue_id => $issue->issue_id,
2653 itemnumber => $item->itemnumber,
2654 borrowernumber => $patron->borrowernumber,
2656 due => output_pref($ten_days_ago)
2659 is( int( $patron->account->balance() ),
2660 10, "Overdue fine of 10 days overdue" );
2662 # Fake longoverdue with charge and not marking returned
2663 LostItem( $item->itemnumber, 'cronjob', 0 );
2664 is( int( $patron->account->balance() ),
2665 17, "Lost fine of 7 plus 10 days overdue" );
2667 # Now we return it today
2668 AddReturn( $item->barcode, $library->{branchcode} );
2669 is( int( $patron->account->balance() ),
2670 17, "Should have a single 10 days overdue fine and lost charge" );
2673 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2676 subtest 'bug 8338 | backdated return resulting in zero amount fine' => sub {
2680 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2682 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2684 # Fake fines cronjob on this checkout
2686 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2687 $one_day_ago, $now );
2690 issue_id => $issue->issue_id,
2691 itemnumber => $item->itemnumber,
2692 borrowernumber => $patron->borrowernumber,
2694 due => output_pref($one_day_ago)
2697 is( int( $patron->account->balance() ),
2698 1, "Overdue fine of 1 day overdue" );
2700 # Backdated return (dropbox mode example - charge should be removed)
2701 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2702 is( int( $patron->account->balance() ),
2703 0, "Overdue fine should be annulled" );
2704 my $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2705 is( $lines->count, 0, "Overdue fine accountline has been removed");
2707 $issue = AddIssue( $patron->unblessed, $item->barcode, $two_days_ago ); # date due was 2d ago
2709 # Fake fines cronjob on this checkout
2711 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2712 $two_days_ago, $now );
2715 issue_id => $issue->issue_id,
2716 itemnumber => $item->itemnumber,
2717 borrowernumber => $patron->borrowernumber,
2719 due => output_pref($one_day_ago)
2722 is( int( $patron->account->balance() ),
2723 2, "Overdue fine of 2 days overdue" );
2725 # Payment made against fine
2726 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2727 my $debit = $lines->next;
2728 my $credit = $patron->account->add_credit(
2732 interface => 'test',
2735 $credit->apply( { debits => [$debit] } );
2737 is( int( $patron->account->balance() ),
2738 0, "Overdue fine should be paid off" );
2739 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2740 is ( $lines->count, 2, "Overdue (debit) and Payment (credit) present");
2741 my $line = $lines->next;
2742 is( $line->amount+0, 2, "Overdue fine amount remains as 2 days");
2743 is( $line->amountoutstanding+0, 0, "Overdue fine amountoutstanding reduced to 0");
2745 # Backdated return (dropbox mode example - charge should be removed)
2746 AddReturn( $item->barcode, $library->{branchcode}, undef, $one_day_ago );
2747 is( int( $patron->account->balance() ),
2748 -1, "Refund credit has been applied" );
2749 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber }, { order_by => { '-asc' => 'accountlines_id' }});
2750 is( $lines->count, 3, "Overdue (debit), Payment (credit) and Refund (credit) are all present");
2752 $line = $lines->next;
2753 is($line->amount+0,1, "Overdue fine amount has been reduced to 1");
2754 is($line->amountoutstanding+0,0, "Overdue fine amount outstanding remains at 0");
2755 is($line->status,'RETURNED', "Overdue fine is fixed");
2756 $line = $lines->next;
2757 is($line->amount+0,-2, "Original payment amount remains as 2");
2758 is($line->amountoutstanding+0,0, "Original payment remains applied");
2759 $line = $lines->next;
2760 is($line->amount+0,-1, "Refund amount correctly set to 1");
2761 is($line->amountoutstanding+0,-1, "Refund amount outstanding unspent");
2764 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2767 subtest 'bug 25417 | backdated return + exemptfine' => sub {
2771 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2773 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2775 # Fake fines cronjob on this checkout
2777 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2778 $one_day_ago, $now );
2781 issue_id => $issue->issue_id,
2782 itemnumber => $item->itemnumber,
2783 borrowernumber => $patron->borrowernumber,
2785 due => output_pref($one_day_ago)
2788 is( int( $patron->account->balance() ),
2789 1, "Overdue fine of 1 day overdue" );
2791 # Backdated return (dropbox mode example - charge should no longer exist)
2792 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2793 is( int( $patron->account->balance() ),
2794 0, "Overdue fine should be annulled" );
2797 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2800 subtest 'bug 24075 | backdated return with return datetime matching due datetime' => sub {
2803 t::lib::Mocks::mock_preference( 'CalculateFinesOnBackdate', 1 );
2805 my $due_date = dt_from_string;
2806 my $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2811 issue_id => $issue->issue_id,
2812 itemnumber => $item->itemnumber,
2813 borrowernumber => $patron->borrowernumber,
2815 due => output_pref($due_date)
2818 is( $patron->account->balance(),
2819 0.25, 'Overdue fine of $0.25 recorded' );
2821 # Backdate return to exact due date and time
2822 my ( undef, $message ) =
2823 AddReturn( $item->barcode, $library->{branchcode},
2827 Koha::Account::Lines->find( { issue_id => $issue->id } );
2828 ok( !$accountline, 'accountline removed as expected' );
2831 $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2836 issue_id => $issue->issue_id,
2837 itemnumber => $item->itemnumber,
2838 borrowernumber => $patron->borrowernumber,
2840 due => output_pref($due_date)
2843 is( $patron->account->balance(),
2844 0.25, 'Overdue fine of $0.25 recorded' );
2846 # Partial pay accruing fine
2847 my $lines = Koha::Account::Lines->search(
2849 borrowernumber => $patron->borrowernumber,
2850 issue_id => $issue->id
2853 my $debit = $lines->next;
2854 my $credit = $patron->account->add_credit(
2858 interface => 'test',
2861 $credit->apply( { debits => [$debit] } );
2863 is( $patron->account->balance(), .05, 'Overdue fine reduced to $0.05' );
2865 # Backdate return to exact due date and time
2866 ( undef, $message ) =
2867 AddReturn( $item->barcode, $library->{branchcode},
2870 $lines = Koha::Account::Lines->search(
2872 borrowernumber => $patron->borrowernumber,
2873 issue_id => $issue->id
2876 $accountline = $lines->next;
2877 is( $accountline->amountoutstanding + 0,
2878 0, 'Partially paid fee amount outstanding was reduced to 0' );
2879 is( $accountline->amount + 0,
2880 0, 'Partially paid fee amount was reduced to 0' );
2881 is( $patron->account->balance(), -0.20, 'Patron refund recorded' );
2884 Koha::Account::Lines->search(
2885 { borrowernumber => $patron->borrowernumber } )->delete;
2888 subtest 'enh 23091 | Lost item return policies' => sub {
2891 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2893 my $branchcode_false =
2894 $builder->build( { source => 'Branch' } )->{branchcode};
2895 my $specific_rule_false = $builder->build(
2897 source => 'CirculationRule',
2899 branchcode => $branchcode_false,
2900 categorycode => undef,
2902 rule_name => 'lostreturn',
2907 my $branchcode_refund =
2908 $builder->build( { source => 'Branch' } )->{branchcode};
2909 my $specific_rule_refund = $builder->build(
2911 source => 'CirculationRule',
2913 branchcode => $branchcode_refund,
2914 categorycode => undef,
2916 rule_name => 'lostreturn',
2917 rule_value => 'refund'
2921 my $branchcode_restore =
2922 $builder->build( { source => 'Branch' } )->{branchcode};
2923 my $specific_rule_restore = $builder->build(
2925 source => 'CirculationRule',
2927 branchcode => $branchcode_restore,
2928 categorycode => undef,
2930 rule_name => 'lostreturn',
2931 rule_value => 'restore'
2935 my $branchcode_charge =
2936 $builder->build( { source => 'Branch' } )->{branchcode};
2937 my $specific_rule_charge = $builder->build(
2939 source => 'CirculationRule',
2941 branchcode => $branchcode_charge,
2942 categorycode => undef,
2944 rule_name => 'lostreturn',
2945 rule_value => 'charge'
2950 my $replacement_amount = 99.00;
2951 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
2952 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2953 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
2954 t::lib::Mocks::mock_preference( 'BlockReturnOfLostItems', 0 );
2955 t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl',
2957 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge',
2960 subtest 'lostreturn | false' => sub {
2963 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_false });
2965 my $item = $builder->build_sample_item(
2967 replacementprice => $replacement_amount
2972 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
2974 # Fake fines cronjob on this checkout
2976 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2977 $ten_days_ago, $now );
2980 issue_id => $issue->issue_id,
2981 itemnumber => $item->itemnumber,
2982 borrowernumber => $patron->borrowernumber,
2984 due => output_pref($ten_days_ago)
2987 my $overdue_fees = Koha::Account::Lines->search(
2989 borrowernumber => $patron->id,
2990 itemnumber => $item->itemnumber,
2991 debit_type_code => 'OVERDUE'
2994 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
2995 my $overdue_fee = $overdue_fees->next;
2996 is( $overdue_fee->amount + 0,
2997 10, 'The right OVERDUE amount is generated' );
2998 is( $overdue_fee->amountoutstanding + 0,
3000 'The right OVERDUE amountoutstanding is generated' );
3002 # Simulate item marked as lost
3003 $item->itemlost(3)->store;
3004 C4::Circulation::LostItem( $item->itemnumber, 1 );
3006 my $lost_fee_lines = Koha::Account::Lines->search(
3008 borrowernumber => $patron->id,
3009 itemnumber => $item->itemnumber,
3010 debit_type_code => 'LOST'
3013 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3014 my $lost_fee_line = $lost_fee_lines->next;
3015 is( $lost_fee_line->amount + 0,
3016 $replacement_amount, 'The right LOST amount is generated' );
3017 is( $lost_fee_line->amountoutstanding + 0,
3018 $replacement_amount,
3019 'The right LOST amountoutstanding is generated' );
3020 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3023 my ( $returned, $message ) =
3024 AddReturn( $item->barcode, $branchcode_false, undef, $five_days_ago );
3026 $overdue_fee->discard_changes;
3027 is( $overdue_fee->amount + 0,
3028 10, 'The OVERDUE amount is left intact' );
3029 is( $overdue_fee->amountoutstanding + 0,
3031 'The OVERDUE amountoutstanding is left intact' );
3033 $lost_fee_line->discard_changes;
3034 is( $lost_fee_line->amount + 0,
3035 $replacement_amount, 'The LOST amount is left intact' );
3036 is( $lost_fee_line->amountoutstanding + 0,
3037 $replacement_amount,
3038 'The LOST amountoutstanding is left intact' );
3039 # FIXME: Should we set the LOST fee status to 'FOUND' regardless of whether we're refunding or not?
3040 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3043 subtest 'lostreturn | refund' => sub {
3046 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_refund });
3048 my $item = $builder->build_sample_item(
3050 replacementprice => $replacement_amount
3055 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3057 # Fake fines cronjob on this checkout
3059 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3060 $ten_days_ago, $now );
3063 issue_id => $issue->issue_id,
3064 itemnumber => $item->itemnumber,
3065 borrowernumber => $patron->borrowernumber,
3067 due => output_pref($ten_days_ago)
3070 my $overdue_fees = Koha::Account::Lines->search(
3072 borrowernumber => $patron->id,
3073 itemnumber => $item->itemnumber,
3074 debit_type_code => 'OVERDUE'
3077 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3078 my $overdue_fee = $overdue_fees->next;
3079 is( $overdue_fee->amount + 0,
3080 10, 'The right OVERDUE amount is generated' );
3081 is( $overdue_fee->amountoutstanding + 0,
3083 'The right OVERDUE amountoutstanding is generated' );
3085 # Simulate item marked as lost
3086 $item->itemlost(3)->store;
3087 C4::Circulation::LostItem( $item->itemnumber, 1 );
3089 my $lost_fee_lines = Koha::Account::Lines->search(
3091 borrowernumber => $patron->id,
3092 itemnumber => $item->itemnumber,
3093 debit_type_code => 'LOST'
3096 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3097 my $lost_fee_line = $lost_fee_lines->next;
3098 is( $lost_fee_line->amount + 0,
3099 $replacement_amount, 'The right LOST amount is generated' );
3100 is( $lost_fee_line->amountoutstanding + 0,
3101 $replacement_amount,
3102 'The right LOST amountoutstanding is generated' );
3103 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3105 # Return the lost item
3106 my ( undef, $message ) =
3107 AddReturn( $item->barcode, $branchcode_refund, undef, $five_days_ago );
3109 $overdue_fee->discard_changes;
3110 is( $overdue_fee->amount + 0,
3111 10, 'The OVERDUE amount is left intact' );
3112 is( $overdue_fee->amountoutstanding + 0,
3114 'The OVERDUE amountoutstanding is left intact' );
3116 $lost_fee_line->discard_changes;
3117 is( $lost_fee_line->amount + 0,
3118 $replacement_amount, 'The LOST amount is left intact' );
3119 is( $lost_fee_line->amountoutstanding + 0,
3121 'The LOST amountoutstanding is refunded' );
3122 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3125 subtest 'lostreturn | restore' => sub {
3128 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_restore });
3130 my $item = $builder->build_sample_item(
3132 replacementprice => $replacement_amount
3137 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode , $ten_days_ago);
3139 # Fake fines cronjob on this checkout
3141 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3142 $ten_days_ago, $now );
3145 issue_id => $issue->issue_id,
3146 itemnumber => $item->itemnumber,
3147 borrowernumber => $patron->borrowernumber,
3149 due => output_pref($ten_days_ago)
3152 my $overdue_fees = Koha::Account::Lines->search(
3154 borrowernumber => $patron->id,
3155 itemnumber => $item->itemnumber,
3156 debit_type_code => 'OVERDUE'
3159 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3160 my $overdue_fee = $overdue_fees->next;
3161 is( $overdue_fee->amount + 0,
3162 10, 'The right OVERDUE amount is generated' );
3163 is( $overdue_fee->amountoutstanding + 0,
3165 'The right OVERDUE amountoutstanding is generated' );
3167 # Simulate item marked as lost
3168 $item->itemlost(3)->store;
3169 C4::Circulation::LostItem( $item->itemnumber, 1 );
3171 my $lost_fee_lines = Koha::Account::Lines->search(
3173 borrowernumber => $patron->id,
3174 itemnumber => $item->itemnumber,
3175 debit_type_code => 'LOST'
3178 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3179 my $lost_fee_line = $lost_fee_lines->next;
3180 is( $lost_fee_line->amount + 0,
3181 $replacement_amount, 'The right LOST amount is generated' );
3182 is( $lost_fee_line->amountoutstanding + 0,
3183 $replacement_amount,
3184 'The right LOST amountoutstanding is generated' );
3185 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3187 # Simulate refunding overdue fees upon marking item as lost
3188 my $overdue_forgive = $patron->account->add_credit(
3191 user_id => $manager->borrowernumber,
3192 library_id => $branchcode_restore,
3193 interface => 'test',
3195 item_id => $item->itemnumber
3198 $overdue_forgive->apply( { debits => [$overdue_fee] } );
3199 $overdue_fee->discard_changes;
3200 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3203 my ( undef, $message ) =
3204 AddReturn( $item->barcode, $branchcode_restore, undef, $five_days_ago );
3206 $overdue_fee->discard_changes;
3207 is( $overdue_fee->amount + 0,
3208 10, 'The OVERDUE amount is left intact' );
3209 is( $overdue_fee->amountoutstanding + 0,
3211 'The OVERDUE amountoutstanding is restored' );
3213 $lost_fee_line->discard_changes;
3214 is( $lost_fee_line->amount + 0,
3215 $replacement_amount, 'The LOST amount is left intact' );
3216 is( $lost_fee_line->amountoutstanding + 0,
3218 'The LOST amountoutstanding is refunded' );
3219 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3222 subtest 'lostreturn | charge' => sub {
3225 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_charge });
3227 my $item = $builder->build_sample_item(
3229 replacementprice => $replacement_amount
3234 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3236 # Fake fines cronjob on this checkout
3238 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3239 $ten_days_ago, $now );
3242 issue_id => $issue->issue_id,
3243 itemnumber => $item->itemnumber,
3244 borrowernumber => $patron->borrowernumber,
3246 due => output_pref($ten_days_ago)
3249 my $overdue_fees = Koha::Account::Lines->search(
3251 borrowernumber => $patron->id,
3252 itemnumber => $item->itemnumber,
3253 debit_type_code => 'OVERDUE'
3256 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3257 my $overdue_fee = $overdue_fees->next;
3258 is( $overdue_fee->amount + 0,
3259 10, 'The right OVERDUE amount is generated' );
3260 is( $overdue_fee->amountoutstanding + 0,
3262 'The right OVERDUE amountoutstanding is generated' );
3264 # Simulate item marked as lost
3265 $item->itemlost(3)->store;
3266 C4::Circulation::LostItem( $item->itemnumber, 1 );
3268 my $lost_fee_lines = Koha::Account::Lines->search(
3270 borrowernumber => $patron->id,
3271 itemnumber => $item->itemnumber,
3272 debit_type_code => 'LOST'
3275 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3276 my $lost_fee_line = $lost_fee_lines->next;
3277 is( $lost_fee_line->amount + 0,
3278 $replacement_amount, 'The right LOST amount is generated' );
3279 is( $lost_fee_line->amountoutstanding + 0,
3280 $replacement_amount,
3281 'The right LOST amountoutstanding is generated' );
3282 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3284 # Simulate refunding overdue fees upon marking item as lost
3285 my $overdue_forgive = $patron->account->add_credit(
3288 user_id => $manager->borrowernumber,
3289 library_id => $branchcode_charge,
3290 interface => 'test',
3292 item_id => $item->itemnumber
3295 $overdue_forgive->apply( { debits => [$overdue_fee] } );
3296 $overdue_fee->discard_changes;
3297 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3300 my ( undef, $message ) =
3301 AddReturn( $item->barcode, $branchcode_charge, undef, $five_days_ago );
3303 $lost_fee_line->discard_changes;
3304 is( $lost_fee_line->amount + 0,
3305 $replacement_amount, 'The LOST amount is left intact' );
3306 is( $lost_fee_line->amountoutstanding + 0,
3308 'The LOST amountoutstanding is refunded' );
3309 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3311 $overdue_fees = Koha::Account::Lines->search(
3313 borrowernumber => $patron->id,
3314 itemnumber => $item->itemnumber,
3315 debit_type_code => 'OVERDUE'
3318 order_by => { '-asc' => 'accountlines_id'}
3321 is( $overdue_fees->count, 2, 'A second OVERDUE fee has been added' );
3322 $overdue_fee = $overdue_fees->next;
3323 is( $overdue_fee->amount + 0,
3324 10, 'The original OVERDUE amount is left intact' );
3325 is( $overdue_fee->amountoutstanding + 0,
3327 'The original OVERDUE amountoutstanding is left as forgiven' );
3328 $overdue_fee = $overdue_fees->next;
3329 is( $overdue_fee->amount + 0,
3330 5, 'The new OVERDUE amount is correct for the backdated return' );
3331 is( $overdue_fee->amountoutstanding + 0,
3333 'The new OVERDUE amountoutstanding is correct for the backdated return' );
3338 subtest '_FixOverduesOnReturn' => sub {
3341 my $manager = $builder->build_object({ class => "Koha::Patrons" });
3342 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
3344 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
3346 my $branchcode = $library2->{branchcode};
3348 my $item = $builder->build_sample_item(
3350 biblionumber => $biblio->biblionumber,
3351 library => $branchcode,
3352 replacementprice => 99.00,
3357 my $patron = $builder->build( { source => 'Borrower' } );
3359 ## Start with basic call, should just close out the open fine
3360 my $accountline = Koha::Account::Line->new(
3362 borrowernumber => $patron->{borrowernumber},
3363 debit_type_code => 'OVERDUE',
3364 status => 'UNRETURNED',
3365 itemnumber => $item->itemnumber,
3367 amountoutstanding => 99.00,
3368 interface => 'test',
3372 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
3374 $accountline->_result()->discard_changes();
3376 is( $accountline->amountoutstanding+0, 99, 'Fine has the same amount outstanding as previously' );
3377 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3378 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3380 ## Run again, with exemptfine enabled
3383 debit_type_code => 'OVERDUE',
3384 status => 'UNRETURNED',
3385 amountoutstanding => 99.00,
3389 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3391 $accountline->_result()->discard_changes();
3392 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'APPLY' })->next();
3394 is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
3395 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3396 is( $accountline->status, 'RETURNED', 'Open fine ( account type OVERDUE ) has been set to returned ( status RETURNED )');
3397 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
3398 is( $offset->amount + 0, -99, "Amount of offset is correct" );
3399 my $credit = $offset->credit;
3400 is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
3401 is( $credit->amount + 0, -99, "Credit amount is set correctly" );
3402 is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
3404 # Bug 25417 - Only forgive fines where there is an amount outstanding to forgive
3407 debit_type_code => 'OVERDUE',
3408 status => 'UNRETURNED',
3409 amountoutstanding => 0.00,
3414 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3416 $accountline->_result()->discard_changes();
3417 $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'CREATE' })->next();
3418 is( $offset, undef, "No offset created when trying to forgive fine with no outstanding balance" );
3419 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3420 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3423 subtest 'Set waiting flag' => sub {
3426 my $library_1 = $builder->build( { source => 'Branch' } );
3427 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3428 my $library_2 = $builder->build( { source => 'Branch' } );
3429 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3431 my $item = $builder->build_sample_item(
3433 library => $library_1->{branchcode},
3437 set_userenv( $library_2 );
3438 my $reserve_id = AddReserve(
3440 branchcode => $library_2->{branchcode},
3441 borrowernumber => $patron_2->{borrowernumber},
3442 biblionumber => $item->biblionumber,
3444 itemnumber => $item->itemnumber,
3448 set_userenv( $library_1 );
3449 my $do_transfer = 1;
3450 my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
3451 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3452 my $hold = Koha::Holds->find( $reserve_id );
3453 is( $hold->found, 'T', 'Hold is in transit' );
3455 my ( $status ) = CheckReserves($item->itemnumber);
3456 is( $status, 'Transferred', 'Hold is not waiting yet');
3458 set_userenv( $library_2 );
3460 AddReturn( $item->barcode, $library_2->{branchcode} );
3461 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3462 $hold = Koha::Holds->find( $reserve_id );
3463 is( $hold->found, 'W', 'Hold is waiting' );
3464 ( $status ) = CheckReserves($item->itemnumber);
3465 is( $status, 'Waiting', 'Now the hold is waiting');
3467 #Bug 21944 - Waiting transfer checked in at branch other than pickup location
3468 set_userenv( $library_1 );
3469 (undef, my $messages, undef, undef ) = AddReturn ( $item->barcode, $library_1->{branchcode} );
3470 $hold = Koha::Holds->find( $reserve_id );
3471 is( $hold->found, undef, 'Hold is no longer marked waiting' );
3472 is( $hold->priority, 1, "Hold is now priority one again");
3473 is( $hold->waitingdate, undef, "Hold no longer has a waiting date");
3474 is( $hold->itemnumber, $item->itemnumber, "Hold has retained its' itemnumber");
3475 is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned");
3476 is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message");
3477 is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message");
3480 subtest 'Cancel transfers on lost items' => sub {
3483 my $library_to = $builder->build_object( { class => 'Koha::Libraries' } );
3484 my $item = $builder->build_sample_item();
3485 my $holdingbranch = $item->holdingbranch;
3486 # Historic transfer (datearrived is defined)
3487 my $old_transfer = $builder->build_object(
3489 class => 'Koha::Item::Transfers',
3491 itemnumber => $item->itemnumber,
3492 frombranch => $holdingbranch,
3493 tobranch => $library_to->branchcode,
3495 datesent => \'NOW()',
3496 datearrived => \'NOW()',
3497 datecancelled => undef,
3498 daterequested => \'NOW()'
3502 # Queued transfer (datesent is undefined)
3503 my $transfer_1 = $builder->build_object(
3505 class => 'Koha::Item::Transfers',
3507 itemnumber => $item->itemnumber,
3508 frombranch => $holdingbranch,
3509 tobranch => $library_to->branchcode,
3512 datearrived => undef,
3513 datecancelled => undef,
3514 daterequested => \'NOW()'
3518 # In transit transfer (datesent is defined, datearrived and datecancelled are both undefined)
3519 my $transfer_2 = $builder->build_object(
3521 class => 'Koha::Item::Transfers',
3523 itemnumber => $item->itemnumber,
3524 frombranch => $holdingbranch,
3525 tobranch => $library_to->branchcode,
3527 datesent => \'NOW()',
3528 datearrived => undef,
3529 datecancelled => undef,
3530 daterequested => \'NOW()'
3535 # Simulate item being marked as lost
3536 $item->itemlost(1)->store;
3537 LostItem( $item->itemnumber, 'test', 1 );
3539 $transfer_1->discard_changes;
3540 isnt($transfer_1->datecancelled, undef, "Queud transfer was cancelled upon item lost");
3541 is($transfer_1->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3542 $transfer_2->discard_changes;
3543 isnt($transfer_2->datecancelled, undef, "Active transfer was cancelled upon item lost");
3544 is($transfer_2->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3545 $old_transfer->discard_changes;
3546 is($old_transfer->datecancelled, undef, "Old transfers are unaffected");
3547 $item->discard_changes;
3548 is($item->holdingbranch, $holdingbranch, "Items holding branch remains unchanged");
3551 subtest 'CanBookBeIssued | is_overdue' => sub {
3554 # Set a simple circ policy
3555 Koha::CirculationRules->set_rules(
3557 categorycode => undef,
3558 branchcode => undef,
3562 reservesallowed => 25,
3564 lengthunit => 'days',
3565 renewalsallowed => 1,
3567 norenewalbefore => undef,
3575 my $now = dt_from_string;
3576 my $five_days_go = output_pref({ dt => $now->clone->add( days => 5 ), dateonly => 1});
3577 my $ten_days_go = output_pref({ dt => $now->clone->add( days => 10), dateonly => 1 });
3578 my $library = $builder->build( { source => 'Branch' } );
3579 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
3581 my $item = $builder->build_sample_item(
3583 library => $library->{branchcode},
3587 my $issue = AddIssue( $patron->unblessed, $item->barcode, $five_days_go ); # date due was 10d ago
3588 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->itemnumber } );
3589 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
3590 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->barcode,$ten_days_go, undef, undef, undef);
3591 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
3592 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
3595 subtest 'ItemsDeniedRenewal preference' => sub {
3598 C4::Context->set_preference('ItemsDeniedRenewal','');
3600 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
3601 Koha::CirculationRules->set_rules(
3603 categorycode => '*',
3605 branchcode => $idr_lib->branchcode,
3607 reservesallowed => 25,
3609 lengthunit => 'days',
3610 renewalsallowed => 10,
3612 norenewalbefore => undef,
3620 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
3621 homebranch => $idr_lib->branchcode,
3625 itemcallnumber => undef,
3629 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
3630 homebranch => $idr_lib->branchcode,
3633 location => 'NOPROC'
3637 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
3638 branchcode => $idr_lib->branchcode,
3641 my $future = dt_from_string->add( days => 1 );
3642 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3643 returndate => undef,
3646 borrowernumber => $idr_borrower->borrowernumber,
3647 itemnumber => $deny_book->itemnumber,
3648 onsite_checkout => 0,
3649 date_due => $future,
3652 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3653 returndate => undef,
3656 borrowernumber => $idr_borrower->borrowernumber,
3657 itemnumber => $allow_book->itemnumber,
3658 onsite_checkout => 0,
3659 date_due => $future,
3665 my ( $idr_mayrenew, $idr_error ) =
3666 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3667 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
3668 is( $idr_error, undef, 'Renewal allowed when no rules' );
3670 $idr_rules="withdrawn: [1]";
3672 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3673 ( $idr_mayrenew, $idr_error ) =
3674 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3675 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
3676 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
3677 ( $idr_mayrenew, $idr_error ) =
3678 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3679 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3680 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3682 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
3684 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3685 ( $idr_mayrenew, $idr_error ) =
3686 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3687 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
3688 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
3689 ( $idr_mayrenew, $idr_error ) =
3690 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3691 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3692 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3694 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
3696 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3697 ( $idr_mayrenew, $idr_error ) =
3698 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3699 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
3700 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
3701 ( $idr_mayrenew, $idr_error ) =
3702 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3703 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3704 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3706 $idr_rules="itemcallnumber: [NULL]";
3707 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3708 ( $idr_mayrenew, $idr_error ) =
3709 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3710 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
3711 $idr_rules="itemcallnumber: ['']";
3712 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3713 ( $idr_mayrenew, $idr_error ) =
3714 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3715 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
3717 $idr_rules="itemnotes: [NULL]";
3718 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3719 ( $idr_mayrenew, $idr_error ) =
3720 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3721 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
3722 $idr_rules="itemnotes: ['']";
3723 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3724 ( $idr_mayrenew, $idr_error ) =
3725 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3726 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
3729 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
3732 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3733 my $library = $builder->build( { source => 'Branch' } );
3734 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3736 my $item = $builder->build_sample_item(
3738 library => $library->{branchcode},
3742 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3743 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3744 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3747 subtest 'CanBookBeIssued | notforloan' => sub {
3750 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
3752 my $library = $builder->build( { source => 'Branch' } );
3753 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3755 my $itemtype = $builder->build(
3757 source => 'Itemtype',
3758 value => { notforloan => undef, }
3761 my $item = $builder->build_sample_item(
3763 library => $library->{branchcode},
3764 itype => $itemtype->{itemtype},
3767 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3769 my ( $issuingimpossible, $needsconfirmation );
3772 subtest 'item-level_itypes = 1' => sub {
3775 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
3776 # Is for loan at item type and item level
3777 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3778 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3779 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3781 # not for loan at item type level
3782 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3783 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3784 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3787 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3788 'Item can not be issued, not for loan at item type level'
3791 # not for loan at item level
3792 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3793 $item->notforloan( 1 )->store;
3794 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3795 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3798 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3799 'Item can not be issued, not for loan at item type level'
3803 subtest 'item-level_itypes = 0' => sub {
3806 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3808 # We set another itemtype for biblioitem
3809 my $itemtype = $builder->build(
3811 source => 'Itemtype',
3812 value => { notforloan => undef, }
3816 # for loan at item type and item level
3817 $item->notforloan(0)->store;
3818 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3819 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3820 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3821 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3823 # not for loan at item type level
3824 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3825 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3826 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3829 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3830 'Item can not be issued, not for loan at item type level'
3833 # not for loan at item level
3834 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3835 $item->notforloan( 1 )->store;
3836 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3837 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3840 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3841 'Item can not be issued, not for loan at item type level'
3845 # TODO test with AllowNotForLoanOverride = 1
3848 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
3851 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
3852 my $item = $builder->build_sample_item(
3854 onloan => '2018-01-01',
3858 AddReturn( $item->barcode, $item->homebranch );
3859 $item->discard_changes; # refresh
3860 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
3864 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
3869 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3871 my $issuing_charges = 15;
3872 my $title = 'A title';
3873 my $author = 'Author, An';
3874 my $barcode = 'WHATARETHEODDS';
3876 my $circ = Test::MockModule->new('C4::Circulation');
3878 'GetIssuingCharges',
3880 return $issuing_charges;
3884 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3885 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
3886 my $patron = $builder->build_object({
3887 class => 'Koha::Patrons',
3888 value => { branchcode => $library->id }
3891 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
3892 my $item_id = Koha::Item->new(
3894 biblionumber => $biblio->biblionumber,
3895 homebranch => $library->id,
3896 holdingbranch => $library->id,
3897 barcode => $barcode,
3898 replacementprice => 23.00,
3899 itype => $itemtype->id
3901 )->store->itemnumber;
3902 my $item = Koha::Items->find( $item_id );
3904 my $context = Test::MockModule->new('C4::Context');
3905 $context->mock( userenv => { branch => $library->id } );
3907 # Check the item out
3908 AddIssue( $patron->unblessed, $item->barcode );
3911 AddRenewal( $patron->borrowernumber, $item->itemnumber, $library->id, undef, {break=>"the_renewal"} );
3912 } 'Koha::Exceptions::Checkout::FailedRenewal', 'Exception is thrown when renewal update to issues fails';
3914 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3915 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3916 my %params_renewal = (
3917 timestamp => { -like => $date . "%" },
3918 module => "CIRCULATION",
3919 action => "RENEWAL",
3921 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3922 AddRenewal( $patron->id, $item->id, $library->id );
3923 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3924 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3926 my $checkouts = $patron->checkouts;
3927 # The following will fail if run on 00:00:00
3928 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3930 my $lines = Koha::Account::Lines->search({
3931 borrowernumber => $patron->id,
3932 itemnumber => $item->id
3935 is( $lines->count, 2 );
3937 my $line = $lines->next;
3938 is( $line->debit_type_code, 'RENT', 'The issue of item with issuing charge generates an accountline of the correct type' );
3939 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
3940 is( $line->description, '', 'AddIssue does not set a hardcoded description for the accountline' );
3942 $line = $lines->next;
3943 is( $line->debit_type_code, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3944 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
3945 is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3947 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3949 $context = Test::MockModule->new('C4::Context');
3950 $context->mock( userenv => { branch => undef, interface => 'CRON'} ); #Test statistical logging of renewal via cron (atuo_renew)
3952 my $now = dt_from_string;
3953 $date = output_pref( { dt => $now, dateonly => 1, dateformat => 'iso' } );
3954 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3955 my $sth = $dbh->prepare("SELECT COUNT(*) FROM statistics WHERE itemnumber = ? AND branch = ?");
3956 $sth->execute($item->id, $library->id);
3957 my ($old_stats_size) = $sth->fetchrow_array;
3958 AddRenewal( $patron->id, $item->id, $library->id );
3959 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3960 $sth->execute($item->id, $library->id);
3961 my ($new_stats_size) = $sth->fetchrow_array;
3962 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3963 is( $new_stats_size, $old_stats_size + 1, 'renew statistic successfully added with passed branch' );
3965 AddReturn( $item->id, $library->id, undef, $date );
3966 AddIssue( $patron->unblessed, $item->barcode, $now );
3967 AddRenewal( $patron->id, $item->id, $library->id, undef, undef, 1 );
3968 my $lines_skipped = Koha::Account::Lines->search({
3969 borrowernumber => $patron->id,
3970 itemnumber => $item->id
3972 is( $lines_skipped->count, 5, 'Passing skipfinecalc causes fine calculation on renewal to be skipped' );
3976 subtest 'ProcessOfflinePayment() tests' => sub {
3983 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
3984 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3985 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3987 is( $result, 'Success.', 'The right string is returned' );
3989 my $lines = $patron->account->lines;
3990 is( $lines->count, 1, 'line created correctly');
3992 my $line = $lines->next;
3993 is( $line->amount+0, $amount * -1, 'amount picked from params' );
3994 is( $line->branchcode, $library->id, 'branchcode set correctly' );
3998 subtest 'Incremented fee tests' => sub {
4001 my $dt = dt_from_string();
4002 Time::Fake->offset( $dt->epoch );
4004 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
4007 $builder->build_object( { class => 'Koha::Libraries' } )->store;
4009 $module->mock( 'userenv', sub { { branch => $library->id } } );
4011 my $patron = $builder->build_object(
4013 class => 'Koha::Patrons',
4014 value => { categorycode => $patron_category->{categorycode} }
4018 my $itemtype = $builder->build_object(
4020 class => 'Koha::ItemTypes',
4022 notforloan => undef,
4024 rentalcharge_daily => 1,
4025 rentalcharge_daily_calendar => 0
4030 my $item = $builder->build_sample_item(
4032 library => $library->{branchcode},
4033 itype => $itemtype->id,
4037 is( $itemtype->rentalcharge_daily+0,
4038 1, 'Daily rental charge stored and retreived correctly' );
4039 is( $item->effective_itemtype, $itemtype->id,
4040 "Itemtype set correctly for item" );
4042 my $now = dt_from_string;
4043 my $dt_from = $now->clone;
4044 my $dt_to = $now->clone->add( days => 7 );
4045 my $dt_to_renew = $now->clone->add( days => 13 );
4049 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4050 my $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4051 is( $accountline->amount+0, 7,
4052 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0"
4054 $accountline->delete();
4055 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4056 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4057 is( $accountline->amount+0, 6,
4058 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0, for renewal"
4060 $accountline->delete();
4063 t::lib::Mocks::mock_preference( 'finesCalendar', 'noFinesWhenClosed' );
4064 $itemtype->rentalcharge_daily_calendar(1)->store();
4066 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4067 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4068 is( $accountline->amount+0, 7,
4069 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1"
4071 $accountline->delete();
4072 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4073 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4074 is( $accountline->amount+0, 6,
4075 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1, for renewal"
4077 $accountline->delete();
4080 my $calendar = C4::Calendar->new( branchcode => $library->id );
4081 # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
4083 ( $dt_from->day_of_week == 6 ) ? 0
4084 : ( $dt_from->day_of_week == 7 ) ? 1
4085 : $dt_from->day_of_week + 1;
4086 my $closed_day_name = $dt_from->clone->add(days => 1)->day_name;
4087 $calendar->insert_week_day_holiday(
4088 weekday => $closed_day,
4089 title => 'Test holiday',
4090 description => 'Test holiday'
4093 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4094 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4095 is( $accountline->amount+0, 6,
4096 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name"
4098 $accountline->delete();
4099 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4100 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4101 is( $accountline->amount+0, 5,
4102 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name, for renewal"
4104 $accountline->delete();
4107 $itemtype->rentalcharge(2)->store;
4108 is( $itemtype->rentalcharge+0, 2,
4109 'Rental charge updated and retreived correctly' );
4111 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4113 Koha::Account::Lines->search( { itemnumber => $item->id } );
4114 is( $accountlines->count, '2',
4115 "Fixed charge and accrued charge recorded distinctly" );
4116 $accountlines->delete();
4117 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4118 $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
4119 is( $accountlines->count, '2',
4120 "Fixed charge and accrued charge recorded distinctly, for renewal" );
4121 $accountlines->delete();
4123 $itemtype->rentalcharge(0)->store;
4124 is( $itemtype->rentalcharge+0, 0,
4125 'Rental charge reset and retreived correctly' );
4128 Koha::CirculationRules->set_rule(
4130 categorycode => $patron->categorycode,
4131 itemtype => $itemtype->id,
4132 branchcode => $library->id,
4133 rule_name => 'lengthunit',
4134 rule_value => 'hours',
4138 $itemtype->rentalcharge_hourly('0.25')->store();
4139 is( $itemtype->rentalcharge_hourly,
4140 '0.25', 'Hourly rental charge stored and retreived correctly' );
4142 $dt_to = $now->clone->add( hours => 168 );
4143 $dt_to_renew = $now->clone->add( hours => 312 );
4145 $itemtype->rentalcharge_hourly_calendar(0)->store();
4147 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4148 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4149 is( $accountline->amount + 0, 42,
4150 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)" );
4151 $accountline->delete();
4152 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4153 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4154 is( $accountline->amount + 0, 36,
4155 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)" );
4156 $accountline->delete();
4159 $itemtype->rentalcharge_hourly_calendar(1)->store();
4161 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4162 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4163 is( $accountline->amount + 0, 36,
4164 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name (168h - 24h * 0.25u)" );
4165 $accountline->delete();
4166 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4167 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4168 is( $accountline->amount + 0, 30,
4169 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name, for renewal (312h - 168h - 24h * 0.25u" );
4170 $accountline->delete();
4173 $calendar->delete_holiday( weekday => $closed_day );
4175 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4176 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4177 is( $accountline->amount + 0, 42,
4178 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u" );
4179 $accountline->delete();
4180 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4181 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4182 is( $accountline->amount + 0, 36,
4183 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)" );
4184 $accountline->delete();
4189 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
4192 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
4193 t::lib::Mocks::mock_preference('item-level_itypes', 1);
4196 $builder->build_object( { class => 'Koha::Libraries' } )->store;
4197 my $patron = $builder->build_object(
4199 class => 'Koha::Patrons',
4200 value => { categorycode => $patron_category->{categorycode} }
4204 my $itemtype = $builder->build_object(
4206 class => 'Koha::ItemTypes',
4210 rentalcharge_daily => 0
4215 my $item = $builder->build_sample_item(
4217 library => $library->id,
4221 itype => $itemtype->id,
4225 my ( $issuingimpossible, $needsconfirmation );
4226 my $dt_from = dt_from_string();
4227 my $dt_due = $dt_from->clone->add( days => 3 );
4229 $itemtype->rentalcharge(1)->store;
4230 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4231 is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' );
4232 $itemtype->rentalcharge('0')->store;
4233 $itemtype->rentalcharge_daily(1)->store;
4234 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4235 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
4236 $itemtype->rentalcharge_daily('0')->store;
4239 subtest 'CanBookBeIssued & CircConfirmItemParts' => sub {
4242 t::lib::Mocks::mock_preference('CircConfirmItemParts', 1);
4244 my $patron = $builder->build_object(
4246 class => 'Koha::Patrons',
4247 value => { categorycode => $patron_category->{categorycode} }
4251 my $item = $builder->build_sample_item(
4253 materials => 'includes DVD',
4257 my $dt_due = dt_from_string->add( days => 3 );
4259 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4260 is_deeply( $needsconfirmation, { ADDITIONAL_MATERIALS => 'includes DVD' }, 'Item needs confirmation of additional parts' );
4263 subtest 'Do not return on renewal (LOST charge)' => sub {
4266 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'onpayment');
4267 my $library = $builder->build_object( { class => "Koha::Libraries" } );
4268 my $manager = $builder->build_object( { class => "Koha::Patrons" } );
4269 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
4271 my $biblio = $builder->build_sample_biblio;
4273 my $item = $builder->build_sample_item(
4275 biblionumber => $biblio->biblionumber,
4276 library => $library->branchcode,
4277 replacementprice => 99.00,
4282 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
4283 AddIssue( $patron->unblessed, $item->barcode );
4285 my $accountline = Koha::Account::Line->new(
4287 borrowernumber => $patron->borrowernumber,
4288 debit_type_code => 'LOST',
4290 itemnumber => $item->itemnumber,
4292 amountoutstanding => 12,
4293 interface => 'something',
4297 # AddRenewal doesn't call _FixAccountForLostAndFound
4298 AddIssue( $patron->unblessed, $item->barcode );
4300 is( $patron->checkouts->count, 1,
4301 'Renewal should not return the item even if a LOST payment has been made earlier'
4305 subtest 'Filling a hold should cancel existing transfer' => sub {
4308 t::lib::Mocks::mock_preference('AutomaticItemReturn', 1);
4310 my $libraryA = $builder->build_object( { class => 'Koha::Libraries' } );
4311 my $libraryB = $builder->build_object( { class => 'Koha::Libraries' } );
4312 my $patron = $builder->build_object(
4314 class => 'Koha::Patrons',
4316 categorycode => $patron_category->{categorycode},
4317 branchcode => $libraryA->branchcode,
4322 my $item = $builder->build_sample_item({
4323 homebranch => $libraryB->branchcode,
4326 my ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4327 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 1, "We generate a transfer on checkin");
4329 branchcode => $libraryA->branchcode,
4330 borrowernumber => $patron->borrowernumber,
4331 biblionumber => $item->biblionumber,
4332 itemnumber => $item->itemnumber
4334 my $reserves = Koha::Holds->search({ itemnumber => $item->itemnumber });
4335 is( $reserves->count, 1, "Reserve is placed");
4336 ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4337 my $reserve = $reserves->next;
4338 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 0, $reserve->reserve_id );
4339 $reserve->discard_changes;
4340 ok( $reserve->found eq 'W', "Reserve is marked waiting" );
4341 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 0, "No outstanding transfers when hold is waiting");
4344 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddReturn' => sub {
4348 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4349 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4350 my $patron = $builder->build_object(
4352 class => 'Koha::Patrons',
4353 value => { categorycode => $patron_category->{categorycode} }
4357 my $biblionumber = $builder->build_sample_biblio(
4359 branchcode => $library->branchcode,
4363 # And the circulation rule
4364 Koha::CirculationRules->search->delete;
4365 Koha::CirculationRules->set_rules(
4367 categorycode => undef,
4369 branchcode => undef,
4372 lengthunit => 'days',
4378 source => 'CirculationRule',
4380 branchcode => undef,
4381 categorycode => undef,
4383 rule_name => 'lostreturn',
4384 rule_value => 'refund'
4389 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4392 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4393 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4395 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4397 my $item = $builder->build_sample_item(
4399 biblionumber => $biblionumber,
4400 library => $library->branchcode,
4401 replacementprice => '42',
4404 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4405 LostItem( $item->itemnumber, 'cli', 0 );
4406 $item->_result->itemlost(1);
4407 $item->_result->itemlost_on( $lost_on );
4408 $item->_result->update();
4410 my $a = Koha::Account::Lines->search(
4412 itemnumber => $item->id,
4413 borrowernumber => $patron->borrowernumber
4416 ok( $a, "Found accountline for lost fee" );
4417 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4418 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4419 $a = $a->get_from_storage;
4420 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4424 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4427 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4428 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4430 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4432 my $item = $builder->build_sample_item(
4434 biblionumber => $biblionumber,
4435 library => $library->branchcode,
4436 replacementprice => '42',
4439 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4440 LostItem( $item->itemnumber, 'cli', 0 );
4441 $item->_result->itemlost(1);
4442 $item->_result->itemlost_on( $lost_on );
4443 $item->_result->update();
4445 my $a = Koha::Account::Lines->search(
4447 itemnumber => $item->id,
4448 borrowernumber => $patron->borrowernumber
4451 ok( $a, "Found accountline for lost fee" );
4452 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4453 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4454 $a = $a->get_from_storage;
4455 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4459 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4462 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4463 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4465 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4467 my $item = $builder->build_sample_item(
4469 biblionumber => $biblionumber,
4470 library => $library->branchcode,
4471 replacementprice => '42',
4474 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4475 LostItem( $item->itemnumber, 'cli', 0 );
4476 $item->_result->itemlost(1);
4477 $item->_result->itemlost_on( $lost_on );
4478 $item->_result->update();
4480 my $a = Koha::Account::Lines->search(
4482 itemnumber => $item->id,
4483 borrowernumber => $patron->borrowernumber
4486 ok( $a, "Found accountline for lost fee" );
4487 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4488 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4489 $a = $a->get_from_storage;
4490 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4494 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4497 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4498 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4500 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4502 my $item = $builder->build_sample_item(
4504 biblionumber => $biblionumber,
4505 library => $library->branchcode,
4506 replacementprice => '42',
4509 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4510 LostItem( $item->itemnumber, 'cli', 0 );
4511 $item->_result->itemlost(1);
4512 $item->_result->itemlost_on( $lost_on );
4513 $item->_result->update();
4515 my $a = Koha::Account::Lines->search(
4517 itemnumber => $item->id,
4518 borrowernumber => $patron->borrowernumber
4522 ok( $a, "Found accountline for lost fee" );
4523 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4524 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4525 $a = $a->get_from_storage;
4526 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4531 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddIssue' => sub {
4535 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4536 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4537 my $patron = $builder->build_object(
4539 class => 'Koha::Patrons',
4540 value => { categorycode => $patron_category->{categorycode} }
4543 my $patron2 = $builder->build_object(
4545 class => 'Koha::Patrons',
4546 value => { categorycode => $patron_category->{categorycode} }
4550 my $biblionumber = $builder->build_sample_biblio(
4552 branchcode => $library->branchcode,
4556 # And the circulation rule
4557 Koha::CirculationRules->search->delete;
4558 Koha::CirculationRules->set_rules(
4560 categorycode => undef,
4562 branchcode => undef,
4565 lengthunit => 'days',
4571 source => 'CirculationRule',
4573 branchcode => undef,
4574 categorycode => undef,
4576 rule_name => 'lostreturn',
4577 rule_value => 'refund'
4582 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4585 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4586 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4588 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4590 my $item = $builder->build_sample_item(
4592 biblionumber => $biblionumber,
4593 library => $library->branchcode,
4594 replacementprice => '42',
4597 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4598 LostItem( $item->itemnumber, 'cli', 0 );
4599 $item->_result->itemlost(1);
4600 $item->_result->itemlost_on( $lost_on );
4601 $item->_result->update();
4603 my $a = Koha::Account::Lines->search(
4605 itemnumber => $item->id,
4606 borrowernumber => $patron->borrowernumber
4609 ok( $a, "Found accountline for lost fee" );
4610 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4611 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4612 $a = $a->get_from_storage;
4613 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4618 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4621 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4622 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4624 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4626 my $item = $builder->build_sample_item(
4628 biblionumber => $biblionumber,
4629 library => $library->branchcode,
4630 replacementprice => '42',
4633 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4634 LostItem( $item->itemnumber, 'cli', 0 );
4635 $item->_result->itemlost(1);
4636 $item->_result->itemlost_on( $lost_on );
4637 $item->_result->update();
4639 my $a = Koha::Account::Lines->search(
4641 itemnumber => $item->id,
4642 borrowernumber => $patron->borrowernumber
4645 ok( $a, "Found accountline for lost fee" );
4646 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4647 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4648 $a = $a->get_from_storage;
4649 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4653 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4656 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4657 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4659 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4661 my $item = $builder->build_sample_item(
4663 biblionumber => $biblionumber,
4664 library => $library->branchcode,
4665 replacementprice => '42',
4668 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4669 LostItem( $item->itemnumber, 'cli', 0 );
4670 $item->_result->itemlost(1);
4671 $item->_result->itemlost_on( $lost_on );
4672 $item->_result->update();
4674 my $a = Koha::Account::Lines->search(
4676 itemnumber => $item->id,
4677 borrowernumber => $patron->borrowernumber
4680 ok( $a, "Found accountline for lost fee" );
4681 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4682 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4683 $a = $a->get_from_storage;
4684 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4688 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4691 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4692 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4694 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4696 my $item = $builder->build_sample_item(
4698 biblionumber => $biblionumber,
4699 library => $library->branchcode,
4700 replacementprice => '42',
4703 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4704 LostItem( $item->itemnumber, 'cli', 0 );
4705 $item->_result->itemlost(1);
4706 $item->_result->itemlost_on( $lost_on );
4707 $item->_result->update();
4709 my $a = Koha::Account::Lines->search(
4711 itemnumber => $item->id,
4712 borrowernumber => $patron->borrowernumber
4716 ok( $a, "Found accountline for lost fee" );
4717 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4718 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4719 $a = $a->get_from_storage;
4720 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4725 subtest 'transferbook tests' => sub {
4729 { C4::Circulation::transferbook({}); }
4730 'Koha::Exceptions::MissingParameter',
4731 'Koha::Patron->store raises an exception on missing params';
4734 { C4::Circulation::transferbook({to_branch=>'anything'}); }
4735 'Koha::Exceptions::MissingParameter',
4736 'Koha::Patron->store raises an exception on missing params';
4739 { C4::Circulation::transferbook({from_branch=>'anything'}); }
4740 'Koha::Exceptions::MissingParameter',
4741 'Koha::Patron->store raises an exception on missing params';
4743 my ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here'});
4744 is( $doreturn, 0, "No return without barcode");
4745 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4746 is( $messages->{BadBarcode}, undef, "No barcode passed means undef BadBarcode" );
4748 ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here',barcode=>'BadBarcode'});
4749 is( $doreturn, 0, "No return without barcode");
4750 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4751 is( $messages->{BadBarcode}, 'BadBarcode', "No barcode passed means undef BadBarcode" );
4755 subtest 'Checkout should correctly terminate a transfer' => sub {
4758 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4759 my $patron_1 = $builder->build_object(
4761 class => 'Koha::Patrons',
4762 value => { branchcode => $library_1->branchcode }
4765 my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } );
4766 my $patron_2 = $builder->build_object(
4768 class => 'Koha::Patrons',
4769 value => { branchcode => $library_2->branchcode }
4773 my $item = $builder->build_sample_item(
4775 library => $library_1->branchcode,
4779 t::lib::Mocks::mock_userenv( { branchcode => $library_1->branchcode } );
4780 my $reserve_id = AddReserve(
4782 branchcode => $library_2->branchcode,
4783 borrowernumber => $patron_2->borrowernumber,
4784 biblionumber => $item->biblionumber,
4785 itemnumber => $item->itemnumber,
4790 my $do_transfer = 1;
4791 ModItemTransfer( $item->itemnumber, $library_1->branchcode,
4792 $library_2->branchcode, 'Manual' );
4793 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
4794 GetOtherReserves( $item->itemnumber )
4795 ; # To put the Reason, it's what does returns.pl...
4796 my $hold = Koha::Holds->find($reserve_id);
4797 is( $hold->found, 'T', 'Hold is in transit' );
4798 my $transfer = $item->get_transfer;
4799 is( $transfer->frombranch, $library_1->branchcode );
4800 is( $transfer->tobranch, $library_2->branchcode );
4801 is( $transfer->reason, 'Reserve' );
4803 t::lib::Mocks::mock_userenv( { branchcode => $library_2->branchcode } );
4804 AddIssue( $patron_1->unblessed, $item->barcode );
4805 $transfer = $transfer->get_from_storage;
4806 isnt( $transfer->datearrived, undef );
4807 $hold = $hold->get_from_storage;
4808 is( $hold->found, undef, 'Hold is waiting' );
4809 is( $hold->priority, 1, );
4812 subtest 'AddIssue records staff who checked out item if appropriate' => sub {
4815 $module->mock( 'userenv', sub { { branch => $library->{id} } } );
4817 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4818 my $patron = $builder->build_object(
4820 class => 'Koha::Patrons',
4821 value => { categorycode => $patron_category->{categorycode} }
4824 my $issuer = $builder->build_object(
4826 class => 'Koha::Patrons',
4827 value => { categorycode => $patron_category->{categorycode} }
4830 my $item = $builder->build_sample_item(
4832 library => $library->{branchcode}
4836 $module->mock( 'userenv', sub { { branch => $library->id, number => $issuer->{borrowernumber} } } );
4838 my $dt_from = dt_from_string();
4839 my $dt_to = dt_from_string()->add( days => 7 );
4841 my $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4843 is( $issue->issuer, undef, "Staff who checked out the item not recorded when RecordStaffUserOnCheckout turned off" );
4845 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 1);
4848 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4850 is( $issue->issuer, $issuer->{borrowernumber}, "Staff who checked out the item recorded when RecordStaffUserOnCheckout turned on" );
4853 subtest "Item's onloan value should be set if checked out item is checked out to a different patron" => sub {
4856 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4857 my $patron_1 = $builder->build_object(
4859 class => 'Koha::Patrons',
4860 value => { branchcode => $library_1->branchcode }
4863 my $patron_2 = $builder->build_object(
4865 class => 'Koha::Patrons',
4866 value => { branchcode => $library_1->branchcode }
4870 my $item = $builder->build_sample_item(
4872 library => $library_1->branchcode,
4876 AddIssue( $patron_1->unblessed, $item->barcode );
4877 ok( $item->get_from_storage->onloan, "Item's onloan column is set after initial checkout" );
4878 AddIssue( $patron_2->unblessed, $item->barcode );
4879 ok( $item->get_from_storage->onloan, "Item's onloan column is set after second checkout" );
4882 subtest "updateWrongTransfer tests" => sub {
4885 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
4886 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
4887 my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
4888 my $item = $builder->build_sample_item(
4890 homebranch => $library1->branchcode,
4891 holdingbranch => $library2->branchcode,
4892 datelastseen => undef
4896 my $transfer = $builder->build_object(
4898 class => 'Koha::Item::Transfers',
4900 itemnumber => $item->itemnumber,
4901 frombranch => $library2->branchcode,
4902 tobranch => $library1->branchcode,
4903 daterequested => dt_from_string,
4904 datesent => dt_from_string,
4905 datecancelled => undef,
4906 datearrived => undef,
4911 is( ref($transfer), 'Koha::Item::Transfer', 'Mock transfer added' );
4913 my $new_transfer = C4::Circulation::updateWrongTransfer($item->itemnumber, $library1->branchcode);
4914 is(ref($new_transfer), 'Koha::Item::Transfer', "updateWrongTransfer returns a 'Koha::Item::Transfer' object");
4915 ok( !$new_transfer->in_transit, "New transfer is NOT created as in transit (or cancelled)");
4917 my $original_transfer = $transfer->get_from_storage;
4918 ok( defined($original_transfer->datecancelled), "Original transfer was cancelled");
4919 is( $original_transfer->cancellation_reason, 'WrongTransfer', "Original transfer cancellation reason is 'WrongTransfer'");
4922 subtest "SendCirculationAlert" => sub {
4925 # Setup branch, borrowr, and notice
4926 my $library = $builder->build_object({ class => 'Koha::Libraries' });
4927 set_userenv( $library->unblessed);
4928 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
4929 C4::Members::Messaging::SetMessagingPreference({
4930 borrowernumber => $patron->id,
4931 message_transport_types => ['email'],
4932 message_attribute_id => 5
4934 my $item = $builder->build_sample_item();
4935 my $checkin_notice = $builder->build_object({
4936 class => 'Koha::Notice::Templates',
4938 module => 'circulation',
4940 branchcode => $library->branchcode,
4941 name => 'Test Checkin',
4943 content => "Checkins:\n----\n[% biblio.title %]-[% old_checkout.issue_id %]\n----Thank you.",
4944 message_transport_type => 'email',
4949 # Checkout an item, mark it returned, generate a notice
4950 my $issue_1 = AddIssue( $patron->unblessed, $item->barcode);
4951 MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0, { skip_record_index => 1} );
4952 C4::Circulation::SendCirculationAlert({
4954 item => $item->unblessed,
4955 borrower => $patron->unblessed,
4956 branch => $library->branchcode,
4959 my $notice = Koha::Notice::Messages->find({ borrowernumber => $patron->id, letter_code => 'CHECKIN' });
4960 is($notice->content,"Checkins:\n".$item->biblio->title."-".$issue_1->id."\nThank you.", 'Letter generated with expected output on first checkin' );
4962 # Checkout an item, mark it returned, generate a notice
4963 my $issue_2 = AddIssue( $patron->unblessed, $item->barcode);
4964 MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0, { skip_record_index => 1} );
4965 C4::Circulation::SendCirculationAlert({
4967 item => $item->unblessed,
4968 borrower => $patron->unblessed,
4969 branch => $library->branchcode,
4972 $notice->discard_changes();
4973 is($notice->content,"Checkins:\n".$item->biblio->title."-".$issue_1->id."\n".$item->biblio->title."-".$issue_2->id."\nThank you.", 'Letter appended with expected output on second checkin' );
4977 $schema->storage->txn_rollback;
4978 C4::Context->clear_syspref_cache();
4979 $branches = Koha::Libraries->search();
4980 for my $branch ( $branches->next ) {
4981 my $key = $branch->branchcode . "_holidays";
4982 $cache->clear_from_cache($key);