3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 57;
24 use Test::Deep qw( cmp_deeply );
30 use POSIX qw( floor );
32 use t::lib::TestBuilder;
35 use C4::Calendar qw( new insert_single_holiday insert_week_day_holiday delete_holiday );
36 use C4::Circulation qw( AddIssue AddReturn CanBookBeRenewed GetIssuingCharges AddRenewal GetSoonestRenewDate GetLatestAutoRenewDate LostItem GetUpcomingDueIssues CanBookBeIssued AddIssuingCharge MarkIssueReturned ProcessOfflinePayment transferbook updateWrongTransfer );
38 use C4::Items qw( ModItemTransfer );
40 use C4::Reserves qw( AddReserve ModReserve ModReserveCancelAll ModReserveAffect CheckReserves GetOtherReserves );
41 use C4::Overdues qw( CalcFine UpdateFine get_chargeable_units );
42 use C4::Members::Messaging qw( SetMessagingPreference );
43 use Koha::DateUtils qw( dt_from_string output_pref );
46 use Koha::Item::Transfers;
49 use Koha::Patron::Debarments qw( GetDebarments AddDebarment DelUniqueDebarment );
51 use Koha::CirculationRules;
52 use Koha::Subscriptions;
53 use Koha::Account::Lines;
54 use Koha::Account::Offsets;
56 use Koha::Notice::Messages;
60 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
64 my ( $error, $question, $alert ) = @_;
66 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
67 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
68 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
72 sub test_debarment_on_checkout {
74 my $item = $params->{item};
75 my $library = $params->{library};
76 my $patron = $params->{patron};
77 my $due_date = $params->{due_date} || dt_from_string;
78 my $return_date = $params->{return_date} || dt_from_string;
79 my $expected_expiration_date = $params->{expiration_date};
81 $expected_expiration_date = output_pref(
83 dt => $expected_expiration_date,
89 my $line_number = $caller[2];
90 AddIssue( $patron, $item->barcode, $due_date );
92 my ( undef, $message ) = AddReturn( $item->barcode, $library->{branchcode}, undef, $return_date );
93 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
94 or diag('AddReturn returned message ' . Dumper $message );
95 my $debarments = Koha::Patron::Debarments::GetDebarments(
96 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
97 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
99 is( $debarments->[0]->{expiration},
100 $expected_expiration_date, 'Test at line ' . $line_number );
101 Koha::Patron::Debarments::DelUniqueDebarment(
102 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
105 my $schema = Koha::Database->schema;
106 $schema->storage->txn_begin;
107 my $builder = t::lib::TestBuilder->new;
108 my $dbh = C4::Context->dbh;
110 # Prevent random failures by mocking ->now
111 my $now_value = dt_from_string;
112 my $mocked_datetime = Test::MockModule->new('DateTime');
113 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
115 my $cache = Koha::Caches->get_instance();
116 $dbh->do(q|DELETE FROM special_holidays|);
117 $dbh->do(q|DELETE FROM repeatable_holidays|);
118 my $branches = Koha::Libraries->search();
119 for my $branch ( $branches->next ) {
120 my $key = $branch->branchcode . "_holidays";
121 $cache->clear_from_cache($key);
124 # Start with a clean slate
125 $dbh->do('DELETE FROM issues');
126 $dbh->do('DELETE FROM borrowers');
128 # Disable recording of the staff who checked out an item until we're ready for it
129 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 0);
131 my $module = Test::MockModule->new('C4::Context');
133 my $library = $builder->build({
136 my $library2 = $builder->build({
139 my $itemtype = $builder->build(
141 source => 'Itemtype',
145 rentalcharge_daily => 0,
146 defaultreplacecost => undef,
151 my $patron_category = $builder->build(
153 source => 'Category',
155 category_type => 'P',
157 BlockExpiredPatronOpacActions => -1, # Pick the pref value
162 my $CircControl = C4::Context->preference('CircControl');
163 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
166 homebranch => $library2->{branchcode},
167 holdingbranch => $library2->{branchcode}
171 branchcode => $library2->{branchcode}
174 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
176 # No userenv, PickupLibrary
177 t::lib::Mocks::mock_preference('IndependentBranches', '0');
178 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
180 C4::Context->preference('CircControl'),
182 'CircControl changed to PickupLibrary'
185 C4::Circulation::_GetCircControlBranch($item, $borrower),
186 $item->{$HomeOrHoldingBranch},
187 '_GetCircControlBranch returned item branch (no userenv defined)'
190 # No userenv, PatronLibrary
191 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
193 C4::Context->preference('CircControl'),
195 'CircControl changed to PatronLibrary'
198 C4::Circulation::_GetCircControlBranch($item, $borrower),
199 $borrower->{branchcode},
200 '_GetCircControlBranch returned borrower branch'
203 # No userenv, ItemHomeLibrary
204 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
206 C4::Context->preference('CircControl'),
208 'CircControl changed to ItemHomeLibrary'
211 $item->{$HomeOrHoldingBranch},
212 C4::Circulation::_GetCircControlBranch($item, $borrower),
213 '_GetCircControlBranch returned item branch'
217 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
218 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
220 # Userenv set, PickupLibrary
221 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
223 C4::Context->preference('CircControl'),
225 'CircControl changed to PickupLibrary'
228 C4::Circulation::_GetCircControlBranch($item, $borrower),
229 $library2->{branchcode},
230 '_GetCircControlBranch returned current branch'
233 # Userenv set, PatronLibrary
234 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
236 C4::Context->preference('CircControl'),
238 'CircControl changed to PatronLibrary'
241 C4::Circulation::_GetCircControlBranch($item, $borrower),
242 $borrower->{branchcode},
243 '_GetCircControlBranch returned borrower branch'
246 # Userenv set, ItemHomeLibrary
247 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
249 C4::Context->preference('CircControl'),
251 'CircControl changed to ItemHomeLibrary'
254 C4::Circulation::_GetCircControlBranch($item, $borrower),
255 $item->{$HomeOrHoldingBranch},
256 '_GetCircControlBranch returned item branch'
259 # Reset initial configuration
260 t::lib::Mocks::mock_preference('CircControl', $CircControl);
262 C4::Context->preference('CircControl'),
264 'CircControl reset to its initial value'
267 # Set a simple circ policy
268 $dbh->do('DELETE FROM circulation_rules');
269 Koha::CirculationRules->set_rules(
271 categorycode => undef,
275 reservesallowed => 25,
277 lengthunit => 'days',
278 renewalsallowed => 1,
280 norenewalbefore => undef,
288 subtest "CanBookBeRenewed AllowRenewalIfOtherItemsAvailable multiple borrowers and items tests" => sub {
291 #Can only reserve from home branch
292 Koha::CirculationRules->set_rule(
296 rule_name => 'holdallowed',
300 Koha::CirculationRules->set_rule(
303 categorycode => undef,
305 rule_name => 'onshelfholds',
310 # Patrons from three different branches
311 my $patron_borrower = $builder->build_object({ class => 'Koha::Patrons' });
312 my $patron_hold_1 = $builder->build_object({ class => 'Koha::Patrons' });
313 my $patron_hold_2 = $builder->build_object({ class => 'Koha::Patrons' });
314 my $biblio = $builder->build_sample_biblio();
316 # Item at each patron branch
317 my $item_1 = $builder->build_sample_item({
318 biblionumber => $biblio->biblionumber,
319 homebranch => $patron_borrower->branchcode
321 my $item_2 = $builder->build_sample_item({
322 biblionumber => $biblio->biblionumber,
323 homebranch => $patron_hold_2->branchcode
325 my $item_3 = $builder->build_sample_item({
326 biblionumber => $biblio->biblionumber,
327 homebranch => $patron_hold_1->branchcode
330 my $issue = AddIssue( $patron_borrower->unblessed, $item_1->barcode);
331 my $datedue = dt_from_string( $issue->date_due() );
332 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
337 branchcode => $patron_hold_1->branchcode,
338 borrowernumber => $patron_hold_1->borrowernumber,
339 biblionumber => $biblio->biblionumber,
341 reservation_date => dt_from_string(),
342 expiration_date => undef,
349 branchcode => $patron_hold_2->branchcode,
350 borrowernumber => $patron_hold_2->borrowernumber,
351 biblionumber => $biblio->biblionumber,
353 reservation_date => dt_from_string(),
354 expiration_date => undef,
359 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
361 my ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
362 is( $renewokay, 0, 'Cannot renew, reserved');
363 is( $error, 'on_reserve', 'Cannot renew, reserved (returned error is on_reserve)');
365 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
367 ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
368 is( $renewokay, 1, 'Can renew, two items available for two holds');
369 is( $error, undef, 'Can renew, each reserve has an item');
374 subtest "GetIssuingCharges tests" => sub {
376 my $branch_discount = $builder->build_object({ class => 'Koha::Libraries' });
377 my $branch_no_discount = $builder->build_object({ class => 'Koha::Libraries' });
378 Koha::CirculationRules->set_rule(
380 categorycode => undef,
381 branchcode => $branch_discount->branchcode,
383 rule_name => 'rentaldiscount',
387 my $itype_charge = $builder->build_object({
388 class => 'Koha::ItemTypes',
393 my $itype_no_charge = $builder->build_object({
394 class => 'Koha::ItemTypes',
399 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
400 my $item_1 = $builder->build_sample_item({ itype => $itype_charge->itemtype });
401 my $item_2 = $builder->build_sample_item({ itype => $itype_no_charge->itemtype });
403 t::lib::Mocks::mock_userenv({ branchcode => $branch_no_discount->branchcode });
404 # For now the sub always uses the env branch, this should follow CircControl instead
405 my ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
406 is( $charge + 0, 10.00, "Charge fetched correctly when no discount exists");
407 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
408 is( $charge + 0, 0.00, "Charge fetched correctly when no discount exists and no charge");
410 t::lib::Mocks::mock_userenv({ branchcode => $branch_discount->branchcode });
411 # For now the sub always uses the env branch, this should follow CircControl instead
412 ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
413 is( $charge + 0, 8.50, "Charge fetched correctly when discount exists");
414 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
415 is( $charge + 0, 0.00, "Charge fetched correctly when discount exists and no charge");
419 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
420 subtest "CanBookBeRenewed tests" => sub {
423 C4::Context->set_preference('ItemsDeniedRenewal','');
424 # Generate test biblio
425 my $biblio = $builder->build_sample_biblio();
427 my $branch = $library2->{branchcode};
429 my $item_1 = $builder->build_sample_item(
431 biblionumber => $biblio->biblionumber,
433 replacementprice => 12.00,
437 $reused_itemnumber_1 = $item_1->itemnumber;
439 my $item_2 = $builder->build_sample_item(
441 biblionumber => $biblio->biblionumber,
443 replacementprice => 23.00,
447 $reused_itemnumber_2 = $item_2->itemnumber;
449 my $item_3 = $builder->build_sample_item(
451 biblionumber => $biblio->biblionumber,
453 replacementprice => 23.00,
459 my %renewing_borrower_data = (
461 surname => 'Renewal',
462 categorycode => $patron_category->{categorycode},
463 branchcode => $branch,
466 my %reserving_borrower_data = (
467 firstname => 'Katrin',
468 surname => 'Reservation',
469 categorycode => $patron_category->{categorycode},
470 branchcode => $branch,
473 my %hold_waiting_borrower_data = (
475 surname => 'Reservation',
476 categorycode => $patron_category->{categorycode},
477 branchcode => $branch,
480 my %restricted_borrower_data = (
481 firstname => 'Alice',
482 surname => 'Reservation',
483 categorycode => $patron_category->{categorycode},
484 debarred => '3228-01-01',
485 branchcode => $branch,
488 my %expired_borrower_data = (
491 categorycode => $patron_category->{categorycode},
492 branchcode => $branch,
493 dateexpiry => dt_from_string->subtract( months => 1 ),
496 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
497 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
498 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
499 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
500 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
502 my $renewing_borrower_obj = Koha::Patrons->find( $renewing_borrowernumber );
503 my $renewing_borrower = $renewing_borrower_obj->unblessed;
504 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
505 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
512 my $checkitem = undef;
515 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
516 my $datedue = dt_from_string( $issue->date_due() );
517 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
519 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
520 $datedue = dt_from_string( $issue->date_due() );
521 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
524 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
525 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
527 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
528 is( $renewokay, 1, 'Can renew, no holds for this title or item');
531 # Biblio-level hold, renewal test
534 branchcode => $branch,
535 borrowernumber => $reserving_borrowernumber,
536 biblionumber => $biblio->biblionumber,
537 priority => $priority,
538 reservation_date => $resdate,
539 expiration_date => $expdate,
541 itemnumber => $checkitem,
546 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
547 Koha::CirculationRules->set_rule(
549 categorycode => undef,
552 rule_name => 'onshelfholds',
556 Koha::CirculationRules->set_rule(
558 categorycode => undef,
561 rule_name => 'renewalsallowed',
565 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
566 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
567 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
568 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
569 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
571 # Now let's add an item level hold, we should no longer be able to renew the item
572 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
574 borrowernumber => $hold_waiting_borrowernumber,
575 biblionumber => $biblio->biblionumber,
576 itemnumber => $item_1->itemnumber,
577 branchcode => $branch,
581 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
582 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
585 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
586 # be able to renew these items
587 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
589 borrowernumber => $hold_waiting_borrowernumber,
590 biblionumber => $biblio->biblionumber,
591 itemnumber => $item_3->itemnumber,
592 branchcode => $branch,
597 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
598 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
599 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
600 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
601 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
603 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
604 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
605 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
607 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
608 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
609 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
611 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
612 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
613 AddIssue($reserving_borrower, $item_3->barcode);
614 my $reserve = $dbh->selectrow_hashref(
615 'SELECT * FROM old_reserves WHERE reserve_id = ?',
619 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
621 # Item-level hold, renewal test
624 branchcode => $branch,
625 borrowernumber => $reserving_borrowernumber,
626 biblionumber => $biblio->biblionumber,
627 priority => $priority,
628 reservation_date => $resdate,
629 expiration_date => $expdate,
631 itemnumber => $item_1->itemnumber,
636 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
637 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
638 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
640 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
641 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
643 # Items can't fill hold for reasons
644 $item_1->notforloan(1)->store;
645 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
646 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
647 $item_1->set({notforloan => 0, itype => $itemtype })->store;
649 # FIXME: Add more for itemtype not for loan etc.
651 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
652 my $item_5 = $builder->build_sample_item(
654 biblionumber => $biblio->biblionumber,
656 replacementprice => 23.00,
660 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
661 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
663 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
664 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
665 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
666 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
667 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
668 is( $error, 'restriction', "Correct error returned");
670 # Users cannot renew an overdue item
671 my $item_6 = $builder->build_sample_item(
673 biblionumber => $biblio->biblionumber,
675 replacementprice => 23.00,
680 my $item_7 = $builder->build_sample_item(
682 biblionumber => $biblio->biblionumber,
684 replacementprice => 23.00,
689 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
690 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
692 my $now = dt_from_string();
693 my $five_weeks = DateTime::Duration->new(weeks => 5);
694 my $five_weeks_ago = $now - $five_weeks;
695 t::lib::Mocks::mock_preference('finesMode', 'production');
697 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
698 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
700 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
701 C4::Overdues::UpdateFine(
703 issue_id => $passeddatedue1->id(),
704 itemnumber => $item_7->itemnumber,
705 borrowernumber => $renewing_borrower->{borrowernumber},
707 due => Koha::DateUtils::output_pref($five_weeks_ago)
711 # Make sure fine calculation isn't skipped when adding renewal
712 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
714 t::lib::Mocks::mock_preference('RenewalLog', 0);
715 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
716 my %params_renewal = (
717 timestamp => { -like => $date . "%" },
718 module => "CIRCULATION",
722 timestamp => { -like => $date . "%" },
723 module => "CIRCULATION",
726 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
727 my $dt = dt_from_string();
728 Time::Fake->offset( $dt->epoch );
729 my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
730 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
731 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
732 isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
735 t::lib::Mocks::mock_preference('RenewalLog', 1);
736 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
737 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
738 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
739 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
740 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
742 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
743 is( $fines->count, 2, 'AddRenewal left both fines' );
744 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
745 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
748 t::lib::Mocks::mock_preference('OverduesBlockRenewing','allow');
749 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
750 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
751 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
752 is( $renewokay, 1, '(Bug 8236), Can renew, this item is overdue but not pref does not block');
754 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
755 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
756 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is not overdue but patron has overdues');
757 is( $error, 'overdue', "Correct error returned");
758 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
759 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue so patron has overdues');
760 is( $error, 'overdue', "Correct error returned");
762 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
763 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
764 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
765 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
766 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
767 is( $error, 'overdue', "Correct error returned");
770 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
771 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
772 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
773 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
774 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
775 $new_log_size = Koha::ActionLogs->count( \%params_issue );
776 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
778 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
781 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
785 # Test automatic renewal before value for "norenewalbefore" in policy is set
786 # In this case automatic renewal is not permitted prior to due date
787 my $item_4 = $builder->build_sample_item(
789 biblionumber => $biblio->biblionumber,
791 replacementprice => 16.00,
796 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
797 ( $renewokay, $error ) =
798 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
799 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
800 is( $error, 'auto_too_soon',
801 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
804 branchcode => $branch,
805 borrowernumber => $reserving_borrowernumber,
806 biblionumber => $biblio->biblionumber,
807 itemnumber => $bibitems,
808 priority => $priority,
809 reservation_date => $resdate,
810 expiration_date => $expdate,
813 itemnumber => $item_4->itemnumber,
817 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
818 is( $renewokay, 0, 'Still should not be able to renew' );
819 is( $error, 'on_reserve', 'returned code is on_reserve, reserve checked when not checking for cron' );
820 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, undef, 1 );
821 is( $renewokay, 0, 'Still should not be able to renew' );
822 is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked when checking for cron' );
823 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
824 is( $renewokay, 0, 'Still should not be able to renew' );
825 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
826 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1, 1 );
827 is( $renewokay, 0, 'Still should not be able to renew' );
828 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
829 $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
830 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
831 is( $renewokay, 0, 'Still should not be able to renew' );
832 is( $error, 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
833 ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);
837 $renewing_borrower_obj->autorenew_checkouts(0)->store;
838 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
839 is( $renewokay, 1, 'No renewal before is undef, but patron opted out of auto_renewal' );
840 $renewing_borrower_obj->autorenew_checkouts(1)->store;
844 # Test premature manual renewal
845 Koha::CirculationRules->set_rule(
847 categorycode => undef,
850 rule_name => 'norenewalbefore',
855 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
856 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
857 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
860 # Test premature automatic renewal
861 ( $renewokay, $error ) =
862 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
863 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
864 is( $error, 'auto_too_soon',
865 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
868 $renewing_borrower_obj->autorenew_checkouts(0)->store;
869 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
870 is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
871 is( $error, 'too_soon', 'Error is too_soon, no auto' );
872 $renewing_borrower_obj->autorenew_checkouts(1)->store;
874 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
875 # and test automatic renewal again
876 $dbh->do(q{UPDATE circulation_rules SET rule_value = '0' WHERE rule_name = 'norenewalbefore'});
877 ( $renewokay, $error ) =
878 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
879 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
880 is( $error, 'auto_too_soon',
881 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
884 $renewing_borrower_obj->autorenew_checkouts(0)->store;
885 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
886 is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
887 is( $error, 'too_soon', 'Error is too_soon, no auto' );
888 $renewing_borrower_obj->autorenew_checkouts(1)->store;
890 # Change policy so that loans can be renewed 99 days prior to the due date
891 # and test automatic renewal again
892 $dbh->do(q{UPDATE circulation_rules SET rule_value = '99' WHERE rule_name = 'norenewalbefore'});
893 ( $renewokay, $error ) =
894 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
895 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
896 is( $error, 'auto_renew',
897 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
900 $renewing_borrower_obj->autorenew_checkouts(0)->store;
901 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
902 is( $renewokay, 1, 'No renewal before is 99, patron opted out of auto_renewal so can renew' );
903 $renewing_borrower_obj->autorenew_checkouts(1)->store;
905 subtest "too_late_renewal / no_auto_renewal_after" => sub {
907 my $item_to_auto_renew = $builder->build_sample_item(
909 biblionumber => $biblio->biblionumber,
914 my $ten_days_before = dt_from_string->add( days => -10 );
915 my $ten_days_ahead = dt_from_string->add( days => 10 );
916 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
918 Koha::CirculationRules->set_rules(
920 categorycode => undef,
924 norenewalbefore => '7',
925 no_auto_renewal_after => '9',
929 ( $renewokay, $error ) =
930 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
931 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
932 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
934 Koha::CirculationRules->set_rules(
936 categorycode => undef,
940 norenewalbefore => '7',
941 no_auto_renewal_after => '10',
945 ( $renewokay, $error ) =
946 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
947 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
948 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
950 Koha::CirculationRules->set_rules(
952 categorycode => undef,
956 norenewalbefore => '7',
957 no_auto_renewal_after => '11',
961 ( $renewokay, $error ) =
962 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
963 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
964 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
966 Koha::CirculationRules->set_rules(
968 categorycode => undef,
972 norenewalbefore => '10',
973 no_auto_renewal_after => '11',
977 ( $renewokay, $error ) =
978 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
979 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
980 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
982 Koha::CirculationRules->set_rules(
984 categorycode => undef,
988 norenewalbefore => '10',
989 no_auto_renewal_after => undef,
990 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
994 ( $renewokay, $error ) =
995 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
996 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
997 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
999 Koha::CirculationRules->set_rules(
1001 categorycode => undef,
1002 branchcode => undef,
1005 norenewalbefore => '7',
1006 no_auto_renewal_after => '15',
1007 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
1011 ( $renewokay, $error ) =
1012 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1013 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1014 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
1016 Koha::CirculationRules->set_rules(
1018 categorycode => undef,
1019 branchcode => undef,
1022 norenewalbefore => '10',
1023 no_auto_renewal_after => undef,
1024 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 1 ),
1028 ( $renewokay, $error ) =
1029 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1030 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1031 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
1034 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
1036 my $item_to_auto_renew = $builder->build_sample_item(
1038 biblionumber => $biblio->biblionumber,
1043 my $ten_days_before = dt_from_string->add( days => -10 );
1044 my $ten_days_ahead = dt_from_string->add( days => 10 );
1045 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1047 Koha::CirculationRules->set_rules(
1049 categorycode => undef,
1050 branchcode => undef,
1053 norenewalbefore => '10',
1054 no_auto_renewal_after => '11',
1058 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
1059 C4::Context->set_preference('OPACFineNoRenewals','10');
1060 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1061 my $fines_amount = 5;
1062 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
1063 $account->add_debit(
1065 amount => $fines_amount,
1066 interface => 'test',
1068 item_id => $item_to_auto_renew->itemnumber,
1069 description => "Some fines"
1071 )->status('RETURNED')->store;
1072 ( $renewokay, $error ) =
1073 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1074 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1075 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
1077 $account->add_debit(
1079 amount => $fines_amount,
1080 interface => 'test',
1082 item_id => $item_to_auto_renew->itemnumber,
1083 description => "Some fines"
1085 )->status('RETURNED')->store;
1086 ( $renewokay, $error ) =
1087 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1088 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1089 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
1091 $account->add_debit(
1093 amount => $fines_amount,
1094 interface => 'test',
1096 item_id => $item_to_auto_renew->itemnumber,
1097 description => "Some fines"
1099 )->status('RETURNED')->store;
1100 ( $renewokay, $error ) =
1101 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1102 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1103 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
1105 $account->add_credit(
1107 amount => $fines_amount,
1108 interface => 'test',
1110 description => "Some payment"
1113 ( $renewokay, $error ) =
1114 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1115 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1116 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1118 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
1119 ( $renewokay, $error ) =
1120 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1121 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1122 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1124 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
1125 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1128 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
1130 my $item_to_auto_renew = $builder->build_sample_item(
1132 biblionumber => $biblio->biblionumber,
1137 Koha::CirculationRules->set_rules(
1139 categorycode => undef,
1140 branchcode => undef,
1143 norenewalbefore => 10,
1144 no_auto_renewal_after => 11,
1149 my $ten_days_before = dt_from_string->add( days => -10 );
1150 my $ten_days_ahead = dt_from_string->add( days => 10 );
1152 # Patron is expired and BlockExpiredPatronOpacActions=0
1153 # => auto renew is allowed
1154 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
1155 my $patron = $expired_borrower;
1156 my $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1157 ( $renewokay, $error ) =
1158 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1159 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1160 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
1161 Koha::Checkouts->find( $checkout->issue_id )->delete;
1164 # Patron is expired and BlockExpiredPatronOpacActions=1
1165 # => auto renew is not allowed
1166 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1167 $patron = $expired_borrower;
1168 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1169 ( $renewokay, $error ) =
1170 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1171 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1172 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
1173 Koha::Checkouts->find( $checkout->issue_id )->delete;
1176 # Patron is not expired and BlockExpiredPatronOpacActions=1
1177 # => auto renew is allowed
1178 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1179 $patron = $renewing_borrower;
1180 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1181 ( $renewokay, $error ) =
1182 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1183 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1184 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
1185 Koha::Checkouts->find( $checkout->issue_id )->delete;
1188 subtest "GetLatestAutoRenewDate" => sub {
1190 my $item_to_auto_renew = $builder->build_sample_item(
1192 biblionumber => $biblio->biblionumber,
1197 my $ten_days_before = dt_from_string->add( days => -10 );
1198 my $ten_days_ahead = dt_from_string->add( days => 10 );
1199 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1200 Koha::CirculationRules->set_rules(
1202 categorycode => undef,
1203 branchcode => undef,
1206 norenewalbefore => '7',
1207 no_auto_renewal_after => '',
1208 no_auto_renewal_after_hard_limit => undef,
1212 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1213 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
1214 my $five_days_before = dt_from_string->add( days => -5 );
1215 Koha::CirculationRules->set_rules(
1217 categorycode => undef,
1218 branchcode => undef,
1221 norenewalbefore => '10',
1222 no_auto_renewal_after => '5',
1223 no_auto_renewal_after_hard_limit => undef,
1227 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1228 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1229 $five_days_before->truncate( to => 'minute' ),
1230 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
1232 my $five_days_ahead = dt_from_string->add( days => 5 );
1233 $dbh->do(q{UPDATE circulation_rules SET rule_value = '10' WHERE rule_name = 'norenewalbefore'});
1234 $dbh->do(q{UPDATE circulation_rules SET rule_value = '15' WHERE rule_name = 'no_auto_renewal_after'});
1235 $dbh->do(q{UPDATE circulation_rules SET rule_value = NULL WHERE rule_name = 'no_auto_renewal_after_hard_limit'});
1236 Koha::CirculationRules->set_rules(
1238 categorycode => undef,
1239 branchcode => undef,
1242 norenewalbefore => '10',
1243 no_auto_renewal_after => '15',
1244 no_auto_renewal_after_hard_limit => undef,
1248 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1249 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1250 $five_days_ahead->truncate( to => 'minute' ),
1251 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
1253 my $two_days_ahead = dt_from_string->add( days => 2 );
1254 Koha::CirculationRules->set_rules(
1256 categorycode => undef,
1257 branchcode => undef,
1260 norenewalbefore => '10',
1261 no_auto_renewal_after => '',
1262 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1266 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1267 is( $latest_auto_renew_date->truncate( to => 'day' ),
1268 $two_days_ahead->truncate( to => 'day' ),
1269 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
1271 Koha::CirculationRules->set_rules(
1273 categorycode => undef,
1274 branchcode => undef,
1277 norenewalbefore => '10',
1278 no_auto_renewal_after => '15',
1279 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1283 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1284 is( $latest_auto_renew_date->truncate( to => 'day' ),
1285 $two_days_ahead->truncate( to => 'day' ),
1286 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
1292 # set policy to forbid renewals
1293 Koha::CirculationRules->set_rules(
1295 categorycode => undef,
1296 branchcode => undef,
1299 norenewalbefore => undef,
1300 renewalsallowed => 0,
1305 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1306 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1307 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1309 # Too many unseen renewals
1310 Koha::CirculationRules->set_rules(
1312 categorycode => undef,
1313 branchcode => undef,
1316 unseen_renewals_allowed => 2,
1317 renewalsallowed => 10,
1321 t::lib::Mocks::mock_preference('UnseenRenewals', 1);
1322 $dbh->do('UPDATE issues SET unseen_renewals = 2 where borrowernumber = ? AND itemnumber = ?', undef, ($renewing_borrowernumber, $item_1->itemnumber));
1323 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1324 is( $renewokay, 0, 'Cannot renew, 0 unseen renewals allowed');
1325 is( $error, 'too_unseen', 'Cannot renew, returned code is too_unseen');
1326 Koha::CirculationRules->set_rules(
1328 categorycode => undef,
1329 branchcode => undef,
1332 norenewalbefore => undef,
1333 renewalsallowed => 0,
1337 t::lib::Mocks::mock_preference('UnseenRenewals', 0);
1339 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1340 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1341 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1343 C4::Overdues::UpdateFine(
1345 issue_id => $issue->id(),
1346 itemnumber => $item_1->itemnumber,
1347 borrowernumber => $renewing_borrower->{borrowernumber},
1350 due => Koha::DateUtils::output_pref($datedue)
1354 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
1355 is( $line->debit_type_code, 'OVERDUE', 'Account line type is OVERDUE' );
1356 is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
1357 is( $line->amountoutstanding+0, 15, 'Account line amount outstanding is 15.00' );
1358 is( $line->amount+0, 15, 'Account line amount is 15.00' );
1359 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
1361 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
1362 is( $offset->type, 'CREATE', 'Account offset type is CREATE' );
1363 is( $offset->amount+0, 15, 'Account offset amount is 15.00' );
1365 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
1366 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
1368 LostItem( $item_1->itemnumber, 'test', 1 );
1370 $line = Koha::Account::Lines->find($line->id);
1371 is( $line->debit_type_code, 'OVERDUE', 'Account type remains as OVERDUE' );
1372 isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
1374 my $item = Koha::Items->find($item_1->itemnumber);
1375 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
1376 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
1377 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
1379 my $total_due = $dbh->selectrow_array(
1380 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1381 undef, $renewing_borrower->{borrowernumber}
1384 is( $total_due+0, 15, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
1386 C4::Context->dbh->do("DELETE FROM accountlines");
1388 C4::Overdues::UpdateFine(
1390 issue_id => $issue2->id(),
1391 itemnumber => $item_2->itemnumber,
1392 borrowernumber => $renewing_borrower->{borrowernumber},
1395 due => Koha::DateUtils::output_pref($datedue)
1399 LostItem( $item_2->itemnumber, 'test', 0 );
1401 my $item2 = Koha::Items->find($item_2->itemnumber);
1402 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
1403 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
1405 $total_due = $dbh->selectrow_array(
1406 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1407 undef, $renewing_borrower->{borrowernumber}
1410 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
1412 my $future = dt_from_string();
1413 $future->add( days => 7 );
1414 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
1415 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
1417 my $manager = $builder->build_object({ class => "Koha::Patrons" });
1418 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
1419 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1420 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
1421 LostItem( $item_3->itemnumber, 'test', 0 );
1422 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
1423 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
1425 $accountline->description,
1426 sprintf( "%s %s %s",
1427 $item_3->biblio->title || '',
1428 $item_3->barcode || '',
1429 $item_3->itemcallnumber || '' ),
1430 "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
1434 subtest "GetUpcomingDueIssues" => sub {
1437 my $branch = $library2->{branchcode};
1439 #Create another record
1440 my $biblio2 = $builder->build_sample_biblio();
1443 my $item_1 = Koha::Items->find($reused_itemnumber_1);
1444 my $item_2 = Koha::Items->find($reused_itemnumber_2);
1445 my $item_3 = $builder->build_sample_item(
1447 biblionumber => $biblio2->biblionumber,
1455 my %a_borrower_data = (
1456 firstname => 'Fridolyn',
1457 surname => 'SOMERS',
1458 categorycode => $patron_category->{categorycode},
1459 branchcode => $branch,
1462 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1463 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1465 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1466 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1467 my $today = DateTime->today(time_zone => C4::Context->tz());
1469 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1470 my $datedue = dt_from_string( $issue->date_due() );
1471 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1472 my $datedue2 = dt_from_string( $issue->date_due() );
1476 # GetUpcomingDueIssues tests
1478 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1479 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1482 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1483 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1484 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1487 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1488 is ( scalar( @$upcoming_dues ), 1,
1489 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1492 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1494 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1496 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1497 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1499 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1500 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1502 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1503 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1505 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1506 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1508 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1509 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1511 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1512 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1516 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1517 my $branch = $library2->{branchcode};
1519 my $biblio = $builder->build_sample_biblio();
1522 my $item = $builder->build_sample_item(
1524 biblionumber => $biblio->biblionumber,
1531 my %a_borrower_data = (
1532 firstname => 'Kyle',
1534 categorycode => $patron_category->{categorycode},
1535 branchcode => $branch,
1538 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1540 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1541 my $issue = AddIssue( $borrower, $item->barcode );
1544 issue_id => $issue->id(),
1545 itemnumber => $item->itemnumber,
1546 borrowernumber => $borrowernumber,
1552 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1553 my $count = $hr->{count};
1555 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1558 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1559 $dbh->do('DELETE FROM issues');
1560 $dbh->do('DELETE FROM items');
1561 $dbh->do('DELETE FROM circulation_rules');
1562 Koha::CirculationRules->set_rules(
1564 categorycode => undef,
1566 branchcode => undef,
1568 reservesallowed => 25,
1570 lengthunit => 'days',
1571 renewalsallowed => 1,
1573 norenewalbefore => undef,
1581 my $biblio = $builder->build_sample_biblio();
1583 my $item_1 = $builder->build_sample_item(
1585 biblionumber => $biblio->biblionumber,
1586 library => $library2->{branchcode},
1591 my $item_2= $builder->build_sample_item(
1593 biblionumber => $biblio->biblionumber,
1594 library => $library2->{branchcode},
1599 my $borrowernumber1 = Koha::Patron->new({
1600 firstname => 'Kyle',
1602 categorycode => $patron_category->{categorycode},
1603 branchcode => $library2->{branchcode},
1604 })->store->borrowernumber;
1605 my $borrowernumber2 = Koha::Patron->new({
1606 firstname => 'Chelsea',
1608 categorycode => $patron_category->{categorycode},
1609 branchcode => $library2->{branchcode},
1610 })->store->borrowernumber;
1612 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1613 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1615 my $issue = AddIssue( $borrower1, $item_1->barcode );
1617 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1618 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1622 branchcode => $library2->{branchcode},
1623 borrowernumber => $borrowernumber2,
1624 biblionumber => $biblio->biblionumber,
1629 Koha::CirculationRules->set_rules(
1631 categorycode => undef,
1633 branchcode => undef,
1639 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1640 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1641 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1643 Koha::CirculationRules->set_rules(
1645 categorycode => undef,
1647 branchcode => undef,
1653 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1654 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1655 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1657 Koha::CirculationRules->set_rules(
1659 categorycode => undef,
1661 branchcode => undef,
1667 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1668 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1669 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1671 Koha::CirculationRules->set_rules(
1673 categorycode => undef,
1675 branchcode => undef,
1681 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1682 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1683 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1685 # Setting item not checked out to be not for loan but holdable
1686 $item_2->notforloan(-1)->store;
1688 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1689 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1693 # Don't allow renewing onsite checkout
1694 my $branch = $library->{branchcode};
1696 #Create another record
1697 my $biblio = $builder->build_sample_biblio();
1699 my $item = $builder->build_sample_item(
1701 biblionumber => $biblio->biblionumber,
1707 my $borrowernumber = Koha::Patron->new({
1710 categorycode => $patron_category->{categorycode},
1711 branchcode => $branch,
1712 })->store->borrowernumber;
1714 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1716 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1717 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1718 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1719 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1723 my $library = $builder->build({ source => 'Branch' });
1725 my $biblio = $builder->build_sample_biblio();
1727 my $item = $builder->build_sample_item(
1729 biblionumber => $biblio->biblionumber,
1730 library => $library->{branchcode},
1735 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1737 my $issue = AddIssue( $patron, $item->barcode );
1740 issue_id => $issue->id(),
1741 itemnumber => $item->itemnumber,
1742 borrowernumber => $patron->{borrowernumber},
1749 issue_id => $issue->id(),
1750 itemnumber => $item->itemnumber,
1751 borrowernumber => $patron->{borrowernumber},
1756 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1759 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1762 my $homebranch = $builder->build( { source => 'Branch' } );
1763 my $holdingbranch = $builder->build( { source => 'Branch' } );
1764 my $otherbranch = $builder->build( { source => 'Branch' } );
1765 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1766 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1768 my $item = $builder->build_sample_item(
1770 homebranch => $homebranch->{branchcode},
1771 holdingbranch => $holdingbranch->{branchcode},
1775 set_userenv($holdingbranch);
1777 my $issue = AddIssue( $patron_1->unblessed, $item->barcode );
1778 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1780 my ( $error, $question, $alerts );
1782 # AllowReturnToBranch == anywhere
1783 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1784 ## Test that unknown barcodes don't generate internal server errors
1785 set_userenv($homebranch);
1786 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1787 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1788 ## Can be issued from homebranch
1789 set_userenv($homebranch);
1790 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1791 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1792 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1793 ## Can be issued from holdingbranch
1794 set_userenv($holdingbranch);
1795 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1796 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1797 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1798 ## Can be issued from another branch
1799 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1800 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1801 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1803 # AllowReturnToBranch == holdingbranch
1804 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1805 ## Cannot be issued from homebranch
1806 set_userenv($homebranch);
1807 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1808 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1809 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1810 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1811 ## Can be issued from holdinbranch
1812 set_userenv($holdingbranch);
1813 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1814 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1815 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1816 ## Cannot be issued from another branch
1817 set_userenv($otherbranch);
1818 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1819 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1820 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1821 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1823 # AllowReturnToBranch == homebranch
1824 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1825 ## Can be issued from holdinbranch
1826 set_userenv($homebranch);
1827 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1828 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1829 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1830 ## Cannot be issued from holdinbranch
1831 set_userenv($holdingbranch);
1832 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1833 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1834 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1835 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1836 ## Cannot be issued from holdinbranch
1837 set_userenv($otherbranch);
1838 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1839 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1840 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1841 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1843 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1846 subtest 'AddIssue & AllowReturnToBranch' => sub {
1849 my $homebranch = $builder->build( { source => 'Branch' } );
1850 my $holdingbranch = $builder->build( { source => 'Branch' } );
1851 my $otherbranch = $builder->build( { source => 'Branch' } );
1852 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1853 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1855 my $item = $builder->build_sample_item(
1857 homebranch => $homebranch->{branchcode},
1858 holdingbranch => $holdingbranch->{branchcode},
1862 set_userenv($holdingbranch);
1864 my $ref_issue = 'Koha::Checkout';
1865 my $issue = AddIssue( $patron_1, $item->barcode );
1867 my ( $error, $question, $alerts );
1869 # AllowReturnToBranch == homebranch
1870 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1871 ## Can be issued from homebranch
1872 set_userenv($homebranch);
1873 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1874 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1875 ## Can be issued from holdinbranch
1876 set_userenv($holdingbranch);
1877 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1878 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1879 ## Can be issued from another branch
1880 set_userenv($otherbranch);
1881 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1882 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1884 # AllowReturnToBranch == holdinbranch
1885 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1886 ## Cannot be issued from homebranch
1887 set_userenv($homebranch);
1888 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1889 ## Can be issued from holdingbranch
1890 set_userenv($holdingbranch);
1891 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1892 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1893 ## Cannot be issued from another branch
1894 set_userenv($otherbranch);
1895 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1897 # AllowReturnToBranch == homebranch
1898 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1899 ## Can be issued from homebranch
1900 set_userenv($homebranch);
1901 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1902 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1903 ## Cannot be issued from holdinbranch
1904 set_userenv($holdingbranch);
1905 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1906 ## Cannot be issued from another branch
1907 set_userenv($otherbranch);
1908 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1909 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1912 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1915 my $library = $builder->build( { source => 'Branch' } );
1916 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1917 my $item_1 = $builder->build_sample_item(
1919 library => $library->{branchcode},
1922 my $item_2 = $builder->build_sample_item(
1924 library => $library->{branchcode},
1928 my ( $error, $question, $alerts );
1930 # Patron cannot issue item_1, they have overdues
1931 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1932 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, $yesterday ); # Add an overdue
1934 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1935 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1936 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1937 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1939 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1940 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1941 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1942 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1944 # Patron cannot issue item_1, they are debarred
1945 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1946 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1947 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1948 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1949 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1951 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1952 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1953 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1954 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1957 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1960 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1961 my $patron_category_x = $builder->build_object(
1963 class => 'Koha::Patron::Categories',
1964 value => { category_type => 'X' }
1967 my $patron = $builder->build_object(
1969 class => 'Koha::Patrons',
1971 categorycode => $patron_category_x->categorycode,
1972 gonenoaddress => undef,
1979 my $item_1 = $builder->build_sample_item(
1981 library => $library->{branchcode},
1985 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->barcode );
1986 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1988 # TODO There are other tests to provide here
1991 subtest 'MultipleReserves' => sub {
1994 my $biblio = $builder->build_sample_biblio();
1996 my $branch = $library2->{branchcode};
1998 my $item_1 = $builder->build_sample_item(
2000 biblionumber => $biblio->biblionumber,
2002 replacementprice => 12.00,
2007 my $item_2 = $builder->build_sample_item(
2009 biblionumber => $biblio->biblionumber,
2011 replacementprice => 12.00,
2018 my $resdate = undef;
2019 my $expdate = undef;
2021 my $checkitem = undef;
2024 my %renewing_borrower_data = (
2025 firstname => 'John',
2026 surname => 'Renewal',
2027 categorycode => $patron_category->{categorycode},
2028 branchcode => $branch,
2030 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
2031 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
2032 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
2033 my $datedue = dt_from_string( $issue->date_due() );
2034 is (defined $issue->date_due(), 1, "item 1 checked out");
2035 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
2037 my %reserving_borrower_data1 = (
2038 firstname => 'Katrin',
2039 surname => 'Reservation',
2040 categorycode => $patron_category->{categorycode},
2041 branchcode => $branch,
2043 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
2046 branchcode => $branch,
2047 borrowernumber => $reserving_borrowernumber1,
2048 biblionumber => $biblio->biblionumber,
2049 priority => $priority,
2050 reservation_date => $resdate,
2051 expiration_date => $expdate,
2053 itemnumber => $checkitem,
2058 my %reserving_borrower_data2 = (
2059 firstname => 'Kirk',
2060 surname => 'Reservation',
2061 categorycode => $patron_category->{categorycode},
2062 branchcode => $branch,
2064 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
2067 branchcode => $branch,
2068 borrowernumber => $reserving_borrowernumber2,
2069 biblionumber => $biblio->biblionumber,
2070 priority => $priority,
2071 reservation_date => $resdate,
2072 expiration_date => $expdate,
2074 itemnumber => $checkitem,
2080 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2081 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
2084 my $item_3 = $builder->build_sample_item(
2086 biblionumber => $biblio->biblionumber,
2088 replacementprice => 12.00,
2094 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2095 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
2099 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
2102 my $library = $builder->build( { source => 'Branch' } );
2103 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2105 my $biblionumber = $builder->build_sample_biblio(
2107 branchcode => $library->{branchcode},
2110 my $item_1 = $builder->build_sample_item(
2112 biblionumber => $biblionumber,
2113 library => $library->{branchcode},
2117 my $item_2 = $builder->build_sample_item(
2119 biblionumber => $biblionumber,
2120 library => $library->{branchcode},
2124 my ( $error, $question, $alerts );
2125 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, dt_from_string->add( days => 1 ) );
2127 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2128 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2130 { error => $error, alerts => $alerts },
2131 { error => {}, alerts => {} },
2132 'No error or alert should be raised'
2134 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
2136 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2137 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2139 { error => $error, question => $question, alerts => $alerts },
2140 { error => {}, question => {}, alerts => {} },
2141 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1'
2144 # Add a subscription
2145 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
2147 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2148 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2150 { error => $error, question => $question, alerts => $alerts },
2151 { error => {}, question => {}, alerts => {} },
2152 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2155 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2156 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2158 { error => $error, question => $question, alerts => $alerts },
2159 { error => {}, question => {}, alerts => {} },
2160 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2164 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
2167 my $library = $builder->build( { source => 'Branch' } );
2168 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2171 my $biblionumber = $builder->build_sample_biblio(
2173 branchcode => $library->{branchcode},
2176 my $item_1 = $builder->build_sample_item(
2178 biblionumber => $biblionumber,
2179 library => $library->{branchcode},
2182 my $item_2 = $builder->build_sample_item(
2184 biblionumber => $biblionumber,
2185 library => $library->{branchcode},
2189 # And the circulation rule
2190 Koha::CirculationRules->search->delete;
2191 Koha::CirculationRules->set_rules(
2193 categorycode => undef,
2195 branchcode => undef,
2198 firstremind => 1, # 1 day of grace
2199 finedays => 2, # 2 days of fine per day of overdue
2200 lengthunit => 'days',
2205 # Patron cannot issue item_1, they have overdues
2206 my $now = dt_from_string;
2207 my $five_days_ago = $now->clone->subtract( days => 5 );
2208 my $ten_days_ago = $now->clone->subtract( days => 10 );
2209 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2210 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2211 ; # Add another overdue
2213 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
2214 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2215 my $debarments = Koha::Patron::Debarments::GetDebarments(
2216 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2217 is( scalar(@$debarments), 1 );
2219 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
2220 # Same for the others
2221 my $expected_expiration = output_pref(
2223 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2224 dateformat => 'sql',
2228 is( $debarments->[0]->{expiration}, $expected_expiration );
2230 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2231 $debarments = Koha::Patron::Debarments::GetDebarments(
2232 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2233 is( scalar(@$debarments), 1 );
2234 $expected_expiration = output_pref(
2236 dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),
2237 dateformat => 'sql',
2241 is( $debarments->[0]->{expiration}, $expected_expiration );
2243 Koha::Patron::Debarments::DelUniqueDebarment(
2244 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2246 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
2247 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2248 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2249 ; # Add another overdue
2250 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2251 $debarments = Koha::Patron::Debarments::GetDebarments(
2252 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2253 is( scalar(@$debarments), 1 );
2254 $expected_expiration = output_pref(
2256 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2257 dateformat => 'sql',
2261 is( $debarments->[0]->{expiration}, $expected_expiration );
2263 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2264 $debarments = Koha::Patron::Debarments::GetDebarments(
2265 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2266 is( scalar(@$debarments), 1 );
2267 $expected_expiration = output_pref(
2269 dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
2270 dateformat => 'sql',
2274 is( $debarments->[0]->{expiration}, $expected_expiration );
2277 subtest 'AddReturn + suspension_chargeperiod' => sub {
2280 my $library = $builder->build( { source => 'Branch' } );
2281 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2283 my $biblionumber = $builder->build_sample_biblio(
2285 branchcode => $library->{branchcode},
2288 my $item_1 = $builder->build_sample_item(
2290 biblionumber => $biblionumber,
2291 library => $library->{branchcode},
2295 # And the issuing rule
2296 Koha::CirculationRules->search->delete;
2297 Koha::CirculationRules->set_rules(
2299 categorycode => '*',
2304 firstremind => 0, # 0 day of grace
2305 finedays => 2, # 2 days of fine per day of overdue
2306 suspension_chargeperiod => 1,
2307 lengthunit => 'days',
2312 my $now = dt_from_string;
2313 my $five_days_ago = $now->clone->subtract( days => 5 );
2314 # We want to charge 2 days every day, without grace
2315 # With 5 days of overdue: 5 * Z
2316 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2317 test_debarment_on_checkout(
2320 library => $library,
2322 due_date => $five_days_ago,
2323 expiration_date => $expected_expiration,
2327 # Same with undef firstremind
2328 Koha::CirculationRules->search->delete;
2329 Koha::CirculationRules->set_rules(
2331 categorycode => '*',
2336 firstremind => undef, # 0 day of grace
2337 finedays => 2, # 2 days of fine per day of overdue
2338 suspension_chargeperiod => 1,
2339 lengthunit => 'days',
2344 my $now = dt_from_string;
2345 my $five_days_ago = $now->clone->subtract( days => 5 );
2346 # We want to charge 2 days every day, without grace
2347 # With 5 days of overdue: 5 * Z
2348 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2349 test_debarment_on_checkout(
2352 library => $library,
2354 due_date => $five_days_ago,
2355 expiration_date => $expected_expiration,
2359 # We want to charge 2 days every 2 days, without grace
2360 # With 5 days of overdue: (5 * 2) / 2
2361 Koha::CirculationRules->set_rule(
2363 categorycode => undef,
2364 branchcode => undef,
2366 rule_name => 'suspension_chargeperiod',
2371 $expected_expiration = $now->clone->add( days => floor( 5 * 2 ) / 2 );
2372 test_debarment_on_checkout(
2375 library => $library,
2377 due_date => $five_days_ago,
2378 expiration_date => $expected_expiration,
2382 # We want to charge 2 days every 3 days, with 1 day of grace
2383 # With 5 days of overdue: ((5-1) / 3 ) * 2
2384 Koha::CirculationRules->set_rules(
2386 categorycode => undef,
2387 branchcode => undef,
2390 suspension_chargeperiod => 3,
2395 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
2396 test_debarment_on_checkout(
2399 library => $library,
2401 due_date => $five_days_ago,
2402 expiration_date => $expected_expiration,
2406 # Use finesCalendar to know if holiday must be skipped to calculate the due date
2407 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
2408 Koha::CirculationRules->set_rules(
2410 categorycode => undef,
2411 branchcode => undef,
2415 suspension_chargeperiod => 1,
2420 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
2421 t::lib::Mocks::mock_preference('SuspensionsCalendar', 'noSuspensionsWhenClosed');
2423 # Adding a holiday 2 days ago
2424 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
2425 my $two_days_ago = $now->clone->subtract( days => 2 );
2426 $calendar->insert_single_holiday(
2427 day => $two_days_ago->day,
2428 month => $two_days_ago->month,
2429 year => $two_days_ago->year,
2430 title => 'holidayTest-2d',
2431 description => 'holidayDesc 2 days ago'
2433 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
2434 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
2435 test_debarment_on_checkout(
2438 library => $library,
2440 due_date => $five_days_ago,
2441 expiration_date => $expected_expiration,
2445 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
2446 my $two_days_ahead = $now->clone->add( days => 2 );
2447 $calendar->insert_single_holiday(
2448 day => $two_days_ahead->day,
2449 month => $two_days_ahead->month,
2450 year => $two_days_ahead->year,
2451 title => 'holidayTest+2d',
2452 description => 'holidayDesc 2 days ahead'
2455 # Same as above, but we should skip D+2
2456 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
2457 test_debarment_on_checkout(
2460 library => $library,
2462 due_date => $five_days_ago,
2463 expiration_date => $expected_expiration,
2467 # Adding another holiday, day of expiration date
2468 my $expected_expiration_dt = dt_from_string($expected_expiration);
2469 $calendar->insert_single_holiday(
2470 day => $expected_expiration_dt->day,
2471 month => $expected_expiration_dt->month,
2472 year => $expected_expiration_dt->year,
2473 title => 'holidayTest_exp',
2474 description => 'holidayDesc on expiration date'
2476 # Expiration date will be the day after
2477 test_debarment_on_checkout(
2480 library => $library,
2482 due_date => $five_days_ago,
2483 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
2487 test_debarment_on_checkout(
2490 library => $library,
2492 return_date => $now->clone->add(days => 5),
2493 expiration_date => $now->clone->add(days => 5 + (5 * 2 - 1) ),
2497 test_debarment_on_checkout(
2500 library => $library,
2502 due_date => $now->clone->add(days => 1),
2503 return_date => $now->clone->add(days => 5),
2504 expiration_date => $now->clone->add(days => 5 + (4 * 2 - 1) ),
2510 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
2513 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2514 my $patron1 = $builder->build_object(
2516 class => 'Koha::Patrons',
2518 library => $library->branchcode,
2519 categorycode => $patron_category->{categorycode}
2523 my $patron2 = $builder->build_object(
2525 class => 'Koha::Patrons',
2527 library => $library->branchcode,
2528 categorycode => $patron_category->{categorycode}
2533 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
2535 my $item = $builder->build_sample_item(
2537 library => $library->branchcode,
2541 my ( $error, $question, $alerts );
2542 my $issue = AddIssue( $patron1->unblessed, $item->barcode );
2544 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2545 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2546 is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
2548 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
2549 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2550 is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
2552 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2556 subtest 'AddReturn | is_overdue' => sub {
2559 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
2560 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
2561 t::lib::Mocks::mock_preference('finesMode', 'production');
2562 t::lib::Mocks::mock_preference('MaxFine', '100');
2564 my $library = $builder->build( { source => 'Branch' } );
2565 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2566 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2567 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2569 my $item = $builder->build_sample_item(
2571 library => $library->{branchcode},
2572 replacementprice => 7
2576 Koha::CirculationRules->search->delete;
2577 Koha::CirculationRules->set_rules(
2579 categorycode => undef,
2581 branchcode => undef,
2584 lengthunit => 'days',
2585 fine => 1, # Charge 1 every day of overdue
2591 my $now = dt_from_string;
2592 my $one_day_ago = $now->clone->subtract( days => 1 );
2593 my $two_days_ago = $now->clone->subtract( days => 2 );
2594 my $five_days_ago = $now->clone->subtract( days => 5 );
2595 my $ten_days_ago = $now->clone->subtract( days => 10 );
2596 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2598 # No return date specified, today will be used => 10 days overdue charged
2599 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2600 AddReturn( $item->barcode, $library->{branchcode} );
2601 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2602 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2604 # specify return date 5 days before => no overdue charged
2605 AddIssue( $patron->unblessed, $item->barcode, $five_days_ago ); # date due was 5d ago
2606 AddReturn( $item->barcode, $library->{branchcode}, undef, $ten_days_ago );
2607 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2608 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2610 # specify return date 5 days later => 5 days overdue charged
2611 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2612 AddReturn( $item->barcode, $library->{branchcode}, undef, $five_days_ago );
2613 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2614 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2616 # specify return date 5 days later, specify exemptfine => no overdue charge
2617 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2618 AddReturn( $item->barcode, $library->{branchcode}, 1, $five_days_ago );
2619 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2620 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2622 subtest 'bug 22877 | Lost item return' => sub {
2626 my $issue = AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2628 # Fake fines cronjob on this checkout
2630 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2631 $ten_days_ago, $now );
2634 issue_id => $issue->issue_id,
2635 itemnumber => $item->itemnumber,
2636 borrowernumber => $patron->borrowernumber,
2638 due => output_pref($ten_days_ago)
2641 is( int( $patron->account->balance() ),
2642 10, "Overdue fine of 10 days overdue" );
2644 # Fake longoverdue with charge and not marking returned
2645 LostItem( $item->itemnumber, 'cronjob', 0 );
2646 is( int( $patron->account->balance() ),
2647 17, "Lost fine of 7 plus 10 days overdue" );
2649 # Now we return it today
2650 AddReturn( $item->barcode, $library->{branchcode} );
2651 is( int( $patron->account->balance() ),
2652 17, "Should have a single 10 days overdue fine and lost charge" );
2655 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2658 subtest 'bug 8338 | backdated return resulting in zero amount fine' => sub {
2662 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2664 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2666 # Fake fines cronjob on this checkout
2668 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2669 $one_day_ago, $now );
2672 issue_id => $issue->issue_id,
2673 itemnumber => $item->itemnumber,
2674 borrowernumber => $patron->borrowernumber,
2676 due => output_pref($one_day_ago)
2679 is( int( $patron->account->balance() ),
2680 1, "Overdue fine of 1 day overdue" );
2682 # Backdated return (dropbox mode example - charge should be removed)
2683 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2684 is( int( $patron->account->balance() ),
2685 0, "Overdue fine should be annulled" );
2686 my $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2687 is( $lines->count, 0, "Overdue fine accountline has been removed");
2689 $issue = AddIssue( $patron->unblessed, $item->barcode, $two_days_ago ); # date due was 2d ago
2691 # Fake fines cronjob on this checkout
2693 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2694 $two_days_ago, $now );
2697 issue_id => $issue->issue_id,
2698 itemnumber => $item->itemnumber,
2699 borrowernumber => $patron->borrowernumber,
2701 due => output_pref($one_day_ago)
2704 is( int( $patron->account->balance() ),
2705 2, "Overdue fine of 2 days overdue" );
2707 # Payment made against fine
2708 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2709 my $debit = $lines->next;
2710 my $credit = $patron->account->add_credit(
2714 interface => 'test',
2717 $credit->apply( { debits => [$debit] } );
2719 is( int( $patron->account->balance() ),
2720 0, "Overdue fine should be paid off" );
2721 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2722 is ( $lines->count, 2, "Overdue (debit) and Payment (credit) present");
2723 my $line = $lines->next;
2724 is( $line->amount+0, 2, "Overdue fine amount remains as 2 days");
2725 is( $line->amountoutstanding+0, 0, "Overdue fine amountoutstanding reduced to 0");
2727 # Backdated return (dropbox mode example - charge should be removed)
2728 AddReturn( $item->barcode, $library->{branchcode}, undef, $one_day_ago );
2729 is( int( $patron->account->balance() ),
2730 -1, "Refund credit has been applied" );
2731 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber }, { order_by => { '-asc' => 'accountlines_id' }});
2732 is( $lines->count, 3, "Overdue (debit), Payment (credit) and Refund (credit) are all present");
2734 $line = $lines->next;
2735 is($line->amount+0,1, "Overdue fine amount has been reduced to 1");
2736 is($line->amountoutstanding+0,0, "Overdue fine amount outstanding remains at 0");
2737 is($line->status,'RETURNED', "Overdue fine is fixed");
2738 $line = $lines->next;
2739 is($line->amount+0,-2, "Original payment amount remains as 2");
2740 is($line->amountoutstanding+0,0, "Original payment remains applied");
2741 $line = $lines->next;
2742 is($line->amount+0,-1, "Refund amount correctly set to 1");
2743 is($line->amountoutstanding+0,-1, "Refund amount outstanding unspent");
2746 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2749 subtest 'bug 25417 | backdated return + exemptfine' => sub {
2753 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2755 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2757 # Fake fines cronjob on this checkout
2759 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2760 $one_day_ago, $now );
2763 issue_id => $issue->issue_id,
2764 itemnumber => $item->itemnumber,
2765 borrowernumber => $patron->borrowernumber,
2767 due => output_pref($one_day_ago)
2770 is( int( $patron->account->balance() ),
2771 1, "Overdue fine of 1 day overdue" );
2773 # Backdated return (dropbox mode example - charge should no longer exist)
2774 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2775 is( int( $patron->account->balance() ),
2776 0, "Overdue fine should be annulled" );
2779 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2782 subtest 'bug 24075 | backdated return with return datetime matching due datetime' => sub {
2785 t::lib::Mocks::mock_preference( 'CalculateFinesOnBackdate', 1 );
2787 my $due_date = dt_from_string;
2788 my $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2793 issue_id => $issue->issue_id,
2794 itemnumber => $item->itemnumber,
2795 borrowernumber => $patron->borrowernumber,
2797 due => output_pref($due_date)
2800 is( $patron->account->balance(),
2801 0.25, 'Overdue fine of $0.25 recorded' );
2803 # Backdate return to exact due date and time
2804 my ( undef, $message ) =
2805 AddReturn( $item->barcode, $library->{branchcode},
2809 Koha::Account::Lines->find( { issue_id => $issue->id } );
2810 ok( !$accountline, 'accountline removed as expected' );
2813 $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2818 issue_id => $issue->issue_id,
2819 itemnumber => $item->itemnumber,
2820 borrowernumber => $patron->borrowernumber,
2822 due => output_pref($due_date)
2825 is( $patron->account->balance(),
2826 0.25, 'Overdue fine of $0.25 recorded' );
2828 # Partial pay accruing fine
2829 my $lines = Koha::Account::Lines->search(
2831 borrowernumber => $patron->borrowernumber,
2832 issue_id => $issue->id
2835 my $debit = $lines->next;
2836 my $credit = $patron->account->add_credit(
2840 interface => 'test',
2843 $credit->apply( { debits => [$debit] } );
2845 is( $patron->account->balance(), .05, 'Overdue fine reduced to $0.05' );
2847 # Backdate return to exact due date and time
2848 ( undef, $message ) =
2849 AddReturn( $item->barcode, $library->{branchcode},
2852 $lines = Koha::Account::Lines->search(
2854 borrowernumber => $patron->borrowernumber,
2855 issue_id => $issue->id
2858 $accountline = $lines->next;
2859 is( $accountline->amountoutstanding + 0,
2860 0, 'Partially paid fee amount outstanding was reduced to 0' );
2861 is( $accountline->amount + 0,
2862 0, 'Partially paid fee amount was reduced to 0' );
2863 is( $patron->account->balance(), -0.20, 'Patron refund recorded' );
2866 Koha::Account::Lines->search(
2867 { borrowernumber => $patron->borrowernumber } )->delete;
2870 subtest 'enh 23091 | Lost item return policies' => sub {
2873 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2875 my $branchcode_false =
2876 $builder->build( { source => 'Branch' } )->{branchcode};
2877 my $specific_rule_false = $builder->build(
2879 source => 'CirculationRule',
2881 branchcode => $branchcode_false,
2882 categorycode => undef,
2884 rule_name => 'lostreturn',
2889 my $branchcode_refund =
2890 $builder->build( { source => 'Branch' } )->{branchcode};
2891 my $specific_rule_refund = $builder->build(
2893 source => 'CirculationRule',
2895 branchcode => $branchcode_refund,
2896 categorycode => undef,
2898 rule_name => 'lostreturn',
2899 rule_value => 'refund'
2903 my $branchcode_restore =
2904 $builder->build( { source => 'Branch' } )->{branchcode};
2905 my $specific_rule_restore = $builder->build(
2907 source => 'CirculationRule',
2909 branchcode => $branchcode_restore,
2910 categorycode => undef,
2912 rule_name => 'lostreturn',
2913 rule_value => 'restore'
2917 my $branchcode_charge =
2918 $builder->build( { source => 'Branch' } )->{branchcode};
2919 my $specific_rule_charge = $builder->build(
2921 source => 'CirculationRule',
2923 branchcode => $branchcode_charge,
2924 categorycode => undef,
2926 rule_name => 'lostreturn',
2927 rule_value => 'charge'
2932 my $replacement_amount = 99.00;
2933 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
2934 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2935 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
2936 t::lib::Mocks::mock_preference( 'BlockReturnOfLostItems', 0 );
2937 t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl',
2939 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge',
2942 subtest 'lostreturn | false' => sub {
2945 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_false });
2947 my $item = $builder->build_sample_item(
2949 replacementprice => $replacement_amount
2954 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
2956 # Fake fines cronjob on this checkout
2958 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2959 $ten_days_ago, $now );
2962 issue_id => $issue->issue_id,
2963 itemnumber => $item->itemnumber,
2964 borrowernumber => $patron->borrowernumber,
2966 due => output_pref($ten_days_ago)
2969 my $overdue_fees = Koha::Account::Lines->search(
2971 borrowernumber => $patron->id,
2972 itemnumber => $item->itemnumber,
2973 debit_type_code => 'OVERDUE'
2976 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
2977 my $overdue_fee = $overdue_fees->next;
2978 is( $overdue_fee->amount + 0,
2979 10, 'The right OVERDUE amount is generated' );
2980 is( $overdue_fee->amountoutstanding + 0,
2982 'The right OVERDUE amountoutstanding is generated' );
2984 # Simulate item marked as lost
2985 $item->itemlost(3)->store;
2986 C4::Circulation::LostItem( $item->itemnumber, 1 );
2988 my $lost_fee_lines = Koha::Account::Lines->search(
2990 borrowernumber => $patron->id,
2991 itemnumber => $item->itemnumber,
2992 debit_type_code => 'LOST'
2995 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
2996 my $lost_fee_line = $lost_fee_lines->next;
2997 is( $lost_fee_line->amount + 0,
2998 $replacement_amount, 'The right LOST amount is generated' );
2999 is( $lost_fee_line->amountoutstanding + 0,
3000 $replacement_amount,
3001 'The right LOST amountoutstanding is generated' );
3002 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3005 my ( $returned, $message ) =
3006 AddReturn( $item->barcode, $branchcode_false, undef, $five_days_ago );
3008 $overdue_fee->discard_changes;
3009 is( $overdue_fee->amount + 0,
3010 10, 'The OVERDUE amount is left intact' );
3011 is( $overdue_fee->amountoutstanding + 0,
3013 'The OVERDUE amountoutstanding is left intact' );
3015 $lost_fee_line->discard_changes;
3016 is( $lost_fee_line->amount + 0,
3017 $replacement_amount, 'The LOST amount is left intact' );
3018 is( $lost_fee_line->amountoutstanding + 0,
3019 $replacement_amount,
3020 'The LOST amountoutstanding is left intact' );
3021 # FIXME: Should we set the LOST fee status to 'FOUND' regardless of whether we're refunding or not?
3022 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3025 subtest 'lostreturn | refund' => sub {
3028 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_refund });
3030 my $item = $builder->build_sample_item(
3032 replacementprice => $replacement_amount
3037 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3039 # Fake fines cronjob on this checkout
3041 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3042 $ten_days_ago, $now );
3045 issue_id => $issue->issue_id,
3046 itemnumber => $item->itemnumber,
3047 borrowernumber => $patron->borrowernumber,
3049 due => output_pref($ten_days_ago)
3052 my $overdue_fees = Koha::Account::Lines->search(
3054 borrowernumber => $patron->id,
3055 itemnumber => $item->itemnumber,
3056 debit_type_code => 'OVERDUE'
3059 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3060 my $overdue_fee = $overdue_fees->next;
3061 is( $overdue_fee->amount + 0,
3062 10, 'The right OVERDUE amount is generated' );
3063 is( $overdue_fee->amountoutstanding + 0,
3065 'The right OVERDUE amountoutstanding is generated' );
3067 # Simulate item marked as lost
3068 $item->itemlost(3)->store;
3069 C4::Circulation::LostItem( $item->itemnumber, 1 );
3071 my $lost_fee_lines = Koha::Account::Lines->search(
3073 borrowernumber => $patron->id,
3074 itemnumber => $item->itemnumber,
3075 debit_type_code => 'LOST'
3078 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3079 my $lost_fee_line = $lost_fee_lines->next;
3080 is( $lost_fee_line->amount + 0,
3081 $replacement_amount, 'The right LOST amount is generated' );
3082 is( $lost_fee_line->amountoutstanding + 0,
3083 $replacement_amount,
3084 'The right LOST amountoutstanding is generated' );
3085 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3087 # Return the lost item
3088 my ( undef, $message ) =
3089 AddReturn( $item->barcode, $branchcode_refund, undef, $five_days_ago );
3091 $overdue_fee->discard_changes;
3092 is( $overdue_fee->amount + 0,
3093 10, 'The OVERDUE amount is left intact' );
3094 is( $overdue_fee->amountoutstanding + 0,
3096 'The OVERDUE amountoutstanding is left intact' );
3098 $lost_fee_line->discard_changes;
3099 is( $lost_fee_line->amount + 0,
3100 $replacement_amount, 'The LOST amount is left intact' );
3101 is( $lost_fee_line->amountoutstanding + 0,
3103 'The LOST amountoutstanding is refunded' );
3104 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3107 subtest 'lostreturn | restore' => sub {
3110 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_restore });
3112 my $item = $builder->build_sample_item(
3114 replacementprice => $replacement_amount
3119 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode , $ten_days_ago);
3121 # Fake fines cronjob on this checkout
3123 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3124 $ten_days_ago, $now );
3127 issue_id => $issue->issue_id,
3128 itemnumber => $item->itemnumber,
3129 borrowernumber => $patron->borrowernumber,
3131 due => output_pref($ten_days_ago)
3134 my $overdue_fees = Koha::Account::Lines->search(
3136 borrowernumber => $patron->id,
3137 itemnumber => $item->itemnumber,
3138 debit_type_code => 'OVERDUE'
3141 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3142 my $overdue_fee = $overdue_fees->next;
3143 is( $overdue_fee->amount + 0,
3144 10, 'The right OVERDUE amount is generated' );
3145 is( $overdue_fee->amountoutstanding + 0,
3147 'The right OVERDUE amountoutstanding is generated' );
3149 # Simulate item marked as lost
3150 $item->itemlost(3)->store;
3151 C4::Circulation::LostItem( $item->itemnumber, 1 );
3153 my $lost_fee_lines = Koha::Account::Lines->search(
3155 borrowernumber => $patron->id,
3156 itemnumber => $item->itemnumber,
3157 debit_type_code => 'LOST'
3160 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3161 my $lost_fee_line = $lost_fee_lines->next;
3162 is( $lost_fee_line->amount + 0,
3163 $replacement_amount, 'The right LOST amount is generated' );
3164 is( $lost_fee_line->amountoutstanding + 0,
3165 $replacement_amount,
3166 'The right LOST amountoutstanding is generated' );
3167 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3169 # Simulate refunding overdue fees upon marking item as lost
3170 my $overdue_forgive = $patron->account->add_credit(
3173 user_id => $manager->borrowernumber,
3174 library_id => $branchcode_restore,
3175 interface => 'test',
3177 item_id => $item->itemnumber
3180 $overdue_forgive->apply( { debits => [$overdue_fee] } );
3181 $overdue_fee->discard_changes;
3182 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3185 my ( undef, $message ) =
3186 AddReturn( $item->barcode, $branchcode_restore, undef, $five_days_ago );
3188 $overdue_fee->discard_changes;
3189 is( $overdue_fee->amount + 0,
3190 10, 'The OVERDUE amount is left intact' );
3191 is( $overdue_fee->amountoutstanding + 0,
3193 'The OVERDUE amountoutstanding is restored' );
3195 $lost_fee_line->discard_changes;
3196 is( $lost_fee_line->amount + 0,
3197 $replacement_amount, 'The LOST amount is left intact' );
3198 is( $lost_fee_line->amountoutstanding + 0,
3200 'The LOST amountoutstanding is refunded' );
3201 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3204 subtest 'lostreturn | charge' => sub {
3207 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_charge });
3209 my $item = $builder->build_sample_item(
3211 replacementprice => $replacement_amount
3216 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3218 # Fake fines cronjob on this checkout
3220 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3221 $ten_days_ago, $now );
3224 issue_id => $issue->issue_id,
3225 itemnumber => $item->itemnumber,
3226 borrowernumber => $patron->borrowernumber,
3228 due => output_pref($ten_days_ago)
3231 my $overdue_fees = Koha::Account::Lines->search(
3233 borrowernumber => $patron->id,
3234 itemnumber => $item->itemnumber,
3235 debit_type_code => 'OVERDUE'
3238 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3239 my $overdue_fee = $overdue_fees->next;
3240 is( $overdue_fee->amount + 0,
3241 10, 'The right OVERDUE amount is generated' );
3242 is( $overdue_fee->amountoutstanding + 0,
3244 'The right OVERDUE amountoutstanding is generated' );
3246 # Simulate item marked as lost
3247 $item->itemlost(3)->store;
3248 C4::Circulation::LostItem( $item->itemnumber, 1 );
3250 my $lost_fee_lines = Koha::Account::Lines->search(
3252 borrowernumber => $patron->id,
3253 itemnumber => $item->itemnumber,
3254 debit_type_code => 'LOST'
3257 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3258 my $lost_fee_line = $lost_fee_lines->next;
3259 is( $lost_fee_line->amount + 0,
3260 $replacement_amount, 'The right LOST amount is generated' );
3261 is( $lost_fee_line->amountoutstanding + 0,
3262 $replacement_amount,
3263 'The right LOST amountoutstanding is generated' );
3264 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3266 # Simulate refunding overdue fees upon marking item as lost
3267 my $overdue_forgive = $patron->account->add_credit(
3270 user_id => $manager->borrowernumber,
3271 library_id => $branchcode_charge,
3272 interface => 'test',
3274 item_id => $item->itemnumber
3277 $overdue_forgive->apply( { debits => [$overdue_fee] } );
3278 $overdue_fee->discard_changes;
3279 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3282 my ( undef, $message ) =
3283 AddReturn( $item->barcode, $branchcode_charge, undef, $five_days_ago );
3285 $lost_fee_line->discard_changes;
3286 is( $lost_fee_line->amount + 0,
3287 $replacement_amount, 'The LOST amount is left intact' );
3288 is( $lost_fee_line->amountoutstanding + 0,
3290 'The LOST amountoutstanding is refunded' );
3291 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3293 $overdue_fees = Koha::Account::Lines->search(
3295 borrowernumber => $patron->id,
3296 itemnumber => $item->itemnumber,
3297 debit_type_code => 'OVERDUE'
3300 order_by => { '-asc' => 'accountlines_id'}
3303 is( $overdue_fees->count, 2, 'A second OVERDUE fee has been added' );
3304 $overdue_fee = $overdue_fees->next;
3305 is( $overdue_fee->amount + 0,
3306 10, 'The original OVERDUE amount is left intact' );
3307 is( $overdue_fee->amountoutstanding + 0,
3309 'The original OVERDUE amountoutstanding is left as forgiven' );
3310 $overdue_fee = $overdue_fees->next;
3311 is( $overdue_fee->amount + 0,
3312 5, 'The new OVERDUE amount is correct for the backdated return' );
3313 is( $overdue_fee->amountoutstanding + 0,
3315 'The new OVERDUE amountoutstanding is correct for the backdated return' );
3320 subtest '_FixOverduesOnReturn' => sub {
3323 my $manager = $builder->build_object({ class => "Koha::Patrons" });
3324 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
3326 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
3328 my $branchcode = $library2->{branchcode};
3330 my $item = $builder->build_sample_item(
3332 biblionumber => $biblio->biblionumber,
3333 library => $branchcode,
3334 replacementprice => 99.00,
3339 my $patron = $builder->build( { source => 'Borrower' } );
3341 ## Start with basic call, should just close out the open fine
3342 my $accountline = Koha::Account::Line->new(
3344 borrowernumber => $patron->{borrowernumber},
3345 debit_type_code => 'OVERDUE',
3346 status => 'UNRETURNED',
3347 itemnumber => $item->itemnumber,
3349 amountoutstanding => 99.00,
3350 interface => 'test',
3354 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
3356 $accountline->_result()->discard_changes();
3358 is( $accountline->amountoutstanding+0, 99, 'Fine has the same amount outstanding as previously' );
3359 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3360 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3362 ## Run again, with exemptfine enabled
3365 debit_type_code => 'OVERDUE',
3366 status => 'UNRETURNED',
3367 amountoutstanding => 99.00,
3371 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3373 $accountline->_result()->discard_changes();
3374 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'APPLY' })->next();
3376 is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
3377 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3378 is( $accountline->status, 'RETURNED', 'Open fine ( account type OVERDUE ) has been set to returned ( status RETURNED )');
3379 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
3380 is( $offset->amount + 0, -99, "Amount of offset is correct" );
3381 my $credit = $offset->credit;
3382 is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
3383 is( $credit->amount + 0, -99, "Credit amount is set correctly" );
3384 is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
3386 # Bug 25417 - Only forgive fines where there is an amount outstanding to forgive
3389 debit_type_code => 'OVERDUE',
3390 status => 'UNRETURNED',
3391 amountoutstanding => 0.00,
3396 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3398 $accountline->_result()->discard_changes();
3399 $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'CREATE' })->next();
3400 is( $offset, undef, "No offset created when trying to forgive fine with no outstanding balance" );
3401 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3402 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3405 subtest 'Set waiting flag' => sub {
3408 my $library_1 = $builder->build( { source => 'Branch' } );
3409 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3410 my $library_2 = $builder->build( { source => 'Branch' } );
3411 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3413 my $item = $builder->build_sample_item(
3415 library => $library_1->{branchcode},
3419 set_userenv( $library_2 );
3420 my $reserve_id = AddReserve(
3422 branchcode => $library_2->{branchcode},
3423 borrowernumber => $patron_2->{borrowernumber},
3424 biblionumber => $item->biblionumber,
3426 itemnumber => $item->itemnumber,
3430 set_userenv( $library_1 );
3431 my $do_transfer = 1;
3432 my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
3433 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3434 my $hold = Koha::Holds->find( $reserve_id );
3435 is( $hold->found, 'T', 'Hold is in transit' );
3437 my ( $status ) = CheckReserves($item->itemnumber);
3438 is( $status, 'Transferred', 'Hold is not waiting yet');
3440 set_userenv( $library_2 );
3442 AddReturn( $item->barcode, $library_2->{branchcode} );
3443 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3444 $hold = Koha::Holds->find( $reserve_id );
3445 is( $hold->found, 'W', 'Hold is waiting' );
3446 ( $status ) = CheckReserves($item->itemnumber);
3447 is( $status, 'Waiting', 'Now the hold is waiting');
3449 #Bug 21944 - Waiting transfer checked in at branch other than pickup location
3450 set_userenv( $library_1 );
3451 (undef, my $messages, undef, undef ) = AddReturn ( $item->barcode, $library_1->{branchcode} );
3452 $hold = Koha::Holds->find( $reserve_id );
3453 is( $hold->found, undef, 'Hold is no longer marked waiting' );
3454 is( $hold->priority, 1, "Hold is now priority one again");
3455 is( $hold->waitingdate, undef, "Hold no longer has a waiting date");
3456 is( $hold->itemnumber, $item->itemnumber, "Hold has retained its' itemnumber");
3457 is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned");
3458 is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message");
3459 is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message");
3462 subtest 'Cancel transfers on lost items' => sub {
3465 my $library_to = $builder->build_object( { class => 'Koha::Libraries' } );
3466 my $item = $builder->build_sample_item();
3467 my $holdingbranch = $item->holdingbranch;
3468 # Historic transfer (datearrived is defined)
3469 my $old_transfer = $builder->build_object(
3471 class => 'Koha::Item::Transfers',
3473 itemnumber => $item->itemnumber,
3474 frombranch => $holdingbranch,
3475 tobranch => $library_to->branchcode,
3477 datesent => \'NOW()',
3478 datearrived => \'NOW()',
3479 datecancelled => undef,
3480 daterequested => \'NOW()'
3484 # Queued transfer (datesent is undefined)
3485 my $transfer_1 = $builder->build_object(
3487 class => 'Koha::Item::Transfers',
3489 itemnumber => $item->itemnumber,
3490 frombranch => $holdingbranch,
3491 tobranch => $library_to->branchcode,
3494 datearrived => undef,
3495 datecancelled => undef,
3496 daterequested => \'NOW()'
3500 # In transit transfer (datesent is defined, datearrived and datecancelled are both undefined)
3501 my $transfer_2 = $builder->build_object(
3503 class => 'Koha::Item::Transfers',
3505 itemnumber => $item->itemnumber,
3506 frombranch => $holdingbranch,
3507 tobranch => $library_to->branchcode,
3509 datesent => \'NOW()',
3510 datearrived => undef,
3511 datecancelled => undef,
3512 daterequested => \'NOW()'
3517 # Simulate item being marked as lost
3518 $item->itemlost(1)->store;
3519 LostItem( $item->itemnumber, 'test', 1 );
3521 $transfer_1->discard_changes;
3522 isnt($transfer_1->datecancelled, undef, "Queud transfer was cancelled upon item lost");
3523 is($transfer_1->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3524 $transfer_2->discard_changes;
3525 isnt($transfer_2->datecancelled, undef, "Active transfer was cancelled upon item lost");
3526 is($transfer_2->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3527 $old_transfer->discard_changes;
3528 is($old_transfer->datecancelled, undef, "Old transfers are unaffected");
3529 $item->discard_changes;
3530 is($item->holdingbranch, $holdingbranch, "Items holding branch remains unchanged");
3533 subtest 'CanBookBeIssued | is_overdue' => sub {
3536 # Set a simple circ policy
3537 Koha::CirculationRules->set_rules(
3539 categorycode => undef,
3540 branchcode => undef,
3544 reservesallowed => 25,
3546 lengthunit => 'days',
3547 renewalsallowed => 1,
3549 norenewalbefore => undef,
3557 my $now = dt_from_string;
3558 my $five_days_go = output_pref({ dt => $now->clone->add( days => 5 ), dateonly => 1});
3559 my $ten_days_go = output_pref({ dt => $now->clone->add( days => 10), dateonly => 1 });
3560 my $library = $builder->build( { source => 'Branch' } );
3561 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
3563 my $item = $builder->build_sample_item(
3565 library => $library->{branchcode},
3569 my $issue = AddIssue( $patron->unblessed, $item->barcode, $five_days_go ); # date due was 10d ago
3570 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->itemnumber } );
3571 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
3572 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->barcode,$ten_days_go, undef, undef, undef);
3573 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
3574 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
3577 subtest 'ItemsDeniedRenewal preference' => sub {
3580 C4::Context->set_preference('ItemsDeniedRenewal','');
3582 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
3583 Koha::CirculationRules->set_rules(
3585 categorycode => '*',
3587 branchcode => $idr_lib->branchcode,
3589 reservesallowed => 25,
3591 lengthunit => 'days',
3592 renewalsallowed => 10,
3594 norenewalbefore => undef,
3602 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
3603 homebranch => $idr_lib->branchcode,
3607 itemcallnumber => undef,
3611 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
3612 homebranch => $idr_lib->branchcode,
3615 location => 'NOPROC'
3619 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
3620 branchcode => $idr_lib->branchcode,
3623 my $future = dt_from_string->add( days => 1 );
3624 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3625 returndate => undef,
3628 borrowernumber => $idr_borrower->borrowernumber,
3629 itemnumber => $deny_book->itemnumber,
3630 onsite_checkout => 0,
3631 date_due => $future,
3634 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3635 returndate => undef,
3638 borrowernumber => $idr_borrower->borrowernumber,
3639 itemnumber => $allow_book->itemnumber,
3640 onsite_checkout => 0,
3641 date_due => $future,
3647 my ( $idr_mayrenew, $idr_error ) =
3648 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3649 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
3650 is( $idr_error, undef, 'Renewal allowed when no rules' );
3652 $idr_rules="withdrawn: [1]";
3654 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3655 ( $idr_mayrenew, $idr_error ) =
3656 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3657 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
3658 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
3659 ( $idr_mayrenew, $idr_error ) =
3660 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3661 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3662 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3664 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
3666 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3667 ( $idr_mayrenew, $idr_error ) =
3668 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3669 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
3670 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
3671 ( $idr_mayrenew, $idr_error ) =
3672 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3673 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3674 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3676 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
3678 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3679 ( $idr_mayrenew, $idr_error ) =
3680 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3681 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
3682 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
3683 ( $idr_mayrenew, $idr_error ) =
3684 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3685 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3686 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3688 $idr_rules="itemcallnumber: [NULL]";
3689 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3690 ( $idr_mayrenew, $idr_error ) =
3691 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3692 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
3693 $idr_rules="itemcallnumber: ['']";
3694 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3695 ( $idr_mayrenew, $idr_error ) =
3696 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3697 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
3699 $idr_rules="itemnotes: [NULL]";
3700 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3701 ( $idr_mayrenew, $idr_error ) =
3702 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3703 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
3704 $idr_rules="itemnotes: ['']";
3705 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3706 ( $idr_mayrenew, $idr_error ) =
3707 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3708 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
3711 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
3714 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3715 my $library = $builder->build( { source => 'Branch' } );
3716 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3718 my $item = $builder->build_sample_item(
3720 library => $library->{branchcode},
3724 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3725 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3726 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3729 subtest 'CanBookBeIssued | notforloan' => sub {
3732 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
3734 my $library = $builder->build( { source => 'Branch' } );
3735 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3737 my $itemtype = $builder->build(
3739 source => 'Itemtype',
3740 value => { notforloan => undef, }
3743 my $item = $builder->build_sample_item(
3745 library => $library->{branchcode},
3746 itype => $itemtype->{itemtype},
3749 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3751 my ( $issuingimpossible, $needsconfirmation );
3754 subtest 'item-level_itypes = 1' => sub {
3757 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
3758 # Is for loan at item type and item level
3759 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3760 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3761 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3763 # not for loan at item type level
3764 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3765 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3766 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3769 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3770 'Item can not be issued, not for loan at item type level'
3773 # not for loan at item level
3774 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3775 $item->notforloan( 1 )->store;
3776 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3777 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3780 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3781 'Item can not be issued, not for loan at item type level'
3785 subtest 'item-level_itypes = 0' => sub {
3788 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3790 # We set another itemtype for biblioitem
3791 my $itemtype = $builder->build(
3793 source => 'Itemtype',
3794 value => { notforloan => undef, }
3798 # for loan at item type and item level
3799 $item->notforloan(0)->store;
3800 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3801 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3802 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3803 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3805 # not for loan at item type level
3806 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3807 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3808 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3811 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3812 'Item can not be issued, not for loan at item type level'
3815 # not for loan at item level
3816 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3817 $item->notforloan( 1 )->store;
3818 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3819 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3822 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3823 'Item can not be issued, not for loan at item type level'
3827 # TODO test with AllowNotForLoanOverride = 1
3830 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
3833 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
3834 my $item = $builder->build_sample_item(
3836 onloan => '2018-01-01',
3840 AddReturn( $item->barcode, $item->homebranch );
3841 $item->discard_changes; # refresh
3842 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
3846 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
3851 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3853 my $issuing_charges = 15;
3854 my $title = 'A title';
3855 my $author = 'Author, An';
3856 my $barcode = 'WHATARETHEODDS';
3858 my $circ = Test::MockModule->new('C4::Circulation');
3860 'GetIssuingCharges',
3862 return $issuing_charges;
3866 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3867 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
3868 my $patron = $builder->build_object({
3869 class => 'Koha::Patrons',
3870 value => { branchcode => $library->id }
3873 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
3874 my $item_id = Koha::Item->new(
3876 biblionumber => $biblio->biblionumber,
3877 homebranch => $library->id,
3878 holdingbranch => $library->id,
3879 barcode => $barcode,
3880 replacementprice => 23.00,
3881 itype => $itemtype->id
3883 )->store->itemnumber;
3884 my $item = Koha::Items->find( $item_id );
3886 my $context = Test::MockModule->new('C4::Context');
3887 $context->mock( userenv => { branch => $library->id } );
3889 # Check the item out
3890 AddIssue( $patron->unblessed, $item->barcode );
3893 AddRenewal( $patron->borrowernumber, $item->itemnumber, $library->id, undef, {break=>"the_renewal"} );
3894 } 'Koha::Exceptions::Checkout::FailedRenewal', 'Exception is thrown when renewal update to issues fails';
3896 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3897 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3898 my %params_renewal = (
3899 timestamp => { -like => $date . "%" },
3900 module => "CIRCULATION",
3901 action => "RENEWAL",
3903 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3904 AddRenewal( $patron->id, $item->id, $library->id );
3905 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3906 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3908 my $checkouts = $patron->checkouts;
3909 # The following will fail if run on 00:00:00
3910 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3912 my $lines = Koha::Account::Lines->search({
3913 borrowernumber => $patron->id,
3914 itemnumber => $item->id
3917 is( $lines->count, 2 );
3919 my $line = $lines->next;
3920 is( $line->debit_type_code, 'RENT', 'The issue of item with issuing charge generates an accountline of the correct type' );
3921 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
3922 is( $line->description, '', 'AddIssue does not set a hardcoded description for the accountline' );
3924 $line = $lines->next;
3925 is( $line->debit_type_code, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3926 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
3927 is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3929 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3931 $context = Test::MockModule->new('C4::Context');
3932 $context->mock( userenv => { branch => undef, interface => 'CRON'} ); #Test statistical logging of renewal via cron (atuo_renew)
3934 my $now = dt_from_string;
3935 $date = output_pref( { dt => $now, dateonly => 1, dateformat => 'iso' } );
3936 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3937 my $sth = $dbh->prepare("SELECT COUNT(*) FROM statistics WHERE itemnumber = ? AND branch = ?");
3938 $sth->execute($item->id, $library->id);
3939 my ($old_stats_size) = $sth->fetchrow_array;
3940 AddRenewal( $patron->id, $item->id, $library->id );
3941 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3942 $sth->execute($item->id, $library->id);
3943 my ($new_stats_size) = $sth->fetchrow_array;
3944 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3945 is( $new_stats_size, $old_stats_size + 1, 'renew statistic successfully added with passed branch' );
3947 AddReturn( $item->id, $library->id, undef, $date );
3948 AddIssue( $patron->unblessed, $item->barcode, $now );
3949 AddRenewal( $patron->id, $item->id, $library->id, undef, undef, 1 );
3950 my $lines_skipped = Koha::Account::Lines->search({
3951 borrowernumber => $patron->id,
3952 itemnumber => $item->id
3954 is( $lines_skipped->count, 5, 'Passing skipfinecalc causes fine calculation on renewal to be skipped' );
3958 subtest 'ProcessOfflinePayment() tests' => sub {
3965 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
3966 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3967 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3969 is( $result, 'Success.', 'The right string is returned' );
3971 my $lines = $patron->account->lines;
3972 is( $lines->count, 1, 'line created correctly');
3974 my $line = $lines->next;
3975 is( $line->amount+0, $amount * -1, 'amount picked from params' );
3976 is( $line->branchcode, $library->id, 'branchcode set correctly' );
3980 subtest 'Incremented fee tests' => sub {
3983 my $dt = dt_from_string();
3984 Time::Fake->offset( $dt->epoch );
3986 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
3989 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3991 $module->mock( 'userenv', sub { { branch => $library->id } } );
3993 my $patron = $builder->build_object(
3995 class => 'Koha::Patrons',
3996 value => { categorycode => $patron_category->{categorycode} }
4000 my $itemtype = $builder->build_object(
4002 class => 'Koha::ItemTypes',
4004 notforloan => undef,
4006 rentalcharge_daily => 1,
4007 rentalcharge_daily_calendar => 0
4012 my $item = $builder->build_sample_item(
4014 library => $library->{branchcode},
4015 itype => $itemtype->id,
4019 is( $itemtype->rentalcharge_daily+0,
4020 1, 'Daily rental charge stored and retreived correctly' );
4021 is( $item->effective_itemtype, $itemtype->id,
4022 "Itemtype set correctly for item" );
4024 my $now = dt_from_string;
4025 my $dt_from = $now->clone;
4026 my $dt_to = $now->clone->add( days => 7 );
4027 my $dt_to_renew = $now->clone->add( days => 13 );
4031 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4032 my $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4033 is( $accountline->amount+0, 7,
4034 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0"
4036 $accountline->delete();
4037 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4038 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4039 is( $accountline->amount+0, 6,
4040 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0, for renewal"
4042 $accountline->delete();
4045 t::lib::Mocks::mock_preference( 'finesCalendar', 'noFinesWhenClosed' );
4046 $itemtype->rentalcharge_daily_calendar(1)->store();
4048 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4049 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4050 is( $accountline->amount+0, 7,
4051 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1"
4053 $accountline->delete();
4054 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4055 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4056 is( $accountline->amount+0, 6,
4057 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1, for renewal"
4059 $accountline->delete();
4062 my $calendar = C4::Calendar->new( branchcode => $library->id );
4063 # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
4065 ( $dt_from->day_of_week == 6 ) ? 0
4066 : ( $dt_from->day_of_week == 7 ) ? 1
4067 : $dt_from->day_of_week + 1;
4068 my $closed_day_name = $dt_from->clone->add(days => 1)->day_name;
4069 $calendar->insert_week_day_holiday(
4070 weekday => $closed_day,
4071 title => 'Test holiday',
4072 description => 'Test holiday'
4075 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4076 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4077 is( $accountline->amount+0, 6,
4078 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name"
4080 $accountline->delete();
4081 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4082 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4083 is( $accountline->amount+0, 5,
4084 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name, for renewal"
4086 $accountline->delete();
4089 $itemtype->rentalcharge(2)->store;
4090 is( $itemtype->rentalcharge+0, 2,
4091 'Rental charge updated and retreived correctly' );
4093 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4095 Koha::Account::Lines->search( { itemnumber => $item->id } );
4096 is( $accountlines->count, '2',
4097 "Fixed charge and accrued charge recorded distinctly" );
4098 $accountlines->delete();
4099 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4100 $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
4101 is( $accountlines->count, '2',
4102 "Fixed charge and accrued charge recorded distinctly, for renewal" );
4103 $accountlines->delete();
4105 $itemtype->rentalcharge(0)->store;
4106 is( $itemtype->rentalcharge+0, 0,
4107 'Rental charge reset and retreived correctly' );
4110 Koha::CirculationRules->set_rule(
4112 categorycode => $patron->categorycode,
4113 itemtype => $itemtype->id,
4114 branchcode => $library->id,
4115 rule_name => 'lengthunit',
4116 rule_value => 'hours',
4120 $itemtype->rentalcharge_hourly('0.25')->store();
4121 is( $itemtype->rentalcharge_hourly,
4122 '0.25', 'Hourly rental charge stored and retreived correctly' );
4124 $dt_to = $now->clone->add( hours => 168 );
4125 $dt_to_renew = $now->clone->add( hours => 312 );
4127 $itemtype->rentalcharge_hourly_calendar(0)->store();
4129 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4130 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4131 is( $accountline->amount + 0, 42,
4132 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)" );
4133 $accountline->delete();
4134 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4135 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4136 is( $accountline->amount + 0, 36,
4137 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)" );
4138 $accountline->delete();
4141 $itemtype->rentalcharge_hourly_calendar(1)->store();
4143 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4144 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4145 is( $accountline->amount + 0, 36,
4146 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name (168h - 24h * 0.25u)" );
4147 $accountline->delete();
4148 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4149 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4150 is( $accountline->amount + 0, 30,
4151 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name, for renewal (312h - 168h - 24h * 0.25u" );
4152 $accountline->delete();
4155 $calendar->delete_holiday( weekday => $closed_day );
4157 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4158 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4159 is( $accountline->amount + 0, 42,
4160 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u" );
4161 $accountline->delete();
4162 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4163 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4164 is( $accountline->amount + 0, 36,
4165 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)" );
4166 $accountline->delete();
4171 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
4174 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
4175 t::lib::Mocks::mock_preference('item-level_itypes', 1);
4178 $builder->build_object( { class => 'Koha::Libraries' } )->store;
4179 my $patron = $builder->build_object(
4181 class => 'Koha::Patrons',
4182 value => { categorycode => $patron_category->{categorycode} }
4186 my $itemtype = $builder->build_object(
4188 class => 'Koha::ItemTypes',
4192 rentalcharge_daily => 0
4197 my $item = $builder->build_sample_item(
4199 library => $library->id,
4203 itype => $itemtype->id,
4207 my ( $issuingimpossible, $needsconfirmation );
4208 my $dt_from = dt_from_string();
4209 my $dt_due = $dt_from->clone->add( days => 3 );
4211 $itemtype->rentalcharge(1)->store;
4212 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4213 is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' );
4214 $itemtype->rentalcharge('0')->store;
4215 $itemtype->rentalcharge_daily(1)->store;
4216 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4217 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
4218 $itemtype->rentalcharge_daily('0')->store;
4221 subtest 'CanBookBeIssued & CircConfirmItemParts' => sub {
4224 t::lib::Mocks::mock_preference('CircConfirmItemParts', 1);
4226 my $patron = $builder->build_object(
4228 class => 'Koha::Patrons',
4229 value => { categorycode => $patron_category->{categorycode} }
4233 my $item = $builder->build_sample_item(
4235 materials => 'includes DVD',
4239 my $dt_due = dt_from_string->add( days => 3 );
4241 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4242 is_deeply( $needsconfirmation, { ADDITIONAL_MATERIALS => 'includes DVD' }, 'Item needs confirmation of additional parts' );
4245 subtest 'Do not return on renewal (LOST charge)' => sub {
4248 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'onpayment');
4249 my $library = $builder->build_object( { class => "Koha::Libraries" } );
4250 my $manager = $builder->build_object( { class => "Koha::Patrons" } );
4251 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
4253 my $biblio = $builder->build_sample_biblio;
4255 my $item = $builder->build_sample_item(
4257 biblionumber => $biblio->biblionumber,
4258 library => $library->branchcode,
4259 replacementprice => 99.00,
4264 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
4265 AddIssue( $patron->unblessed, $item->barcode );
4267 my $accountline = Koha::Account::Line->new(
4269 borrowernumber => $patron->borrowernumber,
4270 debit_type_code => 'LOST',
4272 itemnumber => $item->itemnumber,
4274 amountoutstanding => 12,
4275 interface => 'something',
4279 # AddRenewal doesn't call _FixAccountForLostAndFound
4280 AddIssue( $patron->unblessed, $item->barcode );
4282 is( $patron->checkouts->count, 1,
4283 'Renewal should not return the item even if a LOST payment has been made earlier'
4287 subtest 'Filling a hold should cancel existing transfer' => sub {
4290 t::lib::Mocks::mock_preference('AutomaticItemReturn', 1);
4292 my $libraryA = $builder->build_object( { class => 'Koha::Libraries' } );
4293 my $libraryB = $builder->build_object( { class => 'Koha::Libraries' } );
4294 my $patron = $builder->build_object(
4296 class => 'Koha::Patrons',
4298 categorycode => $patron_category->{categorycode},
4299 branchcode => $libraryA->branchcode,
4304 my $item = $builder->build_sample_item({
4305 homebranch => $libraryB->branchcode,
4308 my ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4309 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 1, "We generate a transfer on checkin");
4311 branchcode => $libraryA->branchcode,
4312 borrowernumber => $patron->borrowernumber,
4313 biblionumber => $item->biblionumber,
4314 itemnumber => $item->itemnumber
4316 my $reserves = Koha::Holds->search({ itemnumber => $item->itemnumber });
4317 is( $reserves->count, 1, "Reserve is placed");
4318 ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4319 my $reserve = $reserves->next;
4320 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 0, $reserve->reserve_id );
4321 $reserve->discard_changes;
4322 ok( $reserve->found eq 'W', "Reserve is marked waiting" );
4323 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 0, "No outstanding transfers when hold is waiting");
4326 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddReturn' => sub {
4330 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4331 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4332 my $patron = $builder->build_object(
4334 class => 'Koha::Patrons',
4335 value => { categorycode => $patron_category->{categorycode} }
4339 my $biblionumber = $builder->build_sample_biblio(
4341 branchcode => $library->branchcode,
4345 # And the circulation rule
4346 Koha::CirculationRules->search->delete;
4347 Koha::CirculationRules->set_rules(
4349 categorycode => undef,
4351 branchcode => undef,
4354 lengthunit => 'days',
4360 source => 'CirculationRule',
4362 branchcode => undef,
4363 categorycode => undef,
4365 rule_name => 'lostreturn',
4366 rule_value => 'refund'
4371 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4374 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4375 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4377 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4379 my $item = $builder->build_sample_item(
4381 biblionumber => $biblionumber,
4382 library => $library->branchcode,
4383 replacementprice => '42',
4386 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4387 LostItem( $item->itemnumber, 'cli', 0 );
4388 $item->_result->itemlost(1);
4389 $item->_result->itemlost_on( $lost_on );
4390 $item->_result->update();
4392 my $a = Koha::Account::Lines->search(
4394 itemnumber => $item->id,
4395 borrowernumber => $patron->borrowernumber
4398 ok( $a, "Found accountline for lost fee" );
4399 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4400 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4401 $a = $a->get_from_storage;
4402 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4406 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4409 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4410 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4412 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4414 my $item = $builder->build_sample_item(
4416 biblionumber => $biblionumber,
4417 library => $library->branchcode,
4418 replacementprice => '42',
4421 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4422 LostItem( $item->itemnumber, 'cli', 0 );
4423 $item->_result->itemlost(1);
4424 $item->_result->itemlost_on( $lost_on );
4425 $item->_result->update();
4427 my $a = Koha::Account::Lines->search(
4429 itemnumber => $item->id,
4430 borrowernumber => $patron->borrowernumber
4433 ok( $a, "Found accountline for lost fee" );
4434 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4435 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4436 $a = $a->get_from_storage;
4437 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4441 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4444 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4445 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4447 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4449 my $item = $builder->build_sample_item(
4451 biblionumber => $biblionumber,
4452 library => $library->branchcode,
4453 replacementprice => '42',
4456 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4457 LostItem( $item->itemnumber, 'cli', 0 );
4458 $item->_result->itemlost(1);
4459 $item->_result->itemlost_on( $lost_on );
4460 $item->_result->update();
4462 my $a = Koha::Account::Lines->search(
4464 itemnumber => $item->id,
4465 borrowernumber => $patron->borrowernumber
4468 ok( $a, "Found accountline for lost fee" );
4469 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4470 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4471 $a = $a->get_from_storage;
4472 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4476 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4479 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4480 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4482 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4484 my $item = $builder->build_sample_item(
4486 biblionumber => $biblionumber,
4487 library => $library->branchcode,
4488 replacementprice => '42',
4491 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4492 LostItem( $item->itemnumber, 'cli', 0 );
4493 $item->_result->itemlost(1);
4494 $item->_result->itemlost_on( $lost_on );
4495 $item->_result->update();
4497 my $a = Koha::Account::Lines->search(
4499 itemnumber => $item->id,
4500 borrowernumber => $patron->borrowernumber
4504 ok( $a, "Found accountline for lost fee" );
4505 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4506 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4507 $a = $a->get_from_storage;
4508 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4513 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddIssue' => sub {
4517 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4518 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4519 my $patron = $builder->build_object(
4521 class => 'Koha::Patrons',
4522 value => { categorycode => $patron_category->{categorycode} }
4525 my $patron2 = $builder->build_object(
4527 class => 'Koha::Patrons',
4528 value => { categorycode => $patron_category->{categorycode} }
4532 my $biblionumber = $builder->build_sample_biblio(
4534 branchcode => $library->branchcode,
4538 # And the circulation rule
4539 Koha::CirculationRules->search->delete;
4540 Koha::CirculationRules->set_rules(
4542 categorycode => undef,
4544 branchcode => undef,
4547 lengthunit => 'days',
4553 source => 'CirculationRule',
4555 branchcode => undef,
4556 categorycode => undef,
4558 rule_name => 'lostreturn',
4559 rule_value => 'refund'
4564 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4567 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4568 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4570 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4572 my $item = $builder->build_sample_item(
4574 biblionumber => $biblionumber,
4575 library => $library->branchcode,
4576 replacementprice => '42',
4579 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4580 LostItem( $item->itemnumber, 'cli', 0 );
4581 $item->_result->itemlost(1);
4582 $item->_result->itemlost_on( $lost_on );
4583 $item->_result->update();
4585 my $a = Koha::Account::Lines->search(
4587 itemnumber => $item->id,
4588 borrowernumber => $patron->borrowernumber
4591 ok( $a, "Found accountline for lost fee" );
4592 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4593 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4594 $a = $a->get_from_storage;
4595 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4600 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4603 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4604 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4606 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4608 my $item = $builder->build_sample_item(
4610 biblionumber => $biblionumber,
4611 library => $library->branchcode,
4612 replacementprice => '42',
4615 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4616 LostItem( $item->itemnumber, 'cli', 0 );
4617 $item->_result->itemlost(1);
4618 $item->_result->itemlost_on( $lost_on );
4619 $item->_result->update();
4621 my $a = Koha::Account::Lines->search(
4623 itemnumber => $item->id,
4624 borrowernumber => $patron->borrowernumber
4627 ok( $a, "Found accountline for lost fee" );
4628 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4629 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4630 $a = $a->get_from_storage;
4631 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4635 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4638 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4639 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4641 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4643 my $item = $builder->build_sample_item(
4645 biblionumber => $biblionumber,
4646 library => $library->branchcode,
4647 replacementprice => '42',
4650 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4651 LostItem( $item->itemnumber, 'cli', 0 );
4652 $item->_result->itemlost(1);
4653 $item->_result->itemlost_on( $lost_on );
4654 $item->_result->update();
4656 my $a = Koha::Account::Lines->search(
4658 itemnumber => $item->id,
4659 borrowernumber => $patron->borrowernumber
4662 ok( $a, "Found accountline for lost fee" );
4663 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4664 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4665 $a = $a->get_from_storage;
4666 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4670 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4673 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4674 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4676 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4678 my $item = $builder->build_sample_item(
4680 biblionumber => $biblionumber,
4681 library => $library->branchcode,
4682 replacementprice => '42',
4685 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4686 LostItem( $item->itemnumber, 'cli', 0 );
4687 $item->_result->itemlost(1);
4688 $item->_result->itemlost_on( $lost_on );
4689 $item->_result->update();
4691 my $a = Koha::Account::Lines->search(
4693 itemnumber => $item->id,
4694 borrowernumber => $patron->borrowernumber
4698 ok( $a, "Found accountline for lost fee" );
4699 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4700 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4701 $a = $a->get_from_storage;
4702 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4707 subtest 'transferbook tests' => sub {
4711 { C4::Circulation::transferbook({}); }
4712 'Koha::Exceptions::MissingParameter',
4713 'Koha::Patron->store raises an exception on missing params';
4716 { C4::Circulation::transferbook({to_branch=>'anything'}); }
4717 'Koha::Exceptions::MissingParameter',
4718 'Koha::Patron->store raises an exception on missing params';
4721 { C4::Circulation::transferbook({from_branch=>'anything'}); }
4722 'Koha::Exceptions::MissingParameter',
4723 'Koha::Patron->store raises an exception on missing params';
4725 my ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here'});
4726 is( $doreturn, 0, "No return without barcode");
4727 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4728 is( $messages->{BadBarcode}, undef, "No barcode passed means undef BadBarcode" );
4730 ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here',barcode=>'BadBarcode'});
4731 is( $doreturn, 0, "No return without barcode");
4732 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4733 is( $messages->{BadBarcode}, 'BadBarcode', "No barcode passed means undef BadBarcode" );
4737 subtest 'Checkout should correctly terminate a transfer' => sub {
4740 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4741 my $patron_1 = $builder->build_object(
4743 class => 'Koha::Patrons',
4744 value => { branchcode => $library_1->branchcode }
4747 my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } );
4748 my $patron_2 = $builder->build_object(
4750 class => 'Koha::Patrons',
4751 value => { branchcode => $library_2->branchcode }
4755 my $item = $builder->build_sample_item(
4757 library => $library_1->branchcode,
4761 t::lib::Mocks::mock_userenv( { branchcode => $library_1->branchcode } );
4762 my $reserve_id = AddReserve(
4764 branchcode => $library_2->branchcode,
4765 borrowernumber => $patron_2->borrowernumber,
4766 biblionumber => $item->biblionumber,
4767 itemnumber => $item->itemnumber,
4772 my $do_transfer = 1;
4773 ModItemTransfer( $item->itemnumber, $library_1->branchcode,
4774 $library_2->branchcode, 'Manual' );
4775 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
4776 GetOtherReserves( $item->itemnumber )
4777 ; # To put the Reason, it's what does returns.pl...
4778 my $hold = Koha::Holds->find($reserve_id);
4779 is( $hold->found, 'T', 'Hold is in transit' );
4780 my $transfer = $item->get_transfer;
4781 is( $transfer->frombranch, $library_1->branchcode );
4782 is( $transfer->tobranch, $library_2->branchcode );
4783 is( $transfer->reason, 'Reserve' );
4785 t::lib::Mocks::mock_userenv( { branchcode => $library_2->branchcode } );
4786 AddIssue( $patron_1->unblessed, $item->barcode );
4787 $transfer = $transfer->get_from_storage;
4788 isnt( $transfer->datearrived, undef );
4789 $hold = $hold->get_from_storage;
4790 is( $hold->found, undef, 'Hold is waiting' );
4791 is( $hold->priority, 1, );
4794 subtest 'AddIssue records staff who checked out item if appropriate' => sub {
4797 $module->mock( 'userenv', sub { { branch => $library->{id} } } );
4799 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4800 my $patron = $builder->build_object(
4802 class => 'Koha::Patrons',
4803 value => { categorycode => $patron_category->{categorycode} }
4806 my $issuer = $builder->build_object(
4808 class => 'Koha::Patrons',
4809 value => { categorycode => $patron_category->{categorycode} }
4812 my $item = $builder->build_sample_item(
4814 library => $library->{branchcode}
4818 $module->mock( 'userenv', sub { { branch => $library->id, number => $issuer->{borrowernumber} } } );
4820 my $dt_from = dt_from_string();
4821 my $dt_to = dt_from_string()->add( days => 7 );
4823 my $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4825 is( $issue->issuer, undef, "Staff who checked out the item not recorded when RecordStaffUserOnCheckout turned off" );
4827 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 1);
4830 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4832 is( $issue->issuer, $issuer->{borrowernumber}, "Staff who checked out the item recorded when RecordStaffUserOnCheckout turned on" );
4835 subtest "Item's onloan value should be set if checked out item is checked out to a different patron" => sub {
4838 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4839 my $patron_1 = $builder->build_object(
4841 class => 'Koha::Patrons',
4842 value => { branchcode => $library_1->branchcode }
4845 my $patron_2 = $builder->build_object(
4847 class => 'Koha::Patrons',
4848 value => { branchcode => $library_1->branchcode }
4852 my $item = $builder->build_sample_item(
4854 library => $library_1->branchcode,
4858 AddIssue( $patron_1->unblessed, $item->barcode );
4859 ok( $item->get_from_storage->onloan, "Item's onloan column is set after initial checkout" );
4860 AddIssue( $patron_2->unblessed, $item->barcode );
4861 ok( $item->get_from_storage->onloan, "Item's onloan column is set after second checkout" );
4864 subtest "updateWrongTransfer tests" => sub {
4867 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
4868 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
4869 my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
4870 my $item = $builder->build_sample_item(
4872 homebranch => $library1->branchcode,
4873 holdingbranch => $library2->branchcode,
4874 datelastseen => undef
4878 my $transfer = $builder->build_object(
4880 class => 'Koha::Item::Transfers',
4882 itemnumber => $item->itemnumber,
4883 frombranch => $library2->branchcode,
4884 tobranch => $library1->branchcode,
4885 daterequested => dt_from_string,
4886 datesent => dt_from_string,
4887 datecancelled => undef,
4888 datearrived => undef,
4893 is( ref($transfer), 'Koha::Item::Transfer', 'Mock transfer added' );
4895 my $new_transfer = C4::Circulation::updateWrongTransfer($item->itemnumber, $library1->branchcode);
4896 is(ref($new_transfer), 'Koha::Item::Transfer', "updateWrongTransfer returns a 'Koha::Item::Transfer' object");
4897 ok( !$new_transfer->in_transit, "New transfer is NOT created as in transit (or cancelled)");
4899 my $original_transfer = $transfer->get_from_storage;
4900 ok( defined($original_transfer->datecancelled), "Original transfer was cancelled");
4901 is( $original_transfer->cancellation_reason, 'WrongTransfer', "Original transfer cancellation reason is 'WrongTransfer'");
4904 subtest "SendCirculationAlert" => sub {
4907 # Setup branch, borrowr, and notice
4908 my $library = $builder->build_object({ class => 'Koha::Libraries' });
4909 set_userenv( $library->unblessed);
4910 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
4911 C4::Members::Messaging::SetMessagingPreference({
4912 borrowernumber => $patron->id,
4913 message_transport_types => ['email'],
4914 message_attribute_id => 5
4916 my $item = $builder->build_sample_item();
4917 my $checkin_notice = $builder->build_object({
4918 class => 'Koha::Notice::Templates',
4920 module => 'circulation',
4922 branchcode => $library->branchcode,
4923 name => 'Test Checkin',
4925 content => "Checkins:\n----\n[% biblio.title %]-[% old_checkout.issue_id %]\n----Thank you.",
4926 message_transport_type => 'email',
4931 # Checkout an item, mark it returned, generate a notice
4932 my $issue_1 = AddIssue( $patron->unblessed, $item->barcode);
4933 MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0, { skip_record_index => 1} );
4934 C4::Circulation::SendCirculationAlert({
4936 item => $item->unblessed,
4937 borrower => $patron->unblessed,
4938 branch => $library->branchcode,
4941 my $notice = Koha::Notice::Messages->find({ borrowernumber => $patron->id, letter_code => 'CHECKIN' });
4942 is($notice->content,"Checkins:\n".$item->biblio->title."-".$issue_1->id."\nThank you.", 'Letter generated with expected output on first checkin' );
4944 # Checkout an item, mark it returned, generate a notice
4945 my $issue_2 = AddIssue( $patron->unblessed, $item->barcode);
4946 MarkIssueReturned( $patron->borrowernumber, $item->itemnumber, undef, 0, { skip_record_index => 1} );
4947 C4::Circulation::SendCirculationAlert({
4949 item => $item->unblessed,
4950 borrower => $patron->unblessed,
4951 branch => $library->branchcode,
4954 $notice->discard_changes();
4955 is($notice->content,"Checkins:\n".$item->biblio->title."-".$issue_1->id."\n".$item->biblio->title."-".$issue_2->id."\nThank you.", 'Letter appended with expected output on second checkin' );
4959 subtest "GetSoonestRenewDate tests" => sub {
4961 Koha::CirculationRules->set_rule(
4963 categorycode => undef,
4964 branchcode => undef,
4966 rule_name => 'norenewalbefore',
4970 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
4971 my $item = $builder->build_sample_item();
4972 my $issue = AddIssue( $patron->unblessed, $item->barcode);
4973 my $datedue = dt_from_string( $issue->date_due() );
4976 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
4977 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
4979 GetSoonestRenewDate( $patron->id, $item->itemnumber ),
4980 $datedue->clone->add( days => -7 ),
4981 'Bug 14395: Renewals permitted 7 days before due date, as expected'
4985 # Test 'date' setting for syspref NoRenewalBeforePrecision
4986 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
4988 GetSoonestRenewDate( $patron->id, $item->itemnumber ),
4989 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
4990 'Bug 14395: Renewals permitted 7 days before due date, as expected'
4994 Koha::CirculationRules->set_rule(
4996 categorycode => undef,
4997 branchcode => undef,
4999 rule_name => 'norenewalbefore',
5000 rule_value => undef,
5005 GetSoonestRenewDate( $patron->id, $item->itemnumber ),
5007 'Checkouts without auto-renewal can be renewed immediately if no norenewalbefore'
5010 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
5011 $issue->auto_renew(1)->store;
5013 GetSoonestRenewDate( $patron->id, $item->itemnumber ),
5014 $datedue->clone->truncate( to => 'day' ),
5015 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
5017 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact' );
5019 GetSoonestRenewDate( $patron->id, $item->itemnumber ),
5021 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore'
5025 $schema->storage->txn_rollback;
5026 C4::Context->clear_syspref_cache();
5027 $branches = Koha::Libraries->search();
5028 for my $branch ( $branches->next ) {
5029 my $key = $branch->branchcode . "_holidays";
5030 $cache->clear_from_cache($key);