10 use Test::More tests => 6;
12 use t::lib::TestBuilder;
16 use_ok('C4::Reserves');
19 my $schema = Koha::Database->schema;
20 $schema->storage->txn_begin;
21 my $dbh = C4::Context->dbh;
23 my $builder = t::lib::TestBuilder->new;
25 my $library1 = $builder->build({
28 my $library2 = $builder->build({
33 t::lib::Mocks::mock_userenv({ branchcode => $library1->{branchcode} });
35 my $bib_title = "Test Title";
37 my $borrower1 = $builder->build({
40 branchcode => $library1->{branchcode},
41 dateexpiry => '3000-01-01',
45 my $borrower2 = $builder->build({
48 branchcode => $library1->{branchcode},
49 dateexpiry => '3000-01-01',
53 # Test hold_fulfillment_policy
54 my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes LIMIT 1") };
55 my $borrowernumber1 = $borrower1->{borrowernumber};
56 my $borrowernumber2 = $borrower2->{borrowernumber};
57 my $library_A = $library1->{branchcode};
58 my $library_B = $library2->{branchcode};
60 $dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$bib_title', '2011-02-01')");
62 my $biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$bib_title'")
63 or BAIL_OUT("Cannot find newly created biblio record");
65 $dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
67 my $biblioitemnumber =
68 $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
69 or BAIL_OUT("Cannot find newly created biblioitems record");
72 INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype)
73 VALUES ('AllowHoldIf1', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype')
77 $dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber")
78 or BAIL_OUT("Cannot find newly created item");
80 my $item1 = GetItem( $itemnumber1 );
83 INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype)
84 VALUES ('AllowHoldIf2', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype')
88 $dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber ORDER BY itemnumber DESC")
89 or BAIL_OUT("Cannot find newly created item");
91 my $item2 = GetItem( $itemnumber2 );
93 $dbh->do("DELETE FROM issuingrules");
94 my $rule = Koha::IssuingRule->new(
102 reservesallowed => 99,
108 my $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
109 is( $is, 0, "Item cannot be held, 2 items available" );
111 my $issue1 = AddIssue( $borrower2, $item1->{barcode} );
113 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
114 is( $is, 0, "Item cannot be held, 1 item available" );
116 AddIssue( $borrower2, $item2->{barcode} );
118 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
119 is( $is, 1, "Item can be held, no items available" );
121 AddReturn( $item1->{barcode} );
123 { # Remove the issue for the first patron, and modify the branch for item1
124 subtest 'IsAvailableForItemLevelRequest behaviours depending on ReservesControlBranch + holdallowed' => sub {
127 my $hold_allowed_from_home_library = 1;
128 my $hold_allowed_from_any_libraries = 2;
129 my $sth_delete_rules = $dbh->prepare(q|DELETE FROM default_circ_rules|);
130 my $sth_insert_rule = $dbh->prepare(q|INSERT INTO default_circ_rules(singleton, maxissueqty, maxonsiteissueqty, holdallowed, hold_fulfillment_policy, returnbranch) VALUES ('singleton', NULL, NULL, ?, 'any', 'homebranch');|);
132 subtest 'Item is available at a different library' => sub {
135 Koha::Items->find( $item1->{itemnumber} )->set({homebranch => $library_B, holdingbranch => $library_B })->store;
136 $item1 = GetItem( $itemnumber1 );
138 #One shelf holds is 'If all unavailable'/2
139 #Item 1 homebranch library B is available
140 #Item 2 homebranch library A is checked out
141 #Borrower1 is from library A
142 #CircControl has no effect - same rule for all branches as set at line 96
143 #FIXME: ReservesControlBranch is not checked in these subs we are testing
146 $sth_delete_rules->execute;
147 $sth_insert_rule->execute( $hold_allowed_from_home_library );
149 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
150 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
151 is( $is, 1, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" );
153 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
154 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
155 is( $is, 1, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" );
159 $sth_delete_rules->execute;
160 $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
162 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
163 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
164 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" );
166 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
167 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
168 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" );
172 subtest 'Item is available at the same library' => sub {
175 Koha::Items->find( $item1->{itemnumber} )->set({homebranch => $library_A, holdingbranch => $library_A })->store;
176 $item1 = GetItem( $itemnumber1 );
178 #One shelf holds is 'If all unavailable'/2
179 #Item 1 homebranch library A is available
180 #Item 2 homebranch library A is checked out
181 #Borrower1 is from library A
182 #CircControl has no effect - same rule for all branches as set at line 96
183 #ReservesControlBranch is not checked in these subs we are testing?
186 $sth_delete_rules->execute;
187 $sth_insert_rule->execute( $hold_allowed_from_home_library );
189 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
190 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
191 is( $is, 0, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
193 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
194 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
195 is( $is, 0, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
199 $sth_delete_rules->execute;
200 $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
202 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
203 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
204 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
206 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
207 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
208 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
214 my $biblio = $builder->build({
218 my $item3 = $builder->build({
221 biblionumber => $biblio->{biblionumber},
230 my $hold = $builder->build({
233 itemnumber => $item3->{itemnumber},
238 $dbh->do("DELETE FROM issuingrules");
239 $rule = Koha::IssuingRule->new(
247 reservesallowed => 99,
253 $is = IsAvailableForItemLevelRequest( $item3, $borrower1);
254 is( $is, 1, "Item can be held, items in transit are not available" );
257 $schema->storage->txn_rollback;