10 use Test::More tests => 22;
18 use lib $FindBin::Bin;
19 use_ok('C4::Reserves');
22 my $dbh = C4::Context->dbh;
25 $dbh->{AutoCommit} = 0;
26 $dbh->{RaiseError} = 1;
28 my $borrowers_count = 5;
30 # Setup Test------------------------
32 diag("Creating biblio instance for testing.");
33 my ($bibnum, $title, $bibitemnum) = create_helper_biblio();
35 # Helper item for that biblio.
36 diag("Creating item instance for testing.");
37 my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
39 # Create some borrowers
41 foreach (1..$borrowers_count) {
42 my $borrowernumber = AddMember(
43 firstname => 'my firstname',
44 surname => 'my surname ' . $_,
48 push @borrowernumbers, $borrowernumber;
51 my $biblionumber = $bibnum;
53 my @branches = GetBranchesLoop();
54 my $branch = $branches[0][0]{value};
56 # Create five item level holds
57 foreach my $borrowernumber ( @borrowernumbers ) {
69 my $checkitem = $itemnumber,
75 my ($count, $reserves) = GetReservesFromBiblionumber($biblionumber);
76 is( $count, $borrowers_count, "Test GetReserves()" );
79 my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
80 ok($reserve_id, "Test GetReservesFromItemnumber()");
83 my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
84 ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
87 ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
90 CancelReserve({ 'reserve_id' => $reserve_id });
91 ($count, $reserves) = GetReservesFromBiblionumber($biblionumber);
92 ok( $count == $borrowers_count - 1, "Test CancelReserve()" );
95 ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
97 reserve_id => $reserve_id,
99 branchcode => $branch,
100 itemnumber => $itemnumber,
101 suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
103 $reserve = GetReserve( $reserve_id );
104 ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
105 ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
106 ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
108 ToggleSuspend( $reserve_id );
109 $reserve = GetReserve( $reserve_id );
110 ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
112 ToggleSuspend( $reserve_id, '2012-01-01' );
113 $reserve = GetReserve( $reserve_id );
114 ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
116 AutoUnsuspendReserves();
117 $reserve = GetReserve( $reserve_id );
118 ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
120 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
125 my $constraint = 'a',
135 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
136 my $reserveid = C4::Reserves::GetReserveId(
138 biblionumber => $biblionumber,
139 borrowernumber => $borrowernumber
142 is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
143 ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
144 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
145 ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
148 my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
149 ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
152 ($count, $reserves) = GetReservesFromBiblionumber($biblionumber,1);
153 $reserve = $reserves->[1];
154 AlterPriority( 'top', $reserve->{'reserve_id'} );
155 $reserve = GetReserve( $reserve->{'reserve_id'} );
156 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
158 AlterPriority( 'down', $reserve->{'reserve_id'} );
159 $reserve = GetReserve( $reserve->{'reserve_id'} );
160 ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
162 AlterPriority( 'up', $reserve->{'reserve_id'} );
163 $reserve = GetReserve( $reserve->{'reserve_id'} );
164 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
166 AlterPriority( 'bottom', $reserve->{'reserve_id'} );
167 $reserve = GetReserve( $reserve->{'reserve_id'} );
168 ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
170 # Regression test for bug 2394
172 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
173 # a patron is not permittedo to request an item whose homebranch (i.e.,
174 # owner of the item) is different from the patron's own library.
175 # However, if canreservefromotherbranches is turned ON, the patron can
176 # create such hold requests.
178 # Note that canreservefromotherbranches has no effect if
179 # IndependentBranches is OFF.
181 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio();
182 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
183 = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
184 $dbh->do('DELETE FROM issuingrules');
186 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
187 VALUES (?, ?, ?, ?)},
192 # make sure some basic sysprefs are set
193 t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
194 t::lib::Mocks::mock_preference('item-level_itypes', 1);
196 # if IndependentBranches is OFF, a CPL patron can reserve an MPL item
197 t::lib::Mocks::mock_preference('IndependentBranches', 0);
199 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
200 'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
203 # if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
204 t::lib::Mocks::mock_preference('IndependentBranches', 1);
205 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
207 ! CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
208 'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
211 # ... unless canreservefromotherbranches is ON
212 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
214 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
215 '... unless canreservefromotherbranches is ON (bug 2394)'
218 # Helper method to set up a Biblio.
219 sub create_helper_biblio {
220 my $bib = MARC::Record->new();
221 my $title = 'Silence in the library';
223 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
224 MARC::Field->new('245', ' ', ' ', a => $title),
226 return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');