9 use Test::More tests => 49;
18 use Koha::DateUtils qw( dt_from_string output_pref );
22 use lib $FindBin::Bin;
23 use_ok('C4::Reserves');
26 my $dbh = C4::Context->dbh;
29 $dbh->{AutoCommit} = 0;
30 $dbh->{RaiseError} = 1;
32 my $borrowers_count = 5;
34 $dbh->do('DELETE FROM itemtypes');
35 $dbh->do('DELETE FROM reserves');
36 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
37 $insert_sth->execute('CAN');
38 $insert_sth->execute('CANNOT');
39 $insert_sth->execute('DUMMY');
41 # Setup Test------------------------
42 # Create a biblio instance for testing
43 my ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
45 # Create item instance for testing.
46 my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
48 # Create some borrowers
50 foreach (1..$borrowers_count) {
51 my $borrowernumber = AddMember(
52 firstname => 'my firstname',
53 surname => 'my surname ' . $_,
57 push @borrowernumbers, $borrowernumber;
60 my $biblionumber = $bibnum;
62 my @branches = GetBranchesLoop();
63 my $branch = $branches[0][0]{value};
65 # Create five item level holds
66 foreach my $borrowernumber ( @borrowernumbers ) {
78 my $checkitem = $itemnumber,
84 my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
85 is( scalar(@$reserves), $borrowers_count, "Test GetReserves()" );
88 my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
89 is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "GetReservesFromItemnumber should return a valid reserve date");
90 is( $borrowernumber, $borrowernumbers[0], "GetReservesFromItemnumber should return a valid borrowernumber");
91 is( $branchcode, 'CPL', "GetReservesFromItemnumber should return a valid branchcode");
92 ok($reserve_id, "Test GetReservesFromItemnumber()");
94 my $hold = Koha::Holds->find( $reserve_id );
95 ok( $hold, "Koha::Holds found the hold" );
96 my $hold_biblio = $hold->biblio();
97 ok( $hold_biblio, "Got biblio using biblio() method" );
98 ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
99 my $hold_item = $hold->item();
100 ok( $hold_item, "Got item using item() method" );
101 ok( $hold_item == $hold->item(), "item method returns stashed item" );
102 my $hold_branch = $hold->branch();
103 ok( $hold_branch, "Got branch using branch() method" );
104 ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
105 my $hold_found = $hold->found();
106 $hold->set({ found => 'W'})->store();
107 is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
109 my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
110 ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
113 ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
116 CancelReserve({ 'reserve_id' => $reserve_id });
117 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
118 is( scalar(@$reserves), $borrowers_count - 1, "Test CancelReserve()" );
121 ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
123 reserve_id => $reserve_id,
125 branchcode => $branch,
126 itemnumber => $itemnumber,
127 suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
129 $reserve = GetReserve( $reserve_id );
130 ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
131 ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
132 ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
134 ToggleSuspend( $reserve_id );
135 $reserve = GetReserve( $reserve_id );
136 ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
138 ToggleSuspend( $reserve_id, '2012-01-01' );
139 $reserve = GetReserve( $reserve_id );
140 ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
142 AutoUnsuspendReserves();
143 $reserve = GetReserve( $reserve_id );
144 ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
146 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
151 my $constraint = 'a',
161 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
162 my $reserveid = C4::Reserves::GetReserveId(
164 biblionumber => $biblionumber,
165 borrowernumber => $borrowernumber
168 is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
169 ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
170 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
171 ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
174 my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
175 ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
178 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
179 $reserve = $reserves->[1];
180 AlterPriority( 'top', $reserve->{'reserve_id'} );
181 $reserve = GetReserve( $reserve->{'reserve_id'} );
182 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
184 AlterPriority( 'down', $reserve->{'reserve_id'} );
185 $reserve = GetReserve( $reserve->{'reserve_id'} );
186 ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
188 AlterPriority( 'up', $reserve->{'reserve_id'} );
189 $reserve = GetReserve( $reserve->{'reserve_id'} );
190 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
192 AlterPriority( 'bottom', $reserve->{'reserve_id'} );
193 $reserve = GetReserve( $reserve->{'reserve_id'} );
194 ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
196 # Regression test for bug 2394
198 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
199 # a patron is not permittedo to request an item whose homebranch (i.e.,
200 # owner of the item) is different from the patron's own library.
201 # However, if canreservefromotherbranches is turned ON, the patron can
202 # create such hold requests.
204 # Note that canreservefromotherbranches has no effect if
205 # IndependentBranches is OFF.
207 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio('DUMMY');
208 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
209 = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
210 $dbh->do('DELETE FROM issuingrules');
212 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
213 VALUES (?, ?, ?, ?)},
218 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
219 VALUES (?, ?, ?, ?)},
221 '*', '*', 'CANNOT', 0
224 # make sure some basic sysprefs are set
225 t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
226 t::lib::Mocks::mock_preference('item-level_itypes', 1);
228 # if IndependentBranches is OFF, a CPL patron can reserve an MPL item
229 t::lib::Mocks::mock_preference('IndependentBranches', 0);
231 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
232 'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
235 # if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
236 t::lib::Mocks::mock_preference('IndependentBranches', 1);
237 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
239 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'cannotReserveFromOtherBranches',
240 'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
243 # ... unless canreservefromotherbranches is ON
244 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
246 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
247 '... unless canreservefromotherbranches is ON (bug 2394)'
250 # Regression test for bug 11336
251 ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
252 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
262 my $reserveid1 = C4::Reserves::GetReserveId(
264 biblionumber => $bibnum,
265 borrowernumber => $borrowernumbers[0]
269 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
278 my $reserveid2 = C4::Reserves::GetReserveId(
280 biblionumber => $bibnum,
281 borrowernumber => $borrowernumbers[1]
285 CancelReserve({ reserve_id => $reserveid1 });
287 $reserve2 = GetReserve( $reserveid2 );
288 is( $reserve2->{priority}, 1, "After cancelreserve, the 2nd reserve becomes the first on the waiting list" );
290 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
299 my $reserveid3 = C4::Reserves::GetReserveId(
301 biblionumber => $bibnum,
302 borrowernumber => $borrowernumbers[0]
306 my $reserve3 = GetReserve( $reserveid3 );
307 is( $reserve3->{priority}, 2, "New reserve for patron 0, the reserve has a priority = 2" );
309 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
310 $reserve3 = GetReserve( $reserveid3 );
311 is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
313 ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
314 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 );
315 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
316 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
317 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 );
318 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
319 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
321 # Regression test for bug 9532
322 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
323 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
333 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
334 "cannot request item if policy that matches on item-level item type forbids it"
336 ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
338 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK',
339 "can request item if policy that matches on item type allows it"
342 t::lib::Mocks::mock_preference('item-level_itypes', 0);
343 ModItem({ itype => undef }, $item_bibnum, $itemnumber);
345 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
346 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
350 # Test branch item rules
352 $dbh->do('DELETE FROM issuingrules');
354 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
355 VALUES (?, ?, ?, ?)},
359 $dbh->do('DELETE FROM branch_item_rules');
360 $dbh->do('DELETE FROM default_branch_circ_rules');
361 $dbh->do('DELETE FROM default_branch_item_rules');
362 $dbh->do('DELETE FROM default_circ_rules');
364 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
366 }, {}, 'CPL', 'CANNOT', 0, 'homebranch');
368 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
370 }, {}, 'CPL', 'CAN', 1, 'homebranch');
371 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
372 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
373 { homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
374 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'notReservable',
375 "CanItemBeReserved should returns 'notReservable'");
377 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
378 { homebranch => 'MPL', holdingbranch => 'CPL', itype => 'CAN' } , $bibnum);
379 is(CanItemBeReserved($borrowernumbers[0], $itemnumber),
380 'cannotReserveFromOtherBranches',
381 "CanItemBeReserved should returns 'cannotReserveFromOtherBranches'");
383 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
384 { homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CAN' } , $bibnum);
385 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'OK',
386 "CanItemBeReserved should returns 'OK'");
389 # Test CancelExpiredReserves
390 C4::Context->set_preference('ExpireReservesMaxPickUpDelay', 1);
391 C4::Context->set_preference('ReservesMaxPickUpDelay', 1);
393 my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst ) = localtime(time);
396 $reserves = $dbh->selectall_arrayref('SELECT * FROM reserves', { Slice => {} });
397 $reserve = $reserves->[0];
398 my $calendar = C4::Calendar->new(branchcode => $reserve->{branchcode});
399 $calendar->insert_single_holiday(
404 description => 'Test',
406 $reserve_id = $reserve->{reserve_id};
407 $dbh->do("UPDATE reserves SET waitingdate = DATE_SUB( NOW(), INTERVAL 5 DAY ), found = 'W', priority = 0 WHERE reserve_id = ?", undef, $reserve_id );
408 C4::Context->set_preference('ExpireReservesOnHolidays', 0);
409 CancelExpiredReserves();
410 my $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
411 is( $count, 1, "Waiting reserve beyond max pickup delay *not* canceled on holiday" );
412 C4::Context->set_preference('ExpireReservesOnHolidays', 1);
413 CancelExpiredReserves();
414 $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
415 is( $count, 0, "Waiting reserve beyond max pickup delay canceled on holiday" );
417 # Test expirationdate
418 $reserve = $reserves->[1];
419 $reserve_id = $reserve->{reserve_id};
420 $dbh->do("UPDATE reserves SET expirationdate = DATE_SUB( NOW(), INTERVAL 1 DAY ) WHERE reserve_id = ?", undef, $reserve_id );
421 CancelExpiredReserves();
422 $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
423 is( $count, 0, "Reserve with manual expiration date canceled correctly" );
425 # Helper method to set up a Biblio.
426 sub create_helper_biblio {
427 my $itemtype = shift;
428 my $bib = MARC::Record->new();
429 my $title = 'Silence in the library';
431 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
432 MARC::Field->new('245', ' ', ' ', a => $title),
433 MARC::Field->new('942', ' ', ' ', c => $itemtype),
435 return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');