3 # Copyright 2015 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 31;
37 use Koha::Patron::Categories;
40 use Koha::Virtualshelves;
42 use t::lib::TestBuilder;
45 my $schema = Koha::Database->new->schema;
46 $schema->storage->txn_begin;
48 my $builder = t::lib::TestBuilder->new;
49 my $library = $builder->build({source => 'Branch' });
50 my $category = $builder->build({source => 'Category' });
51 my $nb_of_patrons = Koha::Patrons->search->count;
52 my $new_patron_1 = Koha::Patron->new(
53 { cardnumber => 'test_cn_1',
54 branchcode => $library->{branchcode},
55 categorycode => $category->{categorycode},
56 surname => 'surname for patron1',
57 firstname => 'firstname for patron1',
58 userid => 'a_nonexistent_userid_1',
59 flags => 1, # Is superlibrarian
62 my $new_patron_2 = Koha::Patron->new(
63 { cardnumber => 'test_cn_2',
64 branchcode => $library->{branchcode},
65 categorycode => $category->{categorycode},
66 surname => 'surname for patron2',
67 firstname => 'firstname for patron2',
68 userid => 'a_nonexistent_userid_2',
72 C4::Context->_new_userenv('xxx');
73 set_logged_in_user( $new_patron_1 );
75 is( Koha::Patrons->search->count, $nb_of_patrons + 2, 'The 2 patrons should have been added' );
77 my $retrieved_patron_1 = Koha::Patrons->find( $new_patron_1->borrowernumber );
78 is( $retrieved_patron_1->cardnumber, $new_patron_1->cardnumber, 'Find a patron by borrowernumber should return the correct patron' );
80 subtest 'library' => sub {
82 is( $retrieved_patron_1->library->branchcode, $library->{branchcode}, 'Koha::Patron->library should return the correct library' );
83 is( ref($retrieved_patron_1->library), 'Koha::Library', 'Koha::Patron->library should return a Koha::Library object' );
86 subtest 'guarantees' => sub {
88 my $guarantees = $new_patron_1->guarantees;
89 is( ref($guarantees), 'Koha::Patrons', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
90 is( $guarantees->count, 0, 'new_patron_1 should have 0 guarantee' );
91 my @guarantees = $new_patron_1->guarantees;
92 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantees should return an array in a list context' );
93 is( scalar(@guarantees), 0, 'new_patron_1 should have 0 guarantee' );
95 my $guarantee_1 = $builder->build({ source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber }});
96 my $guarantee_2 = $builder->build({ source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber }});
98 $guarantees = $new_patron_1->guarantees;
99 is( ref($guarantees), 'Koha::Patrons', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
100 is( $guarantees->count, 2, 'new_patron_1 should have 2 guarantees' );
101 @guarantees = $new_patron_1->guarantees;
102 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantees should return an array in a list context' );
103 is( scalar(@guarantees), 2, 'new_patron_1 should have 2 guarantees' );
104 $_->delete for @guarantees;
107 subtest 'category' => sub {
109 my $patron_category = $new_patron_1->category;
110 is( ref( $patron_category), 'Koha::Patron::Category', );
111 is( $patron_category->categorycode, $category->{categorycode}, );
114 subtest 'siblings' => sub {
116 my $siblings = $new_patron_1->siblings;
117 is( $siblings, undef, 'Koha::Patron->siblings should not crashed if the patron has no guarantor' );
118 my $guarantee_1 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
119 my $retrieved_guarantee_1 = Koha::Patrons->find($guarantee_1);
120 $siblings = $retrieved_guarantee_1->siblings;
121 is( ref($siblings), 'Koha::Patrons', 'Koha::Patron->siblings should return a Koha::Patrons result set in a scalar context' );
122 my @siblings = $retrieved_guarantee_1->siblings;
123 is( ref( \@siblings ), 'ARRAY', 'Koha::Patron->siblings should return an array in a list context' );
124 is( $siblings->count, 0, 'guarantee_1 should not have siblings yet' );
125 my $guarantee_2 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
126 my $guarantee_3 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
127 $siblings = $retrieved_guarantee_1->siblings;
128 is( $siblings->count, 2, 'guarantee_1 should have 2 siblings' );
129 is( $guarantee_2->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_2 should exist in the guarantees' );
130 is( $guarantee_3->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_3 should exist in the guarantees' );
131 $_->delete for $retrieved_guarantee_1->siblings;
132 $retrieved_guarantee_1->delete;
135 subtest 'has_overdues' => sub {
138 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
139 my $item_1 = $builder->build(
142 homebranch => $library->{branchcode},
143 holdingbranch => $library->{branchcode},
147 biblionumber => $biblioitem_1->{biblionumber}
151 my $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
152 is( $retrieved_patron->has_overdues, 0, );
154 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
155 my $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $tomorrow, branchcode => $library->{branchcode} })->store();
156 is( $retrieved_patron->has_overdues, 0, );
158 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
159 $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $yesterday, branchcode => $library->{branchcode} })->store();
160 $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
161 is( $retrieved_patron->has_overdues, 1, );
165 subtest 'update_password' => sub {
168 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
169 my $original_userid = $new_patron_1->userid;
170 my $original_password = $new_patron_1->password;
171 warning_like { $retrieved_patron_1->update_password( $new_patron_2->userid, 'another_password' ) }
173 'Koha::Patron->update_password should warn if the userid is already used by another patron';
174 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->userid, $original_userid, 'Koha::Patron->update_password should not have updated the userid' );
175 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->password, $original_password, 'Koha::Patron->update_password should not have updated the userid' );
177 $retrieved_patron_1->update_password( 'another_nonexistent_userid_1', 'another_password' );
178 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->userid, 'another_nonexistent_userid_1', 'Koha::Patron->update_password should have updated the userid' );
179 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->password, 'another_password', 'Koha::Patron->update_password should have updated the password' );
181 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $new_patron_1->borrowernumber } )->count;
182 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->update_password should have logged' );
184 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
185 $retrieved_patron_1->update_password( 'yet_another_nonexistent_userid_1', 'another_password' );
186 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $new_patron_1->borrowernumber } )->count;
187 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->update_password should not have logged' );
190 subtest 'is_expired' => sub {
192 my $patron = $builder->build({ source => 'Borrower' });
193 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
194 $patron->dateexpiry( undef )->store->discard_changes;
195 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is not set');
196 $patron->dateexpiry( dt_from_string )->store->discard_changes;
197 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is today');
198 $patron->dateexpiry( dt_from_string->add( days => 1 ) )->store->discard_changes;
199 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is tomorrow');
200 $patron->dateexpiry( dt_from_string->add( days => -1 ) )->store->discard_changes;
201 is( $patron->is_expired, 1, 'Patron should be considered expired if dateexpiry is yesterday');
206 subtest 'is_going_to_expire' => sub {
208 my $patron = $builder->build({ source => 'Borrower' });
209 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
210 $patron->dateexpiry( undef )->store->discard_changes;
211 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is not set');
213 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
214 $patron->dateexpiry( dt_from_string )->store->discard_changes;
215 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today');
217 $patron->dateexpiry( dt_from_string )->store->discard_changes;
218 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today and pref is 0');
220 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
221 $patron->dateexpiry( dt_from_string->add( days => 11 ) )->store->discard_changes;
222 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 11 days ahead and pref is 10');
224 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
225 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
226 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 0');
228 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
229 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
230 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 10');
233 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
234 $patron->dateexpiry( dt_from_string->add( days => 20 ) )->store->discard_changes;
235 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 20 days ahead and pref is 10');
237 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 20);
238 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
239 is( $patron->is_going_to_expire, 1, 'Patron should be considered going to expire if dateexpiry is 10 days ahead and pref is 20');
245 subtest 'renew_account' => sub {
248 for my $date ( '2016-03-31', '2016-11-30', dt_from_string() ) {
249 my $dt = dt_from_string( $date, 'iso' );
250 Time::Fake->offset( $dt->epoch );
251 my $a_month_ago = $dt->clone->subtract( months => 1, end_of_month => 'limit' )->truncate( to => 'day' );
252 my $a_year_later = $dt->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
253 my $a_year_later_minus_a_month = $dt->clone->add( months => 11, end_of_month => 'limit' )->truncate( to => 'day' );
254 my $a_month_later = $dt->clone->add( months => 1 , end_of_month => 'limit' )->truncate( to => 'day' );
255 my $a_year_later_plus_a_month = $dt->clone->add( months => 13, end_of_month => 'limit' )->truncate( to => 'day' );
256 my $patron_category = $builder->build(
257 { source => 'Category',
259 enrolmentperiod => 12,
260 enrolmentperioddate => undef,
264 my $patron = $builder->build(
265 { source => 'Borrower',
267 dateexpiry => $a_month_ago,
268 categorycode => $patron_category->{categorycode},
269 date_renewed => undef, # Force builder to not populate the column for new patron
273 my $patron_2 = $builder->build(
274 { source => 'Borrower',
276 dateexpiry => $a_month_ago,
277 categorycode => $patron_category->{categorycode},
281 my $patron_3 = $builder->build(
282 { source => 'Borrower',
284 dateexpiry => $a_month_later,
285 categorycode => $patron_category->{categorycode},
289 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
290 my $retrieved_patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} );
291 my $retrieved_patron_3 = Koha::Patrons->find( $patron_3->{borrowernumber} );
293 is( $retrieved_patron->date_renewed, undef, "Date renewed is not set for patrons that have never been renewed" );
295 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'dateexpiry' );
296 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
297 my $expiry_date = $retrieved_patron->renew_account;
298 is( $expiry_date, $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
299 my $retrieved_expiry_date = Koha::Patrons->find( $patron->{borrowernumber} )->dateexpiry;
300 is( dt_from_string($retrieved_expiry_date), $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
301 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
302 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->renew_account should have logged' );
304 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' );
305 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
306 $expiry_date = $retrieved_patron->renew_account;
307 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
308 $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
309 is( $retrieved_patron->date_renewed, output_pref({ dt => $dt, dateformat => 'iso', dateonly => 1 }), "Date renewed is set when calling renew_account" );
310 $retrieved_expiry_date = $retrieved_patron->dateexpiry;
311 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
312 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
313 is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' );
315 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' );
316 $expiry_date = $retrieved_patron_2->renew_account;
317 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
318 $retrieved_expiry_date = Koha::Patrons->find( $patron_2->{borrowernumber} )->dateexpiry;
319 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
321 $expiry_date = $retrieved_patron_3->renew_account;
322 is( $expiry_date, $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
323 $retrieved_expiry_date = Koha::Patrons->find( $patron_3->{borrowernumber} )->dateexpiry;
324 is( dt_from_string($retrieved_expiry_date), $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
326 $retrieved_patron->delete;
327 $retrieved_patron_2->delete;
328 $retrieved_patron_3->delete;
333 subtest "move_to_deleted" => sub {
335 my $originally_updated_on = '2016-01-01 12:12:12';
336 my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } );
337 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
338 is( ref( $retrieved_patron->move_to_deleted ), 'Koha::Schema::Result::Deletedborrower', 'Koha::Patron->move_to_deleted should return the Deleted patron' )
339 ; # FIXME This should be Koha::Deleted::Patron
340 my $deleted_patron = $schema->resultset('Deletedborrower')
341 ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } )
343 ok( $retrieved_patron->updated_on, 'updated_on should be set for borrowers table' );
344 ok( $deleted_patron->{updated_on}, 'updated_on should be set for deleted_borrowers table' );
345 isnt( $deleted_patron->{updated_on}, $retrieved_patron->updated_on, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column');
346 $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields
347 is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' );
348 $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup
351 subtest "delete" => sub {
353 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
354 my $patron = $builder->build( { source => 'Borrower' } );
355 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
356 my $hold = $builder->build(
357 { source => 'Reserve',
358 value => { borrowernumber => $patron->{borrowernumber} }
361 my $list = $builder->build(
362 { source => 'Virtualshelve',
363 value => { owner => $patron->{borrowernumber} }
367 my $deleted = $retrieved_patron->delete;
368 is( $deleted, 1, 'Koha::Patron->delete should return 1 if the patron has been correctly deleted' );
370 is( Koha::Patrons->find( $patron->{borrowernumber} ), undef, 'Koha::Patron->delete should have deleted the patron' );
372 is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's holds| );
374 is( Koha::Virtualshelves->search( { owner => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's lists| );
376 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'DELETE', object => $retrieved_patron->borrowernumber } )->count;
377 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->delete should have logged' );
380 subtest 'add_enrolment_fee_if_needed' => sub {
383 my $enrolmentfees = { K => 5, J => 10, YA => 20 };
384 foreach( keys %{$enrolmentfees} ) {
385 ( Koha::Patron::Categories->find( $_ ) // $builder->build_object({ class => 'Koha::Patron::Categories', value => { categorycode => $_ } }) )->enrolmentfee( $enrolmentfees->{$_} )->store;
387 my $enrolmentfee_K = $enrolmentfees->{K};
388 my $enrolmentfee_J = $enrolmentfees->{J};
389 my $enrolmentfee_YA = $enrolmentfees->{YA};
391 my %borrower_data = (
392 firstname => 'my firstname',
393 surname => 'my surname',
395 branchcode => $library->{branchcode},
398 my $borrowernumber = C4::Members::AddMember(%borrower_data);
399 $borrower_data{borrowernumber} = $borrowernumber;
401 my $patron = Koha::Patrons->find( $borrowernumber );
402 my $total = $patron->account->balance;
403 is( int($total), int($enrolmentfee_K), "New kid pay $enrolmentfee_K" );
405 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 0 );
406 $borrower_data{categorycode} = 'J';
407 C4::Members::ModMember(%borrower_data);
408 $total = $patron->account->balance;
409 is( int($total), int($enrolmentfee_K), "Kid growing and become a juvenile, but shouldn't pay for the upgrade " );
411 $borrower_data{categorycode} = 'K';
412 C4::Members::ModMember(%borrower_data);
413 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 1 );
415 $borrower_data{categorycode} = 'J';
416 C4::Members::ModMember(%borrower_data);
417 $total = $patron->account->balance;
418 is( int($total), int($enrolmentfee_K + $enrolmentfee_J), "Kid growing and become a juvenile, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) );
420 # Check with calling directly Koha::Patron->get_enrolment_fee_if_needed
421 $patron->categorycode('YA')->store;
422 my $fee = $patron->add_enrolment_fee_if_needed;
423 $total = $patron->account->balance;
425 int($enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA),
426 "Juvenile growing and become an young adult, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA )
432 subtest 'checkouts + pending_checkouts + get_overdues + old_checkouts' => sub {
435 my $library = $builder->build( { source => 'Branch' } );
436 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
437 my $item_1 = $builder->build(
441 homebranch => $library->{branchcode},
442 holdingbranch => $library->{branchcode},
443 biblionumber => $biblionumber_1,
449 my $item_2 = $builder->build(
453 homebranch => $library->{branchcode},
454 holdingbranch => $library->{branchcode},
455 biblionumber => $biblionumber_1,
461 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
462 my $item_3 = $builder->build(
466 homebranch => $library->{branchcode},
467 holdingbranch => $library->{branchcode},
468 biblionumber => $biblionumber_2,
474 my $patron = $builder->build(
476 source => 'Borrower',
477 value => { branchcode => $library->{branchcode} }
481 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
482 my $checkouts = $patron->checkouts;
483 is( $checkouts->count, 0, 'checkouts should not return any issues for that patron' );
484 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
485 my $pending_checkouts = $patron->pending_checkouts;
486 is( $pending_checkouts->count, 0, 'pending_checkouts should not return any issues for that patron' );
487 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
488 my $old_checkouts = $patron->old_checkouts;
489 is( $old_checkouts->count, 0, 'old_checkouts should not return any issues for that patron' );
490 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
492 # Not sure how this is useful, but AddIssue pass this variable to different other subroutines
493 $patron = Koha::Patrons->find( $patron->borrowernumber )->unblessed;
495 my $module = new Test::MockModule('C4::Context');
496 $module->mock( 'userenv', sub { { branch => $library->{branchcode} } } );
498 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
499 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
500 AddIssue( $patron, $item_3->{barcode} );
502 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
503 $checkouts = $patron->checkouts;
504 is( $checkouts->count, 3, 'checkouts should return 3 issues for that patron' );
505 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
506 $pending_checkouts = $patron->pending_checkouts;
507 is( $pending_checkouts->count, 3, 'pending_checkouts should return 3 issues for that patron' );
508 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
510 my $first_checkout = $pending_checkouts->next;
511 is( $first_checkout->unblessed_all_relateds->{biblionumber}, $item_3->{biblionumber}, 'pending_checkouts should prefetch values from other tables (here biblio)' );
513 my $overdues = $patron->get_overdues;
514 is( $overdues->count, 2, 'Patron should have 2 overdues');
515 is( ref($overdues), 'Koha::Checkouts', 'Koha::Patron->get_overdues should return Koha::Checkouts' );
516 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
517 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
520 C4::Circulation::AddReturn( $item_1->{barcode} );
521 C4::Circulation::AddReturn( $item_2->{barcode} );
522 $old_checkouts = $patron->old_checkouts;
523 is( $old_checkouts->count, 2, 'old_checkouts should return 2 old checkouts that patron' );
524 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
527 Koha::Checkouts->search( { borrowernumber => $patron->borrowernumber } )->delete;
529 $module->unmock('userenv');
532 subtest 'get_routinglists' => sub {
535 my $biblio = Koha::Biblio->new()->store();
536 my $subscription = Koha::Subscription->new({
537 biblionumber => $biblio->biblionumber,
541 my $patron = $builder->build( { source => 'Borrower' } );
542 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
544 is( $patron->get_routinglists, 0, 'Retrieves correct number of routing lists: 0' );
546 my $routinglist_count = Koha::Subscription::Routinglists->count;
547 my $routinglist = Koha::Subscription::Routinglist->new({
548 borrowernumber => $patron->borrowernumber,
550 subscriptionid => $subscription->subscriptionid
553 is ($patron->get_routinglists, 1, "Retrieves correct number of routing lists: 1");
555 my @routinglists = $patron->get_routinglists;
556 is ($routinglists[0]->ranking, 5, "Retrieves ranking: 5");
557 is( ref($routinglists[0]), 'Koha::Subscription::Routinglist', 'get_routinglists returns Koha::Subscription::Routinglist objects' );
559 my $subscription2 = Koha::Subscription->new({
560 biblionumber => $biblio->biblionumber,
563 my $routinglist2 = Koha::Subscription::Routinglist->new({
564 borrowernumber => $patron->borrowernumber,
566 subscriptionid => $subscription2->subscriptionid
569 is ($patron->get_routinglists, 2, "Retrieves correct number of routing lists: 2");
571 $patron->delete; # Clean up for later tests
575 subtest 'get_age' => sub {
578 my $patron = $builder->build( { source => 'Borrower' } );
579 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
581 my $today = dt_from_string;
583 $patron->dateofbirth( undef );
584 is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
585 $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1, end_of_month => 'limit' ) );
586 is( $patron->get_age, 12, 'Patron should be 12' );
587 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1, end_of_month => 'limit' ) );
588 is( $patron->get_age, 17, 'Patron should be 17, happy birthday tomorrow!' );
589 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 0, end_of_month => 'limit' ) );
590 is( $patron->get_age, 18, 'Patron should be 18' );
591 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -31, end_of_month => 'limit' ) );
592 is( $patron->get_age, 19, 'Patron should be 19' );
593 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -30, end_of_month => 'limit' ) );
594 is( $patron->get_age, 19, 'Patron should be 19 again' );
595 $patron->dateofbirth( $today->clone->add( years => 0, months => -1, days => -1, end_of_month => 'limit' ) );
596 is( $patron->get_age, 0, 'Patron is a newborn child' );
601 subtest 'account' => sub {
604 my $patron = $builder->build({source => 'Borrower'});
606 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
607 my $account = $patron->account;
608 is( ref($account), 'Koha::Account', 'account should return a Koha::Account object' );
613 subtest 'search_upcoming_membership_expires' => sub {
616 my $expiry_days = 15;
617 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', $expiry_days );
618 my $nb_of_days_before = 1;
619 my $nb_of_days_after = 2;
621 my $builder = t::lib::TestBuilder->new();
623 my $library = $builder->build({ source => 'Branch' });
625 # before we add borrowers to this branch, add the expires we have now
626 # note that this pertains to the current mocked setting of the pref
627 # for this reason we add the new branchcode to most of the tests
628 my $nb_of_expires = Koha::Patrons->search_upcoming_membership_expires->count;
630 my $patron_1 = $builder->build({
631 source => 'Borrower',
633 branchcode => $library->{branchcode},
634 dateexpiry => dt_from_string->add( days => $expiry_days )
638 my $patron_2 = $builder->build({
639 source => 'Borrower',
641 branchcode => $library->{branchcode},
642 dateexpiry => dt_from_string->add( days => $expiry_days - $nb_of_days_before )
646 my $patron_3 = $builder->build({
647 source => 'Borrower',
649 branchcode => $library->{branchcode},
650 dateexpiry => dt_from_string->add( days => $expiry_days + $nb_of_days_after )
654 # Test without extra parameters
655 my $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires();
656 is( $upcoming_mem_expires->count, $nb_of_expires + 1, 'Get upcoming membership expires should return one new borrower.' );
659 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
660 is( $upcoming_mem_expires->count, 1, 'Test with branch parameter' );
661 my $expired = $upcoming_mem_expires->next;
662 is( $expired->surname, $patron_1->{surname}, 'Get upcoming membership expires should return the correct patron.' );
663 is( $expired->library->branchemail, $library->{branchemail}, 'Get upcoming membership expires should return the correct patron.' );
664 is( $expired->branchcode, $patron_1->{branchcode}, 'Get upcoming membership expires should return the correct patron.' );
666 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 0 );
667 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
668 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires with MembershipExpiryDaysNotice==0 should not return new records.' );
670 # Test MembershipExpiryDaysNotice == undef
671 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', undef );
672 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
673 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires without MembershipExpiryDaysNotice should not return new records.' );
675 # Test the before parameter
676 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 15 );
677 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before });
678 is( $upcoming_mem_expires->count, 2, 'Expect two results for before');
679 # Test after parameter also
680 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before, after => $nb_of_days_after });
681 is( $upcoming_mem_expires->count, 3, 'Expect three results when adding after' );
682 Koha::Patrons->search({ borrowernumber => { in => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber}, $patron_3->{borrowernumber} ] } })->delete;
685 subtest 'holds and old_holds' => sub {
688 my $library = $builder->build( { source => 'Branch' } );
689 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
690 my $item_1 = $builder->build(
694 homebranch => $library->{branchcode},
695 holdingbranch => $library->{branchcode},
696 biblionumber => $biblionumber_1
700 my $item_2 = $builder->build(
704 homebranch => $library->{branchcode},
705 holdingbranch => $library->{branchcode},
706 biblionumber => $biblionumber_1
710 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
711 my $item_3 = $builder->build(
715 homebranch => $library->{branchcode},
716 holdingbranch => $library->{branchcode},
717 biblionumber => $biblionumber_2
721 my $patron = $builder->build(
723 source => 'Borrower',
724 value => { branchcode => $library->{branchcode} }
728 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
729 my $holds = $patron->holds;
730 is( ref($holds), 'Koha::Holds',
731 'Koha::Patron->holds should return a Koha::Holds objects' );
732 is( $holds->count, 0, 'There should not be holds placed by this patron yet' );
734 C4::Reserves::AddReserve( $library->{branchcode},
735 $patron->borrowernumber, $biblionumber_1 );
737 C4::Reserves::AddReserve( $library->{branchcode},
738 $patron->borrowernumber, $biblionumber_2, undef, undef, dt_from_string->add( days => 2 ) );
740 $holds = $patron->holds;
741 is( $holds->count, 2, 'There should be 2 holds placed by this patron' );
743 my $old_holds = $patron->old_holds;
744 is( ref($old_holds), 'Koha::Old::Holds',
745 'Koha::Patron->old_holds should return a Koha::Old::Holds objects' );
746 is( $old_holds->count, 0, 'There should not be any old holds yet');
748 my $hold = $holds->next;
751 $old_holds = $patron->old_holds;
752 is( $old_holds->count, 1, 'There should be 1 old (cancelled) hold');
759 subtest 'notice_email_address' => sub {
762 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
764 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'OFF' );
765 is ($patron->notice_email_address, $patron->email, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is off");
767 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
768 is ($patron->notice_email_address, $patron->emailpro, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is emailpro");
773 subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
776 # TODO create a subroutine in t::lib::Mocks
777 my $branch = $builder->build({ source => 'Branch' });
778 my $userenv_patron = $builder->build({
779 source => 'Borrower',
780 value => { branchcode => $branch->{branchcode} },
782 C4::Context->_new_userenv('DUMMY SESSION');
783 C4::Context->set_userenv(
784 $userenv_patron->{borrowernumber},
785 $userenv_patron->{userid},
786 'usercnum', 'First name', 'Surname',
787 $branch->{branchcode},
788 $branch->{branchname},
791 my $anonymous = $builder->build( { source => 'Borrower', }, );
793 t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
795 subtest 'patron privacy is 1 (default)' => sub {
798 t::lib::Mocks::mock_preference('IndependentBranches', 0);
799 my $patron = $builder->build(
800 { source => 'Borrower',
801 value => { privacy => 1, }
804 my $item_1 = $builder->build(
812 my $issue_1 = $builder->build(
815 borrowernumber => $patron->{borrowernumber},
816 itemnumber => $item_1->{itemnumber},
820 my $item_2 = $builder->build(
828 my $issue_2 = $builder->build(
831 borrowernumber => $patron->{borrowernumber},
832 itemnumber => $item_2->{itemnumber},
837 my ( $returned_1, undef, undef ) = C4::Circulation::AddReturn( $item_1->{barcode}, undef, undef, undef, '2010-10-10' );
838 my ( $returned_2, undef, undef ) = C4::Circulation::AddReturn( $item_2->{barcode}, undef, undef, undef, '2011-11-11' );
839 is( $returned_1 && $returned_2, 1, 'The items should have been returned' );
841 my $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } );
842 is( ref($patrons_to_anonymise), 'Koha::Patrons', 'search_patrons_to_anonymise should return Koha::Patrons' );
844 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history( { before => '2010-10-11' } );
845 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
847 my $dbh = C4::Context->dbh;
848 my $sth = $dbh->prepare(q|SELECT borrowernumber FROM old_issues where itemnumber = ?|);
849 $sth->execute($item_1->{itemnumber});
850 my ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
851 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'With privacy=1, the issue should have been anonymised' );
852 $sth->execute($item_2->{itemnumber});
853 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
854 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'The issue should not have been anonymised, the returned date is later' );
856 $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history;
857 $sth->execute($item_2->{itemnumber});
858 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
859 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue should have been anonymised, the returned date is before' );
861 my $sth_reset = $dbh->prepare(q|UPDATE old_issues SET borrowernumber = ? WHERE itemnumber = ?|);
862 $sth_reset->execute( $patron->{borrowernumber}, $item_1->{itemnumber} );
863 $sth_reset->execute( $patron->{borrowernumber}, $item_2->{itemnumber} );
864 $rows_affected = Koha::Patrons->search_patrons_to_anonymise->anonymise_issue_history;
865 $sth->execute($item_1->{itemnumber});
866 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
867 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 1 should have been anonymised, before parameter was not passed' );
868 $sth->execute($item_2->{itemnumber});
869 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
870 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 2 should have been anonymised, before parameter was not passed' );
872 Koha::Patrons->find( $patron->{borrowernumber})->delete;
875 subtest 'patron privacy is 0 (forever)' => sub {
878 t::lib::Mocks::mock_preference('IndependentBranches', 0);
879 my $patron = $builder->build(
880 { source => 'Borrower',
881 value => { privacy => 0, }
884 my $item = $builder->build(
892 my $issue = $builder->build(
895 borrowernumber => $patron->{borrowernumber},
896 itemnumber => $item->{itemnumber},
901 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
902 is( $returned, 1, 'The item should have been returned' );
903 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
904 ok( $rows_affected > 0, 'AnonymiseIssueHistory should not return any error if success' );
906 my $dbh = C4::Context->dbh;
907 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
908 SELECT borrowernumber FROM old_issues where itemnumber = ?
909 |, undef, $item->{itemnumber});
910 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'With privacy=0, the issue should not be anonymised' );
911 Koha::Patrons->find( $patron->{borrowernumber})->delete;
914 t::lib::Mocks::mock_preference( 'AnonymousPatron', '' );
916 subtest 'AnonymousPatron is not defined' => sub {
919 t::lib::Mocks::mock_preference('IndependentBranches', 0);
920 my $patron = $builder->build(
921 { source => 'Borrower',
922 value => { privacy => 1, }
925 my $item = $builder->build(
933 my $issue = $builder->build(
936 borrowernumber => $patron->{borrowernumber},
937 itemnumber => $item->{itemnumber},
942 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
943 is( $returned, 1, 'The item should have been returned' );
944 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
945 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
947 my $dbh = C4::Context->dbh;
948 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
949 SELECT borrowernumber FROM old_issues where itemnumber = ?
950 |, undef, $item->{itemnumber});
951 is( $borrowernumber_used_to_anonymised, undef, 'With AnonymousPatron is not defined, the issue should have been anonymised anyway' );
952 Koha::Patrons->find( $patron->{borrowernumber})->delete;
955 subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub {
957 t::lib::Mocks::mock_preference( 'IndependentBranches', 1 );
958 my $patron = $builder->build(
959 { source => 'Borrower',
960 value => { privacy => 1 } # Another branchcode than the logged in librarian
963 my $item = $builder->build(
971 my $issue = $builder->build(
974 borrowernumber => $patron->{borrowernumber},
975 itemnumber => $item->{itemnumber},
980 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
981 is( Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->count, 0 );
982 Koha::Patrons->find( $patron->{borrowernumber})->delete;
985 Koha::Patrons->find( $anonymous->{borrowernumber})->delete;
986 Koha::Patrons->find( $userenv_patron->{borrowernumber})->delete;
988 # Reset IndependentBranches for further tests
989 t::lib::Mocks::mock_preference('IndependentBranches', 0);
992 subtest 'libraries_where_can_see_patrons + can_see_patron_infos + search_limited' => sub {
1000 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_hide_patron_info => 1 } )->store;
1001 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_hide_patron_info => 1 } )->store;
1002 my $library_11 = $builder->build( { source => 'Branch' } );
1003 my $library_12 = $builder->build( { source => 'Branch' } );
1004 my $library_21 = $builder->build( { source => 'Branch' } );
1005 $library_11 = Koha::Libraries->find( $library_11->{branchcode} );
1006 $library_12 = Koha::Libraries->find( $library_12->{branchcode} );
1007 $library_21 = Koha::Libraries->find( $library_21->{branchcode} );
1008 Koha::Library::Group->new(
1009 { branchcode => $library_11->branchcode, parent_id => $group_1->id } )->store;
1010 Koha::Library::Group->new(
1011 { branchcode => $library_12->branchcode, parent_id => $group_1->id } )->store;
1012 Koha::Library::Group->new(
1013 { branchcode => $library_21->branchcode, parent_id => $group_2->id } )->store;
1015 my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 4, ?)|); # 4 for borrowers
1016 # 2 patrons from library_11 (group1)
1017 # patron_11_1 see patron's infos from outside its group
1018 # Setting flags => undef to not be considered as superlibrarian
1019 my $patron_11_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1020 $patron_11_1 = Koha::Patrons->find( $patron_11_1->{borrowernumber} );
1021 $sth->execute( $patron_11_1->borrowernumber, 'edit_borrowers' );
1022 $sth->execute( $patron_11_1->borrowernumber, 'view_borrower_infos_from_any_libraries' );
1023 # patron_11_2 can only see patron's info from its group
1024 my $patron_11_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1025 $patron_11_2 = Koha::Patrons->find( $patron_11_2->{borrowernumber} );
1026 $sth->execute( $patron_11_2->borrowernumber, 'edit_borrowers' );
1027 # 1 patron from library_12 (group1)
1028 my $patron_12 = $builder->build({ source => 'Borrower', value => { branchcode => $library_12->branchcode, flags => undef, }});
1029 $patron_12 = Koha::Patrons->find( $patron_12->{borrowernumber} );
1030 # 1 patron from library_21 (group2) can only see patron's info from its group
1031 my $patron_21 = $builder->build({ source => 'Borrower', value => { branchcode => $library_21->branchcode, flags => undef, }});
1032 $patron_21 = Koha::Patrons->find( $patron_21->{borrowernumber} );
1033 $sth->execute( $patron_21->borrowernumber, 'edit_borrowers' );
1035 # Pfiou, we can start now!
1036 subtest 'libraries_where_can_see_patrons' => sub {
1041 set_logged_in_user( $patron_11_1 );
1042 @branchcodes = $patron_11_1->libraries_where_can_see_patrons;
1043 is_deeply( \@branchcodes, [], q|patron_11_1 has view_borrower_infos_from_any_libraries => No restriction| );
1045 set_logged_in_user( $patron_11_2 );
1046 @branchcodes = $patron_11_2->libraries_where_can_see_patrons;
1047 is_deeply( \@branchcodes, [ sort ( $library_11->branchcode, $library_12->branchcode ) ], q|patron_11_2 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1049 set_logged_in_user( $patron_21 );
1050 @branchcodes = $patron_21->libraries_where_can_see_patrons;
1051 is_deeply( \@branchcodes, [$library_21->branchcode], q|patron_21 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1053 subtest 'can_see_patron_infos' => sub {
1056 set_logged_in_user( $patron_11_1 );
1057 is( $patron_11_1->can_see_patron_infos( $patron_11_2 ), 1, q|patron_11_1 can see patron_11_2, from its library| );
1058 is( $patron_11_1->can_see_patron_infos( $patron_12 ), 1, q|patron_11_1 can see patron_12, from its group| );
1059 is( $patron_11_1->can_see_patron_infos( $patron_21 ), 1, q|patron_11_1 can see patron_11_2, from another group| );
1061 set_logged_in_user( $patron_11_2 );
1062 is( $patron_11_2->can_see_patron_infos( $patron_11_1 ), 1, q|patron_11_2 can see patron_11_1, from its library| );
1063 is( $patron_11_2->can_see_patron_infos( $patron_12 ), 1, q|patron_11_2 can see patron_12, from its group| );
1064 is( $patron_11_2->can_see_patron_infos( $patron_21 ), 0, q|patron_11_2 can NOT see patron_21, from another group| );
1066 subtest 'search_limited' => sub {
1069 set_logged_in_user( $patron_11_1 );
1070 my $total_number_of_patrons = $nb_of_patrons + 6; # 2 created before + 4 for these subtests
1071 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1072 is( Koha::Patrons->search_limited->count, $total_number_of_patrons, 'patron_11_1 is allowed to see all patrons' );
1074 set_logged_in_user( $patron_11_2 );
1075 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1076 is( Koha::Patrons->search_limited->count, 3, 'patron_12_1 is not allowed to see patrons from other groups, only patron_11_1, patron_11_2 and patron_12' );
1078 set_logged_in_user( $patron_21 );
1079 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1080 is( Koha::Patrons->search_limited->count, 1, 'patron_21 is not allowed to see patrons from other groups, only himself' );
1082 $patron_11_1->delete;
1083 $patron_11_2->delete;
1088 subtest 'account_locked' => sub {
1090 my $patron = $builder->build({ source => 'Borrower', value => { login_attempts => 0 } });
1091 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1092 for my $value ( undef, '', 0 ) {
1093 t::lib::Mocks::mock_preference('FailedloginAttempts', $value);
1094 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1095 $patron->login_attempts(1)->store;
1096 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1099 t::lib::Mocks::mock_preference('FailedloginAttempts', 3);
1100 $patron->login_attempts(2)->store;
1101 is( $patron->account_locked, 0, 'Patron has 2 failed attempts, account should not be considered locked yet' );
1102 $patron->login_attempts(3)->store;
1103 is( $patron->account_locked, 1, 'Patron has 3 failed attempts, account should be considered locked yet' );
1108 subtest 'is_child | is_adult' => sub {
1110 my $category = $builder->build_object(
1112 class => 'Koha::Patron::Categories',
1113 value => { category_type => 'A' }
1116 my $patron_adult = $builder->build_object(
1118 class => 'Koha::Patrons',
1119 value => { categorycode => $category->categorycode }
1122 $category = $builder->build_object(
1124 class => 'Koha::Patron::Categories',
1125 value => { category_type => 'I' }
1128 my $patron_adult_i = $builder->build_object(
1130 class => 'Koha::Patrons',
1131 value => { categorycode => $category->categorycode }
1134 $category = $builder->build_object(
1136 class => 'Koha::Patron::Categories',
1137 value => { category_type => 'C' }
1140 my $patron_child = $builder->build_object(
1142 class => 'Koha::Patrons',
1143 value => { categorycode => $category->categorycode }
1146 $category = $builder->build_object(
1148 class => 'Koha::Patron::Categories',
1149 value => { category_type => 'O' }
1152 my $patron_other = $builder->build_object(
1154 class => 'Koha::Patrons',
1155 value => { categorycode => $category->categorycode }
1158 is( $patron_adult->is_adult, 1, 'Patron from category A should be considered adult' );
1159 is( $patron_adult_i->is_adult, 1, 'Patron from category I should be considered adult' );
1160 is( $patron_child->is_adult, 0, 'Patron from category C should not be considered adult' );
1161 is( $patron_other->is_adult, 0, 'Patron from category O should not be considered adult' );
1163 is( $patron_adult->is_child, 0, 'Patron from category A should be considered child' );
1164 is( $patron_adult_i->is_child, 0, 'Patron from category I should be considered child' );
1165 is( $patron_child->is_child, 1, 'Patron from category C should not be considered child' );
1166 is( $patron_other->is_child, 0, 'Patron from category O should not be considered child' );
1169 $patron_adult->delete;
1170 $patron_adult_i->delete;
1171 $patron_child->delete;
1172 $patron_other->delete;
1175 subtest 'get_overdues' => sub {
1178 my $library = $builder->build( { source => 'Branch' } );
1179 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
1180 my $item_1 = $builder->build(
1184 homebranch => $library->{branchcode},
1185 holdingbranch => $library->{branchcode},
1186 biblionumber => $biblionumber_1
1190 my $item_2 = $builder->build(
1194 homebranch => $library->{branchcode},
1195 holdingbranch => $library->{branchcode},
1196 biblionumber => $biblionumber_1
1200 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
1201 my $item_3 = $builder->build(
1205 homebranch => $library->{branchcode},
1206 holdingbranch => $library->{branchcode},
1207 biblionumber => $biblionumber_2
1211 my $patron = $builder->build(
1213 source => 'Borrower',
1214 value => { branchcode => $library->{branchcode} }
1218 my $module = new Test::MockModule('C4::Context');
1219 $module->mock( 'userenv', sub { { branch => $library->{branchcode} } } );
1221 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
1222 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
1223 AddIssue( $patron, $item_3->{barcode} );
1225 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1226 my $overdues = $patron->get_overdues;
1227 is( $overdues->count, 2, 'Patron should have 2 overdues');
1228 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
1229 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
1231 my $o = $overdues->reset->next;
1232 my $unblessed_overdue = $o->unblessed_all_relateds;
1233 is( exists( $unblessed_overdue->{issuedate} ), 1, 'Fields from the issues table should be filled' );
1234 is( exists( $unblessed_overdue->{itemcallnumber} ), 1, 'Fields from the items table should be filled' );
1235 is( exists( $unblessed_overdue->{title} ), 1, 'Fields from the biblio table should be filled' );
1236 is( exists( $unblessed_overdue->{itemtype} ), 1, 'Fields from the biblioitems table should be filled' );
1239 $patron->checkouts->delete;
1243 subtest 'userid_is_valid' => sub {
1246 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1247 my $patron_category = $builder->build_object(
1249 class => 'Koha::Patron::Categories',
1250 value => { category_type => 'P', enrolmentfee => 0 }
1254 cardnumber => "123456789",
1255 firstname => "Tomasito",
1257 categorycode => $patron_category->categorycode,
1258 branchcode => $library->branchcode,
1261 my $expected_userid_patron_1 = 'tomasito.none';
1262 my $borrowernumber = AddMember(%data);
1263 my $patron_1 = Koha::Patrons->find($borrowernumber);
1264 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1266 $patron_1->userid( 'tomasito.non' );
1267 is( $patron_1->has_valid_userid, # FIXME Joubu: What is the difference with the next test?
1268 1, 'recently created userid -> unique (borrowernumber passed)' );
1270 $patron_1->userid( 'tomasitoxxx' );
1271 is( $patron_1->has_valid_userid,
1272 1, 'non-existent userid -> unique (borrowernumber passed)' );
1273 $patron_1->discard_changes; # We compare with the original userid later
1275 my $patron_not_in_storage = Koha::Patron->new( { userid => '' } );
1276 is( $patron_not_in_storage->has_valid_userid,
1277 0, 'userid exists for another patron, patron is not in storage yet' );
1279 $patron_not_in_storage = Koha::Patron->new( { userid => 'tomasitoxxx' } );
1280 is( $patron_not_in_storage->has_valid_userid,
1281 1, 'non-existent userid, patron is not in storage yet' );
1283 # Regression tests for BZ12226
1284 my $db_patron = Koha::Patron->new( { userid => C4::Context->config('user') } );
1285 is( $db_patron->has_valid_userid,
1286 0, 'Koha::Patron->has_valid_userid should return 0 for the DB user (Bug 12226)' );
1288 # Add a new borrower with the same userid but different cardnumber
1289 $data{cardnumber} = "987654321";
1290 my $new_borrowernumber = AddMember(%data);
1291 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1292 $patron_2->userid($patron_1->userid);
1293 is( $patron_2->has_valid_userid,
1294 0, 'The userid is already in used, it cannot be used for another patron' );
1296 my $new_userid = 'a_user_id';
1297 $data{cardnumber} = "234567890";
1298 $data{userid} = 'a_user_id';
1299 $borrowernumber = AddMember(%data);
1300 my $patron_3 = Koha::Patrons->find($borrowernumber);
1301 is( $patron_3->userid, $new_userid,
1302 'AddMember should insert the given userid' );
1310 subtest 'generate_userid' => sub {
1313 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1314 my $patron_category = $builder->build_object(
1316 class => 'Koha::Patron::Categories',
1317 value => { category_type => 'P', enrolmentfee => 0 }
1321 cardnumber => "123456789",
1322 firstname => "Tomasito",
1324 categorycode => $patron_category->categorycode,
1325 branchcode => $library->branchcode,
1328 my $expected_userid_patron_1 = 'tomasito.none';
1329 my $new_patron = Koha::Patron->new({ firstname => $data{firstname}, surname => $data{surname} } );
1330 my $userid = $new_patron->generate_userid;
1331 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1332 my $borrowernumber = AddMember(%data);
1333 my $patron_1 = Koha::Patrons->find($borrowernumber);
1334 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1336 $userid = $new_patron->generate_userid;
1337 is( $userid, $expected_userid_patron_1 . '1', 'generate_userid should generate the userid we expect' );
1338 $data{cardnumber} = '987654321';
1339 my $new_borrowernumber = AddMember(%data);
1340 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1341 isnt( $patron_2->userid, 'tomasito',
1342 "Patron with duplicate userid has new userid generated" );
1343 is( $patron_2->userid, $expected_userid_patron_1 . '1', # TODO we could make that configurable
1344 "Patron with duplicate userid has new userid generated (1 is appened" );
1346 $userid = $new_patron->generate_userid;
1347 is( $userid, $expected_userid_patron_1 . '2', 'generate_userid should generate the userid we expect' );
1349 $patron_1 = Koha::Patrons->find($borrowernumber);
1350 $patron_1->userid(undef);
1351 $userid = $patron_1->generate_userid;
1352 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1360 $retrieved_patron_1->delete;
1361 is( Koha::Patrons->search->count, $nb_of_patrons + 1, 'Delete should have deleted the patron' );
1363 subtest 'Log cardnumber change' => sub {
1366 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1367 my $patron = $builder->build( { source => 'Borrower' } );
1369 my $cardnumber = $patron->{cardnumber};
1370 $patron->{cardnumber} = 'TESTCARDNUMBER';
1371 ModMember(%$patron);
1373 my @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->{borrowernumber} } );
1374 my $log_info = from_json( $logs[0]->info );
1375 is( $log_info->{cardnumber_replaced}->{new_cardnumber}, 'TESTCARDNUMBER', 'Got correct new cardnumber' );
1376 is( $log_info->{cardnumber_replaced}->{previous_cardnumber}, $cardnumber, 'Got correct old cardnumber' );
1377 is( scalar @logs, 2, 'With BorrowerLogs, Change in cardnumber should be logged, as well as general alert of patron mod.' );
1380 $schema->storage->txn_rollback;
1382 subtest 'Test Koha::Patrons::merge' => sub {
1385 my $schema = Koha::Database->new()->schema();
1387 my $resultsets = $Koha::Patron::RESULTSET_PATRON_ID_MAPPING;
1389 $schema->storage->txn_begin;
1391 my $keeper = $builder->build_object({ class => 'Koha::Patrons' });
1392 my $loser_1 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1393 my $loser_2 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1395 while (my ($r, $field) = each(%$resultsets)) {
1396 $builder->build({ source => $r, value => { $field => $keeper->id } });
1397 $builder->build({ source => $r, value => { $field => $loser_1 } });
1398 $builder->build({ source => $r, value => { $field => $loser_2 } });
1401 $schema->resultset($r)->search( { $field => $keeper->id } );
1402 is( $keeper_rs->count(), 1, "Found 1 $r rows for keeper" );
1405 $schema->resultset($r)->search( { $field => $loser_1 } );
1406 is( $loser_1_rs->count(), 1, "Found 1 $r rows for loser_1" );
1409 $schema->resultset($r)->search( { $field => $loser_2 } );
1410 is( $loser_2_rs->count(), 1, "Found 1 $r rows for loser_2" );
1413 my $results = $keeper->merge_with([ $loser_1, $loser_2 ]);
1415 while (my ($r, $field) = each(%$resultsets)) {
1417 $schema->resultset($r)->search( {$field => $keeper->id } );
1418 is( $keeper_rs->count(), 3, "Found 2 $r rows for keeper" );
1421 is( Koha::Patrons->find($loser_1), undef, 'Loser 1 has been deleted' );
1422 is( Koha::Patrons->find($loser_2), undef, 'Loser 2 has been deleted' );
1424 $schema->storage->txn_rollback;
1427 # TODO Move to t::lib::Mocks and reuse it!
1428 sub set_logged_in_user {
1430 C4::Context->set_userenv(
1431 $patron->borrowernumber, $patron->userid,
1432 $patron->cardnumber, 'firstname',
1433 'surname', $patron->library->branchcode,
1434 'Midway Public Library', $patron->flags,