3 # Copyright 2015 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 33;
31 use C4::Auth qw(checkpw_hash);
35 use Koha::Patron::Categories;
38 use Koha::Virtualshelves;
40 use t::lib::TestBuilder;
43 my $schema = Koha::Database->new->schema;
44 $schema->storage->txn_begin;
46 my $builder = t::lib::TestBuilder->new;
47 my $library = $builder->build({source => 'Branch' });
48 my $category = $builder->build({source => 'Category' });
49 my $nb_of_patrons = Koha::Patrons->search->count;
50 my $new_patron_1 = Koha::Patron->new(
51 { cardnumber => 'test_cn_1',
52 branchcode => $library->{branchcode},
53 categorycode => $category->{categorycode},
54 surname => 'surname for patron1',
55 firstname => 'firstname for patron1',
56 userid => 'a_nonexistent_userid_1',
57 flags => 1, # Is superlibrarian
60 my $new_patron_2 = Koha::Patron->new(
61 { cardnumber => 'test_cn_2',
62 branchcode => $library->{branchcode},
63 categorycode => $category->{categorycode},
64 surname => 'surname for patron2',
65 firstname => 'firstname for patron2',
66 userid => 'a_nonexistent_userid_2',
70 C4::Context->_new_userenv('xxx');
71 set_logged_in_user( $new_patron_1 );
73 is( Koha::Patrons->search->count, $nb_of_patrons + 2, 'The 2 patrons should have been added' );
75 my $retrieved_patron_1 = Koha::Patrons->find( $new_patron_1->borrowernumber );
76 is( $retrieved_patron_1->cardnumber, $new_patron_1->cardnumber, 'Find a patron by borrowernumber should return the correct patron' );
78 subtest 'library' => sub {
80 is( $retrieved_patron_1->library->branchcode, $library->{branchcode}, 'Koha::Patron->library should return the correct library' );
81 is( ref($retrieved_patron_1->library), 'Koha::Library', 'Koha::Patron->library should return a Koha::Library object' );
84 subtest 'guarantees' => sub {
86 my $guarantees = $new_patron_1->guarantees;
87 is( ref($guarantees), 'Koha::Patrons', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
88 is( $guarantees->count, 0, 'new_patron_1 should have 0 guarantee' );
89 my @guarantees = $new_patron_1->guarantees;
90 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantees should return an array in a list context' );
91 is( scalar(@guarantees), 0, 'new_patron_1 should have 0 guarantee' );
93 my $guarantee_1 = $builder->build({ source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber }});
94 my $guarantee_2 = $builder->build({ source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber }});
96 $guarantees = $new_patron_1->guarantees;
97 is( ref($guarantees), 'Koha::Patrons', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
98 is( $guarantees->count, 2, 'new_patron_1 should have 2 guarantees' );
99 @guarantees = $new_patron_1->guarantees;
100 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantees should return an array in a list context' );
101 is( scalar(@guarantees), 2, 'new_patron_1 should have 2 guarantees' );
102 $_->delete for @guarantees;
104 #Test return order of guarantees BZ 18635
105 my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
106 my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
108 my $guarantor = $builder->build_object( { class => 'Koha::Patrons' } );
110 my $order_guarantee1 = $builder->build_object( { class => 'Koha::Patrons' , value => {
112 guarantorid => $guarantor->borrowernumber
116 my $order_guarantee2 = $builder->build_object( { class => 'Koha::Patrons' , value => {
118 guarantorid => $guarantor->borrowernumber
122 my $order_guarantee3 = $builder->build_object( { class => 'Koha::Patrons' , value => {
124 firstname => 'Walrus',
125 guarantorid => $guarantor->borrowernumber
129 my $order_guarantee4 = $builder->build_object( { class => 'Koha::Patrons' , value => {
131 firstname => 'Vulture',
132 guarantorid => $guarantor->borrowernumber
136 my $order_guarantee5 = $builder->build_object( { class => 'Koha::Patrons' , value => {
138 firstname => 'Unicorn',
139 guarantorid => $guarantor->borrowernumber
143 $guarantees = $guarantor->guarantees();
145 is( $guarantees->next()->borrowernumber, $order_guarantee5, "Return first guarantor alphabetically" );
146 is( $guarantees->next()->borrowernumber, $order_guarantee4, "Return second guarantor alphabetically" );
147 is( $guarantees->next()->borrowernumber, $order_guarantee3, "Return third guarantor alphabetically" );
148 is( $guarantees->next()->borrowernumber, $order_guarantee2, "Return fourth guarantor alphabetically" );
149 is( $guarantees->next()->borrowernumber, $order_guarantee1, "Return fifth guarantor alphabetically" );
152 subtest 'category' => sub {
154 my $patron_category = $new_patron_1->category;
155 is( ref( $patron_category), 'Koha::Patron::Category', );
156 is( $patron_category->categorycode, $category->{categorycode}, );
159 subtest 'siblings' => sub {
161 my $siblings = $new_patron_1->siblings;
162 is( $siblings, undef, 'Koha::Patron->siblings should not crashed if the patron has no guarantor' );
163 my $guarantee_1 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
164 my $retrieved_guarantee_1 = Koha::Patrons->find($guarantee_1);
165 $siblings = $retrieved_guarantee_1->siblings;
166 is( ref($siblings), 'Koha::Patrons', 'Koha::Patron->siblings should return a Koha::Patrons result set in a scalar context' );
167 my @siblings = $retrieved_guarantee_1->siblings;
168 is( ref( \@siblings ), 'ARRAY', 'Koha::Patron->siblings should return an array in a list context' );
169 is( $siblings->count, 0, 'guarantee_1 should not have siblings yet' );
170 my $guarantee_2 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
171 my $guarantee_3 = $builder->build( { source => 'Borrower', value => { guarantorid => $new_patron_1->borrowernumber } } );
172 $siblings = $retrieved_guarantee_1->siblings;
173 is( $siblings->count, 2, 'guarantee_1 should have 2 siblings' );
174 is( $guarantee_2->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_2 should exist in the guarantees' );
175 is( $guarantee_3->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_3 should exist in the guarantees' );
176 $_->delete for $retrieved_guarantee_1->siblings;
177 $retrieved_guarantee_1->delete;
180 subtest 'has_overdues' => sub {
183 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
184 my $item_1 = $builder->build(
187 homebranch => $library->{branchcode},
188 holdingbranch => $library->{branchcode},
192 biblionumber => $biblioitem_1->{biblionumber}
196 my $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
197 is( $retrieved_patron->has_overdues, 0, );
199 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
200 my $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $tomorrow, branchcode => $library->{branchcode} })->store();
201 is( $retrieved_patron->has_overdues, 0, );
203 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
204 $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $yesterday, branchcode => $library->{branchcode} })->store();
205 $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
206 is( $retrieved_patron->has_overdues, 1, );
210 subtest 'update_password' => sub {
213 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
214 my $original_userid = $new_patron_1->userid;
215 my $original_password = $new_patron_1->password;
216 warning_like { $retrieved_patron_1->update_password( $new_patron_2->userid, 'another_password' ) }
218 'Koha::Patron->update_password should warn if the userid is already used by another patron';
219 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->userid, $original_userid, 'Koha::Patron->update_password should not have updated the userid' );
220 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->password, $original_password, 'Koha::Patron->update_password should not have updated the userid' );
222 my $digest = $retrieved_patron_1->update_password( 'another_nonexistent_userid_1', 'another_password' );
223 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->userid, 'another_nonexistent_userid_1', 'Koha::Patron->update_password should have updated the userid' );
224 is( Koha::Patrons->find( $new_patron_1->borrowernumber )->password, $digest, 'Koha::Patron->update_password should have updated the password' );
226 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $new_patron_1->borrowernumber } )->count;
227 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->update_password should have logged' );
229 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
230 $retrieved_patron_1->update_password( 'yet_another_nonexistent_userid_1', 'another_password' );
231 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $new_patron_1->borrowernumber } )->count;
232 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->update_password should not have logged' );
235 subtest 'is_expired' => sub {
237 my $patron = $builder->build({ source => 'Borrower' });
238 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
239 $patron->dateexpiry( undef )->store->discard_changes;
240 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is not set');
241 $patron->dateexpiry( dt_from_string )->store->discard_changes;
242 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is today');
243 $patron->dateexpiry( dt_from_string->add( days => 1 ) )->store->discard_changes;
244 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is tomorrow');
245 $patron->dateexpiry( dt_from_string->add( days => -1 ) )->store->discard_changes;
246 is( $patron->is_expired, 1, 'Patron should be considered expired if dateexpiry is yesterday');
251 subtest 'is_going_to_expire' => sub {
253 my $patron = $builder->build({ source => 'Borrower' });
254 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
255 $patron->dateexpiry( undef )->store->discard_changes;
256 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is not set');
258 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
259 $patron->dateexpiry( dt_from_string )->store->discard_changes;
260 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today');
262 $patron->dateexpiry( dt_from_string )->store->discard_changes;
263 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today and pref is 0');
265 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
266 $patron->dateexpiry( dt_from_string->add( days => 11 ) )->store->discard_changes;
267 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 11 days ahead and pref is 10');
269 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
270 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
271 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 0');
273 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
274 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
275 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 10');
278 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
279 $patron->dateexpiry( dt_from_string->add( days => 20 ) )->store->discard_changes;
280 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 20 days ahead and pref is 10');
282 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 20);
283 $patron->dateexpiry( dt_from_string->add( days => 10 ) )->store->discard_changes;
284 is( $patron->is_going_to_expire, 1, 'Patron should be considered going to expire if dateexpiry is 10 days ahead and pref is 20');
290 subtest 'renew_account' => sub {
293 for my $date ( '2016-03-31', '2016-11-30', dt_from_string() ) {
294 my $dt = dt_from_string( $date, 'iso' );
295 Time::Fake->offset( $dt->epoch );
296 my $a_month_ago = $dt->clone->subtract( months => 1, end_of_month => 'limit' )->truncate( to => 'day' );
297 my $a_year_later = $dt->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
298 my $a_year_later_minus_a_month = $dt->clone->add( months => 11, end_of_month => 'limit' )->truncate( to => 'day' );
299 my $a_month_later = $dt->clone->add( months => 1 , end_of_month => 'limit' )->truncate( to => 'day' );
300 my $a_year_later_plus_a_month = $dt->clone->add( months => 13, end_of_month => 'limit' )->truncate( to => 'day' );
301 my $patron_category = $builder->build(
302 { source => 'Category',
304 enrolmentperiod => 12,
305 enrolmentperioddate => undef,
309 my $patron = $builder->build(
310 { source => 'Borrower',
312 dateexpiry => $a_month_ago,
313 categorycode => $patron_category->{categorycode},
314 date_renewed => undef, # Force builder to not populate the column for new patron
318 my $patron_2 = $builder->build(
319 { source => 'Borrower',
321 dateexpiry => $a_month_ago,
322 categorycode => $patron_category->{categorycode},
326 my $patron_3 = $builder->build(
327 { source => 'Borrower',
329 dateexpiry => $a_month_later,
330 categorycode => $patron_category->{categorycode},
334 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
335 my $retrieved_patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} );
336 my $retrieved_patron_3 = Koha::Patrons->find( $patron_3->{borrowernumber} );
338 is( $retrieved_patron->date_renewed, undef, "Date renewed is not set for patrons that have never been renewed" );
340 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'dateexpiry' );
341 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
342 my $expiry_date = $retrieved_patron->renew_account;
343 is( $expiry_date, $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
344 my $retrieved_expiry_date = Koha::Patrons->find( $patron->{borrowernumber} )->dateexpiry;
345 is( dt_from_string($retrieved_expiry_date), $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
346 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
347 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->renew_account should have logged' );
349 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' );
350 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
351 $expiry_date = $retrieved_patron->renew_account;
352 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
353 $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
354 is( $retrieved_patron->date_renewed, output_pref({ dt => $dt, dateformat => 'iso', dateonly => 1 }), "Date renewed is set when calling renew_account" );
355 $retrieved_expiry_date = $retrieved_patron->dateexpiry;
356 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
357 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
358 is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' );
360 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' );
361 $expiry_date = $retrieved_patron_2->renew_account;
362 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
363 $retrieved_expiry_date = Koha::Patrons->find( $patron_2->{borrowernumber} )->dateexpiry;
364 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
366 $expiry_date = $retrieved_patron_3->renew_account;
367 is( $expiry_date, $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
368 $retrieved_expiry_date = Koha::Patrons->find( $patron_3->{borrowernumber} )->dateexpiry;
369 is( dt_from_string($retrieved_expiry_date), $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
371 $retrieved_patron->delete;
372 $retrieved_patron_2->delete;
373 $retrieved_patron_3->delete;
378 subtest "move_to_deleted" => sub {
380 my $originally_updated_on = '2016-01-01 12:12:12';
381 my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } );
382 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
383 is( ref( $retrieved_patron->move_to_deleted ), 'Koha::Schema::Result::Deletedborrower', 'Koha::Patron->move_to_deleted should return the Deleted patron' )
384 ; # FIXME This should be Koha::Deleted::Patron
385 my $deleted_patron = $schema->resultset('Deletedborrower')
386 ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } )
388 ok( $retrieved_patron->updated_on, 'updated_on should be set for borrowers table' );
389 ok( $deleted_patron->{updated_on}, 'updated_on should be set for deleted_borrowers table' );
390 isnt( $deleted_patron->{updated_on}, $retrieved_patron->updated_on, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column');
391 $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields
392 is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' );
393 $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup
396 subtest "delete" => sub {
398 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
399 my $patron = $builder->build( { source => 'Borrower' } );
400 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
401 my $hold = $builder->build(
402 { source => 'Reserve',
403 value => { borrowernumber => $patron->{borrowernumber} }
406 my $list = $builder->build(
407 { source => 'Virtualshelve',
408 value => { owner => $patron->{borrowernumber} }
412 my $deleted = $retrieved_patron->delete;
413 is( $deleted, 1, 'Koha::Patron->delete should return 1 if the patron has been correctly deleted' );
415 is( Koha::Patrons->find( $patron->{borrowernumber} ), undef, 'Koha::Patron->delete should have deleted the patron' );
417 is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's holds| );
419 is( Koha::Virtualshelves->search( { owner => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's lists| );
421 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'DELETE', object => $retrieved_patron->borrowernumber } )->count;
422 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->delete should have logged' );
425 subtest 'Koha::Patrons->delete' => sub {
427 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
428 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
429 my $id1 = $patron1->borrowernumber;
430 my $set = Koha::Patrons->search({ borrowernumber => { '>=' => $id1 }});
431 is( $set->count, 2, 'Two patrons found as expected' );
432 my $count1 = $schema->resultset('Deletedborrower')->count;
433 is( $set->delete, 1, 'Two patrons deleted' );
434 my $count2 = $schema->resultset('Deletedborrower')->count;
435 is( $count2, $count1 + 2, 'Patrons moved to deletedborrowers' );
438 subtest 'add_enrolment_fee_if_needed' => sub {
441 my $enrolmentfees = { K => 5, J => 10, YA => 20 };
442 foreach( keys %{$enrolmentfees} ) {
443 ( Koha::Patron::Categories->find( $_ ) // $builder->build_object({ class => 'Koha::Patron::Categories', value => { categorycode => $_ } }) )->enrolmentfee( $enrolmentfees->{$_} )->store;
445 my $enrolmentfee_K = $enrolmentfees->{K};
446 my $enrolmentfee_J = $enrolmentfees->{J};
447 my $enrolmentfee_YA = $enrolmentfees->{YA};
449 my %borrower_data = (
450 firstname => 'my firstname',
451 surname => 'my surname',
453 branchcode => $library->{branchcode},
456 my $borrowernumber = Koha::Patron->new(\%borrower_data)->store->borrowernumber;
457 $borrower_data{borrowernumber} = $borrowernumber;
459 my $patron = Koha::Patrons->find( $borrowernumber );
460 my $total = $patron->account->balance;
461 is( int($total), int($enrolmentfee_K), "New kid pay $enrolmentfee_K" );
463 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 0 );
464 $borrower_data{categorycode} = 'J';
465 $patron->set(\%borrower_data)->store;
466 $total = $patron->account->balance;
467 is( int($total), int($enrolmentfee_K), "Kid growing and become a juvenile, but shouldn't pay for the upgrade " );
469 $borrower_data{categorycode} = 'K';
470 $patron->set(\%borrower_data)->store;
471 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 1 );
473 $borrower_data{categorycode} = 'J';
474 $patron->set(\%borrower_data)->store;
475 $total = $patron->account->balance;
476 is( int($total), int($enrolmentfee_K + $enrolmentfee_J), "Kid growing and become a juvenile, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) );
478 # Check with calling directly Koha::Patron->get_enrolment_fee_if_needed
479 $patron->categorycode('YA')->store;
480 $total = $patron->account->balance;
482 int($enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA),
483 "Juvenile growing and become an young adult, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA )
489 subtest 'checkouts + pending_checkouts + get_overdues + old_checkouts' => sub {
492 my $library = $builder->build( { source => 'Branch' } );
493 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
494 my $item_1 = $builder->build(
498 homebranch => $library->{branchcode},
499 holdingbranch => $library->{branchcode},
500 biblionumber => $biblionumber_1,
506 my $item_2 = $builder->build(
510 homebranch => $library->{branchcode},
511 holdingbranch => $library->{branchcode},
512 biblionumber => $biblionumber_1,
518 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
519 my $item_3 = $builder->build(
523 homebranch => $library->{branchcode},
524 holdingbranch => $library->{branchcode},
525 biblionumber => $biblionumber_2,
531 my $patron = $builder->build(
533 source => 'Borrower',
534 value => { branchcode => $library->{branchcode} }
538 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
539 my $checkouts = $patron->checkouts;
540 is( $checkouts->count, 0, 'checkouts should not return any issues for that patron' );
541 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
542 my $pending_checkouts = $patron->pending_checkouts;
543 is( $pending_checkouts->count, 0, 'pending_checkouts should not return any issues for that patron' );
544 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
545 my $old_checkouts = $patron->old_checkouts;
546 is( $old_checkouts->count, 0, 'old_checkouts should not return any issues for that patron' );
547 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
549 # Not sure how this is useful, but AddIssue pass this variable to different other subroutines
550 $patron = Koha::Patrons->find( $patron->borrowernumber )->unblessed;
552 my $module = new Test::MockModule('C4::Context');
553 $module->mock( 'userenv', sub { { branch => $library->{branchcode} } } );
555 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
556 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
557 AddIssue( $patron, $item_3->{barcode} );
559 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
560 $checkouts = $patron->checkouts;
561 is( $checkouts->count, 3, 'checkouts should return 3 issues for that patron' );
562 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
563 $pending_checkouts = $patron->pending_checkouts;
564 is( $pending_checkouts->count, 3, 'pending_checkouts should return 3 issues for that patron' );
565 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
567 my $first_checkout = $pending_checkouts->next;
568 is( $first_checkout->unblessed_all_relateds->{biblionumber}, $item_3->{biblionumber}, 'pending_checkouts should prefetch values from other tables (here biblio)' );
570 my $overdues = $patron->get_overdues;
571 is( $overdues->count, 2, 'Patron should have 2 overdues');
572 is( ref($overdues), 'Koha::Checkouts', 'Koha::Patron->get_overdues should return Koha::Checkouts' );
573 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
574 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
577 C4::Circulation::AddReturn( $item_1->{barcode} );
578 C4::Circulation::AddReturn( $item_2->{barcode} );
579 $old_checkouts = $patron->old_checkouts;
580 is( $old_checkouts->count, 2, 'old_checkouts should return 2 old checkouts that patron' );
581 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
584 Koha::Checkouts->search( { borrowernumber => $patron->borrowernumber } )->delete;
586 $module->unmock('userenv');
589 subtest 'get_routing_lists' => sub {
592 my $biblio = Koha::Biblio->new()->store();
593 my $subscription = Koha::Subscription->new({
594 biblionumber => $biblio->biblionumber,
598 my $patron = $builder->build( { source => 'Borrower' } );
599 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
601 is( $patron->get_routing_lists->count, 0, 'Retrieves correct number of routing lists: 0' );
603 my $routinglist_count = Koha::Subscription::Routinglists->count;
604 my $routinglist = Koha::Subscription::Routinglist->new({
605 borrowernumber => $patron->borrowernumber,
607 subscriptionid => $subscription->subscriptionid
610 is ($patron->get_routing_lists->count, 1, "Retrieves correct number of routing lists: 1");
612 my $routinglists = $patron->get_routing_lists;
613 is ($routinglists->next->ranking, 5, "Retrieves ranking: 5");
614 is( ref($routinglists), 'Koha::Subscription::Routinglists', 'get_routing_lists returns Koha::Subscription::Routinglists' );
616 my $subscription2 = Koha::Subscription->new({
617 biblionumber => $biblio->biblionumber,
620 my $routinglist2 = Koha::Subscription::Routinglist->new({
621 borrowernumber => $patron->borrowernumber,
623 subscriptionid => $subscription2->subscriptionid
626 is ($patron->get_routing_lists->count, 2, "Retrieves correct number of routing lists: 2");
628 $patron->delete; # Clean up for later tests
632 subtest 'get_age' => sub {
635 my $patron = $builder->build( { source => 'Borrower' } );
636 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
638 my $today = dt_from_string;
640 $patron->dateofbirth( undef );
641 is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
642 $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1, end_of_month => 'limit' ) );
643 is( $patron->get_age, 12, 'Patron should be 12' );
644 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1, end_of_month => 'limit' ) );
645 is( $patron->get_age, 17, 'Patron should be 17, happy birthday tomorrow!' );
646 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 0, end_of_month => 'limit' ) );
647 is( $patron->get_age, 18, 'Patron should be 18' );
648 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -31, end_of_month => 'limit' ) );
649 is( $patron->get_age, 19, 'Patron should be 19' );
650 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -30, end_of_month => 'limit' ) );
651 is( $patron->get_age, 19, 'Patron should be 19 again' );
652 $patron->dateofbirth( $today->clone->add( years => 0, months => -1, days => -1, end_of_month => 'limit' ) );
653 is( $patron->get_age, 0, 'Patron is a newborn child' );
658 subtest 'account' => sub {
661 my $patron = $builder->build({source => 'Borrower'});
663 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
664 my $account = $patron->account;
665 is( ref($account), 'Koha::Account', 'account should return a Koha::Account object' );
670 subtest 'search_upcoming_membership_expires' => sub {
673 my $expiry_days = 15;
674 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', $expiry_days );
675 my $nb_of_days_before = 1;
676 my $nb_of_days_after = 2;
678 my $builder = t::lib::TestBuilder->new();
680 my $library = $builder->build({ source => 'Branch' });
682 # before we add borrowers to this branch, add the expires we have now
683 # note that this pertains to the current mocked setting of the pref
684 # for this reason we add the new branchcode to most of the tests
685 my $nb_of_expires = Koha::Patrons->search_upcoming_membership_expires->count;
687 my $patron_1 = $builder->build({
688 source => 'Borrower',
690 branchcode => $library->{branchcode},
691 dateexpiry => dt_from_string->add( days => $expiry_days )
695 my $patron_2 = $builder->build({
696 source => 'Borrower',
698 branchcode => $library->{branchcode},
699 dateexpiry => dt_from_string->add( days => $expiry_days - $nb_of_days_before )
703 my $patron_3 = $builder->build({
704 source => 'Borrower',
706 branchcode => $library->{branchcode},
707 dateexpiry => dt_from_string->add( days => $expiry_days + $nb_of_days_after )
711 # Test without extra parameters
712 my $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires();
713 is( $upcoming_mem_expires->count, $nb_of_expires + 1, 'Get upcoming membership expires should return one new borrower.' );
716 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
717 is( $upcoming_mem_expires->count, 1, 'Test with branch parameter' );
718 my $expired = $upcoming_mem_expires->next;
719 is( $expired->surname, $patron_1->{surname}, 'Get upcoming membership expires should return the correct patron.' );
720 is( $expired->library->branchemail, $library->{branchemail}, 'Get upcoming membership expires should return the correct patron.' );
721 is( $expired->branchcode, $patron_1->{branchcode}, 'Get upcoming membership expires should return the correct patron.' );
723 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 0 );
724 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
725 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires with MembershipExpiryDaysNotice==0 should not return new records.' );
727 # Test MembershipExpiryDaysNotice == undef
728 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', undef );
729 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
730 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires without MembershipExpiryDaysNotice should not return new records.' );
732 # Test the before parameter
733 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 15 );
734 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before });
735 is( $upcoming_mem_expires->count, 2, 'Expect two results for before');
736 # Test after parameter also
737 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before, after => $nb_of_days_after });
738 is( $upcoming_mem_expires->count, 3, 'Expect three results when adding after' );
739 Koha::Patrons->search({ borrowernumber => { in => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber}, $patron_3->{borrowernumber} ] } })->delete;
742 subtest 'holds and old_holds' => sub {
745 my $library = $builder->build( { source => 'Branch' } );
746 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
747 my $item_1 = $builder->build(
751 homebranch => $library->{branchcode},
752 holdingbranch => $library->{branchcode},
753 biblionumber => $biblionumber_1
757 my $item_2 = $builder->build(
761 homebranch => $library->{branchcode},
762 holdingbranch => $library->{branchcode},
763 biblionumber => $biblionumber_1
767 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
768 my $item_3 = $builder->build(
772 homebranch => $library->{branchcode},
773 holdingbranch => $library->{branchcode},
774 biblionumber => $biblionumber_2
778 my $patron = $builder->build(
780 source => 'Borrower',
781 value => { branchcode => $library->{branchcode} }
785 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
786 my $holds = $patron->holds;
787 is( ref($holds), 'Koha::Holds',
788 'Koha::Patron->holds should return a Koha::Holds objects' );
789 is( $holds->count, 0, 'There should not be holds placed by this patron yet' );
791 C4::Reserves::AddReserve( $library->{branchcode},
792 $patron->borrowernumber, $biblionumber_1 );
794 C4::Reserves::AddReserve( $library->{branchcode},
795 $patron->borrowernumber, $biblionumber_2, undef, undef, dt_from_string->add( days => 2 ) );
797 $holds = $patron->holds;
798 is( $holds->count, 2, 'There should be 2 holds placed by this patron' );
800 my $old_holds = $patron->old_holds;
801 is( ref($old_holds), 'Koha::Old::Holds',
802 'Koha::Patron->old_holds should return a Koha::Old::Holds objects' );
803 is( $old_holds->count, 0, 'There should not be any old holds yet');
805 my $hold = $holds->next;
808 $old_holds = $patron->old_holds;
809 is( $old_holds->count, 1, 'There should be 1 old (cancelled) hold');
816 subtest 'notice_email_address' => sub {
819 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
821 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'OFF' );
822 is ($patron->notice_email_address, $patron->email, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is off");
824 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
825 is ($patron->notice_email_address, $patron->emailpro, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is emailpro");
830 subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
833 # TODO create a subroutine in t::lib::Mocks
834 my $branch = $builder->build({ source => 'Branch' });
835 my $userenv_patron = $builder->build({
836 source => 'Borrower',
837 value => { branchcode => $branch->{branchcode} },
839 C4::Context->_new_userenv('DUMMY SESSION');
840 C4::Context->set_userenv(
841 $userenv_patron->{borrowernumber},
842 $userenv_patron->{userid},
843 'usercnum', 'First name', 'Surname',
844 $branch->{branchcode},
845 $branch->{branchname},
848 my $anonymous = $builder->build( { source => 'Borrower', }, );
850 t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
852 subtest 'patron privacy is 1 (default)' => sub {
855 t::lib::Mocks::mock_preference('IndependentBranches', 0);
856 my $patron = $builder->build(
857 { source => 'Borrower',
858 value => { privacy => 1, }
861 my $item_1 = $builder->build(
869 my $issue_1 = $builder->build(
872 borrowernumber => $patron->{borrowernumber},
873 itemnumber => $item_1->{itemnumber},
877 my $item_2 = $builder->build(
885 my $issue_2 = $builder->build(
888 borrowernumber => $patron->{borrowernumber},
889 itemnumber => $item_2->{itemnumber},
894 my ( $returned_1, undef, undef ) = C4::Circulation::AddReturn( $item_1->{barcode}, undef, undef, undef, '2010-10-10' );
895 my ( $returned_2, undef, undef ) = C4::Circulation::AddReturn( $item_2->{barcode}, undef, undef, undef, '2011-11-11' );
896 is( $returned_1 && $returned_2, 1, 'The items should have been returned' );
898 my $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } );
899 is( ref($patrons_to_anonymise), 'Koha::Patrons', 'search_patrons_to_anonymise should return Koha::Patrons' );
901 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history( { before => '2010-10-11' } );
902 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
904 my $dbh = C4::Context->dbh;
905 my $sth = $dbh->prepare(q|SELECT borrowernumber FROM old_issues where itemnumber = ?|);
906 $sth->execute($item_1->{itemnumber});
907 my ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
908 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'With privacy=1, the issue should have been anonymised' );
909 $sth->execute($item_2->{itemnumber});
910 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
911 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'The issue should not have been anonymised, the returned date is later' );
913 $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history;
914 $sth->execute($item_2->{itemnumber});
915 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
916 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue should have been anonymised, the returned date is before' );
918 my $sth_reset = $dbh->prepare(q|UPDATE old_issues SET borrowernumber = ? WHERE itemnumber = ?|);
919 $sth_reset->execute( $patron->{borrowernumber}, $item_1->{itemnumber} );
920 $sth_reset->execute( $patron->{borrowernumber}, $item_2->{itemnumber} );
921 $rows_affected = Koha::Patrons->search_patrons_to_anonymise->anonymise_issue_history;
922 $sth->execute($item_1->{itemnumber});
923 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
924 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 1 should have been anonymised, before parameter was not passed' );
925 $sth->execute($item_2->{itemnumber});
926 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
927 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 2 should have been anonymised, before parameter was not passed' );
929 Koha::Patrons->find( $patron->{borrowernumber})->delete;
932 subtest 'patron privacy is 0 (forever)' => sub {
935 t::lib::Mocks::mock_preference('IndependentBranches', 0);
936 my $patron = $builder->build(
937 { source => 'Borrower',
938 value => { privacy => 0, }
941 my $item = $builder->build(
949 my $issue = $builder->build(
952 borrowernumber => $patron->{borrowernumber},
953 itemnumber => $item->{itemnumber},
958 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
959 is( $returned, 1, 'The item should have been returned' );
960 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
961 ok( $rows_affected > 0, 'AnonymiseIssueHistory should not return any error if success' );
963 my $dbh = C4::Context->dbh;
964 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
965 SELECT borrowernumber FROM old_issues where itemnumber = ?
966 |, undef, $item->{itemnumber});
967 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'With privacy=0, the issue should not be anonymised' );
968 Koha::Patrons->find( $patron->{borrowernumber})->delete;
971 t::lib::Mocks::mock_preference( 'AnonymousPatron', '' );
973 subtest 'AnonymousPatron is not defined' => sub {
976 t::lib::Mocks::mock_preference('IndependentBranches', 0);
977 my $patron = $builder->build(
978 { source => 'Borrower',
979 value => { privacy => 1, }
982 my $item = $builder->build(
990 my $issue = $builder->build(
993 borrowernumber => $patron->{borrowernumber},
994 itemnumber => $item->{itemnumber},
999 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
1000 is( $returned, 1, 'The item should have been returned' );
1001 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
1002 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
1004 my $dbh = C4::Context->dbh;
1005 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
1006 SELECT borrowernumber FROM old_issues where itemnumber = ?
1007 |, undef, $item->{itemnumber});
1008 is( $borrowernumber_used_to_anonymised, undef, 'With AnonymousPatron is not defined, the issue should have been anonymised anyway' );
1009 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1012 subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub {
1014 t::lib::Mocks::mock_preference( 'IndependentBranches', 1 );
1015 my $patron = $builder->build(
1016 { source => 'Borrower',
1017 value => { privacy => 1 } # Another branchcode than the logged in librarian
1020 my $item = $builder->build(
1028 my $issue = $builder->build(
1029 { source => 'Issue',
1031 borrowernumber => $patron->{borrowernumber},
1032 itemnumber => $item->{itemnumber},
1037 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
1038 is( Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->count, 0 );
1039 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1042 Koha::Patrons->find( $anonymous->{borrowernumber})->delete;
1043 Koha::Patrons->find( $userenv_patron->{borrowernumber})->delete;
1045 # Reset IndependentBranches for further tests
1046 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1049 subtest 'libraries_where_can_see_patrons + can_see_patron_infos + search_limited' => sub {
1057 $nb_of_patrons = Koha::Patrons->search->count;
1058 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_hide_patron_info => 1 } )->store;
1059 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_hide_patron_info => 1 } )->store;
1060 my $library_11 = $builder->build( { source => 'Branch' } );
1061 my $library_12 = $builder->build( { source => 'Branch' } );
1062 my $library_21 = $builder->build( { source => 'Branch' } );
1063 $library_11 = Koha::Libraries->find( $library_11->{branchcode} );
1064 $library_12 = Koha::Libraries->find( $library_12->{branchcode} );
1065 $library_21 = Koha::Libraries->find( $library_21->{branchcode} );
1066 Koha::Library::Group->new(
1067 { branchcode => $library_11->branchcode, parent_id => $group_1->id } )->store;
1068 Koha::Library::Group->new(
1069 { branchcode => $library_12->branchcode, parent_id => $group_1->id } )->store;
1070 Koha::Library::Group->new(
1071 { branchcode => $library_21->branchcode, parent_id => $group_2->id } )->store;
1073 my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 4, ?)|); # 4 for borrowers
1074 # 2 patrons from library_11 (group1)
1075 # patron_11_1 see patron's infos from outside its group
1076 # Setting flags => undef to not be considered as superlibrarian
1077 my $patron_11_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1078 $patron_11_1 = Koha::Patrons->find( $patron_11_1->{borrowernumber} );
1079 $sth->execute( $patron_11_1->borrowernumber, 'edit_borrowers' );
1080 $sth->execute( $patron_11_1->borrowernumber, 'view_borrower_infos_from_any_libraries' );
1081 # patron_11_2 can only see patron's info from its group
1082 my $patron_11_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1083 $patron_11_2 = Koha::Patrons->find( $patron_11_2->{borrowernumber} );
1084 $sth->execute( $patron_11_2->borrowernumber, 'edit_borrowers' );
1085 # 1 patron from library_12 (group1)
1086 my $patron_12 = $builder->build({ source => 'Borrower', value => { branchcode => $library_12->branchcode, flags => undef, }});
1087 $patron_12 = Koha::Patrons->find( $patron_12->{borrowernumber} );
1088 # 1 patron from library_21 (group2) can only see patron's info from its group
1089 my $patron_21 = $builder->build({ source => 'Borrower', value => { branchcode => $library_21->branchcode, flags => undef, }});
1090 $patron_21 = Koha::Patrons->find( $patron_21->{borrowernumber} );
1091 $sth->execute( $patron_21->borrowernumber, 'edit_borrowers' );
1093 # Pfiou, we can start now!
1094 subtest 'libraries_where_can_see_patrons' => sub {
1099 set_logged_in_user( $patron_11_1 );
1100 @branchcodes = $patron_11_1->libraries_where_can_see_patrons;
1101 is_deeply( \@branchcodes, [], q|patron_11_1 has view_borrower_infos_from_any_libraries => No restriction| );
1103 set_logged_in_user( $patron_11_2 );
1104 @branchcodes = $patron_11_2->libraries_where_can_see_patrons;
1105 is_deeply( \@branchcodes, [ sort ( $library_11->branchcode, $library_12->branchcode ) ], q|patron_11_2 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1107 set_logged_in_user( $patron_21 );
1108 @branchcodes = $patron_21->libraries_where_can_see_patrons;
1109 is_deeply( \@branchcodes, [$library_21->branchcode], q|patron_21 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1111 subtest 'can_see_patron_infos' => sub {
1114 set_logged_in_user( $patron_11_1 );
1115 is( $patron_11_1->can_see_patron_infos( $patron_11_2 ), 1, q|patron_11_1 can see patron_11_2, from its library| );
1116 is( $patron_11_1->can_see_patron_infos( $patron_12 ), 1, q|patron_11_1 can see patron_12, from its group| );
1117 is( $patron_11_1->can_see_patron_infos( $patron_21 ), 1, q|patron_11_1 can see patron_11_2, from another group| );
1119 set_logged_in_user( $patron_11_2 );
1120 is( $patron_11_2->can_see_patron_infos( $patron_11_1 ), 1, q|patron_11_2 can see patron_11_1, from its library| );
1121 is( $patron_11_2->can_see_patron_infos( $patron_12 ), 1, q|patron_11_2 can see patron_12, from its group| );
1122 is( $patron_11_2->can_see_patron_infos( $patron_21 ), 0, q|patron_11_2 can NOT see patron_21, from another group| );
1124 subtest 'search_limited' => sub {
1127 set_logged_in_user( $patron_11_1 );
1128 my $total_number_of_patrons = $nb_of_patrons + 4; #we added four in these tests
1129 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons' );
1130 is( Koha::Patrons->search_limited->count, $total_number_of_patrons, 'patron_11_1 is allowed to see all patrons' );
1132 set_logged_in_user( $patron_11_2 );
1133 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1134 is( Koha::Patrons->search_limited->count, 3, 'patron_12_1 is not allowed to see patrons from other groups, only patron_11_1, patron_11_2 and patron_12' );
1136 set_logged_in_user( $patron_21 );
1137 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1138 is( Koha::Patrons->search_limited->count, 1, 'patron_21 is not allowed to see patrons from other groups, only himself' );
1140 $patron_11_1->delete;
1141 $patron_11_2->delete;
1146 subtest 'account_locked' => sub {
1148 my $patron = $builder->build({ source => 'Borrower', value => { login_attempts => 0 } });
1149 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1150 for my $value ( undef, '', 0 ) {
1151 t::lib::Mocks::mock_preference('FailedloginAttempts', $value);
1152 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1153 $patron->login_attempts(1)->store;
1154 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1157 t::lib::Mocks::mock_preference('FailedloginAttempts', 3);
1158 $patron->login_attempts(2)->store;
1159 is( $patron->account_locked, 0, 'Patron has 2 failed attempts, account should not be considered locked yet' );
1160 $patron->login_attempts(3)->store;
1161 is( $patron->account_locked, 1, 'Patron has 3 failed attempts, account should be considered locked yet' );
1166 subtest 'is_child | is_adult' => sub {
1168 my $category = $builder->build_object(
1170 class => 'Koha::Patron::Categories',
1171 value => { category_type => 'A' }
1174 my $patron_adult = $builder->build_object(
1176 class => 'Koha::Patrons',
1177 value => { categorycode => $category->categorycode }
1180 $category = $builder->build_object(
1182 class => 'Koha::Patron::Categories',
1183 value => { category_type => 'I' }
1186 my $patron_adult_i = $builder->build_object(
1188 class => 'Koha::Patrons',
1189 value => { categorycode => $category->categorycode }
1192 $category = $builder->build_object(
1194 class => 'Koha::Patron::Categories',
1195 value => { category_type => 'C' }
1198 my $patron_child = $builder->build_object(
1200 class => 'Koha::Patrons',
1201 value => { categorycode => $category->categorycode }
1204 $category = $builder->build_object(
1206 class => 'Koha::Patron::Categories',
1207 value => { category_type => 'O' }
1210 my $patron_other = $builder->build_object(
1212 class => 'Koha::Patrons',
1213 value => { categorycode => $category->categorycode }
1216 is( $patron_adult->is_adult, 1, 'Patron from category A should be considered adult' );
1217 is( $patron_adult_i->is_adult, 1, 'Patron from category I should be considered adult' );
1218 is( $patron_child->is_adult, 0, 'Patron from category C should not be considered adult' );
1219 is( $patron_other->is_adult, 0, 'Patron from category O should not be considered adult' );
1221 is( $patron_adult->is_child, 0, 'Patron from category A should be considered child' );
1222 is( $patron_adult_i->is_child, 0, 'Patron from category I should be considered child' );
1223 is( $patron_child->is_child, 1, 'Patron from category C should not be considered child' );
1224 is( $patron_other->is_child, 0, 'Patron from category O should not be considered child' );
1227 $patron_adult->delete;
1228 $patron_adult_i->delete;
1229 $patron_child->delete;
1230 $patron_other->delete;
1233 subtest 'get_overdues' => sub {
1236 my $library = $builder->build( { source => 'Branch' } );
1237 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
1238 my $item_1 = $builder->build(
1242 homebranch => $library->{branchcode},
1243 holdingbranch => $library->{branchcode},
1244 biblionumber => $biblionumber_1
1248 my $item_2 = $builder->build(
1252 homebranch => $library->{branchcode},
1253 holdingbranch => $library->{branchcode},
1254 biblionumber => $biblionumber_1
1258 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
1259 my $item_3 = $builder->build(
1263 homebranch => $library->{branchcode},
1264 holdingbranch => $library->{branchcode},
1265 biblionumber => $biblionumber_2
1269 my $patron = $builder->build(
1271 source => 'Borrower',
1272 value => { branchcode => $library->{branchcode} }
1276 my $module = new Test::MockModule('C4::Context');
1277 $module->mock( 'userenv', sub { { branch => $library->{branchcode} } } );
1279 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
1280 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
1281 AddIssue( $patron, $item_3->{barcode} );
1283 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1284 my $overdues = $patron->get_overdues;
1285 is( $overdues->count, 2, 'Patron should have 2 overdues');
1286 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
1287 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
1289 my $o = $overdues->reset->next;
1290 my $unblessed_overdue = $o->unblessed_all_relateds;
1291 is( exists( $unblessed_overdue->{issuedate} ), 1, 'Fields from the issues table should be filled' );
1292 is( exists( $unblessed_overdue->{itemcallnumber} ), 1, 'Fields from the items table should be filled' );
1293 is( exists( $unblessed_overdue->{title} ), 1, 'Fields from the biblio table should be filled' );
1294 is( exists( $unblessed_overdue->{itemtype} ), 1, 'Fields from the biblioitems table should be filled' );
1297 $patron->checkouts->delete;
1301 subtest 'userid_is_valid' => sub {
1304 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1305 my $patron_category = $builder->build_object(
1307 class => 'Koha::Patron::Categories',
1308 value => { category_type => 'P', enrolmentfee => 0 }
1312 cardnumber => "123456789",
1313 firstname => "Tomasito",
1315 categorycode => $patron_category->categorycode,
1316 branchcode => $library->branchcode,
1319 my $expected_userid_patron_1 = 'tomasito.none';
1320 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1321 my $patron_1 = Koha::Patrons->find($borrowernumber);
1322 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1324 $patron_1->userid( 'tomasito.non' );
1325 is( $patron_1->has_valid_userid, # FIXME Joubu: What is the difference with the next test?
1326 1, 'recently created userid -> unique (borrowernumber passed)' );
1328 $patron_1->userid( 'tomasitoxxx' );
1329 is( $patron_1->has_valid_userid,
1330 1, 'non-existent userid -> unique (borrowernumber passed)' );
1331 $patron_1->discard_changes; # We compare with the original userid later
1333 my $patron_not_in_storage = Koha::Patron->new( { userid => '' } );
1334 is( $patron_not_in_storage->has_valid_userid,
1335 0, 'userid exists for another patron, patron is not in storage yet' );
1337 $patron_not_in_storage = Koha::Patron->new( { userid => 'tomasitoxxx' } );
1338 is( $patron_not_in_storage->has_valid_userid,
1339 1, 'non-existent userid, patron is not in storage yet' );
1341 # Regression tests for BZ12226
1342 my $db_patron = Koha::Patron->new( { userid => C4::Context->config('user') } );
1343 is( $db_patron->has_valid_userid,
1344 0, 'Koha::Patron->has_valid_userid should return 0 for the DB user (Bug 12226)' );
1346 # Add a new borrower with the same userid but different cardnumber
1347 $data{cardnumber} = "987654321";
1348 my $new_borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1349 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1350 $patron_2->userid($patron_1->userid);
1351 is( $patron_2->has_valid_userid,
1352 0, 'The userid is already in used, it cannot be used for another patron' );
1354 my $new_userid = 'a_user_id';
1355 $data{cardnumber} = "234567890";
1356 $data{userid} = 'a_user_id';
1357 $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1358 my $patron_3 = Koha::Patrons->find($borrowernumber);
1359 is( $patron_3->userid, $new_userid,
1360 'Koha::Patron->store should insert the given userid' );
1368 subtest 'generate_userid' => sub {
1371 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1372 my $patron_category = $builder->build_object(
1374 class => 'Koha::Patron::Categories',
1375 value => { category_type => 'P', enrolmentfee => 0 }
1379 cardnumber => "123456789",
1380 firstname => "Tomasito",
1382 categorycode => $patron_category->categorycode,
1383 branchcode => $library->branchcode,
1386 my $expected_userid_patron_1 = 'tomasito.none';
1387 my $new_patron = Koha::Patron->new({ firstname => $data{firstname}, surname => $data{surname} } );
1388 $new_patron->generate_userid;
1389 my $userid = $new_patron->userid;
1390 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1391 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1392 my $patron_1 = Koha::Patrons->find($borrowernumber);
1393 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1395 $new_patron->generate_userid;
1396 $userid = $new_patron->userid;
1397 is( $userid, $expected_userid_patron_1 . '1', 'generate_userid should generate the userid we expect' );
1398 $data{cardnumber} = '987654321';
1399 my $new_borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1400 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1401 isnt( $patron_2->userid, 'tomasito',
1402 "Patron with duplicate userid has new userid generated" );
1403 is( $patron_2->userid, $expected_userid_patron_1 . '1', # TODO we could make that configurable
1404 "Patron with duplicate userid has new userid generated (1 is appened" );
1406 $new_patron->generate_userid;
1407 $userid = $new_patron->userid;
1408 is( $userid, $expected_userid_patron_1 . '2', 'generate_userid should generate the userid we expect' );
1410 $patron_1 = Koha::Patrons->find($borrowernumber);
1411 $patron_1->userid(undef);
1412 $patron_1->generate_userid;
1413 $userid = $patron_1->userid;
1414 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1421 $nb_of_patrons = Koha::Patrons->search->count;
1422 $retrieved_patron_1->delete;
1423 is( Koha::Patrons->search->count, $nb_of_patrons - 1, 'Delete should have deleted the patron' );
1425 subtest 'Log cardnumber change' => sub {
1428 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1429 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
1431 my $cardnumber = $patron->cardnumber;
1432 $patron->set( { cardnumber => 'TESTCARDNUMBER' });
1435 my @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
1436 my $log_info = from_json( $logs[0]->info );
1437 is( $log_info->{cardnumber_replaced}->{new_cardnumber}, 'TESTCARDNUMBER', 'Got correct new cardnumber' );
1438 is( $log_info->{cardnumber_replaced}->{previous_cardnumber}, $cardnumber, 'Got correct old cardnumber' );
1439 is( scalar @logs, 2, 'With BorrowerLogs, Change in cardnumber should be logged, as well as general alert of patron mod.' );
1442 $schema->storage->txn_rollback;
1444 subtest 'Test Koha::Patrons::merge' => sub {
1447 my $schema = Koha::Database->new()->schema();
1449 my $resultsets = $Koha::Patron::RESULTSET_PATRON_ID_MAPPING;
1451 $schema->storage->txn_begin;
1453 my $keeper = $builder->build_object({ class => 'Koha::Patrons' });
1454 my $loser_1 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1455 my $loser_2 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1457 while (my ($r, $field) = each(%$resultsets)) {
1458 $builder->build({ source => $r, value => { $field => $keeper->id } });
1459 $builder->build({ source => $r, value => { $field => $loser_1 } });
1460 $builder->build({ source => $r, value => { $field => $loser_2 } });
1463 $schema->resultset($r)->search( { $field => $keeper->id } );
1464 is( $keeper_rs->count(), 1, "Found 1 $r rows for keeper" );
1467 $schema->resultset($r)->search( { $field => $loser_1 } );
1468 is( $loser_1_rs->count(), 1, "Found 1 $r rows for loser_1" );
1471 $schema->resultset($r)->search( { $field => $loser_2 } );
1472 is( $loser_2_rs->count(), 1, "Found 1 $r rows for loser_2" );
1475 my $results = $keeper->merge_with([ $loser_1, $loser_2 ]);
1477 while (my ($r, $field) = each(%$resultsets)) {
1479 $schema->resultset($r)->search( {$field => $keeper->id } );
1480 is( $keeper_rs->count(), 3, "Found 2 $r rows for keeper" );
1483 is( Koha::Patrons->find($loser_1), undef, 'Loser 1 has been deleted' );
1484 is( Koha::Patrons->find($loser_2), undef, 'Loser 2 has been deleted' );
1486 $schema->storage->txn_rollback;
1489 subtest '->store' => sub {
1491 my $schema = Koha::Database->new->schema;
1492 $schema->storage->txn_begin;
1494 my $print_error = $schema->storage->dbh->{PrintError};
1495 $schema->storage->dbh->{PrintError} = 0; ; # FIXME This does not longer work - because of the transaction in Koha::Patron->store?
1497 my $patron_1 = $builder->build_object({class=> 'Koha::Patrons'});
1498 my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});
1501 { $patron_2->userid($patron_1->userid)->store; }
1502 'Koha::Exceptions::Object::DuplicateID',
1503 'Koha::Patron->store raises an exception on duplicate ID';
1506 my $password = 'password';
1507 $patron_1->update_password($patron_1->userid, $password);
1508 like( $patron_1->password, qr|^\$2|, 'Password should be hashed using bcrypt (start with $2)' );
1509 my $digest = $patron_1->password;
1510 $patron_1->surname('xxx')->store;
1511 is( $patron_1->password, $digest, 'Password should not have changed on ->store');
1513 $schema->storage->dbh->{PrintError} = $print_error;
1514 $schema->storage->txn_rollback;
1517 subtest '->set_password' => sub {
1521 $schema->storage->txn_begin;
1523 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3 } } );
1525 # Disable logging password changes for this tests
1526 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
1528 # Password-length tests
1529 t::lib::Mocks::mock_preference( 'minPasswordLength', undef );
1530 throws_ok { $patron->set_password('ab'); }
1531 'Koha::Exceptions::Password::TooShort',
1532 'minPasswordLength is undef, fall back to 3, fail test';
1534 t::lib::Mocks::mock_preference( 'minPasswordLength', 2 );
1535 throws_ok { $patron->set_password('ab'); }
1536 'Koha::Exceptions::Password::TooShort',
1537 'minPasswordLength is 2, fall back to 3, fail test';
1539 t::lib::Mocks::mock_preference( 'minPasswordLength', 5 );
1540 throws_ok { $patron->set_password('abcb'); }
1541 'Koha::Exceptions::Password::TooShort',
1542 'minPasswordLength is 5, fail test';
1544 # Trailing spaces tests
1545 throws_ok { $patron->set_password('abcD12d '); }
1546 'Koha::Exceptions::Password::WhitespaceCharacters',
1547 'Password contains trailing spaces, exception is thrown';
1549 # Require strong password tests
1550 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 1 );
1551 throws_ok { $patron->set_password('abcd a'); }
1552 'Koha::Exceptions::Password::TooWeak',
1553 'Password is too weak, exception is thrown';
1555 # Refresh patron from DB, just to make sure
1556 $patron->discard_changes;
1557 is( $patron->login_attempts, 3, 'Previous tests kept login attemps count' );
1559 $patron->set_password('abcD12 34');
1560 $patron->discard_changes;
1562 is( $patron->login_attempts, 0, 'Changing the password resets the login attempts count' );
1565 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
1566 $patron->login_attempts(3)->store;
1567 my $old_digest = $patron->password;
1568 $patron->set_password('abcd a');
1569 $patron->discard_changes;
1571 isnt( $patron->password, $old_digest, 'Password has been updated' );
1572 ok( checkpw_hash('abcd a', $patron->password), 'Password hash is correct' );
1573 is( $patron->login_attempts, 0, 'Login attemps have been reset' );
1575 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1576 is( $number_of_logs, 0, 'Without BorrowerLogs, Koha::Patron->set_password doesn\'t log password changes' );
1578 # Enable logging password changes
1579 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1580 $patron->set_password('abcd b');
1582 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1583 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->set_password does log password changes' );
1585 $schema->storage->txn_rollback;
1590 # TODO Move to t::lib::Mocks and reuse it!
1591 sub set_logged_in_user {
1593 C4::Context->set_userenv(
1594 $patron->borrowernumber, $patron->userid,
1595 $patron->cardnumber, 'firstname',
1596 'surname', $patron->library->branchcode,
1597 'Midway Public Library', $patron->flags,