t/db_dependent/Suggestions.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use DateTime::Duration;
  21 use Test::More tests => 110;
  22 use Test::Warn;
  23
  24 use t::lib::Mocks;
  25 use t::lib::TestBuilder;
  26
  27 use C4::Context;
  28 use C4::Letters;
  29 use C4::Budgets qw( AddBudgetPeriod AddBudget GetBudget );
  30 use Koha::Database;
  31 use Koha::DateUtils qw( dt_from_string output_pref );
  32 use Koha::Libraries;
  33 use Koha::Patrons;
  34 use Koha::Suggestions;
  35
  36 BEGIN {
  37     use_ok('C4::Suggestions');
  38 }
  39
  40 my $schema  = Koha::Database->new->schema;
  41 $schema->storage->txn_begin;
  42 my $dbh = C4::Context->dbh;
  43 my $builder = t::lib::TestBuilder->new;
  44
  45 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0");
  46
  47 # Reset item types to only the default ones
  48 $dbh->do(q|DELETE FROM itemtypes;|);
  49 my $sql = qq|
  50 INSERT INTO itemtypes (itemtype, description, rentalcharge, notforloan, imageurl, summary) VALUES
  51 ('BK', 'Books',5,0,'bridge/book.gif',''),
  52 ('MX', 'Mixed Materials',5,0,'bridge/kit.gif',''),
  53 ('CF', 'Computer Files',5,0,'bridge/computer_file.gif',''),
  54 ('MP', 'Maps',5,0,'bridge/map.gif',''),
  55 ('VM', 'Visual Materials',5,1,'bridge/dvd.gif',''),
  56 ('MU', 'Music',5,0,'bridge/sound.gif',''),
  57 ('CR', 'Continuing Resources',5,0,'bridge/periodical.gif',''),
  58 ('REF', 'Reference',0,1,'bridge/reference.gif','');|;
  59 $dbh->do($sql);
  60 $dbh->do(q|DELETE FROM suggestions|);
  61 $dbh->do(q|DELETE FROM issues|);
  62 $dbh->do(q|DELETE FROM borrowers|);
  63 $dbh->do(q|DELETE FROM letter|);
  64 $dbh->do(q|DELETE FROM message_queue|);
  65 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|);
  66 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'NEW_SUGGESTION', 'Content for new suggestion')|);
  67
  68 # Add CPL if missing.
  69 if (not defined Koha::Libraries->find('CPL')) {
  70     Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store;
  71 }
  72
  73 my $patron_category = $builder->build({ source => 'Category' });
  74
  75 my $member = {
  76     firstname => 'my firstname',
  77     surname => 'my surname',
  78     categorycode => $patron_category->{categorycode},
  79     branchcode => 'CPL',
  80     smsalertnumber => 12345,
  81 };
  82
  83 my $member2 = {
  84     firstname => 'my firstname',
  85     surname => 'my surname',
  86     categorycode => $patron_category->{categorycode},
  87     branchcode => 'CPL',
  88     email => 'to@example.com',
  89 };
  90
  91 my $borrowernumber = Koha::Patron->new($member)->store->borrowernumber;
  92 my $borrowernumber2 = Koha::Patron->new($member2)->store->borrowernumber;
  93
  94 my $biblio_1 = $builder->build_object({ class => 'Koha::Biblios' });
  95 my $my_suggestion = {
  96     title         => 'my title',
  97     author        => 'my author',
  98     publishercode => 'my publishercode',
  99     suggestedby   => $borrowernumber,
 100     biblionumber  => $biblio_1->biblionumber,
 101     branchcode    => 'CPL',
 102     managedby     => '',
 103     manageddate   => '',
 104     accepteddate  => dt_from_string,
 105     note          => 'my note',
 106     quantity      => '', # Insert an empty string into int to catch strict SQL modes errors
 107 };
 108
 109 my $budgetperiod_id = AddBudgetPeriod({
 110     budget_period_startdate   => '2008-01-01',
 111     budget_period_enddate     => '2008-12-31',
 112     budget_period_description => 'MAPERI',
 113     budget_period_active      => 1,
 114 });
 115
 116 my $budget_id = AddBudget({
 117     budget_code      => 'ABCD',
 118     budget_amount    => '123.132000',
 119     budget_name      => 'ABCD',
 120     budget_notes     => 'This is a note',
 121     budget_period_id => $budgetperiod_id,
 122 });
 123 my $my_suggestion_with_budget = {
 124     title         => 'my title 2',
 125     author        => 'my author 2',
 126     publishercode => 'my publishercode 2',
 127     suggestedby   => $borrowernumber,
 128     biblionumber  => $biblio_1->biblionumber,
 129     managedby     => '',
 130     manageddate   => '',
 131     accepteddate  => dt_from_string,
 132     note          => 'my note',
 133     budgetid      => $budget_id,
 134 };
 135 my $my_suggestion_with_budget2 = {
 136     title         => 'my title 3',
 137     author        => 'my author 3',
 138     publishercode => 'my publishercode 3',
 139     suggestedby   => $borrowernumber2,
 140     biblionumber  => $biblio_1->biblionumber,
 141     managedby     => '',
 142     manageddate   => '',
 143     accepteddate  => dt_from_string,
 144     note          => 'my note',
 145     budgetid      => $budget_id,
 146 };
 147
 148 is( CountSuggestion(), 0, 'CountSuggestion without the status returns 0' );
 149 is( CountSuggestion('ASKED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 150 is( CountSuggestion('CHECKED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 151 is( CountSuggestion('ACCEPTED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 152 is( CountSuggestion('REJECTED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 153
 154 my $my_suggestionid = NewSuggestion($my_suggestion);
 155 isnt( $my_suggestionid, 0, 'NewSuggestion returns an not null id' );
 156 my $my_suggestionid_with_budget = NewSuggestion($my_suggestion_with_budget);
 157
 158 is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' );
 159 my $suggestion = GetSuggestion($my_suggestionid);
 160 is( $suggestion->{title}, $my_suggestion->{title}, 'NewSuggestion stores the title correctly' );
 161 is( $suggestion->{author}, $my_suggestion->{author}, 'NewSuggestion stores the author correctly' );
 162 is( $suggestion->{publishercode}, $my_suggestion->{publishercode}, 'NewSuggestion stores the publishercode correctly' );
 163 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'NewSuggestion stores the borrower number correctly' );
 164 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'NewSuggestion stores the biblio number correctly' );
 165 is( $suggestion->{STATUS}, 'ASKED', 'NewSuggestion stores a suggestion with the status ASKED by default' );
 166 is( $suggestion->{managedby}, undef, 'NewSuggestion stores empty string as undef for non existent foreign key (integer)' );
 167 is( $suggestion->{manageddate}, undef, 'NewSuggestion stores empty string as undef for date' );
 168 is( $suggestion->{budgetid}, undef, 'NewSuggestion should set budgetid to NULL if not given' );
 169
 170 is( CountSuggestion('ASKED'), 2, 'CountSuggestion returns the correct number of suggestions' );
 171
 172
 173 is( ModSuggestion(), undef, 'ModSuggestion without the suggestion returns undef' );
 174 my $mod_suggestion1 = {
 175     title         => 'my modified title',
 176     author        => 'my modified author',
 177     publishercode => 'my modified publishercode',
 178     managedby     => '',
 179     manageddate   => '',
 180 };
 181 my $status = ModSuggestion($mod_suggestion1);
 182 is( $status, undef, 'ModSuggestion without the suggestion id returns undef' );
 183
 184 $mod_suggestion1->{suggestionid} = $my_suggestionid;
 185 $status = ModSuggestion($mod_suggestion1);
 186 is( $status, 1, 'ModSuggestion modifies one entry' );
 187 $suggestion = GetSuggestion($my_suggestionid);
 188 is( $suggestion->{title}, $mod_suggestion1->{title}, 'ModSuggestion modifies the title  correctly' );
 189 is( $suggestion->{author}, $mod_suggestion1->{author}, 'ModSuggestion modifies the author correctly' );
 190 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'ModSuggestion modifies the publishercode correctly' );
 191 is( $suggestion->{managedby}, undef, 'ModSuggestion stores empty string as undef for non existent foreign key (integer)' );
 192 is( $suggestion->{manageddate}, undef, 'ModSuggestion stores empty string as undef for date' );
 193 isnt( $suggestion->{accepteddate}, undef, 'ModSuggestion does not update a non given date value' );
 194 is( $suggestion->{note}, 'my note', 'ModSuggestion should not erase data if not given' );
 195
 196 my $messages = C4::Letters::GetQueuedMessages({
 197     borrowernumber => $borrowernumber
 198 });
 199 is( @$messages, 0, 'ModSuggestions does not send an email if the status is not updated' );
 200
 201 my $mod_suggestion2 = {
 202     STATUS       => 'STALLED',
 203     suggestionid => $my_suggestionid,
 204 };
 205 warning_is { $status = ModSuggestion($mod_suggestion2) }
 206            "No suggestions STALLED letter transported by email",
 207            "ModSuggestion status warning is correct";
 208 is( $status, 1, "ModSuggestion Status OK");
 209
 210 my $mod_suggestion3 = {
 211     STATUS       => 'CHECKED',
 212     suggestionid => $my_suggestionid,
 213 };
 214
 215 #Test the message_transport_type of suggestion notices
 216
 217 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is disabled
 218 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 0 );
 219 $status = ModSuggestion($mod_suggestion3);
 220 is( $status, 1, 'ModSuggestion modifies one entry' );
 221 $suggestion = GetSuggestion($my_suggestionid);
 222 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'ModSuggestion modifies the status correctly' );
 223 $messages = C4::Letters::GetQueuedMessages({
 224     borrowernumber => $borrowernumber
 225 });
 226 is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' );
 227 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is disabled the suggestion message_transport_type is always email');
 228 is( CountSuggestion('CHECKED'), 1, 'CountSuggestion returns the correct number of suggestions' );
 229
 230 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a smsalertnumber and no email
 231 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 232 ModSuggestion($mod_suggestion3);
 233 $messages = C4::Letters::GetQueuedMessages({
 234     borrowernumber => $borrowernumber
 235 });
 236 is ($messages->[1]->{message_transport_type}, 'sms', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is sms if the borrower has no email');
 237
 238 #Make a new suggestion for a borrower with defined email and no smsalertnumber
 239 my $my_suggestion_2_id = NewSuggestion($my_suggestion_with_budget2);
 240
 241 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a defined email and no smsalertnumber
 242 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 243 my $mod_suggestion4 = {
 244     STATUS       => 'CHECKED',
 245     suggestionid => $my_suggestion_2_id,
 246 };
 247 ModSuggestion($mod_suggestion4);
 248 $messages = C4::Letters::GetQueuedMessages({
 249     borrowernumber => $borrowernumber2
 250 });
 251 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
 252
 253 {
 254     # Hiding the expected warning displayed by DBI
 255     # DBD::mysql::st execute failed: Incorrect date value: 'invalid date!' for column 'manageddate'
 256     my $stderr;
 257     local *STDERR;
 258     open STDERR, '>', '/dev/null';
 259
 260     $mod_suggestion4->{manageddate} = 'invalid date!';
 261     ModSuggestion($mod_suggestion4);
 262     $messages = C4::Letters::GetQueuedMessages({
 263         borrowernumber => $borrowernumber2
 264     });
 265
 266     close STDERR;
 267     is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
 268 }
 269
 270 is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
 271 $suggestion = GetSuggestionInfo($my_suggestionid);
 272 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );
 273 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfo returns the title correctly' );
 274 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfo returns the author correctly' );
 275 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfo returns the publisher code correctly' );
 276 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 277 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfo returns the biblio number correctly' );
 278 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfo returns the status correctly' );
 279 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfo returns the surname correctly' );
 280 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfo returns the firstname correctly' );
 281 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 282
 283
 284 is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' );
 285 is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' );
 286 is( GetSuggestionFromBiblionumber($biblio_1->biblionumber), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' );
 287
 288
 289 is( GetSuggestionInfoFromBiblionumber(), undef, 'GetSuggestionInfoFromBiblionumber without the biblio number returns undef' );
 290 is( GetSuggestionInfoFromBiblionumber(2), undef, 'GetSuggestionInfoFromBiblionumber with an invalid biblio number returns undef' );
 291 $suggestion = GetSuggestionInfoFromBiblionumber($biblio_1->biblionumber);
 292 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber returns the suggestion id correctly' );
 293 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber returns the title correctly' );
 294 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber returns the author correctly' );
 295 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber returns the publisher code correctly' );
 296 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber returns the borrower number correctly' );
 297 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber returns the biblio number correctly' );
 298 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber returns the status correctly' );
 299 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfoFromBiblionumber returns the surname correctly' );
 300 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfoFromBiblionumber returns the firstname correctly' );
 301 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumeber returns the borrower number correctly' );
 302
 303
 304 my $suggestions = GetSuggestionByStatus();
 305 is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
 306 $suggestions = GetSuggestionByStatus('CHECKED');
 307 is( @$suggestions, 2, 'GetSuggestionByStatus returns the correct number of suggestions' );
 308 is( $suggestions->[0]->{suggestionid}, $my_suggestionid, 'GetSuggestionByStatus returns the suggestion id correctly' );
 309 is( $suggestions->[0]->{title}, $mod_suggestion1->{title}, 'GetSuggestionByStatus returns the title correctly' );
 310 is( $suggestions->[0]->{author}, $mod_suggestion1->{author}, 'GetSuggestionByStatus returns the author correctly' );
 311 is( $suggestions->[0]->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionByStatus returns the publisher code correctly' );
 312 is( $suggestions->[0]->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 313 is( $suggestions->[0]->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionByStatus returns the biblio number correctly' );
 314 is( $suggestions->[0]->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionByStatus returns the status correctly' );
 315 is( $suggestions->[0]->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionByStatus returns the surname correctly' );
 316 is( $suggestions->[0]->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionByStatus returns the firstname correctly' );
 317 is( $suggestions->[0]->{branchcodesuggestedby}, $member->{branchcode}, 'GetSuggestionByStatus returns the branch code correctly' );
 318 is( $suggestions->[0]->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 319 is( $suggestions->[0]->{categorycodesuggestedby}, $member->{categorycode}, 'GetSuggestionByStatus returns the category code correctly' );
 320
 321
 322 is( ConnectSuggestionAndBiblio(), '0E0', 'ConnectSuggestionAndBiblio without arguments returns 0E0' );
 323 my $biblio_2 = $builder->build_object({ class => 'Koha::Biblios' });
 324 my $connect_suggestion_and_biblio = ConnectSuggestionAndBiblio($my_suggestionid, $biblio_2->biblionumber);
 325 is( $connect_suggestion_and_biblio, '1', 'ConnectSuggestionAndBiblio returns 1' );
 326 $suggestion = GetSuggestion($my_suggestionid);
 327 is( $suggestion->{biblionumber}, $biblio_2->biblionumber, 'ConnectSuggestionAndBiblio updates the biblio number correctly' );
 328
 329 my $search_suggestion = SearchSuggestion();
 330 is( @$search_suggestion, 3, 'SearchSuggestion without arguments returns all suggestions' );
 331
 332 $search_suggestion = SearchSuggestion({
 333     title => $mod_suggestion1->{title},
 334 });
 335 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 336 $search_suggestion = SearchSuggestion({
 337     title => 'another title',
 338 });
 339 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 340
 341 $search_suggestion = SearchSuggestion({
 342     author => $mod_suggestion1->{author},
 343 });
 344 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 345 $search_suggestion = SearchSuggestion({
 346     author => 'another author',
 347 });
 348 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 349
 350 $search_suggestion = SearchSuggestion({
 351     publishercode => $mod_suggestion1->{publishercode},
 352 });
 353 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 354 $search_suggestion = SearchSuggestion({
 355     publishercode => 'another publishercode',
 356 });
 357 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 358
 359 $search_suggestion = SearchSuggestion({
 360     STATUS => $mod_suggestion3->{STATUS},
 361 });
 362 is( @$search_suggestion, 2, 'SearchSuggestion returns the correct number of suggestions' );
 363
 364 $search_suggestion = SearchSuggestion({
 365     STATUS => q||
 366 });
 367 is( @$search_suggestion, 0, 'SearchSuggestion should not return all suggestions if we want the suggestions with a STATUS=""' );
 368 $search_suggestion = SearchSuggestion({
 369     STATUS => 'REJECTED',
 370 });
 371 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 372
 373 $search_suggestion = SearchSuggestion({
 374     budgetid => '',
 375 });
 376 is( @$search_suggestion, 3, 'SearchSuggestion (budgetid = "") returns the correct number of suggestions' );
 377 $search_suggestion = SearchSuggestion({
 378     budgetid => $budget_id,
 379 });
 380 is( @$search_suggestion, 2, 'SearchSuggestion (budgetid = $budgetid) returns the correct number of suggestions' );
 381 $search_suggestion = SearchSuggestion({
 382     budgetid => '__NONE__',
 383 });
 384 is( @$search_suggestion, 1, 'SearchSuggestion (budgetid = "__NONE__") returns the correct number of suggestions' );
 385 $search_suggestion = SearchSuggestion({
 386     budgetid => '__ANY__',
 387 });
 388 is( @$search_suggestion, 3, 'SearchSuggestion (budgetid = "__ANY__") returns the correct number of suggestions' );
 389
 390 $search_suggestion = SearchSuggestion({ budgetid => $budget_id });
 391 is( @$search_suggestion[0]->{budget_name}, GetBudget($budget_id)->{budget_name}, 'SearchSuggestion returns the correct budget name');
 392 $search_suggestion = SearchSuggestion({ budgetid => "__NONE__" });
 393 is( @$search_suggestion[0]->{budget_name}, undef, 'SearchSuggestion returns the correct budget name');
 394
 395
 396 my $del_suggestion = {
 397     title => 'my deleted title',
 398     STATUS => 'CHECKED',
 399     suggestedby => $borrowernumber,
 400 };
 401 my $del_suggestionid = NewSuggestion($del_suggestion);
 402
 403 is( CountSuggestion('CHECKED'), 3, 'CountSuggestion returns the correct number of suggestions' );
 404
 405 is( DelSuggestion(), '0E0', 'DelSuggestion without arguments returns 0E0' );
 406 is( DelSuggestion($borrowernumber), '', 'DelSuggestion without the suggestion id returns an empty string' );
 407 is( DelSuggestion(undef, $my_suggestionid), '', 'DelSuggestion with an invalid borrower number returns an empty string' );
 408 $suggestion = DelSuggestion($borrowernumber, $my_suggestionid);
 409 is( $suggestion, 1, 'DelSuggestion deletes one suggestion' );
 410
 411 $suggestions = GetSuggestionByStatus('CHECKED');
 412 is( @$suggestions, 2, 'DelSuggestion deletes one suggestion' );
 413 is( $suggestions->[1]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' );
 414
 415 # Test budgetid fk
 416 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 417 my $my_suggestionid_test_budgetid = NewSuggestion($my_suggestion);
 418 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 419 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
 420
 421 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 422 ModSuggestion( $my_suggestion );
 423 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 424 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
 425
 426 subtest 'GetUnprocessedSuggestions' => sub {
 427     plan tests => 11;
 428     $dbh->do(q|DELETE FROM suggestions|);
 429     my $my_suggestionid         = NewSuggestion($my_suggestion);
 430     my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 431     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return 0 if a suggestion has been processed but not linked to a fund' );
 432     my $status     = ModSuggestion($mod_suggestion1);
 433     my $suggestion = GetSuggestion($my_suggestionid);
 434     is( $suggestion->{budgetid}, undef, 'ModSuggestion should set budgetid to NULL if not given' );
 435     ModSuggestion( { suggestionid => $my_suggestionid, budgetid => $budget_id } );
 436     $suggestion = GetSuggestion($my_suggestionid);
 437     is( $suggestion->{budgetid}, $budget_id, 'ModSuggestion should modify budgetid if given' );
 438
 439     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 440     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 441
 442     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
 443                 'No suggestions REJECTED letter transported by email',
 444                 'Warning raised if no REJECTED letter by email';
 445     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 446     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 447
 448     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
 449                 'No suggestions ASKED letter transported by email',
 450                 'Warning raised if no ASKED letter by email';
 451     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 452     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
 453     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);
 454     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion suggested 4 days ago' );
 455     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(3);
 456     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 3 days ago' );
 457     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(5);
 458     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 5 days ago' );
 459 };
 460
 461 subtest 'DelSuggestionsOlderThan' => sub {
 462     plan tests => 6;
 463
 464     Koha::Suggestions->delete;
 465
 466     # Add four suggestions; note that STATUS needs uppercase (FIXME)
 467     my $d1 = output_pref({ dt => dt_from_string->add(days => -2), dateformat => 'sql' });
 468     my $d2 = output_pref({ dt => dt_from_string->add(days => -4), dateformat => 'sql' });
 469     my $sugg01 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'ASKED' }});
 470     my $sugg02 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'CHECKED' }});
 471     my $sugg03 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ASKED' }});
 472     my $sugg04 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ACCEPTED' }});
 473
 474     # Test no parameter: should do nothing
 475     C4::Suggestions::DelSuggestionsOlderThan();
 476     is( Koha::Suggestions->count, 4, 'No suggestions deleted' );
 477     # Test zero: should do nothing too
 478     C4::Suggestions::DelSuggestionsOlderThan(0);
 479     is( Koha::Suggestions->count, 4, 'No suggestions deleted again' );
 480     # Test negative value
 481     C4::Suggestions::DelSuggestionsOlderThan(-1);
 482     is( Koha::Suggestions->count, 4, 'No suggestions deleted for -1' );
 483
 484     # Test positive values
 485     C4::Suggestions::DelSuggestionsOlderThan(5);
 486     is( Koha::Suggestions->count, 4, 'No suggestions>5d deleted' );
 487     C4::Suggestions::DelSuggestionsOlderThan(3);
 488     is( Koha::Suggestions->count, 3, '1 suggestions>3d deleted' );
 489     C4::Suggestions::DelSuggestionsOlderThan(1);
 490     is( Koha::Suggestions->count, 2, '1 suggestions>1d deleted' );
 491 };
 492
 493 subtest 'EmailPurchaseSuggestions' => sub {
 494     plan tests => 11;
 495
 496     $dbh->do(q|DELETE FROM message_queue|);
 497
 498     t::lib::Mocks::mock_preference( "KohaAdminEmailAddress",
 499         'noreply@hosting.com' );
 500
 501     # EmailPurchaseSuggestions set to disabled
 502     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0" );
 503     NewSuggestion($my_suggestion);
 504     my $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 505         {
 506             borrowernumber => $borrowernumber
 507         }
 508     );
 509     is( @$newsuggestions_messages, 0,
 510         'NewSuggestions does not send an email when disabled' );
 511
 512     # EmailPurchaseSuggestions set to BranchEmailAddress
 513     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 514         "BranchEmailAddress" );
 515     NewSuggestion($my_suggestion);
 516
 517     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 518     NewSuggestion($my_suggestion);
 519
 520     Koha::Libraries->find('CPL')->update( { branchemail => 'branchemail@hosting.com' } );
 521     NewSuggestion($my_suggestion);
 522
 523     Koha::Libraries->find('CPL')->update( { branchreplyto => 'branchemail@b.c' } );
 524     NewSuggestion($my_suggestion);
 525
 526     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 527         {
 528             borrowernumber => $borrowernumber
 529         }
 530     );
 531     isnt( @$newsuggestions_messages, 0, 'NewSuggestions sends an email' );
 532     my $message1 =
 533       C4::Letters::GetMessage( $newsuggestions_messages->[0]->{message_id} );
 534     is( $message1->{to_address}, 'noreply@hosting.com',
 535 'BranchEmailAddress falls back to KohaAdminEmailAddress if branchreplyto, branchemail and ReplytoDefault are not set'
 536     );
 537     my $message2 =
 538       C4::Letters::GetMessage( $newsuggestions_messages->[1]->{message_id} );
 539     is( $message2->{to_address}, 'library@b.c',
 540 'BranchEmailAddress falls back to ReplytoDefault if neither branchreplyto or branchemail are set'
 541     );
 542     my $message3 =
 543       C4::Letters::GetMessage( $newsuggestions_messages->[2]->{message_id} );
 544     is( $message3->{to_address}, 'branchemail@hosting.com',
 545 'BranchEmailAddress uses branchemail if branch_replto is not set'
 546     );
 547     my $message4 =
 548       C4::Letters::GetMessage( $newsuggestions_messages->[3]->{message_id} );
 549     is( $message4->{to_address}, 'branchemail@b.c',
 550 'BranchEmailAddress uses branchreplyto in preference to branchemail when set'
 551     );
 552
 553     # EmailPurchaseSuggestions set to KohaAdminEmailAddress
 554     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 555         "KohaAdminEmailAddress" );
 556
 557     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 558     NewSuggestion($my_suggestion);
 559
 560     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 561     NewSuggestion($my_suggestion);
 562
 563     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 564         {
 565             borrowernumber => $borrowernumber
 566         }
 567     );
 568     my $message5 =
 569       C4::Letters::GetMessage( $newsuggestions_messages->[4]->{message_id} );
 570     is( $message5->{to_address},
 571         'noreply@hosting.com', 'KohaAdminEmailAddress uses KohaAdminEmailAddress when ReplytoDefault is not set' );
 572     my $message6 =
 573       C4::Letters::GetMessage( $newsuggestions_messages->[5]->{message_id} );
 574     is( $message6->{to_address},
 575         'library@b.c', 'KohaAdminEmailAddress uses ReplytoDefualt when ReplytoDefault is set' );
 576
 577     # EmailPurchaseSuggestions set to EmailAddressForSuggestions
 578     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 579         "EmailAddressForSuggestions" );
 580
 581     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 582     NewSuggestion($my_suggestion);
 583
 584     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 585     NewSuggestion($my_suggestion);
 586
 587     t::lib::Mocks::mock_preference( "EmailAddressForSuggestions",
 588         'suggestions@b.c' );
 589     NewSuggestion($my_suggestion);
 590
 591     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 592         {
 593             borrowernumber => $borrowernumber
 594         }
 595     );
 596     my $message7 =
 597       C4::Letters::GetMessage( $newsuggestions_messages->[6]->{message_id} );
 598     is( $message7->{to_address},
 599         'noreply@hosting.com', 'EmailAddressForSuggestions uses KohaAdminEmailAddress when neither EmailAddressForSuggestions or ReplytoDefault are set' );
 600
 601     my $message8 =
 602       C4::Letters::GetMessage( $newsuggestions_messages->[7]->{message_id} );
 603     is( $message8->{to_address},
 604         'library@b.c', 'EmailAddressForSuggestions uses ReplytoDefault when EmailAddressForSuggestions is not set' );
 605
 606     my $message9 =
 607       C4::Letters::GetMessage( $newsuggestions_messages->[8]->{message_id} );
 608     is( $message9->{to_address},
 609         'suggestions@b.c', 'EmailAddressForSuggestions uses EmailAddressForSuggestions when set' );
 610 };
 611
 612 $schema->storage->txn_rollback;