1 package t::lib::QA::TemplateFilters;
37 return _process_tt_content( @_ )->{new_content};
41 return @{_process_tt_content( @_ )->{errors}};
45 sub _process_tt_content {
47 my ( $use_raw, $has_use_raw );
51 for my $line ( split "\n", $content ) {
54 if ( $line =~ m{\[%[^%]+%\]} ) {
56 # handle exceptions first
57 if ( $line =~ m{\|\s*\$raw} ) { # Is the file use the raw filter?
61 # Do we have Asset without the raw filter?
62 if ( $line =~ m{^\s*\[% Asset} && $line !~ m{\|\s*\$raw} ) {
65 error => 'asset_must_be_raw',
67 line_number => $line_number
69 $new_line =~ s/\)\s*%]/) | \$raw %]/;
71 push @new_lines, $new_line;
76 if $line =~ m{\[%(\s|-|~)*USE raw(\s|-|~)*%\]}; # Does [% Use raw %] exist?
79 if ( $line =~ qr{<a href="([^"]+)} ) {
80 my $to_uri_escape = $1;
84 (?<pre_chomp>(\s|\-|~)*)
86 (?<post_chomp>(\s|\-|~)*)
90 ( $new_line, $e ) = process_tt_block($new_line, { %+, filter => 'uri' });
91 push @errors, { line => $line, line_number => $line_number, error => $e } if $e;
99 (?<pre_chomp>(\s|\-|~)*)
100 (?<tt_block>[^%\-~]+)
101 (?<post_chomp>(\s|\-|~)*)
105 ( $new_line, $e ) = process_tt_block($new_line, \%+);
106 push @errors, { line => $line, line_number => $line_number, error => $e } if $e;
109 push @new_lines, $new_line;
112 push @new_lines, $new_line;
117 # Adding [% USE raw %] on top if the filter is used
118 @new_lines = ( '[% USE raw %]', @new_lines )
119 if $use_raw and not $has_use_raw;
121 my $new_content = join "\n", @new_lines;
122 return { errors => \@errors, new_content => $new_content };
125 sub process_tt_block {
126 my ( $line, $params ) = @_;
127 my $tt_block = $params->{tt_block};
128 my $pre_chomp = $params->{pre_chomp};
129 my $post_chomp = $params->{post_chomp};
130 my $filter = $params->{filter} || 'html';
133 return ( $line, $error ) if
134 # It's a TT directive, no filters needed
135 grep { $tt_block =~ $_ } @tt_directives
138 or grep { $tt_block =~ $_ } @tt_methods
141 or $tt_block =~ m{^\#}
143 # Already escaped with a special filter
144 # We could escape it but should be safe
145 or $tt_block =~ m{\s?\|\s?\$KohaDates[^\|]*$}
146 or $tt_block =~ m{\s?\|\s?\$Price[^\|]*$}
147 or $tt_block =~ m{\s?\|\s?\$HtmlTags[^\|]*$}
148 or $tt_block =~ m{\s?\|\s?\$HtmlId[^\|]*$}
150 # Already escaped correctly with raw
151 or $tt_block =~ m{\|\s?\$raw}
153 # Assignment, maybe we should require to use SET (?)
154 or ( $tt_block =~ m{=} and not $tt_block =~ m{\s\|\s} )
156 # Already has url or uri filter
157 or $tt_block =~ m{\|\s?ur(l|i)}
159 # Specific for [% foo UNLESS bar %]
160 or $tt_block =~ m{^(?<before>\S+)\s+UNLESS\s+(?<after>\S+)}
173 ? $post_chomp =~ m|-|
175 : $post_chomp =~ m|~|
180 if ( $tt_block =~ m{\s?\|\s?\$KohaDates[^\|]*\|.*$}
181 or $tt_block =~ m{\s?\|\s?\$Price[^\|]*\|.*$}
182 or $tt_block =~ m{\s?\|\s?\$HtmlTags[^\|]*\|.*$}
185 s/\s*\|\s*(uri|url|html)\s*$//; # Could be another filter...
189 \Q$tt_block\E\s*\|\s*(uri|url|html)
192 }{[%$pre_chomp$tt_block$post_chomp%]}xms;
194 return ( $line, 'extra_filter_not_needed' );
198 # Use the uri filter is needed
199 # If html filtered or not filtered
203 or ($tt_block =~ m{\|\s?html} and not $tt_block =~ m{\|\s?html_entity})
204 or $tt_block !~ m{\s*|\s*(uri|url)}
207 $tt_block =~ s/^\s*|\s*$//g; # trim
208 $tt_block =~ s/\s*\|\s*html\s*//;
212 \Q$tt_block\E(\s*\|\s*html)?
215 }{[%$pre_chomp$tt_block | uri$post_chomp%]}xms;
217 $error = 'wrong_html_filter';
220 $tt_block !~ m{\|\s?html} # already has html filter
223 $tt_block =~ s/^\s*|\s*$//g; # trim
230 }{[%$pre_chomp$tt_block | html$post_chomp%]}xms;
232 $error = 'missing_filter';
234 return ( $line, $error );
241 t::lib::QA::TemplateFilters - Module used by tests and QA script to catch missing filters in template files
245 my $content = read_file($filename);
246 my $new_content = t::lib::QA::TemplateFilters::fix_filters($content);
247 my $errors = t::lib::QA::TemplateFilters::missing_filters($content);
251 The goal of this module is to make the subroutine reusable from the QA scripts
252 and to not duplicate the code.
258 Take a template content file in parameter and return the same content with
259 the correct (guessed) filters.
260 It will also add the [% USE raw %] statement if it is needed.
262 =head2 missing_filters
264 Take a template content file in parameter and return an arrayref of errors.
266 An error is a hashref with 3 keys, error and line, line_number.
268 asset_must_be_raw - When Asset is called without using raw
269 missing_filter - When a TT variable is displayed without filter
270 wrong_html_filter - When a TT variable is using the html filter when uri (or url)
271 should be used instead.
273 * line is the line where the error has been found.
274 * line_number is the line number where the error has been found.
279 Jonathan Druart <jonathan.druart@bugs.koha-community.org>
283 Copyright 2017 - Koha Development Team
287 This file is part of Koha.
289 Koha is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by
290 the Free Software Foundation; either version 3 of the License, or (at your option) any later version.
292 Koha is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
294 You should have received a copy of the GNU General Public License along with Koha; if not, see <http://www.gnu.org/licenses>.