1 package t::lib::QA::TemplateFilters;
36 return _process_tt_content( @_ )->{new_content};
40 return @{_process_tt_content( @_ )->{errors}};
44 sub _process_tt_content {
46 my ( $use_raw, $has_use_raw );
50 for my $line ( split "\n", $content ) {
53 if ( $line =~ m{\[%[^%]+%\]} ) {
55 # handle exceptions first
56 if ( $line =~ m{\|\s*\$raw} ) { # Is the file use the raw filter?
60 # Do we have Asset without the raw filter?
61 if ( $line =~ m{^\s*\[% Asset} && $line !~ m{\|\s*\$raw} ) {
64 error => 'asset_must_be_raw',
66 line_number => $line_number
68 $new_line =~ s/\)\s*%]/) | \$raw %]/;
70 push @new_lines, $new_line;
75 if $line =~ m{\[%(\s|-|~)*USE raw(\s|-|~)*%\]}; # Does [% Use raw %] exist?
78 if ( $line =~ qr{<a href="([^"]+)} ) {
79 my $to_uri_escape = $1;
83 (?<pre_chomp>(\s|\-|~)*)
85 (?<post_chomp>(\s|\-|~)*)
89 ( $new_line, $e ) = process_tt_block($new_line, { %+, filter => 'uri' });
90 push @errors, { line => $line, line_number => $line_number, error => $e } if $e;
98 (?<pre_chomp>(\s|\-|~)*)
100 (?<post_chomp>(\s|\-|~)*)
104 ( $new_line, $e ) = process_tt_block($new_line, \%+);
105 push @errors, { line => $line, line_number => $line_number, error => $e } if $e;
108 push @new_lines, $new_line;
111 push @new_lines, $new_line;
116 # Adding [% USE raw %] on top if the filter is used
117 @new_lines = ( '[% USE raw %]', @new_lines )
118 if $use_raw and not $has_use_raw;
120 my $new_content = join "\n", @new_lines;
121 return { errors => \@errors, new_content => $new_content };
124 sub process_tt_block {
125 my ( $line, $params ) = @_;
126 my $tt_block = $params->{tt_block};
127 my $pre_chomp = $params->{pre_chomp};
128 my $post_chomp = $params->{post_chomp};
129 my $filter = $params->{filter} || 'html';
132 return ( $line, $error ) if
133 # It's a TT directive, no filters needed
134 grep { $tt_block =~ $_ } @tt_directives
137 or grep { $tt_block =~ $_ } @tt_methods
140 or $tt_block =~ m{^\#}
142 # Already escaped with a special filter
143 # We could escape it but should be safe
144 or $tt_block =~ m{\s?\|\s?\$KohaDates[^\|]*$}
145 or $tt_block =~ m{\s?\|\s?\$Price[^\|]*$}
146 or $tt_block =~ m{\s?\|\s?\$HtmlTags[^\|]*$}
148 # Already escaped correctly with raw
149 or $tt_block =~ m{\|\s?\$raw}
151 # Assignment, maybe we should require to use SET (?)
152 or ( $tt_block =~ m{=} and not $tt_block =~ m{\s\|\s} )
154 # Already has url or uri filter
155 or $tt_block =~ m{\|\s?ur(l|i)}
157 # Specific for [% foo UNLESS bar %]
158 or $tt_block =~ m{^(?<before>\S+)\s+UNLESS\s+(?<after>\S+)}
171 ? $post_chomp =~ m|-|
173 : $post_chomp =~ m|~|
178 if ( $tt_block =~ m{\s?\|\s?\$KohaDates[^\|]*\|.*$}
179 or $tt_block =~ m{\s?\|\s?\$Price[^\|]*\|.*$}
180 or $tt_block =~ m{\s?\|\s?\$HtmlTags[^\|]*\|.*$}
183 s/\s*\|\s*(uri|url|html)\s*$//; # Could be another filter...
187 \Q$tt_block\E\s*\|\s*(uri|url|html)
190 }{[%$pre_chomp$tt_block$post_chomp%]}xms;
192 return ( $line, 'extra_filter_not_needed' );
196 # Use the uri filter is needed
197 # If html filtered or not filtered
201 or ($tt_block =~ m{\|\s?html} and not $tt_block =~ m{\|\s?html_entity})
202 or $tt_block !~ m{\s*|\s*(uri|url)}
205 $tt_block =~ s/^\s*|\s*$//g; # trim
206 $tt_block =~ s/\s*\|\s*html\s*//;
210 \Q$tt_block\E(\s*\|\s*html)?
213 }{[%$pre_chomp$tt_block | uri$post_chomp%]}xms;
215 $error = 'wrong_html_filter';
218 $tt_block !~ m{\|\s?html} # already has html filter
221 $tt_block =~ s/^\s*|\s*$//g; # trim
228 }{[%$pre_chomp$tt_block | html$post_chomp%]}xms;
230 $error = 'missing_filter';
232 return ( $line, $error );
239 t::lib::QA::TemplateFilters - Module used by tests and QA script to catch missing filters in template files
243 my $content = read_file($filename);
244 my $new_content = t::lib::QA::TemplateFilters::fix_filters($content);
245 my $errors = t::lib::QA::TemplateFilters::missing_filters($content);
249 The goal of this module is to make the subroutine reusable from the QA scripts
250 and to not duplicate the code.
256 Take a template content file in parameter and return the same content with
257 the correct (guessed) filters.
258 It will also add the [% USE raw %] statement if it is needed.
260 =head2 missing_filters
262 Take a template content file in parameter and return an arrayref of errors.
264 An error is a hashref with 3 keys, error and line, line_number.
266 asset_must_be_raw - When Asset is called without using raw
267 missing_filter - When a TT variable is displayed without filter
268 wrong_html_filter - When a TT variable is using the html filter when uri (or url)
269 should be used instead.
271 * line is the line where the error has been found.
272 * line_number is the line number where the error has been found.
277 Jonathan Druart <jonathan.druart@bugs.koha-community.org>
281 Copyright 2017 - Koha Development Team
285 This file is part of Koha.
287 Koha is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by
288 the Free Software Foundation; either version 3 of the License, or (at your option) any later version.
290 Koha is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
292 You should have received a copy of the GNU General Public License along with Koha; if not, see <http://www.gnu.org/licenses>.