Bug 27117: Only place_holds permission is needed to adjust pickup locations
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 1 Dec 2020 10:44:04 +0000 (11:44 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 28 Dec 2020 13:49:39 +0000 (14:49 +0100)
commit05ba6b702e1e267ec110c83f0b3e133a023d7948
treee1b99b4917a13301c73885d39d4d678445818978
parent6f64a3366a5fdb9c91c5479aa546c402cfabd22d
Bug 27117: Only place_holds permission is needed to adjust pickup locations

The GET /pickup_locations route is requesting the whole reserveforothers
permission whereas only the subpermission place_holds is needed.

Test plan:
0. Don't apply this patch
1. Set the subpermission place_holds but modify_holds_priority
2. Edit a hold and click the pickup library dropdown list
3. You get a JS alert and log displays
  GET /api/v1/app.pl/api/v1/holds/5/pickup_locations
  403 Forbidden
4. Apply this patch
5. Reload the page, click the dropdown list, modify the pickup location
and save
=> Success!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 69c01ee0f2dccd04cfbe8201ba580a15727f5280)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
api/v1/swagger/paths/holds.json
t/db_dependent/api/v1/holds.t