Bug 30133: Simplify code
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 18 Feb 2022 18:22:36 +0000 (15:22 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 25 Feb 2022 00:35:36 +0000 (14:35 -1000)
commit07893d66e8d9194bf2ed6cf90649f7e70ad9d9fa
tree16f1c0bf91bb06f37aaf9b2ee514daa9bf7c888d
parent1758b586424b8e012715ec686b23f8df1835052e
Bug 30133: Simplify code

This patch simplifies the code, and also fixes a problem with branchcode
comparisson failing, highlighted when running the tests

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/items.t
=> FAIL: Tests fail. Notably:
- Link header pagination is wrong
- X-*Total-Count headers have two values (dupicated)
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Items.pm