Bug 18936: (QA follow-up) Fix inconsistencies in IssuingRules.t
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 27 Jan 2020 09:13:44 +0000 (10:13 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 4 Feb 2020 09:56:29 +0000 (09:56 +0000)
commit0d37a9366127644a06dd909dc91dfed046571937
treea2b02ad16b354a22f7d06e192e92258bab6452d7
parent05cabe7b18a0aef9e7cfd7de432956bad758cae5
Bug 18936: (QA follow-up) Fix inconsistencies in IssuingRules.t

* get_effective_rule should not pass rule_value
* indentation fix
* add comment to list the rules we have when the test _is_row_match
is executed
* compare ->rule_name and ->rule_value returns

Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
t/db_dependent/Koha/IssuingRules.t