Bug 26999: (follow-up) Simplify code
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 15 Mar 2021 11:33:49 +0000 (08:33 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 1 Apr 2021 16:51:37 +0000 (18:51 +0200)
commit0fd2be61e8376ad0db0f8ecf1eacde706cec6816
treea3a3d31765608774e2b3684762caf3e7f802e20f
parent13bb39f4c670d72686dd6b76cc0757c2f07b04d5
Bug 26999: (follow-up) Simplify code

Doing
$ git grep pickup_locations_code

shows there's some calculated data that is not actually used anywhere.
We can get rid of it.

This patch also reuses $item_object (which is in the same loop scope) to
avoid an extra DB call.

To test:
1. Run:
   $ git grep pickup_locations_code
=> FAIL: It is only used/set as a comma separated string, inside
request.pl
2. Apply this patch
3. Repeat 1
=> SUCCESS: The unused stuff is not there anymore
4. Open the page for placing some holds
=> SUCCESS: It doesn't explode
5. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
reserve/request.pl