Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 3 Aug 2020 11:09:54 +0000 (13:09 +0200)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Wed, 9 Sep 2020 04:32:25 +0000 (16:32 +1200)
commit104fba4bb0e5dec1914978b324551e443eb51a40
treeb86c924774ca3fff4d2f921f9c135723d13ff7b3
parent518ea70806ec765766a31bbcfcbfa216cbf94eb1
Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail

There is no good reason remove the ability to edit patron's attributes
if PatronSelfRegistrationVerifyByEmail is set.

We cannot have them in the self-registration form (because we don't
store patron's attributes during self-ref), but we can have them when
a patron show/edit their information.

Test plan:
0. Enable PatronSelfRegistrationVerifyByEmail and create patron's
attributes that can be edited at the OPAC
1. Create a new patron using the self-reg feature
=> You don't have the ability to fill in the patron's attribute
2. Edit your personal details (OPAC)
=> Without this patch you still don't see the patron's attribute that
can be edited at the OPAC
=> With this patch applied you can!
3. Notice the wording change on the "Modify patron attribute type" form
and confirm it makes sense

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fc22fb308bdbfc6d1bda3448e966542f2828ad76)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit ae54212e7d05564332dbb28b99ed61103cdecaae)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt