Bug 25942: Fix batch report operations for cardnumbers and biblionumbers
authorNick Clemens <nick@bywatersolutions.com>
Wed, 18 Nov 2020 13:29:33 +0000 (13:29 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Thu, 10 Dec 2020 21:11:40 +0000 (21:11 +0000)
commit1bbef979c65fde016c4fa9ec56ccec7154b10f1d
tree20add2bfd2edf95d79344a832af1d2226d85141f
parent8293c73bacb55dda87025a7986019754e490fa25
Bug 25942: Fix batch report operations for cardnumbers and biblionumbers

This patch moves the processing for these to a block and adds a comment
in place of whitespace and uses template directives to chomp newlines to improve readability

To test:
 1 - Create a report like:
    SELECT biblionumber FROM biblio
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
    (You will need to define a marc modification template)
 4 - The operations don't find the biblios
 5 - Create a report like:
    SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Bug 25942: (follow-up) fix filters

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 443c004bc64543b1755bf0579a68ef32aa36cee5)
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt