Bug 14866: Make high holds work with different item types
authorAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 20 Apr 2020 14:31:27 +0000 (14:31 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 6 Nov 2020 14:55:17 +0000 (15:55 +0100)
commit1deb47e793b6b3c146839e9d5fc29ff535fd13a2
tree37f254d4ceb409dca3e64370c94834e2fb655da0
parent8bd02f991942e307a8603304ffd29d8eb42343c4
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT
Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm
Koha/CirculationRules.pm
admin/smart-rules.pl
installer/data/mysql/atomicupdate/bug_14866-add_decreaseloanholds_circrule.perl [new file with mode: 0644]
installer/onboarding.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
t/db_dependent/DecreaseLoanHighHolds.t